From: Masahiro Yamada <yamada.masahiro@socionext.com> To: William Breathitt Gray <vilhelm.gray@gmail.com> Cc: linux-arch <linux-arch@vger.kernel.org>, preid@electromag.com.au, Arnd Bergmann <arnd@arndb.de>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Linux PM mailing list <linux-pm@vger.kernel.org>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, morten.tiljeset@prevas.dk, sean.nyekjaer@prevas.dk, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, Lukas Wunner <lukas@wunner.de>, Geert Uytterhoeven <geert@linux-m68k.org>, Andrew Morton <akpm@linux-foundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v17 01/14] bitops: Introduce the for_each_set_clump8 macro Date: Thu, 10 Oct 2019 01:28:08 +0900 [thread overview] Message-ID: <CAK7LNATgW7bXUmqV=3QAaJ0Qu73Kox-TgDCQJb=s0=mwewSCUg@mail.gmail.com> (raw) In-Reply-To: <893c3b4f03266c9496137cc98ac2b1bd27f92c73.1570633189.git.vilhelm.gray@gmail.com> On Thu, Oct 10, 2019 at 12:27 AM William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > > This macro iterates for each 8-bit group of bits (clump) with set bits, > within a bitmap memory region. For each iteration, "start" is set to the > bit offset of the found clump, while the respective clump value is > stored to the location pointed by "clump". Additionally, the > bitmap_get_value8 and bitmap_set_value8 functions are introduced to > respectively get and set an 8-bit value in a bitmap memory region. > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Suggested-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > Suggested-by: Lukas Wunner <lukas@wunner.de> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > --- > include/asm-generic/bitops/find.h | 17 +++++++++++++++ > include/linux/bitmap.h | 35 +++++++++++++++++++++++++++++++ > include/linux/bitops.h | 5 +++++ > lib/find_bit.c | 14 +++++++++++++ > 4 files changed, 71 insertions(+) > > diff --git a/include/asm-generic/bitops/find.h b/include/asm-generic/bitops/find.h > index 8a1ee10014de..9fdf21302fdf 100644 > --- a/include/asm-generic/bitops/find.h > +++ b/include/asm-generic/bitops/find.h > @@ -80,4 +80,21 @@ extern unsigned long find_first_zero_bit(const unsigned long *addr, > > #endif /* CONFIG_GENERIC_FIND_FIRST_BIT */ > > +/** > + * find_next_clump8 - find next 8-bit clump with set bits in a memory region > + * @clump: location to store copy of found clump > + * @addr: address to base the search on > + * @size: bitmap size in number of bits > + * @offset: bit offset at which to start searching > + * > + * Returns the bit offset for the next set clump; the found clump value is > + * copied to the location pointed by @clump. If no bits are set, returns @size. > + */ > +extern unsigned long find_next_clump8(unsigned long *clump, > + const unsigned long *addr, > + unsigned long size, unsigned long offset); > + > +#define find_first_clump8(clump, bits, size) \ > + find_next_clump8((clump), (bits), (size), 0) > + > #endif /*_ASM_GENERIC_BITOPS_FIND_H_ */ > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h > index 90528f12bdfa..761fab5b60a7 100644 > --- a/include/linux/bitmap.h > +++ b/include/linux/bitmap.h > @@ -66,6 +66,8 @@ > * bitmap_allocate_region(bitmap, pos, order) Allocate specified bit region > * bitmap_from_arr32(dst, buf, nbits) Copy nbits from u32[] buf to dst > * bitmap_to_arr32(buf, src, nbits) Copy nbits from buf to u32[] dst > + * bitmap_get_value8(map, start) Get 8bit value from map at start > + * bitmap_set_value8(map, value, start) Set 8bit value to map at start > * > * Note, bitmap_zero() and bitmap_fill() operate over the region of > * unsigned longs, that is, bits behind bitmap till the unsigned long > @@ -488,6 +490,39 @@ static inline void bitmap_from_u64(unsigned long *dst, u64 mask) > dst[1] = mask >> 32; > } > > +/** > + * bitmap_get_value8 - get an 8-bit value within a memory region > + * @map: address to the bitmap memory region > + * @start: bit offset of the 8-bit value; must be a multiple of 8 > + * > + * Returns the 8-bit value located at the @start bit offset within the @src > + * memory region. > + */ > +static inline unsigned long bitmap_get_value8(const unsigned long *map, > + unsigned long start) Why is the return type "unsigned long" where you know it return the 8-bit value ? u8? > +{ > + const size_t index = BIT_WORD(start); > + const unsigned long offset = start % BITS_PER_LONG; > + > + return (map[index] >> offset) & 0xFF; > +} > + > +/** > + * bitmap_set_value8 - set an 8-bit value within a memory region > + * @map: address to the bitmap memory region > + * @value: the 8-bit value; values wider than 8 bits may clobber bitmap > + * @start: bit offset of the 8-bit value; must be a multiple of 8 > + */ > +static inline void bitmap_set_value8(unsigned long *map, unsigned long value, Same here, "u8 value" > + unsigned long start) > +{ > + const size_t index = BIT_WORD(start); > + const unsigned long offset = start % BITS_PER_LONG; > + > + map[index] &= ~(0xFF << offset); > + map[index] |= value << offset; > +} > + > #endif /* __ASSEMBLY__ */ > > #endif /* __LINUX_BITMAP_H */ > diff --git a/include/linux/bitops.h b/include/linux/bitops.h > index cf074bce3eb3..fb94a10f7853 100644 > --- a/include/linux/bitops.h > +++ b/include/linux/bitops.h > @@ -40,6 +40,11 @@ extern unsigned long __sw_hweight64(__u64 w); > (bit) < (size); \ > (bit) = find_next_zero_bit((addr), (size), (bit) + 1)) > > +#define for_each_set_clump8(start, clump, bits, size) \ > + for ((start) = find_first_clump8(&(clump), (bits), (size)); \ > + (start) < (size); \ > + (start) = find_next_clump8(&(clump), (bits), (size), (start) + 8)) > + > static inline int get_bitmask_order(unsigned int count) > { > int order; > diff --git a/lib/find_bit.c b/lib/find_bit.c > index 5c51eb45178a..e35a76b291e6 100644 > --- a/lib/find_bit.c > +++ b/lib/find_bit.c > @@ -214,3 +214,17 @@ EXPORT_SYMBOL(find_next_bit_le); > #endif > > #endif /* __BIG_ENDIAN */ > + > +unsigned long find_next_clump8(unsigned long *clump, const unsigned long *addr, Ditto. "u8 *clump" > + unsigned long size, unsigned long offset) > +{ > + offset = find_next_bit(addr, size, offset); > + if (offset == size) > + return size; > + > + offset = round_down(offset, 8); > + *clump = bitmap_get_value8(addr, offset); > + > + return offset; > +} > +EXPORT_SYMBOL(find_next_clump8); > -- > 2.23.0 > -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Masahiro Yamada" <yamada.masahiro@socionext.com> To: "William Breathitt Gray" <vilhelm.gray@gmail.com> Cc: linux-arch <linux-arch@vger.kernel.org>, "preid@electromag.com.au" <preid@electromag.com.au>, Arnd Bergmann <arnd@arndb.de>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Linux PM mailing list <linux-pm@vger.kernel.org>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "morten.tiljeset@prevas.dk" <morten.tiljeset@prevas.dk>, "sean.nyekjaer@prevas.dk" <sean.nyekjaer@prevas.dk>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, Lukas Wunner <lukas@wunner.de>, Geert Uytterhoeven <geert@linux-m68k.org>, Andrew Morton <akpm@linux-foundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v17 01/14] bitops: Introduce the for_each_set_clump8 macro Date: Thu, 10 Oct 2019 01:28:08 +0900 [thread overview] Message-ID: <CAK7LNATgW7bXUmqV=3QAaJ0Qu73Kox-TgDCQJb=s0=mwewSCUg@mail.gmail.com> (raw) Message-ID: <20191009162808.3o_Frhil9TX_CFea6smzxSnwvKOR1yeo2QWe1kZvHoI@z> (raw) In-Reply-To: <893c3b4f03266c9496137cc98ac2b1bd27f92c73.1570633189.git.vilhelm.gray@gmail.com> On Thu, Oct 10, 2019 at 12:27 AM William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > > This macro iterates for each 8-bit group of bits (clump) with set bits, > within a bitmap memory region. For each iteration, "start" is set to the > bit offset of the found clump, while the respective clump value is > stored to the location pointed by "clump". Additionally, the > bitmap_get_value8 and bitmap_set_value8 functions are introduced to > respectively get and set an 8-bit value in a bitmap memory region. > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Suggested-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > Suggested-by: Lukas Wunner <lukas@wunner.de> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > --- > include/asm-generic/bitops/find.h | 17 +++++++++++++++ > include/linux/bitmap.h | 35 +++++++++++++++++++++++++++++++ > include/linux/bitops.h | 5 +++++ > lib/find_bit.c | 14 +++++++++++++ > 4 files changed, 71 insertions(+) > > diff --git a/include/asm-generic/bitops/find.h b/include/asm-generic/bitops/find.h > index 8a1ee10014de..9fdf21302fdf 100644 > --- a/include/asm-generic/bitops/find.h > +++ b/include/asm-generic/bitops/find.h > @@ -80,4 +80,21 @@ extern unsigned long find_first_zero_bit(const unsigned long *addr, > > #endif /* CONFIG_GENERIC_FIND_FIRST_BIT */ > > +/** > + * find_next_clump8 - find next 8-bit clump with set bits in a memory region > + * @clump: location to store copy of found clump > + * @addr: address to base the search on > + * @size: bitmap size in number of bits > + * @offset: bit offset at which to start searching > + * > + * Returns the bit offset for the next set clump; the found clump value is > + * copied to the location pointed by @clump. If no bits are set, returns @size. > + */ > +extern unsigned long find_next_clump8(unsigned long *clump, > + const unsigned long *addr, > + unsigned long size, unsigned long offset); > + > +#define find_first_clump8(clump, bits, size) \ > + find_next_clump8((clump), (bits), (size), 0) > + > #endif /*_ASM_GENERIC_BITOPS_FIND_H_ */ > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h > index 90528f12bdfa..761fab5b60a7 100644 > --- a/include/linux/bitmap.h > +++ b/include/linux/bitmap.h > @@ -66,6 +66,8 @@ > * bitmap_allocate_region(bitmap, pos, order) Allocate specified bit region > * bitmap_from_arr32(dst, buf, nbits) Copy nbits from u32[] buf to dst > * bitmap_to_arr32(buf, src, nbits) Copy nbits from buf to u32[] dst > + * bitmap_get_value8(map, start) Get 8bit value from map at start > + * bitmap_set_value8(map, value, start) Set 8bit value to map at start > * > * Note, bitmap_zero() and bitmap_fill() operate over the region of > * unsigned longs, that is, bits behind bitmap till the unsigned long > @@ -488,6 +490,39 @@ static inline void bitmap_from_u64(unsigned long *dst, u64 mask) > dst[1] = mask >> 32; > } > > +/** > + * bitmap_get_value8 - get an 8-bit value within a memory region > + * @map: address to the bitmap memory region > + * @start: bit offset of the 8-bit value; must be a multiple of 8 > + * > + * Returns the 8-bit value located at the @start bit offset within the @src > + * memory region. > + */ > +static inline unsigned long bitmap_get_value8(const unsigned long *map, > + unsigned long start) Why is the return type "unsigned long" where you know it return the 8-bit value ? u8? > +{ > + const size_t index = BIT_WORD(start); > + const unsigned long offset = start % BITS_PER_LONG; > + > + return (map[index] >> offset) & 0xFF; > +} > + > +/** > + * bitmap_set_value8 - set an 8-bit value within a memory region > + * @map: address to the bitmap memory region > + * @value: the 8-bit value; values wider than 8 bits may clobber bitmap > + * @start: bit offset of the 8-bit value; must be a multiple of 8 > + */ > +static inline void bitmap_set_value8(unsigned long *map, unsigned long value, Same here, "u8 value" > + unsigned long start) > +{ > + const size_t index = BIT_WORD(start); > + const unsigned long offset = start % BITS_PER_LONG; > + > + map[index] &= ~(0xFF << offset); > + map[index] |= value << offset; > +} > + > #endif /* __ASSEMBLY__ */ > > #endif /* __LINUX_BITMAP_H */ > diff --git a/include/linux/bitops.h b/include/linux/bitops.h > index cf074bce3eb3..fb94a10f7853 100644 > --- a/include/linux/bitops.h > +++ b/include/linux/bitops.h > @@ -40,6 +40,11 @@ extern unsigned long __sw_hweight64(__u64 w); > (bit) < (size); \ > (bit) = find_next_zero_bit((addr), (size), (bit) + 1)) > > +#define for_each_set_clump8(start, clump, bits, size) \ > + for ((start) = find_first_clump8(&(clump), (bits), (size)); \ > + (start) < (size); \ > + (start) = find_next_clump8(&(clump), (bits), (size), (start) + 8)) > + > static inline int get_bitmask_order(unsigned int count) > { > int order; > diff --git a/lib/find_bit.c b/lib/find_bit.c > index 5c51eb45178a..e35a76b291e6 100644 > --- a/lib/find_bit.c > +++ b/lib/find_bit.c > @@ -214,3 +214,17 @@ EXPORT_SYMBOL(find_next_bit_le); > #endif > > #endif /* __BIG_ENDIAN */ > + > +unsigned long find_next_clump8(unsigned long *clump, const unsigned long *addr, Ditto. "u8 *clump" > + unsigned long size, unsigned long offset) > +{ > + offset = find_next_bit(addr, size, offset); > + if (offset == size) > + return size; > + > + offset = round_down(offset, 8); > + *clump = bitmap_get_value8(addr, offset); > + > + return offset; > +} > +EXPORT_SYMBOL(find_next_clump8); > -- > 2.23.0 > -- Best Regards Masahiro Yamada _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-09 16:29 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-09 15:26 [PATCH v17 00/14] Introduce the for_each_set_clump8 macro William Breathitt Gray 2019-10-09 15:26 ` William Breathitt Gray 2019-10-09 15:26 ` [PATCH v17 01/14] bitops: " William Breathitt Gray 2019-10-09 15:26 ` William Breathitt Gray 2019-10-09 16:28 ` Masahiro Yamada [this message] 2019-10-09 16:28 ` Masahiro Yamada 2019-10-09 17:02 ` William Breathitt Gray 2019-10-09 17:09 ` Andy Shevchenko 2019-10-09 18:54 ` Geert Uytterhoeven 2019-10-10 2:28 ` Masahiro Yamada 2019-10-10 5:49 ` Andy Shevchenko 2019-10-10 6:29 ` Geert Uytterhoeven 2019-10-10 7:41 ` Andy Shevchenko 2019-10-10 7:49 ` Geert Uytterhoeven 2019-10-10 8:07 ` Andy Shevchenko 2019-10-10 8:21 ` Geert Uytterhoeven 2019-10-10 13:12 ` William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 02/14] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray 2019-10-09 15:27 ` William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 03/14] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 04/14] gpio: 104-idi-48: " William Breathitt Gray 2019-10-09 15:27 ` William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 05/14] gpio: gpio-mm: " William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 06/14] gpio: ws16c48: " William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 07/14] gpio: pci-idio-16: " William Breathitt Gray 2019-10-09 15:27 ` William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 08/14] gpio: pcie-idio-24: " William Breathitt Gray 2019-10-09 15:27 ` William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 09/14] gpio: uniphier: " William Breathitt Gray 2019-10-09 15:27 ` William Breathitt Gray 2019-10-09 16:33 ` Masahiro Yamada 2019-10-09 16:33 ` Masahiro Yamada 2019-10-09 17:05 ` William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 10/14] gpio: 74x164: Utilize the " William Breathitt Gray 2019-10-09 15:27 ` William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 11/14] thermal: intel: intel_soc_dts_iosf: Utilize " William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 12/14] gpio: pisosr: Utilize the " William Breathitt Gray 2019-10-09 15:27 ` William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 13/14] gpio: max3191x: " William Breathitt Gray 2019-10-09 15:27 ` William Breathitt Gray 2019-10-09 15:27 ` [PATCH v17 14/14] gpio: pca953x: " William Breathitt Gray 2019-10-09 15:27 ` William Breathitt Gray
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK7LNATgW7bXUmqV=3QAaJ0Qu73Kox-TgDCQJb=s0=mwewSCUg@mail.gmail.com' \ --to=yamada.masahiro@socionext.com \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=bgolaszewski@baylibre.com \ --cc=geert@linux-m68k.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=lukas@wunner.de \ --cc=morten.tiljeset@prevas.dk \ --cc=preid@electromag.com.au \ --cc=sean.nyekjaer@prevas.dk \ --cc=vilhelm.gray@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).