* [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards @ 2021-05-25 14:30 Christoph Niedermaier 2021-06-02 19:50 ` Rob Herring 2021-07-14 2:26 ` Shawn Guo 0 siblings, 2 replies; 10+ messages in thread From: Christoph Niedermaier @ 2021-05-25 14:30 UTC (permalink / raw) To: devicetree Cc: Christoph Niedermaier, linux-arm-kernel, linux-kernel, robh+dt, Shawn Guo, kernel Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: robh+dt@kernel.org Cc: Shawn Guo <shawnguo@kernel.org> Cc: kernel@dh-electronics.com To: devicetree@vger.kernel.org --- V2: Remove line with fsl,imx6s on the DRC02 Board --- Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index fce2a8670b49..3c4ff79a3be7 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -407,6 +407,12 @@ properties: - const: dfi,fs700e-m60 - const: fsl,imx6dl + - description: i.MX6DL DHCOM PicoITX Board + items: + - const: dh,imx6dl-dhcom-picoitx + - const: dh,imx6dl-dhcom-som + - const: fsl,imx6dl + - description: i.MX6DL Gateworks Ventana Boards items: - enum: @@ -458,6 +464,12 @@ properties: - const: toradex,colibri_imx6dl # Colibri iMX6 Module - const: fsl,imx6dl + - description: i.MX6S DHCOM DRC02 Board + items: + - const: dh,imx6s-dhcom-drc02 + - const: dh,imx6s-dhcom-som + - const: fsl,imx6dl + - description: i.MX6SL based Boards items: - enum: -- 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards 2021-05-25 14:30 [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards Christoph Niedermaier @ 2021-06-02 19:50 ` Rob Herring 2021-06-16 11:19 ` Christoph Niedermaier 2021-07-14 2:26 ` Shawn Guo 1 sibling, 1 reply; 10+ messages in thread From: Rob Herring @ 2021-06-02 19:50 UTC (permalink / raw) To: Christoph Niedermaier Cc: devicetree, linux-arm-kernel, linux-kernel, Shawn Guo, kernel On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: > Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. > > Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: robh+dt@kernel.org > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: kernel@dh-electronics.com > To: devicetree@vger.kernel.org > --- > V2: Remove line with fsl,imx6s on the DRC02 Board > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index fce2a8670b49..3c4ff79a3be7 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -407,6 +407,12 @@ properties: > - const: dfi,fs700e-m60 > - const: fsl,imx6dl > > + - description: i.MX6DL DHCOM PicoITX Board > + items: > + - const: dh,imx6dl-dhcom-picoitx > + - const: dh,imx6dl-dhcom-som > + - const: fsl,imx6dl > + > - description: i.MX6DL Gateworks Ventana Boards > items: > - enum: > @@ -458,6 +464,12 @@ properties: > - const: toradex,colibri_imx6dl # Colibri iMX6 Module > - const: fsl,imx6dl > > + - description: i.MX6S DHCOM DRC02 Board > + items: > + - const: dh,imx6s-dhcom-drc02 > + - const: dh,imx6s-dhcom-som > + - const: fsl,imx6dl fsl,imx6s? > + > - description: i.MX6SL based Boards > items: > - enum: > -- > 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards 2021-06-02 19:50 ` Rob Herring @ 2021-06-16 11:19 ` Christoph Niedermaier 2021-06-16 11:32 ` Marek Vasut 0 siblings, 1 reply; 10+ messages in thread From: Christoph Niedermaier @ 2021-06-16 11:19 UTC (permalink / raw) To: robh+dt Cc: devicetree, linux-arm-kernel, linux-kernel, Shawn Guo, kernel, festevam Send reply also to Rob Herrings +dt email address: From: Rob Herring <robh@kernel.org> Sent: Wednesday, June 2, 2021 9:50 PM > On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: >> Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. >> >> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Cc: robh+dt@kernel.org >> Cc: Shawn Guo <shawnguo@kernel.org> >> Cc: kernel@dh-electronics.com >> To: devicetree@vger.kernel.org >> --- >> V2: Remove line with fsl,imx6s on the DRC02 Board >> --- >> Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >> index fce2a8670b49..3c4ff79a3be7 100644 >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >> @@ -407,6 +407,12 @@ properties: >> - const: dfi,fs700e-m60 >> - const: fsl,imx6dl >> >> + - description: i.MX6DL DHCOM PicoITX Board >> + items: >> + - const: dh,imx6dl-dhcom-picoitx >> + - const: dh,imx6dl-dhcom-som >> + - const: fsl,imx6dl >> + >> - description: i.MX6DL Gateworks Ventana Boards >> items: >> - enum: >> @@ -458,6 +464,12 @@ properties: >> - const: toradex,colibri_imx6dl # Colibri iMX6 Module >> - const: fsl,imx6dl >> >> + - description: i.MX6S DHCOM DRC02 Board >> + items: >> + - const: dh,imx6s-dhcom-drc02 >> + - const: dh,imx6s-dhcom-som >> + - const: fsl,imx6dl > > fsl,imx6s? In the first version I had here an additional line with "fsl,imx6s", but currently the kernel isn't supporting that compatible. The i.MX6 Solo is currently supported by "fsl,imx6dl". So my idea was to add both "fsl,imx6dl" and "fsl,imx6s" to match it maybe on a later kernel version. If there is no match with the Solo now, it will fall back to the i.MX6 DualLite. That is why I had both fsl,imx6s and fsl,imx6dl in that order. On Fabio's advice, I removed the line with "fsl,imx6s" in version 2. Is this what you meant by your comment? > >> + >> - description: i.MX6SL based Boards >> items: >> - enum: >> -- >> 2.11.0 Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards 2021-06-16 11:19 ` Christoph Niedermaier @ 2021-06-16 11:32 ` Marek Vasut 2021-07-08 7:38 ` Christoph Niedermaier 0 siblings, 1 reply; 10+ messages in thread From: Marek Vasut @ 2021-06-16 11:32 UTC (permalink / raw) To: Christoph Niedermaier, robh+dt Cc: devicetree, linux-arm-kernel, linux-kernel, Shawn Guo, kernel, festevam On 6/16/21 1:19 PM, Christoph Niedermaier wrote: > Send reply also to Rob Herrings +dt email address: > > From: Rob Herring <robh@kernel.org> > Sent: Wednesday, June 2, 2021 9:50 PM > >> On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: >>> Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. >>> >>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> Cc: robh+dt@kernel.org >>> Cc: Shawn Guo <shawnguo@kernel.org> >>> Cc: kernel@dh-electronics.com >>> To: devicetree@vger.kernel.org >>> --- >>> V2: Remove line with fsl,imx6s on the DRC02 Board >>> --- >>> Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>> index fce2a8670b49..3c4ff79a3be7 100644 >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>> @@ -407,6 +407,12 @@ properties: >>> - const: dfi,fs700e-m60 >>> - const: fsl,imx6dl >>> >>> + - description: i.MX6DL DHCOM PicoITX Board >>> + items: >>> + - const: dh,imx6dl-dhcom-picoitx >>> + - const: dh,imx6dl-dhcom-som >>> + - const: fsl,imx6dl >>> + >>> - description: i.MX6DL Gateworks Ventana Boards >>> items: >>> - enum: >>> @@ -458,6 +464,12 @@ properties: >>> - const: toradex,colibri_imx6dl # Colibri iMX6 Module >>> - const: fsl,imx6dl >>> >>> + - description: i.MX6S DHCOM DRC02 Board >>> + items: >>> + - const: dh,imx6s-dhcom-drc02 >>> + - const: dh,imx6s-dhcom-som >>> + - const: fsl,imx6dl >> >> fsl,imx6s? > > In the first version I had here an additional line with "fsl,imx6s", > but currently the kernel isn't supporting that compatible. The i.MX6 > Solo is currently supported by "fsl,imx6dl". So my idea was to add > both "fsl,imx6dl" and "fsl,imx6s" to match it maybe on a later kernel > version. If there is no match with the Solo now, it will fall back to > the i.MX6 DualLite. That is why I had both fsl,imx6s and fsl,imx6dl > in that order. On Fabio's advice, I removed the line with "fsl,imx6s" > in version 2. > Is this what you meant by your comment? I didn't notice that at first myself, but I think what Rob means is - const: dh,imx6s-dhcom-drc02 - const: dh,imx6s-dhcom-som - const: fsl,imx6dl <------ this should be consistent with the two above that is - const: dh,imx6s-dhcom-drc02 - const: dh,imx6s-dhcom-som -- const: fsl,imx6dl +- const: fsl,imx6s ^^^^^ But that is a bit odd here: - The MX6S is MX6DL with one CPU core disabled. - The DRC02 device can only house a SOM with MX6S and NOT with MX6DL (due to some thermal design consideration or something). - The kernel discerns the MX6S/MX6DL automatically based on the number of cores it reads from some register, therefore it only has the fsl,mx6dl compatible to cover both MX6S and MX6DL. So, the closest fallback compatible for this device really is the MX6DL, i.e. fsl,imx6dl. So I think this patch is correct as-is, no ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards 2021-06-16 11:32 ` Marek Vasut @ 2021-07-08 7:38 ` Christoph Niedermaier 2021-07-08 11:54 ` Fabio Estevam 2021-07-14 2:23 ` Shawn Guo 0 siblings, 2 replies; 10+ messages in thread From: Christoph Niedermaier @ 2021-07-08 7:38 UTC (permalink / raw) To: robh+dt Cc: devicetree, linux-arm-kernel, linux-kernel, Shawn Guo, kernel, festevam, Marek MV. Vasut From: Marek Vasut [mailto:marex@denx.de] Sent: Wednesday, June 16, 2021 1:33 PM > On 6/16/21 1:19 PM, Christoph Niedermaier wrote: >> Send reply also to Rob Herrings +dt email address: >> >> From: Rob Herring <robh@kernel.org> >> Sent: Wednesday, June 2, 2021 9:50 PM >> >>> On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: >>>> Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. >>>> >>>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Cc: robh+dt@kernel.org >>>> Cc: Shawn Guo <shawnguo@kernel.org> >>>> Cc: kernel@dh-electronics.com >>>> To: devicetree@vger.kernel.org >>>> --- >>>> V2: Remove line with fsl,imx6s on the DRC02 Board >>>> --- >>>> Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>>> index fce2a8670b49..3c4ff79a3be7 100644 >>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>>> @@ -407,6 +407,12 @@ properties: >>>> - const: dfi,fs700e-m60 >>>> - const: fsl,imx6dl >>>> >>>> + - description: i.MX6DL DHCOM PicoITX Board >>>> + items: >>>> + - const: dh,imx6dl-dhcom-picoitx >>>> + - const: dh,imx6dl-dhcom-som >>>> + - const: fsl,imx6dl >>>> + >>>> - description: i.MX6DL Gateworks Ventana Boards >>>> items: >>>> - enum: >>>> @@ -458,6 +464,12 @@ properties: >>>> - const: toradex,colibri_imx6dl # Colibri iMX6 Module >>>> - const: fsl,imx6dl >>>> >>>> + - description: i.MX6S DHCOM DRC02 Board >>>> + items: >>>> + - const: dh,imx6s-dhcom-drc02 >>>> + - const: dh,imx6s-dhcom-som >>>> + - const: fsl,imx6dl >>> >>> fsl,imx6s? >> >> In the first version I had here an additional line with "fsl,imx6s", >> but currently the kernel isn't supporting that compatible. The i.MX6 >> Solo is currently supported by "fsl,imx6dl". So my idea was to add >> both "fsl,imx6dl" and "fsl,imx6s" to match it maybe on a later kernel >> version. If there is no match with the Solo now, it will fall back to >> the i.MX6 DualLite. That is why I had both fsl,imx6s and fsl,imx6dl >> in that order. On Fabio's advice, I removed the line with "fsl,imx6s" >> in version 2. >> Is this what you meant by your comment? > > I didn't notice that at first myself, but I think what Rob means is > > - const: dh,imx6s-dhcom-drc02 > - const: dh,imx6s-dhcom-som > - const: fsl,imx6dl <------ this should be consistent with the two above > > that is > > - const: dh,imx6s-dhcom-drc02 > - const: dh,imx6s-dhcom-som > -- const: fsl,imx6dl > +- const: fsl,imx6s > ^^^^^ > > But that is a bit odd here: > - The MX6S is MX6DL with one CPU core disabled. > - The DRC02 device can only house a SOM with MX6S and NOT with MX6DL > (due to some thermal design consideration or something). > - The kernel discerns the MX6S/MX6DL automatically based on the number > of cores it reads from some register, therefore it only has the > fsl,mx6dl compatible to cover both MX6S and MX6DL. > So, the closest fallback compatible for this device really is the MX6DL, > i.e. fsl,imx6dl. > > So I think this patch is correct as-is, no ? Is this Patch OK? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards 2021-07-08 7:38 ` Christoph Niedermaier @ 2021-07-08 11:54 ` Fabio Estevam 2021-07-14 2:23 ` Shawn Guo 1 sibling, 0 replies; 10+ messages in thread From: Fabio Estevam @ 2021-07-08 11:54 UTC (permalink / raw) To: Christoph Niedermaier Cc: robh+dt, devicetree, linux-arm-kernel, linux-kernel, Shawn Guo, kernel, Marek MV. Vasut Hi Christoph, On Thu, Jul 8, 2021 at 4:39 AM Christoph Niedermaier <cniedermaier@dh-electronics.com> wrote: > Is this Patch OK? It looks good for me: Reviewed-by: Fabio Estevam <festevam@gmail.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards 2021-07-08 7:38 ` Christoph Niedermaier 2021-07-08 11:54 ` Fabio Estevam @ 2021-07-14 2:23 ` Shawn Guo 2021-07-14 20:13 ` Christoph Niedermaier 1 sibling, 1 reply; 10+ messages in thread From: Shawn Guo @ 2021-07-14 2:23 UTC (permalink / raw) To: Christoph Niedermaier Cc: robh+dt, devicetree, linux-arm-kernel, linux-kernel, kernel, festevam, Marek MV. Vasut On Thu, Jul 08, 2021 at 07:38:44AM +0000, Christoph Niedermaier wrote: > From: Marek Vasut [mailto:marex@denx.de] > Sent: Wednesday, June 16, 2021 1:33 PM > > > > On 6/16/21 1:19 PM, Christoph Niedermaier wrote: > >> Send reply also to Rob Herrings +dt email address: > >> > >> From: Rob Herring <robh@kernel.org> > >> Sent: Wednesday, June 2, 2021 9:50 PM > >> > >>> On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: > >>>> Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. > >>>> > >>>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> > >>>> Cc: linux-arm-kernel@lists.infradead.org > >>>> Cc: linux-kernel@vger.kernel.org > >>>> Cc: robh+dt@kernel.org > >>>> Cc: Shawn Guo <shawnguo@kernel.org> > >>>> Cc: kernel@dh-electronics.com > >>>> To: devicetree@vger.kernel.org > >>>> --- > >>>> V2: Remove line with fsl,imx6s on the DRC02 Board > >>>> --- > >>>> Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ > >>>> 1 file changed, 12 insertions(+) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > >>>> index fce2a8670b49..3c4ff79a3be7 100644 > >>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml > >>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > >>>> @@ -407,6 +407,12 @@ properties: > >>>> - const: dfi,fs700e-m60 > >>>> - const: fsl,imx6dl > >>>> > >>>> + - description: i.MX6DL DHCOM PicoITX Board > >>>> + items: > >>>> + - const: dh,imx6dl-dhcom-picoitx > >>>> + - const: dh,imx6dl-dhcom-som > >>>> + - const: fsl,imx6dl > >>>> + > >>>> - description: i.MX6DL Gateworks Ventana Boards > >>>> items: > >>>> - enum: > >>>> @@ -458,6 +464,12 @@ properties: > >>>> - const: toradex,colibri_imx6dl # Colibri iMX6 Module > >>>> - const: fsl,imx6dl > >>>> > >>>> + - description: i.MX6S DHCOM DRC02 Board > >>>> + items: > >>>> + - const: dh,imx6s-dhcom-drc02 > >>>> + - const: dh,imx6s-dhcom-som > >>>> + - const: fsl,imx6dl > >>> > >>> fsl,imx6s? > >> > >> In the first version I had here an additional line with "fsl,imx6s", > >> but currently the kernel isn't supporting that compatible. The i.MX6 > >> Solo is currently supported by "fsl,imx6dl". So my idea was to add > >> both "fsl,imx6dl" and "fsl,imx6s" to match it maybe on a later kernel > >> version. If there is no match with the Solo now, it will fall back to > >> the i.MX6 DualLite. That is why I had both fsl,imx6s and fsl,imx6dl > >> in that order. On Fabio's advice, I removed the line with "fsl,imx6s" > >> in version 2. > >> Is this what you meant by your comment? > > > > I didn't notice that at first myself, but I think what Rob means is > > > > - const: dh,imx6s-dhcom-drc02 > > - const: dh,imx6s-dhcom-som > > - const: fsl,imx6dl <------ this should be consistent with the two above > > > > that is > > > > - const: dh,imx6s-dhcom-drc02 > > - const: dh,imx6s-dhcom-som > > -- const: fsl,imx6dl > > +- const: fsl,imx6s > > ^^^^^ > > > > But that is a bit odd here: > > - The MX6S is MX6DL with one CPU core disabled. > > - The DRC02 device can only house a SOM with MX6S and NOT with MX6DL > > (due to some thermal design consideration or something). > > - The kernel discerns the MX6S/MX6DL automatically based on the number > > of cores it reads from some register, therefore it only has the > > fsl,mx6dl compatible to cover both MX6S and MX6DL. > > So, the closest fallback compatible for this device really is the MX6DL, > > i.e. fsl,imx6dl. > > > > So I think this patch is correct as-is, no ? > > Is this Patch OK? Can we explain that fsl,imx6s thing a bit with some comments or commit log? Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards 2021-07-14 2:23 ` Shawn Guo @ 2021-07-14 20:13 ` Christoph Niedermaier 0 siblings, 0 replies; 10+ messages in thread From: Christoph Niedermaier @ 2021-07-14 20:13 UTC (permalink / raw) To: Shawn Guo Cc: robh+dt, devicetree, linux-arm-kernel, linux-kernel, kernel, festevam, Marek MV. Vasut From: Shawn Guo [mailto:shawnguo@kernel.org] Sent: Wednesday, July 14, 2021 4:24 AM > On Thu, Jul 08, 2021 at 07:38:44AM +0000, Christoph Niedermaier wrote: >> From: Marek Vasut [mailto:marex@denx.de] >> Sent: Wednesday, June 16, 2021 1:33 PM >> >> >>> On 6/16/21 1:19 PM, Christoph Niedermaier wrote: >>>> Send reply also to Rob Herrings +dt email address: >>>> >>>> From: Rob Herring <robh@kernel.org> >>>> Sent: Wednesday, June 2, 2021 9:50 PM >>>> >>>>> On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: >>>>>> Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. >>>>>> >>>>>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> >>>>>> Cc: linux-arm-kernel@lists.infradead.org >>>>>> Cc: linux-kernel@vger.kernel.org >>>>>> Cc: robh+dt@kernel.org >>>>>> Cc: Shawn Guo <shawnguo@kernel.org> >>>>>> Cc: kernel@dh-electronics.com >>>>>> To: devicetree@vger.kernel.org >>>>>> --- >>>>>> V2: Remove line with fsl,imx6s on the DRC02 Board >>>>>> --- >>>>>> Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ >>>>>> 1 file changed, 12 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>>>>> index fce2a8670b49..3c4ff79a3be7 100644 >>>>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>>>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>>>>> @@ -407,6 +407,12 @@ properties: >>>>>> - const: dfi,fs700e-m60 >>>>>> - const: fsl,imx6dl >>>>>> >>>>>> + - description: i.MX6DL DHCOM PicoITX Board >>>>>> + items: >>>>>> + - const: dh,imx6dl-dhcom-picoitx >>>>>> + - const: dh,imx6dl-dhcom-som >>>>>> + - const: fsl,imx6dl >>>>>> + >>>>>> - description: i.MX6DL Gateworks Ventana Boards >>>>>> items: >>>>>> - enum: >>>>>> @@ -458,6 +464,12 @@ properties: >>>>>> - const: toradex,colibri_imx6dl # Colibri iMX6 Module >>>>>> - const: fsl,imx6dl >>>>>> >>>>>> + - description: i.MX6S DHCOM DRC02 Board >>>>>> + items: >>>>>> + - const: dh,imx6s-dhcom-drc02 >>>>>> + - const: dh,imx6s-dhcom-som >>>>>> + - const: fsl,imx6dl >>>>> >>>>> fsl,imx6s? >>>> >>>> In the first version I had here an additional line with "fsl,imx6s", >>>> but currently the kernel isn't supporting that compatible. The i.MX6 >>>> Solo is currently supported by "fsl,imx6dl". So my idea was to add >>>> both "fsl,imx6dl" and "fsl,imx6s" to match it maybe on a later kernel >>>> version. If there is no match with the Solo now, it will fall back to >>>> the i.MX6 DualLite. That is why I had both fsl,imx6s and fsl,imx6dl >>>> in that order. On Fabio's advice, I removed the line with "fsl,imx6s" >>>> in version 2. >>>> Is this what you meant by your comment? >>> >>> I didn't notice that at first myself, but I think what Rob means is >>> >>> - const: dh,imx6s-dhcom-drc02 >>> - const: dh,imx6s-dhcom-som >>> - const: fsl,imx6dl <------ this should be consistent with the two above >>> >>> that is >>> >>> - const: dh,imx6s-dhcom-drc02 >>> - const: dh,imx6s-dhcom-som >>> -- const: fsl,imx6dl >>> +- const: fsl,imx6s >>> ^^^^^ >>> >>> But that is a bit odd here: >>> - The MX6S is MX6DL with one CPU core disabled. >>> - The DRC02 device can only house a SOM with MX6S and NOT with MX6DL >>> (due to some thermal design consideration or something). >>> - The kernel discerns the MX6S/MX6DL automatically based on the number >>> of cores it reads from some register, therefore it only has the >>> fsl,mx6dl compatible to cover both MX6S and MX6DL. >>> So, the closest fallback compatible for this device really is the MX6DL, >>> i.e. fsl,imx6dl. >>> >>> So I think this patch is correct as-is, no ? >> >> Is this Patch OK? > > Can we explain that fsl,imx6s thing a bit with some comments or commit > log? > > Shawn I will send a version 3. Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards 2021-05-25 14:30 [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards Christoph Niedermaier 2021-06-02 19:50 ` Rob Herring @ 2021-07-14 2:26 ` Shawn Guo 2021-07-14 20:19 ` Christoph Niedermaier 1 sibling, 1 reply; 10+ messages in thread From: Shawn Guo @ 2021-07-14 2:26 UTC (permalink / raw) To: Christoph Niedermaier Cc: devicetree, linux-arm-kernel, linux-kernel, robh+dt, kernel On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: > Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. > > Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: robh+dt@kernel.org > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: kernel@dh-electronics.com > To: devicetree@vger.kernel.org > --- > V2: Remove line with fsl,imx6s on the DRC02 Board > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ In the future, please have this bindings patch included in the series that actually uses it. Shawn > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index fce2a8670b49..3c4ff79a3be7 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -407,6 +407,12 @@ properties: > - const: dfi,fs700e-m60 > - const: fsl,imx6dl > > + - description: i.MX6DL DHCOM PicoITX Board > + items: > + - const: dh,imx6dl-dhcom-picoitx > + - const: dh,imx6dl-dhcom-som > + - const: fsl,imx6dl > + > - description: i.MX6DL Gateworks Ventana Boards > items: > - enum: > @@ -458,6 +464,12 @@ properties: > - const: toradex,colibri_imx6dl # Colibri iMX6 Module > - const: fsl,imx6dl > > + - description: i.MX6S DHCOM DRC02 Board > + items: > + - const: dh,imx6s-dhcom-drc02 > + - const: dh,imx6s-dhcom-som > + - const: fsl,imx6dl > + > - description: i.MX6SL based Boards > items: > - enum: > -- > 2.11.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards 2021-07-14 2:26 ` Shawn Guo @ 2021-07-14 20:19 ` Christoph Niedermaier 0 siblings, 0 replies; 10+ messages in thread From: Christoph Niedermaier @ 2021-07-14 20:19 UTC (permalink / raw) To: Shawn Guo Cc: robh+dt, devicetree, linux-arm-kernel, linux-kernel, kernel, festevam, Marek MV. Vasut From: Shawn Guo [mailto:shawnguo@kernel.org] Sent: Wednesday, July 14, 2021 4:26 AM > On Tue, May 25, 2021 at 04:30:01PM +0200, Christoph Niedermaier wrote: >> Add DH electronics DHCOM PicoITX and DHCOM DRC02 boards. >> >> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Cc: robh+dt@kernel.org >> Cc: Shawn Guo <shawnguo@kernel.org> >> Cc: kernel@dh-electronics.com >> To: devicetree@vger.kernel.org >> --- >> V2: Remove line with fsl,imx6s on the DRC02 Board >> --- >> Documentation/devicetree/bindings/arm/fsl.yaml | 12 ++++++++++++ > > In the future, please have this bindings patch included in the series > that actually uses it. > > Shawn > OK. Thanks and regards Christoph >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >> index fce2a8670b49..3c4ff79a3be7 100644 >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >> @@ -407,6 +407,12 @@ properties: >> - const: dfi,fs700e-m60 >> - const: fsl,imx6dl >> >> + - description: i.MX6DL DHCOM PicoITX Board >> + items: >> + - const: dh,imx6dl-dhcom-picoitx >> + - const: dh,imx6dl-dhcom-som >> + - const: fsl,imx6dl >> + >> - description: i.MX6DL Gateworks Ventana Boards >> items: >> - enum: >> @@ -458,6 +464,12 @@ properties: >> - const: toradex,colibri_imx6dl # Colibri iMX6 Module >> - const: fsl,imx6dl >> >> + - description: i.MX6S DHCOM DRC02 Board >> + items: >> + - const: dh,imx6s-dhcom-drc02 >> + - const: dh,imx6s-dhcom-som >> + - const: fsl,imx6dl >> + >> - description: i.MX6SL based Boards >> items: >> - enum: >> -- >> 2.11.0 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-07-14 23:31 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-25 14:30 [PATCH V2] dt-bindings: arm: fsl: Add DHCOM PicoITX and DHCOM DRC02 boards Christoph Niedermaier 2021-06-02 19:50 ` Rob Herring 2021-06-16 11:19 ` Christoph Niedermaier 2021-06-16 11:32 ` Marek Vasut 2021-07-08 7:38 ` Christoph Niedermaier 2021-07-08 11:54 ` Fabio Estevam 2021-07-14 2:23 ` Shawn Guo 2021-07-14 20:13 ` Christoph Niedermaier 2021-07-14 2:26 ` Shawn Guo 2021-07-14 20:19 ` Christoph Niedermaier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).