* [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile
@ 2022-09-26 9:35 Irui Wang
2022-09-28 13:38 ` Allen-KH Cheng (程冠勳)
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Irui Wang @ 2022-09-26 9:35 UTC (permalink / raw)
To: Hans Verkuil, Alexandre Courbot, Tiffany Lin,
Mauro Carvalho Chehab, Rob Herring, Matthias Brugger,
Hsin-Yi Wang, angelogioacchino.delregno, nicolas.dufresne
Cc: Maoguang Meng, Longfei Wang, Yunfei Dong, Irui Wang, linux-media,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
The encoder driver support h264 baseline, main, high encoder
profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
the unsupported profile.
get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
0: Baseline
2: Main
4: High
Signed-off-by: Irui Wang <irui.wang@mediatek.com>
---
drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
index d810a78dde51..d65800a3b89d 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
@@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct mtk_vcodec_ctx *ctx)
0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE);
v4l2_ctrl_new_std_menu(handler, ops, V4L2_CID_MPEG_VIDEO_H264_PROFILE,
V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
- 0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
+ ~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE) |
+ (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
+ (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
+ V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
v4l2_ctrl_new_std_menu(handler, ops, V4L2_CID_MPEG_VIDEO_H264_LEVEL,
h264_max_level,
0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile
2022-09-26 9:35 [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile Irui Wang
@ 2022-09-28 13:38 ` Allen-KH Cheng (程冠勳)
2022-09-29 1:54 ` yunfei.dong
2022-09-29 8:32 ` AngeloGioacchino Del Regno
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Allen-KH Cheng (程冠勳) @ 2022-09-28 13:38 UTC (permalink / raw)
To: robh+dt, Tiffany Lin (林慧珊),
mchehab, nicolas.dufresne, Irui Wang (王瑞),
hsinyi, hverkuil-cisco, matthias.bgg, angelogioacchino.delregno,
acourbot
Cc: linux-kernel, linux-mediatek,
Longfei Wang (王龙飞),
linux-media, devicetree, Maoguang Meng (孟毛广),
Yunfei Dong (董云飞),
Project_Global_Chrome_Upstream_Group, linux-arm-kernel
Hi Irui,
Tested-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Tested for CTS cases on the mt8186 corsola board.
Thanks,
Allen
On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote:
> The encoder driver support h264 baseline, main, high encoder
> profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
> the unsupported profile.
>
> get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
> h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
> 0: Baseline
> 2: Main
> 4: High
>
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> ---
> drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> index d810a78dde51..d65800a3b89d 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct
> mtk_vcodec_ctx *ctx)
> 0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE);
> v4l2_ctrl_new_std_menu(handler, ops,
> V4L2_CID_MPEG_VIDEO_H264_PROFILE,
> V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
> - 0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> + ~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE)
> |
> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
> + V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> v4l2_ctrl_new_std_menu(handler, ops,
> V4L2_CID_MPEG_VIDEO_H264_LEVEL,
> h264_max_level,
> 0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile
2022-09-28 13:38 ` Allen-KH Cheng (程冠勳)
@ 2022-09-29 1:54 ` yunfei.dong
0 siblings, 0 replies; 8+ messages in thread
From: yunfei.dong @ 2022-09-29 1:54 UTC (permalink / raw)
To: Allen-KH Cheng (程冠勳),
robh+dt, Tiffany Lin (林慧珊),
mchehab, nicolas.dufresne, Irui Wang (王瑞),
hsinyi, hverkuil-cisco, matthias.bgg, angelogioacchino.delregno,
acourbot
Cc: linux-kernel, linux-mediatek,
Longfei Wang (王龙飞),
linux-media, devicetree, Maoguang Meng (孟毛广),
Project_Global_Chrome_Upstream_Group, linux-arm-kernel
Hi Irui,
Reviewed-by: Yunfei Dong <yunfei.dong@mediatek.com>
Thanks
Yunfei Dong
On Wed, 2022-09-28 at 21:38 +0800, Allen-KH Cheng (程冠勳) wrote:
> Hi Irui,
>
> Tested-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
>
> Tested for CTS cases on the mt8186 corsola board.
>
> Thanks,
> Allen
>
> On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote:
> > The encoder driver support h264 baseline, main, high encoder
> > profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
> > the unsupported profile.
> >
> > get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
> > h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
> > 0: Baseline
> > 2: Main
> > 4: High
> >
> > Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> > ---
> > drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > index d810a78dde51..d65800a3b89d 100644
> > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct
> > mtk_vcodec_ctx *ctx)
> > 0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE);
> > v4l2_ctrl_new_std_menu(handler, ops,
> > V4L2_CID_MPEG_VIDEO_H264_PROFILE,
> > V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
> > - 0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> > + ~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE)
> > >
> >
> > + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
> > + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
> > + V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> > v4l2_ctrl_new_std_menu(handler, ops,
> > V4L2_CID_MPEG_VIDEO_H264_LEVEL,
> > h264_max_level,
> > 0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile
2022-09-26 9:35 [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile Irui Wang
2022-09-28 13:38 ` Allen-KH Cheng (程冠勳)
@ 2022-09-29 8:32 ` AngeloGioacchino Del Regno
2022-10-19 10:07 ` Irui Wang
2022-11-15 11:40 ` Irui Wang (王瑞)
3 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-29 8:32 UTC (permalink / raw)
To: Irui Wang, Hans Verkuil, Alexandre Courbot, Tiffany Lin,
Mauro Carvalho Chehab, Rob Herring, Matthias Brugger,
Hsin-Yi Wang, nicolas.dufresne
Cc: Maoguang Meng, Longfei Wang, Yunfei Dong, linux-media,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Il 26/09/22 11:35, Irui Wang ha scritto:
> The encoder driver support h264 baseline, main, high encoder
> profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
> the unsupported profile.
>
> get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
> h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
> 0: Baseline
> 2: Main
> 4: High
>
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile
2022-09-26 9:35 [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile Irui Wang
2022-09-28 13:38 ` Allen-KH Cheng (程冠勳)
2022-09-29 8:32 ` AngeloGioacchino Del Regno
@ 2022-10-19 10:07 ` Irui Wang
2022-11-15 11:40 ` Irui Wang (王瑞)
3 siblings, 0 replies; 8+ messages in thread
From: Irui Wang @ 2022-10-19 10:07 UTC (permalink / raw)
To: Hans Verkuil, Alexandre Courbot, Tiffany Lin,
Mauro Carvalho Chehab, Rob Herring, Matthias Brugger,
Hsin-Yi Wang, angelogioacchino.delregno, nicolas.dufresne
Cc: Maoguang Meng, Longfei Wang, Yunfei Dong, linux-media,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Dear Hans,
Gently ping for this patch, could you help to review this patch?
Thanks
Best Regards
On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote:
> The encoder driver support h264 baseline, main, high encoder
> profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
> the unsupported profile.
>
> get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
> h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
> 0: Baseline
> 2: Main
> 4: High
>
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> ---
> drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> index d810a78dde51..d65800a3b89d 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct
> mtk_vcodec_ctx *ctx)
> 0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE);
> v4l2_ctrl_new_std_menu(handler, ops,
> V4L2_CID_MPEG_VIDEO_H264_PROFILE,
> V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
> - 0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> + ~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE)
> |
> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
> + V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> v4l2_ctrl_new_std_menu(handler, ops,
> V4L2_CID_MPEG_VIDEO_H264_LEVEL,
> h264_max_level,
> 0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile
2022-09-26 9:35 [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile Irui Wang
` (2 preceding siblings ...)
2022-10-19 10:07 ` Irui Wang
@ 2022-11-15 11:40 ` Irui Wang (王瑞)
2022-11-15 11:49 ` Hans Verkuil
3 siblings, 1 reply; 8+ messages in thread
From: Irui Wang (王瑞) @ 2022-11-15 11:40 UTC (permalink / raw)
To: robh+dt, Tiffany Lin (林慧珊),
mchehab, nicolas.dufresne, hverkuil-cisco, hsinyi, matthias.bgg,
angelogioacchino.delregno, acourbot
Cc: linux-kernel, linux-mediatek,
Longfei Wang (王龙飞),
linux-media, devicetree, Maoguang Meng (孟毛广),
Yunfei Dong (董云飞),
Project_Global_Chrome_Upstream_Group, linux-arm-kernel
Dear Hans,
Gently ping for this patch.
May I know this patch current status? It seems is under your reviewing
state?
Thanks
Best Regards
On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote:
> The encoder driver support h264 baseline, main, high encoder
> profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
> the unsupported profile.
>
> get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
> h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
> 0: Baseline
> 2: Main
> 4: High
>
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> ---
> drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> index d810a78dde51..d65800a3b89d 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct
> mtk_vcodec_ctx *ctx)
> 0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE);
> v4l2_ctrl_new_std_menu(handler, ops,
> V4L2_CID_MPEG_VIDEO_H264_PROFILE,
> V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
> - 0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> + ~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE)
> |
> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
> + V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> v4l2_ctrl_new_std_menu(handler, ops,
> V4L2_CID_MPEG_VIDEO_H264_LEVEL,
> h264_max_level,
> 0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile
2022-11-15 11:40 ` Irui Wang (王瑞)
@ 2022-11-15 11:49 ` Hans Verkuil
2022-11-15 11:57 ` Irui Wang (王瑞)
0 siblings, 1 reply; 8+ messages in thread
From: Hans Verkuil @ 2022-11-15 11:49 UTC (permalink / raw)
To: Irui Wang (王瑞),
robh+dt, Tiffany Lin (林慧珊),
mchehab, nicolas.dufresne, hsinyi, matthias.bgg,
angelogioacchino.delregno, acourbot
Cc: linux-kernel, linux-mediatek,
Longfei Wang (王龙飞),
linux-media, devicetree, Maoguang Meng (孟毛广),
Yunfei Dong (董云飞),
Project_Global_Chrome_Upstream_Group, linux-arm-kernel
Hi Irui,
On 11/15/22 12:40, Irui Wang (王瑞) wrote:
> Dear Hans,
>
> Gently ping for this patch.
> May I know this patch current status? It seems is under your reviewing
> state?
Mauro was on vacation last week, but he said that he hopes to merge
the pending PRs tomorrow. Fingers crossed...
Regards,
Hans
>
> Thanks
> Best Regards
>
> On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote:
>> The encoder driver support h264 baseline, main, high encoder
>> profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
>> the unsupported profile.
>>
>> get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
>> h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
>> 0: Baseline
>> 2: Main
>> 4: High
>>
>> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
>> ---
>> drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
>> b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
>> index d810a78dde51..d65800a3b89d 100644
>> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
>> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
>> @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct
>> mtk_vcodec_ctx *ctx)
>> 0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE);
>> v4l2_ctrl_new_std_menu(handler, ops,
>> V4L2_CID_MPEG_VIDEO_H264_PROFILE,
>> V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
>> -0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
>> +~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE)
>> |
>> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
>> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
>> +V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
>> v4l2_ctrl_new_std_menu(handler, ops,
>> V4L2_CID_MPEG_VIDEO_H264_LEVEL,
>> h264_max_level,
>> 0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
>
> ************* MEDIATEK Confidentiality Notice
> ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
>
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile
2022-11-15 11:49 ` Hans Verkuil
@ 2022-11-15 11:57 ` Irui Wang (王瑞)
0 siblings, 0 replies; 8+ messages in thread
From: Irui Wang (王瑞) @ 2022-11-15 11:57 UTC (permalink / raw)
To: robh+dt, Tiffany Lin (林慧珊),
nicolas.dufresne, mchehab, hverkuil-cisco, hsinyi, matthias.bgg,
angelogioacchino.delregno, acourbot
Cc: linux-kernel, linux-mediatek,
Longfei Wang (王龙飞),
linux-media, devicetree, Maoguang Meng (孟毛广),
Yunfei Dong (董云飞),
Project_Global_Chrome_Upstream_Group, linux-arm-kernel
Dear Hans,
Got it, thank you very much.
Best Regards
On Tue, 2022-11-15 at 12:49 +0100, Hans Verkuil wrote:
> Hi Irui,
>
> On 11/15/22 12:40, Irui Wang (王瑞) wrote:
> > Dear Hans,
> >
> > Gently ping for this patch.
> > May I know this patch current status? It seems is under your
> > reviewing
> > state?
>
> Mauro was on vacation last week, but he said that he hopes to merge
> the pending PRs tomorrow. Fingers crossed...
>
> Regards,
>
> Hans
>
> >
> > Thanks
> > Best Regards
> >
> > On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote:
> > > The encoder driver support h264 baseline, main, high encoder
> > > profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
> > > the unsupported profile.
> > >
> > > get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
> > > h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
> > > 0: Baseline
> > > 2: Main
> > > 4: High
> > >
> > > Signed-off-by: Irui Wang <irui.wang@mediatek.com>
> > > ---
> > > drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5
> > > ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > > b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > > index d810a78dde51..d65800a3b89d 100644
> > > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
> > > @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct
> > > mtk_vcodec_ctx *ctx)
> > > 0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE);
> > > v4l2_ctrl_new_std_menu(handler, ops,
> > > V4L2_CID_MPEG_VIDEO_H264_PROFILE,
> > > V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
> > > -0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> > > +~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE)
> > > >
> > >
> > > + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
> > > + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
> > > +V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
> > > v4l2_ctrl_new_std_menu(handler, ops,
> > > V4L2_CID_MPEG_VIDEO_H264_LEVEL,
> > > h264_max_level,
> > > 0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
> >
> > ************* MEDIATEK Confidentiality Notice
> > ********************
> > The information contained in this e-mail message (including any
> > attachments) may be confidential, proprietary, privileged, or
> > otherwise
> > exempt from disclosure under applicable laws. It is intended to be
> > conveyed only to the designated recipient(s). Any use,
> > dissemination,
> > distribution, printing, retaining or copying of this e-mail
> > (including its
> > attachments) by unintended recipient(s) is strictly prohibited and
> > may
> > be unlawful. If you are not an intended recipient of this e-mail,
> > or believe
> >
> > that you have received this e-mail in error, please notify the
> > sender
> > immediately (by replying to this e-mail), delete any and all copies
> > of
> > this e-mail (including any attachments) from your system, and do
> > not
> > disclose the content of this e-mail to any other person. Thank you!
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-15 12:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 9:35 [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile Irui Wang
2022-09-28 13:38 ` Allen-KH Cheng (程冠勳)
2022-09-29 1:54 ` yunfei.dong
2022-09-29 8:32 ` AngeloGioacchino Del Regno
2022-10-19 10:07 ` Irui Wang
2022-11-15 11:40 ` Irui Wang (王瑞)
2022-11-15 11:49 ` Hans Verkuil
2022-11-15 11:57 ` Irui Wang (王瑞)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).