From: Rajendra Nayak <rnayak@codeaurora.org>
To: linux-kernel@vger.kernel.org
Cc: ulf.hansson@linaro.org, Rajendra Nayak <rnayak@codeaurora.org>,
linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, rafael@kernel.org,
dianders@chromium.org, dri-devel@lists.freedesktop.org,
linux-spi@vger.kernel.org, linux-serial@vger.kernel.org,
viresh.kumar@linaro.org, swboyd@chromium.org
Subject: [RFC v2 06/11] scsi: ufs: Add support to manage multiple power domains in ufshcd-pltfrm
Date: Wed, 20 Mar 2019 15:19:13 +0530 [thread overview]
Message-ID: <20190320094918.20234-7-rnayak@codeaurora.org> (raw)
In-Reply-To: <20190320094918.20234-1-rnayak@codeaurora.org>
Some UFS devices need to manage multiple powerdomains. Add support for
it as part of the ufshcd-pltfrm driver.
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 52 +++++++++++++++++++++++++++++++-
drivers/scsi/ufs/ufshcd.h | 3 ++
2 files changed, 54 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 238a79f21e74..ce33eb8b7510 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -34,6 +34,7 @@
*/
#include <linux/platform_device.h>
+#include <linux/pm_domain.h>
#include <linux/pm_runtime.h>
#include <linux/of.h>
@@ -289,6 +290,43 @@ static void ufshcd_init_lanes_per_dir(struct ufs_hba *hba)
}
}
+static int ufshcd_attach_pds(struct device *dev, struct ufs_hba *hba, int num_pds)
+{
+ int i, ret;
+
+ hba->virt_devs = devm_kzalloc(dev, sizeof(struct device *) * num_pds,
+ GFP_KERNEL);
+ if (!hba->virt_devs)
+ return -ENOMEM;
+
+ hba->num_virt_devs = num_pds;
+ for (i = 0; i < num_pds; i++) {
+ hba->virt_devs[i] = dev_pm_domain_attach_by_id(dev, i);
+ if (IS_ERR(hba->virt_devs[i])) {
+ ret = PTR_ERR(hba->virt_devs[i]);
+ goto unroll_attach;
+ }
+ device_link_add(dev,hba->virt_devs[i], DL_FLAG_RPM_ACTIVE |
+ DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS);
+ }
+
+ return ret;
+
+unroll_attach:
+ for (i--; i >= 0; i--)
+ dev_pm_domain_detach(hba->virt_devs[i], false);
+
+ return ret;
+}
+
+static void ufshcd_detach_pds(struct ufs_hba *hba)
+{
+ int i;
+
+ for (i = 0; i < hba->num_virt_devs; i++)
+ dev_pm_domain_detach(hba->virt_devs[i], false);
+}
+
/**
* ufshcd_pltfrm_init - probe routine of the driver
* @pdev: pointer to Platform device handle
@@ -302,7 +340,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
struct ufs_hba *hba;
void __iomem *mmio_base;
struct resource *mem_res;
- int irq, err;
+ int irq, err, num_pds;
struct device *dev = &pdev->dev;
mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -340,6 +378,16 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
goto dealloc_host;
}
+ num_pds = of_count_phandle_with_args(dev->of_node, "power-domains",
+ "#power-domain-cells");
+ if (num_pds > 1) {
+ err = ufshcd_attach_pds(&pdev->dev, hba, num_pds);
+ if (err) {
+ dev_err(&pdev->dev, "%s: attach of power domains failed %d\n",
+ __func__, err);
+ goto dealloc_host;
+ }
+ }
pm_runtime_get_noresume(&pdev->dev);
pm_runtime_set_active(&pdev->dev);
pm_runtime_enable(&pdev->dev);
@@ -358,6 +406,8 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
return 0;
out_disable_rpm:
+ if (num_pds > 1)
+ ufshcd_detach_pds(hba);
pm_runtime_disable(&pdev->dev);
pm_runtime_set_suspended(&pdev->dev);
pm_runtime_put_noidle(&pdev->dev);
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index ecfa898b9ccc..bca1e008f506 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -517,6 +517,9 @@ struct ufs_hba {
struct Scsi_Host *host;
struct device *dev;
+ struct device **virt_devs;
+ u8 num_virt_devs;
+
/*
* This field is to keep a reference to "scsi_device" corresponding to
* "UFS device" W-LU.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-20 9:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 9:49 [RFC v2 00/11] DVFS in the OPP core Rajendra Nayak
2019-03-20 9:49 ` [RFC v2 01/11] OPP: Don't overwrite rounded clk rate Rajendra Nayak
2019-06-11 10:54 ` Viresh Kumar
2019-06-12 7:42 ` Rajendra Nayak
2019-06-12 8:25 ` Viresh Kumar
2019-06-13 9:54 ` Viresh Kumar
2019-06-14 5:27 ` Viresh Kumar
2019-06-17 3:50 ` Viresh Kumar
2019-06-17 4:07 ` Rajendra Nayak
2019-06-17 4:17 ` Viresh Kumar
2019-06-17 4:25 ` Rajendra Nayak
2019-06-14 5:54 ` Rajendra Nayak
2019-03-20 9:49 ` [RFC v2 02/11] OPP: Make dev_pm_opp_set_rate() with freq=0 as valid Rajendra Nayak
2019-06-14 6:32 ` Viresh Kumar
2019-06-17 4:04 ` Rajendra Nayak
2019-03-20 9:49 ` [RFC v2 03/11] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state Rajendra Nayak
2020-08-11 23:11 ` John Stultz
2020-08-12 1:33 ` John Stultz
2020-08-12 5:48 ` Rajendra Nayak
2020-08-12 7:35 ` Amit Pundir
2020-08-12 7:39 ` Rajendra Nayak
2020-08-12 9:26 ` Rajendra Nayak
2019-03-20 9:49 ` [RFC v2 04/11] spi: spi-geni-qcom: " Rajendra Nayak
2019-03-20 9:49 ` [RFC v2 05/11] arm64: dts: sdm845: Add OPP table for all qup devices Rajendra Nayak
2019-03-20 9:49 ` Rajendra Nayak [this message]
2019-03-20 9:49 ` [RFC v2 07/11] scsi: ufs: Add support for specifying OPP tables in DT Rajendra Nayak
2019-03-20 9:49 ` [RFC v2 08/11] arm64: dts: sdm845: Add ufs opps and power-domains Rajendra Nayak
2019-05-14 7:53 ` Ulf Hansson
2019-03-20 9:49 ` [RFC v2 09/11] drm/msm/dpu: Use OPP API to set clk/perf state Rajendra Nayak
2019-04-10 3:49 ` Viresh Kumar
2019-04-10 3:49 ` Viresh Kumar
2019-03-20 9:49 ` [RFC v2 10/11] drm/msm: dsi: " Rajendra Nayak
2019-03-20 9:49 ` [RFC v2 11/11] arm64: dts: sdm845: Add DSI and MDP OPP tables and power-domains Rajendra Nayak
2019-04-10 3:51 ` [RFC v2 00/11] DVFS in the OPP core Viresh Kumar
2019-04-10 3:51 ` Viresh Kumar
2019-05-21 6:22 ` Viresh Kumar
2019-05-24 6:03 ` Rajendra Nayak
2019-06-17 4:26 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320094918.20234-7-rnayak@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).