From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] regulator: dt-bindings: Sort the compatibles and nodes
Date: Fri, 9 Aug 2019 10:01:34 -0700
Message-ID: <20190809170134.GM26807@tuxbook-pro> (raw)
In-Reply-To: <20190809073616.1235-1-vkoul@kernel.org>
On Fri 09 Aug 00:36 PDT 2019, Vinod Koul wrote:
> It helps to keep sorted order for compatibles and nodes, so sort them
>
> Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> .../regulator/qcom,rpmh-regulator.txt | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt
> index 1a9cab50503a..bab9f71140b8 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt
> @@ -22,12 +22,12 @@ RPMh resource.
>
> The names used for regulator nodes must match those supported by a given PMIC.
> Supported regulator node names:
> - PM8998: smps1 - smps13, ldo1 - ldo28, lvs1 - lvs2
> - PMI8998: bob
> PM8005: smps1 - smps4
> + PM8009: smps1 - smps2, ldo1 - ldo7
> PM8150: smps1 - smps10, ldo1 - ldo18
> PM8150L: smps1 - smps8, ldo1 - ldo11, bob, flash, rgb
> - PM8009: smps1 - smps2, ld01 - ldo7
> + PM8998: smps1 - smps13, ldo1 - ldo28, lvs1 - lvs2
> + PMI8998: bob
>
> ========================
> First Level Nodes - PMIC
> @@ -36,12 +36,13 @@ First Level Nodes - PMIC
> - compatible
> Usage: required
> Value type: <string>
> - Definition: Must be one of: "qcom,pm8998-rpmh-regulators",
> - "qcom,pmi8998-rpmh-regulators" or
> - "qcom,pm8005-rpmh-regulators" or
> - "qcom,pm8150-rpmh-regulators" or
> - "qcom,pm8150l-rpmh-regulators" or
> - "qcom,pm8009-rpmh-regulators".
> + Definition: Must be one of below:
> + "qcom,pm8005-rpmh-regulators"
> + "qcom,pm8009-rpmh-regulators"
> + "qcom,pm8150-rpmh-regulators"
> + "qcom,pm8150l-rpmh-regulators"
> + "qcom,pm8998-rpmh-regulators"
> + "qcom,pmi8998-rpmh-regulators"
Thanks for dropping the "or" as well.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> - qcom,pmic-id
> Usage: required
> --
> 2.20.1
>
prev parent reply index
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 7:36 Vinod Koul
2019-08-09 7:36 ` [PATCH 2/4] regulator: qcom-rpmh: Sort the compatibles Vinod Koul
2019-08-09 12:31 ` Applied "regulator: qcom-rpmh: Sort the compatibles" to the regulator tree Mark Brown
2019-08-09 17:02 ` [PATCH 2/4] regulator: qcom-rpmh: Sort the compatibles Bjorn Andersson
2019-08-09 7:36 ` [PATCH 3/4] regulator: qcom-rpmh: Fix pmic5_bob voltage count Vinod Koul
2019-08-09 12:31 ` Applied "regulator: qcom-rpmh: Fix pmic5_bob voltage count" to the regulator tree Mark Brown
2019-08-09 17:03 ` [PATCH 3/4] regulator: qcom-rpmh: Fix pmic5_bob voltage count Bjorn Andersson
2019-08-09 7:36 ` [PATCH 4/4] regulator: qcom-rpmh: Update PMIC modes for PMIC5 Vinod Koul
2019-08-09 12:31 ` Applied "regulator: qcom-rpmh: Update PMIC modes for PMIC5" to the regulator tree Mark Brown
2019-08-09 18:00 ` [PATCH 4/4] regulator: qcom-rpmh: Update PMIC modes for PMIC5 Bjorn Andersson
2019-08-09 12:31 ` Applied "regulator: dt-bindings: Sort the compatibles and nodes" to the regulator tree Mark Brown
2019-08-09 17:01 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809170134.GM26807@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-ARM-MSM Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
linux-arm-msm@vger.kernel.org
public-inbox-index linux-arm-msm
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git