* [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
@ 2021-01-26 12:45 ` Lee Jones
2021-01-26 13:59 ` Bjorn Andersson
2021-02-11 19:54 ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret' Lee Jones
` (5 subsequent siblings)
6 siblings, 2 replies; 35+ messages in thread
From: Lee Jones @ 2021-01-26 12:45 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, linux-arm-msm, linux-clk
Fixes the following W=1 kernel build warning(s):
drivers/clk/qcom/clk-regmap.c:97: warning: Function parameter or member 'dev' not described in 'devm_clk_register_regmap'
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/clk/qcom/clk-regmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/clk-regmap.c b/drivers/clk/qcom/clk-regmap.c
index ce80db27ccf2a..92ac4e0d7dbe2 100644
--- a/drivers/clk/qcom/clk-regmap.c
+++ b/drivers/clk/qcom/clk-regmap.c
@@ -87,6 +87,7 @@ EXPORT_SYMBOL_GPL(clk_disable_regmap);
/**
* devm_clk_register_regmap - register a clk_regmap clock
*
+ * @dev: reference to the caller's device
* @rclk: clk to operate on
*
* Clocks that use regmap for their register I/O should register their
--
2.25.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param
2021-01-26 12:45 ` [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param Lee Jones
@ 2021-01-26 13:59 ` Bjorn Andersson
2021-02-11 19:54 ` Stephen Boyd
1 sibling, 0 replies; 35+ messages in thread
From: Bjorn Andersson @ 2021-01-26 13:59 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Andy Gross, Michael Turquette, Stephen Boyd,
linux-arm-msm, linux-clk
On Tue 26 Jan 06:45 CST 2021, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/qcom/clk-regmap.c:97: warning: Function parameter or member 'dev' not described in 'devm_clk_register_regmap'
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/clk/qcom/clk-regmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/clk-regmap.c b/drivers/clk/qcom/clk-regmap.c
> index ce80db27ccf2a..92ac4e0d7dbe2 100644
> --- a/drivers/clk/qcom/clk-regmap.c
> +++ b/drivers/clk/qcom/clk-regmap.c
> @@ -87,6 +87,7 @@ EXPORT_SYMBOL_GPL(clk_disable_regmap);
> /**
> * devm_clk_register_regmap - register a clk_regmap clock
> *
> + * @dev: reference to the caller's device
> * @rclk: clk to operate on
> *
> * Clocks that use regmap for their register I/O should register their
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param
2021-01-26 12:45 ` [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param Lee Jones
2021-01-26 13:59 ` Bjorn Andersson
@ 2021-02-11 19:54 ` Stephen Boyd
1 sibling, 0 replies; 35+ messages in thread
From: Stephen Boyd @ 2021-02-11 19:54 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andy Gross, Bjorn Andersson, Michael Turquette,
linux-arm-msm, linux-clk
Quoting Lee Jones (2021-01-26 04:45:23)
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/qcom/clk-regmap.c:97: warning: Function parameter or member 'dev' not described in 'devm_clk_register_regmap'
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret'
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-01-26 12:45 ` [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param Lee Jones
@ 2021-01-26 12:45 ` Lee Jones
2021-01-26 14:01 ` Bjorn Andersson
2021-02-11 19:56 ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}' Lee Jones
` (4 subsequent siblings)
6 siblings, 2 replies; 35+ messages in thread
From: Lee Jones @ 2021-01-26 12:45 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, linux-arm-msm, linux-clk
Fixes the following W=1 kernel build warning(s):
drivers/clk/qcom/gcc-ipq4019.c: In function ‘clk_cpu_div_set_rate’:
drivers/clk/qcom/gcc-ipq4019.c:1279:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/clk/qcom/gcc-ipq4019.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/qcom/gcc-ipq4019.c b/drivers/clk/qcom/gcc-ipq4019.c
index ef5137fd50f3f..8abad4032de71 100644
--- a/drivers/clk/qcom/gcc-ipq4019.c
+++ b/drivers/clk/qcom/gcc-ipq4019.c
@@ -1276,16 +1276,15 @@ static int clk_cpu_div_set_rate(struct clk_hw *hw, unsigned long rate,
struct clk_fepll *pll = to_clk_fepll(hw);
const struct freq_tbl *f;
u32 mask;
- int ret;
f = qcom_find_freq(pll->freq_tbl, rate);
if (!f)
return -EINVAL;
mask = (BIT(pll->cdiv.width) - 1) << pll->cdiv.shift;
- ret = regmap_update_bits(pll->cdiv.clkr.regmap,
- pll->cdiv.reg, mask,
- f->pre_div << pll->cdiv.shift);
+ regmap_update_bits(pll->cdiv.clkr.regmap,
+ pll->cdiv.reg, mask,
+ f->pre_div << pll->cdiv.shift);
/*
* There is no status bit which can be checked for successful CPU
* divider update operation so using delay for the same.
--
2.25.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret'
2021-01-26 12:45 ` [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret' Lee Jones
@ 2021-01-26 14:01 ` Bjorn Andersson
2021-02-11 19:56 ` Stephen Boyd
1 sibling, 0 replies; 35+ messages in thread
From: Bjorn Andersson @ 2021-01-26 14:01 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Andy Gross, Michael Turquette, Stephen Boyd,
linux-arm-msm, linux-clk
On Tue 26 Jan 06:45 CST 2021, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/qcom/gcc-ipq4019.c: In function ‘clk_cpu_div_set_rate’:
> drivers/clk/qcom/gcc-ipq4019.c:1279:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/clk/qcom/gcc-ipq4019.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq4019.c b/drivers/clk/qcom/gcc-ipq4019.c
> index ef5137fd50f3f..8abad4032de71 100644
> --- a/drivers/clk/qcom/gcc-ipq4019.c
> +++ b/drivers/clk/qcom/gcc-ipq4019.c
> @@ -1276,16 +1276,15 @@ static int clk_cpu_div_set_rate(struct clk_hw *hw, unsigned long rate,
> struct clk_fepll *pll = to_clk_fepll(hw);
> const struct freq_tbl *f;
> u32 mask;
> - int ret;
>
> f = qcom_find_freq(pll->freq_tbl, rate);
> if (!f)
> return -EINVAL;
>
> mask = (BIT(pll->cdiv.width) - 1) << pll->cdiv.shift;
> - ret = regmap_update_bits(pll->cdiv.clkr.regmap,
> - pll->cdiv.reg, mask,
> - f->pre_div << pll->cdiv.shift);
> + regmap_update_bits(pll->cdiv.clkr.regmap,
> + pll->cdiv.reg, mask,
> + f->pre_div << pll->cdiv.shift);
> /*
> * There is no status bit which can be checked for successful CPU
> * divider update operation so using delay for the same.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret'
2021-01-26 12:45 ` [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret' Lee Jones
2021-01-26 14:01 ` Bjorn Andersson
@ 2021-02-11 19:56 ` Stephen Boyd
1 sibling, 0 replies; 35+ messages in thread
From: Stephen Boyd @ 2021-02-11 19:56 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andy Gross, Bjorn Andersson, Michael Turquette,
linux-arm-msm, linux-clk
Quoting Lee Jones (2021-01-26 04:45:32)
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/qcom/gcc-ipq4019.c: In function ‘clk_cpu_div_set_rate’:
> drivers/clk/qcom/gcc-ipq4019.c:1279:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}'
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-01-26 12:45 ` [PATCH 04/21] clk: qcom: clk-regmap: Provide missing description for 'devm_clk_register_regmap()'s dev param Lee Jones
2021-01-26 12:45 ` [PATCH 13/21] clk: qcom: gcc-ipq4019: Remove unused variable 'ret' Lee Jones
@ 2021-01-26 12:45 ` Lee Jones
2021-01-26 14:02 ` Bjorn Andersson
2021-02-11 19:57 ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code Lee Jones
` (3 subsequent siblings)
6 siblings, 2 replies; 35+ messages in thread
From: Lee Jones @ 2021-01-26 12:45 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, linux-arm-msm, linux-clk
Fixes the following W=1 kernel build warning(s):
drivers/clk/qcom/mmcc-msm8974.c:85:27: warning: ‘mmcc_xo_mmpll0_1_2_gpll0’ defined but not used [-Wunused-const-variable=]
drivers/clk/qcom/mmcc-msm8974.c:77:32: warning: ‘mmcc_xo_mmpll0_1_2_gpll0_map’ defined but not used [-Wunused-const-variable=]
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/clk/qcom/mmcc-msm8974.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
index 015426262d080..a1552b6771bc6 100644
--- a/drivers/clk/qcom/mmcc-msm8974.c
+++ b/drivers/clk/qcom/mmcc-msm8974.c
@@ -74,22 +74,6 @@ static const char * const mmcc_xo_mmpll0_dsi_hdmi_gpll0[] = {
"dsi1pll",
};
-static const struct parent_map mmcc_xo_mmpll0_1_2_gpll0_map[] = {
- { P_XO, 0 },
- { P_MMPLL0, 1 },
- { P_MMPLL1, 2 },
- { P_GPLL0, 5 },
- { P_MMPLL2, 3 }
-};
-
-static const char * const mmcc_xo_mmpll0_1_2_gpll0[] = {
- "xo",
- "mmpll0_vote",
- "mmpll1_vote",
- "mmss_gpll0_vote",
- "mmpll2",
-};
-
static const struct parent_map mmcc_xo_mmpll0_1_3_gpll0_map[] = {
{ P_XO, 0 },
{ P_MMPLL0, 1 },
--
2.25.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}'
2021-01-26 12:45 ` [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}' Lee Jones
@ 2021-01-26 14:02 ` Bjorn Andersson
2021-02-11 19:57 ` Stephen Boyd
1 sibling, 0 replies; 35+ messages in thread
From: Bjorn Andersson @ 2021-01-26 14:02 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Andy Gross, Michael Turquette, Stephen Boyd,
linux-arm-msm, linux-clk
On Tue 26 Jan 06:45 CST 2021, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/qcom/mmcc-msm8974.c:85:27: warning: ‘mmcc_xo_mmpll0_1_2_gpll0’ defined but not used [-Wunused-const-variable=]
> drivers/clk/qcom/mmcc-msm8974.c:77:32: warning: ‘mmcc_xo_mmpll0_1_2_gpll0_map’ defined but not used [-Wunused-const-variable=]
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/clk/qcom/mmcc-msm8974.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
> index 015426262d080..a1552b6771bc6 100644
> --- a/drivers/clk/qcom/mmcc-msm8974.c
> +++ b/drivers/clk/qcom/mmcc-msm8974.c
> @@ -74,22 +74,6 @@ static const char * const mmcc_xo_mmpll0_dsi_hdmi_gpll0[] = {
> "dsi1pll",
> };
>
> -static const struct parent_map mmcc_xo_mmpll0_1_2_gpll0_map[] = {
> - { P_XO, 0 },
> - { P_MMPLL0, 1 },
> - { P_MMPLL1, 2 },
> - { P_GPLL0, 5 },
> - { P_MMPLL2, 3 }
> -};
> -
> -static const char * const mmcc_xo_mmpll0_1_2_gpll0[] = {
> - "xo",
> - "mmpll0_vote",
> - "mmpll1_vote",
> - "mmss_gpll0_vote",
> - "mmpll2",
> -};
> -
> static const struct parent_map mmcc_xo_mmpll0_1_3_gpll0_map[] = {
> { P_XO, 0 },
> { P_MMPLL0, 1 },
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}'
2021-01-26 12:45 ` [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}' Lee Jones
2021-01-26 14:02 ` Bjorn Andersson
@ 2021-02-11 19:57 ` Stephen Boyd
1 sibling, 0 replies; 35+ messages in thread
From: Stephen Boyd @ 2021-02-11 19:57 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andy Gross, Bjorn Andersson, Michael Turquette,
linux-arm-msm, linux-clk
Quoting Lee Jones (2021-01-26 04:45:35)
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/qcom/mmcc-msm8974.c:85:27: warning: ‘mmcc_xo_mmpll0_1_2_gpll0’ defined but not used [-Wunused-const-variable=]
> drivers/clk/qcom/mmcc-msm8974.c:77:32: warning: ‘mmcc_xo_mmpll0_1_2_gpll0_map’ defined but not used [-Wunused-const-variable=]
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
` (2 preceding siblings ...)
2021-01-26 12:45 ` [PATCH 16/21] clk: qcom: mmcc-msm8974: Remove unused static const tables 'mmcc_xo_mmpll0_1_2_gpll0{map}' Lee Jones
@ 2021-01-26 12:45 ` Lee Jones
2021-01-26 14:04 ` Bjorn Andersson
2021-02-11 19:57 ` Stephen Boyd
2021-02-03 8:31 ` [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
` (2 subsequent siblings)
6 siblings, 2 replies; 35+ messages in thread
From: Lee Jones @ 2021-01-26 12:45 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andy Gross, Bjorn Andersson, Michael Turquette,
Stephen Boyd, linux-arm-msm, linux-clk
Fixes the following W=1 kernel build warning(s):
drivers/clk/qcom/clk-rpm.c:453:29: warning: ‘clk_rpm_branch_ops’ defined but not used [-Wunused-const-variable=]
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/clk/qcom/clk-rpm.c | 63 --------------------------------------
1 file changed, 63 deletions(-)
diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
index f71d228fd6bd5..a18811c380187 100644
--- a/drivers/clk/qcom/clk-rpm.c
+++ b/drivers/clk/qcom/clk-rpm.c
@@ -73,62 +73,6 @@
}, \
}
-#define DEFINE_CLK_RPM_PXO_BRANCH(_platform, _name, _active, r_id, r) \
- static struct clk_rpm _platform##_##_active; \
- static struct clk_rpm _platform##_##_name = { \
- .rpm_clk_id = (r_id), \
- .active_only = true, \
- .peer = &_platform##_##_active, \
- .rate = (r), \
- .branch = true, \
- .hw.init = &(struct clk_init_data){ \
- .ops = &clk_rpm_branch_ops, \
- .name = #_name, \
- .parent_names = (const char *[]){ "pxo_board" }, \
- .num_parents = 1, \
- }, \
- }; \
- static struct clk_rpm _platform##_##_active = { \
- .rpm_clk_id = (r_id), \
- .peer = &_platform##_##_name, \
- .rate = (r), \
- .branch = true, \
- .hw.init = &(struct clk_init_data){ \
- .ops = &clk_rpm_branch_ops, \
- .name = #_active, \
- .parent_names = (const char *[]){ "pxo_board" }, \
- .num_parents = 1, \
- }, \
- }
-
-#define DEFINE_CLK_RPM_CXO_BRANCH(_platform, _name, _active, r_id, r) \
- static struct clk_rpm _platform##_##_active; \
- static struct clk_rpm _platform##_##_name = { \
- .rpm_clk_id = (r_id), \
- .peer = &_platform##_##_active, \
- .rate = (r), \
- .branch = true, \
- .hw.init = &(struct clk_init_data){ \
- .ops = &clk_rpm_branch_ops, \
- .name = #_name, \
- .parent_names = (const char *[]){ "cxo_board" }, \
- .num_parents = 1, \
- }, \
- }; \
- static struct clk_rpm _platform##_##_active = { \
- .rpm_clk_id = (r_id), \
- .active_only = true, \
- .peer = &_platform##_##_name, \
- .rate = (r), \
- .branch = true, \
- .hw.init = &(struct clk_init_data){ \
- .ops = &clk_rpm_branch_ops, \
- .name = #_active, \
- .parent_names = (const char *[]){ "cxo_board" }, \
- .num_parents = 1, \
- }, \
- }
-
#define to_clk_rpm(_hw) container_of(_hw, struct clk_rpm, hw)
struct rpm_cc;
@@ -450,13 +394,6 @@ static const struct clk_ops clk_rpm_ops = {
.recalc_rate = clk_rpm_recalc_rate,
};
-static const struct clk_ops clk_rpm_branch_ops = {
- .prepare = clk_rpm_prepare,
- .unprepare = clk_rpm_unprepare,
- .round_rate = clk_rpm_round_rate,
- .recalc_rate = clk_rpm_recalc_rate,
-};
-
/* MSM8660/APQ8060 */
DEFINE_CLK_RPM(msm8660, afab_clk, afab_a_clk, QCOM_RPM_APPS_FABRIC_CLK);
DEFINE_CLK_RPM(msm8660, sfab_clk, sfab_a_clk, QCOM_RPM_SYS_FABRIC_CLK);
--
2.25.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code
2021-01-26 12:45 ` [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code Lee Jones
@ 2021-01-26 14:04 ` Bjorn Andersson
2021-02-11 19:57 ` Stephen Boyd
1 sibling, 0 replies; 35+ messages in thread
From: Bjorn Andersson @ 2021-01-26 14:04 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Andy Gross, Michael Turquette, Stephen Boyd,
linux-arm-msm, linux-clk
On Tue 26 Jan 06:45 CST 2021, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/qcom/clk-rpm.c:453:29: warning: ‘clk_rpm_branch_ops’ defined but not used [-Wunused-const-variable=]
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/clk/qcom/clk-rpm.c | 63 --------------------------------------
> 1 file changed, 63 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
> index f71d228fd6bd5..a18811c380187 100644
> --- a/drivers/clk/qcom/clk-rpm.c
> +++ b/drivers/clk/qcom/clk-rpm.c
> @@ -73,62 +73,6 @@
> }, \
> }
>
> -#define DEFINE_CLK_RPM_PXO_BRANCH(_platform, _name, _active, r_id, r) \
> - static struct clk_rpm _platform##_##_active; \
> - static struct clk_rpm _platform##_##_name = { \
> - .rpm_clk_id = (r_id), \
> - .active_only = true, \
> - .peer = &_platform##_##_active, \
> - .rate = (r), \
> - .branch = true, \
> - .hw.init = &(struct clk_init_data){ \
> - .ops = &clk_rpm_branch_ops, \
> - .name = #_name, \
> - .parent_names = (const char *[]){ "pxo_board" }, \
> - .num_parents = 1, \
> - }, \
> - }; \
> - static struct clk_rpm _platform##_##_active = { \
> - .rpm_clk_id = (r_id), \
> - .peer = &_platform##_##_name, \
> - .rate = (r), \
> - .branch = true, \
> - .hw.init = &(struct clk_init_data){ \
> - .ops = &clk_rpm_branch_ops, \
> - .name = #_active, \
> - .parent_names = (const char *[]){ "pxo_board" }, \
> - .num_parents = 1, \
> - }, \
> - }
> -
> -#define DEFINE_CLK_RPM_CXO_BRANCH(_platform, _name, _active, r_id, r) \
> - static struct clk_rpm _platform##_##_active; \
> - static struct clk_rpm _platform##_##_name = { \
> - .rpm_clk_id = (r_id), \
> - .peer = &_platform##_##_active, \
> - .rate = (r), \
> - .branch = true, \
> - .hw.init = &(struct clk_init_data){ \
> - .ops = &clk_rpm_branch_ops, \
> - .name = #_name, \
> - .parent_names = (const char *[]){ "cxo_board" }, \
> - .num_parents = 1, \
> - }, \
> - }; \
> - static struct clk_rpm _platform##_##_active = { \
> - .rpm_clk_id = (r_id), \
> - .active_only = true, \
> - .peer = &_platform##_##_name, \
> - .rate = (r), \
> - .branch = true, \
> - .hw.init = &(struct clk_init_data){ \
> - .ops = &clk_rpm_branch_ops, \
> - .name = #_active, \
> - .parent_names = (const char *[]){ "cxo_board" }, \
> - .num_parents = 1, \
> - }, \
> - }
> -
> #define to_clk_rpm(_hw) container_of(_hw, struct clk_rpm, hw)
>
> struct rpm_cc;
> @@ -450,13 +394,6 @@ static const struct clk_ops clk_rpm_ops = {
> .recalc_rate = clk_rpm_recalc_rate,
> };
>
> -static const struct clk_ops clk_rpm_branch_ops = {
> - .prepare = clk_rpm_prepare,
> - .unprepare = clk_rpm_unprepare,
> - .round_rate = clk_rpm_round_rate,
> - .recalc_rate = clk_rpm_recalc_rate,
> -};
> -
> /* MSM8660/APQ8060 */
> DEFINE_CLK_RPM(msm8660, afab_clk, afab_a_clk, QCOM_RPM_APPS_FABRIC_CLK);
> DEFINE_CLK_RPM(msm8660, sfab_clk, sfab_a_clk, QCOM_RPM_SYS_FABRIC_CLK);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code
2021-01-26 12:45 ` [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code Lee Jones
2021-01-26 14:04 ` Bjorn Andersson
@ 2021-02-11 19:57 ` Stephen Boyd
1 sibling, 0 replies; 35+ messages in thread
From: Stephen Boyd @ 2021-02-11 19:57 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Andy Gross, Bjorn Andersson, Michael Turquette,
linux-arm-msm, linux-clk
Quoting Lee Jones (2021-01-26 04:45:37)
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/qcom/clk-rpm.c:453:29: warning: ‘clk_rpm_branch_ops’ defined but not used [-Wunused-const-variable=]
>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
This has been rejected before but OK
Applied to clk-next
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
` (3 preceding siblings ...)
2021-01-26 12:45 ` [PATCH 18/21] clk: qcom: clk-rpm: Remove a bunch of superfluous code Lee Jones
@ 2021-02-03 8:31 ` Lee Jones
2021-02-05 18:55 ` Stephen Boyd
2021-02-08 6:45 ` Tero Kristo
2021-02-11 20:47 ` Stephen Boyd
6 siblings, 1 reply; 35+ messages in thread
From: Lee Jones @ 2021-02-03 8:31 UTC (permalink / raw)
To: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Stephen Boyd, Tali Perry, Tero Kristo,
Thierry Reding, Tomer Maimon, Viresh Kumar
On Tue, 26 Jan 2021, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> This is the last set. Clock is clean after this.
Out of interest, what normally happens to the patches which aren't
picked up by individual driver Maintainers?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-03 8:31 ` [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
@ 2021-02-05 18:55 ` Stephen Boyd
2021-02-05 19:19 ` Lee Jones
0 siblings, 1 reply; 35+ messages in thread
From: Stephen Boyd @ 2021-02-05 18:55 UTC (permalink / raw)
To: Ahmad Fatoum, Andy Gross, Avi Fishman, Benjamin Fair,
Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, Lee Jones, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, NXP Linux Team,
Nancy Yuen, Nuvoton Technologies, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
P rashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-kernel, linux-omap, linux-renesas-soc,
linux-tegra, openbmc
Quoting Lee Jones (2021-02-03 00:31:55)
> On Tue, 26 Jan 2021, Lee Jones wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > This is the last set. Clock is clean after this.
>
> Out of interest, what normally happens to the patches which aren't
> picked up by individual driver Maintainers?
>
I have to go in and figure it out! :)
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-05 18:55 ` Stephen Boyd
@ 2021-02-05 19:19 ` Lee Jones
0 siblings, 0 replies; 35+ messages in thread
From: Lee Jones @ 2021-02-05 19:19 UTC (permalink / raw)
To: Stephen Boyd
Cc: Ahmad Fatoum, Andy Gross, Avi Fishman, Benjamin Fair,
Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, Loc Ho, Maxime Ripard,
Michael Turquette, Michal Simek, NXP Linux Team, Nancy Yuen,
Nuvoton Technologies, Patrick Venture, Pengutronix Kernel Team,
Peter De Schrijver, Philipp Zabel, P rashant Gaikwad, Rajan Vaja,
Rajeev Kumar, Richard Woodruff, Russell King, Sascha Hauer,
Shawn Guo, Shiraz Hashim, Sören Brinkmann, Tali Perry,
Tero Kristo, Thierry Reding, Tomer Maimon, Viresh Kumar,
linux-arm-kernel, linux-arm-msm, linux-clk, linux-kernel,
linux-omap, linux-renesas-soc, linux-tegra, openbmc
On Fri, 05 Feb 2021, Stephen Boyd wrote:
> Quoting Lee Jones (2021-02-03 00:31:55)
> > On Tue, 26 Jan 2021, Lee Jones wrote:
> >
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > This is the last set. Clock is clean after this.
> >
> > Out of interest, what normally happens to the patches which aren't
> > picked up by individual driver Maintainers?
> >
>
> I have to go in and figure it out! :)
Thanks mate, much obliged.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
` (4 preceding siblings ...)
2021-02-03 8:31 ` [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
@ 2021-02-08 6:45 ` Tero Kristo
2021-02-11 20:47 ` Stephen Boyd
6 siblings, 0 replies; 35+ messages in thread
From: Tero Kristo @ 2021-02-08 6:45 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Stephen Boyd, Tali Perry, Thierry Reding,
Tomer Maimon, Viresh Kumar
On 26/01/2021 14:45, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> This is the last set. Clock is clean after this.
>
> Lee Jones (21):
> clk: zynq: pll: Fix kernel-doc formatting in 'clk_register_zynq_pll's
> header
> clk: ti: clkt_dpll: Fix some kernel-doc misdemeanours
> clk: ti: dpll3xxx: Fix some kernel-doc headers and promote other
> worthy ones
> clk: qcom: clk-regmap: Provide missing description for
> 'devm_clk_register_regmap()'s dev param
> clk: sunxi: clk-sun9i-core: Demote non-conformant kernel-doc headers
> clk: sunxi: clk-usb: Demote obvious kernel-doc abuse
> clk: tegra: clk-tegra30: Remove unused variable 'reg'
> clk: clkdev: Ignore suggestion to use gnu_printf() as it's not
> appropriate here
> clk: tegra: cvb: Provide missing description for
> 'tegra_cvb_add_opp_table()'s align param
> clk: ti: dpll44xx: Fix some potential doc-rot
> clk: renesas: renesas-cpg-mssr: Fix formatting issues for
> 'smstpcr_saved's documentation
> clk: sunxi: clk-sun6i-ar100: Demote non-conformant kernel-doc header
> clk: qcom: gcc-ipq4019: Remove unused variable 'ret'
> clk: clk-fixed-mmio: Demote obvious kernel-doc abuse
> clk: clk-npcm7xx: Remove unused static const tables 'npcm7xx_gates'
> and 'npcm7xx_divs_fx'
> clk: qcom: mmcc-msm8974: Remove unused static const tables
> 'mmcc_xo_mmpll0_1_2_gpll0{map}'
> clk: clk-xgene: Add description for 'mask' and fix formatting for
> 'flags'
> clk: qcom: clk-rpm: Remove a bunch of superfluous code
> clk: spear: Move prototype to accessible header
> clk: imx: Move 'imx6sl_set_wait_clk()'s prototype out to accessible
> header
> clk: zynqmp: divider: Add missing description for 'max_div'
>
> arch/arm/mach-imx/common.h | 1 -
> arch/arm/mach-imx/cpuidle-imx6sl.c | 1 +
> arch/arm/mach-imx/pm-imx6.c | 1 +
> arch/arm/mach-spear/generic.h | 12 ---
> arch/arm/mach-spear/spear13xx.c | 1 +
> drivers/clk/clk-fixed-mmio.c | 2 +-
> drivers/clk/clk-npcm7xx.c | 108 -------------------------
> drivers/clk/clk-xgene.c | 5 +-
> drivers/clk/clkdev.c | 7 ++
> drivers/clk/imx/clk-imx6sl.c | 1 +
> drivers/clk/qcom/clk-regmap.c | 1 +
> drivers/clk/qcom/clk-rpm.c | 63 ---------------
> drivers/clk/qcom/gcc-ipq4019.c | 7 +-
> drivers/clk/qcom/mmcc-msm8974.c | 16 ----
> drivers/clk/renesas/renesas-cpg-mssr.c | 4 +-
> drivers/clk/spear/spear1310_clock.c | 1 +
> drivers/clk/spear/spear1340_clock.c | 1 +
> drivers/clk/sunxi/clk-sun6i-ar100.c | 2 +-
> drivers/clk/sunxi/clk-sun9i-core.c | 8 +-
> drivers/clk/sunxi/clk-usb.c | 2 +-
> drivers/clk/tegra/clk-tegra30.c | 5 +-
> drivers/clk/tegra/cvb.c | 1 +
> drivers/clk/ti/clkt_dpll.c | 3 +-
> drivers/clk/ti/dpll3xxx.c | 20 ++---
> drivers/clk/ti/dpll44xx.c | 6 +-
For the TI portions:
Reviewed-by: Tero Kristo <kristo@kernel.org>
> drivers/clk/zynq/pll.c | 12 +--
> drivers/clk/zynqmp/divider.c | 1 +
> include/linux/clk/imx.h | 15 ++++
> include/linux/clk/spear.h | 23 ++++++
> 29 files changed, 92 insertions(+), 238 deletions(-)
> create mode 100644 include/linux/clk/imx.h
> create mode 100644 include/linux/clk/spear.h
>
> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Avi Fishman <avifishman70@gmail.com>
> Cc: Benjamin Fair <benjaminfair@google.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Boris BREZILLON <boris.brezillon@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: "Emilio López" <emilio@elopez.com.ar>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Jan Kotas <jank@cadence.com>
> Cc: Jernej Skrabec <jernej.skrabec@siol.net>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> Cc: Loc Ho <lho@apm.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Nancy Yuen <yuenn@google.com>
> Cc: Nuvoton Technologies <tali.perry@nuvoton.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: openbmc@lists.ozlabs.org
> Cc: Patrick Venture <venture@google.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Peter De Schrijver <pdeschrijver@nvidia.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Prashant Gaikwad <pgaikwad@nvidia.com>
> Cc: Rajan Vaja <rajan.vaja@xilinx.com>
> Cc: Rajeev Kumar <rajeev-dlh.kumar@st.com>
> Cc: Richard Woodruff <r-woodruff2@ti.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Tali Perry <tali.perry1@gmail.com>
> Cc: Tero Kristo <kristo@kernel.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Tomer Maimon <tmaimon77@gmail.com>
> Cc: Viresh Kumar <vireshk@kernel.org>
>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
` (5 preceding siblings ...)
2021-02-08 6:45 ` Tero Kristo
@ 2021-02-11 20:47 ` Stephen Boyd
2021-02-11 21:10 ` Lee Jones
6 siblings, 1 reply; 35+ messages in thread
From: Stephen Boyd @ 2021-02-11 20:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
Quoting Lee Jones (2021-01-26 04:45:19)
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> This is the last set. Clock is clean after this.
Is it possible to slam in some patch that makes W=1 the default for the
clk directory? I'm trying to avoid seeing this patch series again.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-11 20:47 ` Stephen Boyd
@ 2021-02-11 21:10 ` Lee Jones
2021-02-12 3:07 ` Stephen Boyd
0 siblings, 1 reply; 35+ messages in thread
From: Lee Jones @ 2021-02-11 21:10 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
On Thu, 11 Feb 2021, Stephen Boyd wrote:
> Quoting Lee Jones (2021-01-26 04:45:19)
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > This is the last set. Clock is clean after this.
>
> Is it possible to slam in some patch that makes W=1 the default for the
> clk directory? I'm trying to avoid seeing this patch series again.
One of my main goals of this project is that everyone (contributors,
maintainers auto-builder robots etc) will be enabling W=1 builds
*locally*.
This isn't something you'll want to do at a global (i.e. in Mainline)
level. That's kinda the point of W=1.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-11 21:10 ` Lee Jones
@ 2021-02-12 3:07 ` Stephen Boyd
2021-02-12 9:20 ` Lee Jones
2021-02-13 15:58 ` Andrew Lunn
0 siblings, 2 replies; 35+ messages in thread
From: Stephen Boyd @ 2021-02-12 3:07 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
Quoting Lee Jones (2021-02-11 13:10:54)
> On Thu, 11 Feb 2021, Stephen Boyd wrote:
>
> > Quoting Lee Jones (2021-01-26 04:45:19)
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > This is the last set. Clock is clean after this.
> >
> > Is it possible to slam in some patch that makes W=1 the default for the
> > clk directory? I'm trying to avoid seeing this patch series again.
>
> One of my main goals of this project is that everyone (contributors,
> maintainers auto-builder robots etc) will be enabling W=1 builds
> *locally*.
>
> This isn't something you'll want to do at a global (i.e. in Mainline)
> level. That's kinda the point of W=1.
>
Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile?
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-12 3:07 ` Stephen Boyd
@ 2021-02-12 9:20 ` Lee Jones
2021-02-12 21:02 ` Stephen Boyd
2021-02-13 15:58 ` Andrew Lunn
1 sibling, 1 reply; 35+ messages in thread
From: Lee Jones @ 2021-02-12 9:20 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
On Thu, 11 Feb 2021, Stephen Boyd wrote:
> Quoting Lee Jones (2021-02-11 13:10:54)
> > On Thu, 11 Feb 2021, Stephen Boyd wrote:
> >
> > > Quoting Lee Jones (2021-01-26 04:45:19)
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > > >
> > > > This is the last set. Clock is clean after this.
> > >
> > > Is it possible to slam in some patch that makes W=1 the default for the
> > > clk directory? I'm trying to avoid seeing this patch series again.
> >
> > One of my main goals of this project is that everyone (contributors,
> > maintainers auto-builder robots etc) will be enabling W=1 builds
> > *locally*.
> >
> > This isn't something you'll want to do at a global (i.e. in Mainline)
> > level. That's kinda the point of W=1.
> >
>
> Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile?
That would circumvent the point of W=1. Level-1 warnings are deemed,
and I'm paraphrasing/making this up "not worth rejecting pull-requests
over". In contrast, if Linus catches any W=0 warnings at pull-time,
he will reject the pull-request as 'untested'.
W=1 is defiantly something you'll want to enable locally though, and
subsequently push back on contributors submitting code adding new
ones.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-12 9:20 ` Lee Jones
@ 2021-02-12 21:02 ` Stephen Boyd
2021-02-12 21:25 ` Lee Jones
0 siblings, 1 reply; 35+ messages in thread
From: Stephen Boyd @ 2021-02-12 21:02 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
Quoting Lee Jones (2021-02-12 01:20:16)
> On Thu, 11 Feb 2021, Stephen Boyd wrote:
>
> > Quoting Lee Jones (2021-02-11 13:10:54)
> > > On Thu, 11 Feb 2021, Stephen Boyd wrote:
> > >
> > > > Quoting Lee Jones (2021-01-26 04:45:19)
> > > > > This set is part of a larger effort attempting to clean-up W=1
> > > > > kernel builds, which are currently overwhelmingly riddled with
> > > > > niggly little warnings.
> > > > >
> > > > > This is the last set. Clock is clean after this.
> > > >
> > > > Is it possible to slam in some patch that makes W=1 the default for the
> > > > clk directory? I'm trying to avoid seeing this patch series again.
> > >
> > > One of my main goals of this project is that everyone (contributors,
> > > maintainers auto-builder robots etc) will be enabling W=1 builds
> > > *locally*.
> > >
> > > This isn't something you'll want to do at a global (i.e. in Mainline)
> > > level. That's kinda the point of W=1.
> > >
> >
> > Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile?
>
> That would circumvent the point of W=1. Level-1 warnings are deemed,
> and I'm paraphrasing/making this up "not worth rejecting pull-requests
> over". In contrast, if Linus catches any W=0 warnings at pull-time,
> he will reject the pull-request as 'untested'.
>
> W=1 is defiantly something you'll want to enable locally though, and
> subsequently push back on contributors submitting code adding new
> ones.
>
Why should I install a land mine for others to trip over? Won't that
just take them more time because they won't know to compile with W=1 and
then will have to go for another round of review while I push back on
them submitting new warnings?
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-12 21:02 ` Stephen Boyd
@ 2021-02-12 21:25 ` Lee Jones
2021-02-12 21:26 ` Lee Jones
0 siblings, 1 reply; 35+ messages in thread
From: Lee Jones @ 2021-02-12 21:25 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
On Fri, 12 Feb 2021, Stephen Boyd wrote:
> Quoting Lee Jones (2021-02-12 01:20:16)
> > On Thu, 11 Feb 2021, Stephen Boyd wrote:
> >
> > > Quoting Lee Jones (2021-02-11 13:10:54)
> > > > On Thu, 11 Feb 2021, Stephen Boyd wrote:
> > > >
> > > > > Quoting Lee Jones (2021-01-26 04:45:19)
> > > > > > This set is part of a larger effort attempting to clean-up W=1
> > > > > > kernel builds, which are currently overwhelmingly riddled with
> > > > > > niggly little warnings.
> > > > > >
> > > > > > This is the last set. Clock is clean after this.
> > > > >
> > > > > Is it possible to slam in some patch that makes W=1 the default for the
> > > > > clk directory? I'm trying to avoid seeing this patch series again.
> > > >
> > > > One of my main goals of this project is that everyone (contributors,
> > > > maintainers auto-builder robots etc) will be enabling W=1 builds
> > > > *locally*.
> > > >
> > > > This isn't something you'll want to do at a global (i.e. in Mainline)
> > > > level. That's kinda the point of W=1.
> > > >
> > >
> > > Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile?
> >
> > That would circumvent the point of W=1. Level-1 warnings are deemed,
> > and I'm paraphrasing/making this up "not worth rejecting pull-requests
> > over". In contrast, if Linus catches any W=0 warnings at pull-time,
> > he will reject the pull-request as 'untested'.
> >
> > W=1 is defiantly something you'll want to enable locally though, and
> > subsequently push back on contributors submitting code adding new
> > ones.
> >
>
> Why should I install a land mine for others to trip over? Won't that
> just take them more time because they won't know to compile with W=1 and
> then will have to go for another round of review while I push back on
> them submitting new warnings?
The alternative is to not worry about it and review the slow drip of
fixes that will occur as a result. The issues I just fixed were built
up over years. They won't get to that level again.
In my mind contributors should be compiling their submissions with W=1
enabled by default. I'm fairly sure the auto-builders do this now.
Once W=1 warnings are down to an acceptable level in the kernel as a
whole, we can provide some guidance in SubmittingPatches (or similar)
on how to enable them (hint: you add "W=1" on the compile line).
Enabling W=1 in the default build will only serve to annoy Linus IMHO.
If he wants them to be enabled by default, they wouldn't be W=1 in the
first place, they'd be W=0 which *is* the default build.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-12 21:25 ` Lee Jones
@ 2021-02-12 21:26 ` Lee Jones
2021-02-12 22:05 ` Stephen Boyd
0 siblings, 1 reply; 35+ messages in thread
From: Lee Jones @ 2021-02-12 21:26 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
On Fri, 12 Feb 2021, Lee Jones wrote:
> On Fri, 12 Feb 2021, Stephen Boyd wrote:
>
> > Quoting Lee Jones (2021-02-12 01:20:16)
> > > On Thu, 11 Feb 2021, Stephen Boyd wrote:
> > >
> > > > Quoting Lee Jones (2021-02-11 13:10:54)
> > > > > On Thu, 11 Feb 2021, Stephen Boyd wrote:
> > > > >
> > > > > > Quoting Lee Jones (2021-01-26 04:45:19)
> > > > > > > This set is part of a larger effort attempting to clean-up W=1
> > > > > > > kernel builds, which are currently overwhelmingly riddled with
> > > > > > > niggly little warnings.
> > > > > > >
> > > > > > > This is the last set. Clock is clean after this.
> > > > > >
> > > > > > Is it possible to slam in some patch that makes W=1 the default for the
> > > > > > clk directory? I'm trying to avoid seeing this patch series again.
> > > > >
> > > > > One of my main goals of this project is that everyone (contributors,
> > > > > maintainers auto-builder robots etc) will be enabling W=1 builds
> > > > > *locally*.
> > > > >
> > > > > This isn't something you'll want to do at a global (i.e. in Mainline)
> > > > > level. That's kinda the point of W=1.
> > > > >
> > > >
> > > > Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile?
> > >
> > > That would circumvent the point of W=1. Level-1 warnings are deemed,
> > > and I'm paraphrasing/making this up "not worth rejecting pull-requests
> > > over". In contrast, if Linus catches any W=0 warnings at pull-time,
> > > he will reject the pull-request as 'untested'.
> > >
> > > W=1 is defiantly something you'll want to enable locally though, and
> > > subsequently push back on contributors submitting code adding new
> > > ones.
> > >
> >
> > Why should I install a land mine for others to trip over? Won't that
> > just take them more time because they won't know to compile with W=1 and
> > then will have to go for another round of review while I push back on
> > them submitting new warnings?
>
> The alternative is to not worry about it and review the slow drip of
> fixes that will occur as a result. The issues I just fixed were built
> up over years. They won't get to that level again.
>
> In my mind contributors should be compiling their submissions with W=1
> enabled by default. I'm fairly sure the auto-builders do this now.
>
> Once W=1 warnings are down to an acceptable level in the kernel as a
> whole, we can provide some guidance in SubmittingPatches (or similar)
> on how to enable them (hint: you add "W=1" on the compile line).
>
> Enabling W=1 in the default build will only serve to annoy Linus IMHO.
> If he wants them to be enabled by default, they wouldn't be W=1 in the
> first place, they'd be W=0 which *is* the default build.
Just to add real quick - my advice is to enable them for yourself and
send back any issues along with your normal review. A W=1 issue is no
different to a semantic or coding style one.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-12 21:26 ` Lee Jones
@ 2021-02-12 22:05 ` Stephen Boyd
2021-02-12 22:37 ` Lee Jones
0 siblings, 1 reply; 35+ messages in thread
From: Stephen Boyd @ 2021-02-12 22:05 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
Quoting Lee Jones (2021-02-12 13:26:30)
> On Fri, 12 Feb 2021, Lee Jones wrote:
>
> > The alternative is to not worry about it and review the slow drip of
> > fixes that will occur as a result. The issues I just fixed were built
> > up over years. They won't get to that level again.
> >
> > In my mind contributors should be compiling their submissions with W=1
> > enabled by default. I'm fairly sure the auto-builders do this now.
That's good.
> >
> > Once W=1 warnings are down to an acceptable level in the kernel as a
> > whole, we can provide some guidance in SubmittingPatches (or similar)
> > on how to enable them (hint: you add "W=1" on the compile line).
> >
> > Enabling W=1 in the default build will only serve to annoy Linus IMHO.
> > If he wants them to be enabled by default, they wouldn't be W=1 in the
> > first place, they'd be W=0 which *is* the default build.
>
> Just to add real quick - my advice is to enable them for yourself and
> send back any issues along with your normal review. A W=1 issue is no
> different to a semantic or coding style one.
>
I'd like to enable it for only files under drivers/clk/ but it doesn't
seem to work. I'm not asking to enable it at the toplevel Makefile. I'm
asking to enable it for drivers/clk/ so nobody has to think about it now
that you've done the hard work of getting the numbers in this directory
down to zero or close to zero.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-12 22:05 ` Stephen Boyd
@ 2021-02-12 22:37 ` Lee Jones
2021-02-13 0:06 ` Stephen Boyd
0 siblings, 1 reply; 35+ messages in thread
From: Lee Jones @ 2021-02-12 22:37 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
On Fri, 12 Feb 2021, Stephen Boyd wrote:
> Quoting Lee Jones (2021-02-12 13:26:30)
> > On Fri, 12 Feb 2021, Lee Jones wrote:
> >
> > > The alternative is to not worry about it and review the slow drip of
> > > fixes that will occur as a result. The issues I just fixed were built
> > > up over years. They won't get to that level again.
> > >
> > > In my mind contributors should be compiling their submissions with W=1
> > > enabled by default. I'm fairly sure the auto-builders do this now.
>
> That's good.
>
> > >
> > > Once W=1 warnings are down to an acceptable level in the kernel as a
> > > whole, we can provide some guidance in SubmittingPatches (or similar)
> > > on how to enable them (hint: you add "W=1" on the compile line).
> > >
> > > Enabling W=1 in the default build will only serve to annoy Linus IMHO.
> > > If he wants them to be enabled by default, they wouldn't be W=1 in the
> > > first place, they'd be W=0 which *is* the default build.
> >
> > Just to add real quick - my advice is to enable them for yourself and
> > send back any issues along with your normal review. A W=1 issue is no
> > different to a semantic or coding style one.
> >
>
> I'd like to enable it for only files under drivers/clk/ but it doesn't
> seem to work. I'm not asking to enable it at the toplevel Makefile. I'm
> asking to enable it for drivers/clk/ so nobody has to think about it now
> that you've done the hard work of getting the numbers in this directory
> down to zero or close to zero.
I'm not sure which one of us is confused. Probably me, but ...
Even if you could enable it per-subsystem, how would that help you?
How can you ensure that contributors see any new W=1 warnings, but
Linus doesn't? When Linus conducts his build-tests during the merge
window, he is also going to build W=1 for drivers/clk.
All that's going to achieve is put you in the firing line.
From my PoV W=1 builds should be enabled during the development phase
(i.e. contributor, auto-builder, maintainer). By the time patches get
make it into Mainline the review/testing stage is over and only the
default W=0 warnings are meaningful.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-12 22:37 ` Lee Jones
@ 2021-02-13 0:06 ` Stephen Boyd
2021-02-13 16:04 ` Andrew Lunn
0 siblings, 1 reply; 35+ messages in thread
From: Stephen Boyd @ 2021-02-13 0:06 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Ahmad Fatoum, Andy Gross, Avi Fishman,
Benjamin Fair, Bjorn Andersson, Boris BREZILLON, Chen-Yu Tsai,
Emilio López, Fabio Estevam, Geert Uytterhoeven, Jan Kotas,
Jernej Skrabec, Jonathan Hunter, linux-arm-kernel, linux-arm-msm,
linux-clk, linux-omap, linux-renesas-soc, linux-tegra, Loc Ho,
Maxime Ripard, Michael Turquette, Michal Simek, Nancy Yuen,
Nuvoton Technologies, NXP Linux Team, openbmc, Patrick Venture,
Pengutronix Kernel Team, Peter De Schrijver, Philipp Zabel,
Prashant Gaikwad, Rajan Vaja, Rajeev Kumar, Richard Woodruff,
Russell King, Sascha Hauer, Shawn Guo, Shiraz Hashim,
Sören Brinkmann, Tali Perry, Tero Kristo, Thierry Reding,
Tomer Maimon, Viresh Kumar
Quoting Lee Jones (2021-02-12 14:37:39)
> On Fri, 12 Feb 2021, Stephen Boyd wrote:
>
> >
> > I'd like to enable it for only files under drivers/clk/ but it doesn't
> > seem to work. I'm not asking to enable it at the toplevel Makefile. I'm
> > asking to enable it for drivers/clk/ so nobody has to think about it now
> > that you've done the hard work of getting the numbers in this directory
> > down to zero or close to zero.
>
> I'm not sure which one of us is confused. Probably me, but ...
>
> Even if you could enable it per-subsystem, how would that help you?
>
> How can you ensure that contributors see any new W=1 warnings, but
> Linus doesn't? When Linus conducts his build-tests during the merge
> window, he is also going to build W=1 for drivers/clk.
The assumption is contributors would have compiled the code they're
sending, but that's obviously not always the case, so this assumption
relies on developers running make. If they do run make then the hope is
they would see the warnings now, without having to rely on them to know
about passing W=1 to make, and fix them before sending code. If
developers are ignoring build errors or warnings then we can't do
anything anyway.
>
> All that's going to achieve is put you in the firing line.
Ok. Is this prior experience?
>
> From my PoV W=1 builds should be enabled during the development phase
> (i.e. contributor, auto-builder, maintainer). By the time patches get
> make it into Mainline the review/testing stage is over and only the
> default W=0 warnings are meaningful.
>
Alright maybe I don't understand and W=1 builds are noisy for the
drivers/clk subdirectory even after applying these patches. Or it has
some false positives that won't be fixed? Or a new compiler can cause
new warnings to happen? I could see these things being a problem.
I'm trying to see if we can make lives better for everyone by exposing
the warnings by default in the drivers/clk/ directory now that there are
supposedly none left. Shouldn't we tighten the screws now that we've
cleaned them?
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-13 0:06 ` Stephen Boyd
@ 2021-02-13 16:04 ` Andrew Lunn
[not found] ` <161333644244.1254594.4498059850307971318@swboyd.mtv.corp.google.com>
0 siblings, 1 reply; 35+ messages in thread
From: Andrew Lunn @ 2021-02-13 16:04 UTC (permalink / raw)
To: Stephen Boyd
Cc: Lee Jones, Prashant Gaikwad, Tomer Maimon, Geert Uytterhoeven,
Michael Turquette, Bjorn Andersson, Rajeev Kumar, Jan Kotas,
Russell King, Fabio Estevam, linux-clk, Boris BREZILLON,
Ahmad Fatoum, Benjamin Fair, Emilio López, Viresh Kumar,
openbmc, Michal Simek, Jonathan Hunter, Nancy Yuen, Chen-Yu Tsai,
Andy Gross, Loc Ho, NXP Linux Team, Richard Woodruff, Tali Perry,
Philipp Zabel, linux-arm-msm, Sascha Hauer, Maxime Ripard,
linux-tegra, linux-omap, Shiraz Hashim, linux-arm-kernel,
Sören Brinkmann, Jernej Skrabec, Tero Kristo, Rajan Vaja,
Avi Fishman, Patrick Venture, Peter De Schrijver, linux-kernel,
linux-renesas-soc, Nuvoton Technologies, Thierry Reding,
Pengutronix Kernel Team, Shawn Guo
> I'm trying to see if we can make lives better for everyone by exposing
> the warnings by default in the drivers/clk/ directory now that there are
> supposedly none left. Shouldn't we tighten the screws now that we've
> cleaned them?
Do you use patchwork? netdev has a bot attached which applies the
patch and does a W=1 build, and will report any new warnings. But it
does not email the developer, as far as i know. It is up to you as the
maintainer to reject the patch and say why.
Andrew
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
2021-02-12 3:07 ` Stephen Boyd
2021-02-12 9:20 ` Lee Jones
@ 2021-02-13 15:58 ` Andrew Lunn
1 sibling, 0 replies; 35+ messages in thread
From: Andrew Lunn @ 2021-02-13 15:58 UTC (permalink / raw)
To: Stephen Boyd, Arnd Bergmann
Cc: Lee Jones, Prashant Gaikwad, Tomer Maimon, Geert Uytterhoeven,
Michael Turquette, Bjorn Andersson, Rajeev Kumar, Jan Kotas,
Russell King, Fabio Estevam, linux-clk, Boris BREZILLON,
Ahmad Fatoum, Benjamin Fair, Emilio López, Viresh Kumar,
openbmc, Michal Simek, Jonathan Hunter, Nancy Yuen, Chen-Yu Tsai,
Andy Gross, Loc Ho, NXP Linux Team, Richard Woodruff, Tali Perry,
Philipp Zabel, linux-arm-msm, Sascha Hauer, Maxime Ripard,
linux-tegra, linux-omap, Shiraz Hashim, linux-arm-kernel,
Sören Brinkmann, Jernej Skrabec, Tero Kristo, Rajan Vaja,
Avi Fishman, Patrick Venture, Peter De Schrijver, linux-kernel,
linux-renesas-soc, Nuvoton Technologies, Thierry Reding,
Pengutronix Kernel Team, Shawn Guo
On Thu, Feb 11, 2021 at 07:07:30PM -0800, Stephen Boyd wrote:
> Quoting Lee Jones (2021-02-11 13:10:54)
> > On Thu, 11 Feb 2021, Stephen Boyd wrote:
> >
> > > Quoting Lee Jones (2021-01-26 04:45:19)
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > > >
> > > > This is the last set. Clock is clean after this.
> > >
> > > Is it possible to slam in some patch that makes W=1 the default for the
> > > clk directory? I'm trying to avoid seeing this patch series again.
> >
> > One of my main goals of this project is that everyone (contributors,
> > maintainers auto-builder robots etc) will be enabling W=1 builds
> > *locally*.
> >
> > This isn't something you'll want to do at a global (i.e. in Mainline)
> > level. That's kinda the point of W=1.
> >
>
> Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile?
About a cycle ago, Arnd and i played around with this idea. The
Ethernet PHY subsystem is W=1 clean, and most of he network stack
is. But keeping it clean is not so easy, when developers do sometimes
add new warnings, since they have no idea the code is W=1 clean.
You are also not the only one asking for such a feature. RDMA also
asked recently.
Arnd, do you plan to push the patches?
Andrew
^ permalink raw reply [flat|nested] 35+ messages in thread