linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes
@ 2022-09-19 22:08 Bhupesh Sharma
  2022-09-19 22:08 ` [PATCH v6 1/4] ARM: dts: qcom: Use new compatibles for crypto nodes Bhupesh Sharma
                   ` (5 more replies)
  0 siblings, 6 replies; 11+ messages in thread
From: Bhupesh Sharma @ 2022-09-19 22:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-arm-msm
  Cc: agross, linux-kernel, robh+dt, thara.gopinath, devicetree, robh,
	krzysztof.kozlowski, andersson, bhupesh.sharma, bhupesh.linux,
	Jordan Crouse

Changes since v5:
=================
- v5 can be seen here: https://lore.kernel.org/lkml/20211110105922.217895-1-bhupesh.sharma@linaro.org/
- As per Bjorn's suggestion on irc, broke down the patchset into 4
  separate patchsets, one each for the following areas to allow easier
  review and handling from the respective maintainer(s):
        'arm-msm', 'crypto', 'dma' and 'devicetree'
  This patchset is directed for the 'arm-msm' tree / area.
- Addressed Rob's, Vladimir's and Bjorn's review comments on v5.
- Added Tested-by from Jordan received on the v5.
- Also added a 'defconfig' change where I enabled the QCE block as a module.

Changes since v4:
=================
- v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@linaro.org/
- v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@linaro.org/
- Merged the sm8150 and sm8250 enablement patches in the same patchset,
  as per suggestions from Bjorn.
- Dropped a couple of patches from v4, as these have been picked by
  Bjorn already via his tree.
- Addressed review comments from Vladimir, Thara and Rob.
- Collect Reviewed-by from Rob and Thara on some of the patches from the
  v4 patchset.

Changes since v3:
=================
- v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@linaro.org/
- Dropped a couple of patches from v3, on basis of the review comments:
   ~ [PATCH 13/17] crypto: qce: core: Make clocks optional
   ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info()
- Addressed review comments from Thara, Rob and Stephan Gerhold.
- Collect Reviewed-by from Rob and Thara on some of the patches from the
  v3 patchset.

Changes since v2:
=================
- v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@linaro.org/
- Drop a couple of patches from v1, which tried to address the defered
  probing of qce driver in case bam dma driver is not yet probed.
  Replace it instead with a single (simpler) patch [PATCH 16/17].
- Convert bam dma and qce crypto dt-bindings to YAML.
- Addressed review comments from Thara, Bjorn, Vinod and Rob.

Changes since v1:
=================
- v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@linaro.org/ 
- v1 did not work well as reported earlier by Dmitry, so v2 contains the following
  changes/fixes:
  ~ Enable the interconnect path b/w BAM DMA and main memory first
    before trying to access the BAM DMA registers.
  ~ Enable the interconnect path b/w qce crytpo and main memory first
    before trying to access the qce crypto registers.
  ~ Make sure to document the required and optional properties for both
    BAM DMA and qce crypto drivers.
  ~ Add a few debug related print messages in case the qce crypto driver
    passes or fails to probe.
  ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA
    or the interconnect driver(s) (needed on specific Qualcomm parts) are not
    yet probed.

Qualcomm crypto engine (qce) is available on several Snapdragon SoCs.
The qce block supports hardware accelerated algorithms for encryption
and authentication. It also provides support for aes, des, 3des
encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256)
authentication algorithms.

Note that this patchset is dependent on the dt-bindings patchset (see [1]) sent to devicetree list.

[1]. https://lore.kernel.org/linux-arm-msm/20220919195618.926227-1-bhupesh.sharma@linaro.org/

Cc: thara.gopinath@gmail.com
Cc: robh@kernel.org
Cc: andersson@kernel.org
Tested-by: Jordan Crouse <jorcrous@amazon.com>

Bhupesh Sharma (4):
  ARM: dts: qcom: Use new compatibles for crypto nodes
  arm64: dts: qcom: sm8250: Add dt entries to support crypto engine.
  arm64: dts: qcom: sm8150: Add dt entries to support crypto engine.
  arm64: defconfig: Enable Qualcomm QCE crypto

 arch/arm/boot/dts/qcom-ipq4019.dtsi   |  2 +-
 arch/arm64/boot/dts/qcom/ipq6018.dtsi |  2 +-
 arch/arm64/boot/dts/qcom/ipq8074.dtsi |  2 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi |  2 +-
 arch/arm64/boot/dts/qcom/sdm845.dtsi  |  2 +-
 arch/arm64/boot/dts/qcom/sm8150.dtsi  | 28 +++++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/sm8250.dtsi  | 28 +++++++++++++++++++++++++++
 arch/arm64/configs/defconfig          |  1 +
 8 files changed, 62 insertions(+), 5 deletions(-)

-- 
2.37.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH v6 1/4] ARM: dts: qcom: Use new compatibles for crypto nodes
  2022-09-19 22:08 [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
@ 2022-09-19 22:08 ` Bhupesh Sharma
  2022-09-19 22:08 ` [PATCH v6 2/4] arm64: dts: qcom: sm8250: Add dt entries to support crypto engine Bhupesh Sharma
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 11+ messages in thread
From: Bhupesh Sharma @ 2022-09-19 22:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-arm-msm
  Cc: agross, linux-kernel, robh+dt, thara.gopinath, devicetree, robh,
	krzysztof.kozlowski, andersson, bhupesh.sharma, bhupesh.linux,
	Jordan Crouse

Since we are using soc specific qce crypto IP compatibles
in the bindings now, use the same in the device tree files
which include the crypto nodes.

Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Tested-by: Jordan Crouse <jorcrous@amazon.com>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 arch/arm/boot/dts/qcom-ipq4019.dtsi   | 2 +-
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
 arch/arm64/boot/dts/qcom/sdm845.dtsi  | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
index b23591110bd2..9c40714562d5 100644
--- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
@@ -314,7 +314,7 @@ cryptobam: dma-controller@8e04000 {
 		};
 
 		crypto: crypto@8e3a000 {
-			compatible = "qcom,crypto-v5.1";
+			compatible = "qcom,ipq4019-qce";
 			reg = <0x08e3a000 0x6000>;
 			clocks = <&gcc GCC_CRYPTO_AHB_CLK>,
 				 <&gcc GCC_CRYPTO_AXI_CLK>,
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index a7c7ca980a71..0ae3c601b279 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -198,7 +198,7 @@ cryptobam: dma-controller@704000 {
 		};
 
 		crypto: crypto@73a000 {
-			compatible = "qcom,crypto-v5.1";
+			compatible = "qcom,ipq6018-qce";
 			reg = <0x0 0x0073a000 0x0 0x6000>;
 			clocks = <&gcc GCC_CRYPTO_AHB_CLK>,
 				<&gcc GCC_CRYPTO_AXI_CLK>,
diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index a47acf9bdf24..0683ef931413 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -286,7 +286,7 @@ cryptobam: dma-controller@704000 {
 		};
 
 		crypto: crypto@73a000 {
-			compatible = "qcom,crypto-v5.1";
+			compatible = "qcom,ipq8074-qce";
 			reg = <0x0073a000 0x6000>;
 			clocks = <&gcc GCC_CRYPTO_AHB_CLK>,
 				 <&gcc GCC_CRYPTO_AXI_CLK>,
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index c0a2baffa49d..0dd6e1fea99c 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -755,7 +755,7 @@ cryptobam: dma-controller@644000 {
 		};
 
 		crypto: crypto@67a000 {
-			compatible = "qcom,crypto-v5.4";
+			compatible = "qcom,msm8996-qce";
 			reg = <0x0067a000 0x6000>;
 			clocks = <&gcc GCC_CE1_AHB_CLK>,
 				 <&gcc GCC_CE1_AXI_CLK>,
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index d761da47220d..4aa5a82bd265 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2566,7 +2566,7 @@ cryptobam: dma-controller@1dc4000 {
 		};
 
 		crypto: crypto@1dfa000 {
-			compatible = "qcom,crypto-v5.4";
+			compatible = "qcom,sdm845-qce";
 			reg = <0 0x01dfa000 0 0x6000>;
 			clocks = <&gcc GCC_CE1_AHB_CLK>,
 				 <&gcc GCC_CE1_AXI_CLK>,
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v6 2/4] arm64: dts: qcom: sm8250: Add dt entries to support crypto engine.
  2022-09-19 22:08 [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
  2022-09-19 22:08 ` [PATCH v6 1/4] ARM: dts: qcom: Use new compatibles for crypto nodes Bhupesh Sharma
@ 2022-09-19 22:08 ` Bhupesh Sharma
  2022-09-19 22:08 ` [PATCH v6 3/4] arm64: dts: qcom: sm8150: " Bhupesh Sharma
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 11+ messages in thread
From: Bhupesh Sharma @ 2022-09-19 22:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-arm-msm
  Cc: agross, linux-kernel, robh+dt, thara.gopinath, devicetree, robh,
	krzysztof.kozlowski, andersson, bhupesh.sharma, bhupesh.linux,
	Jordan Crouse

Add crypto engine (CE) and CE BAM related nodes and definitions to
'sm8250.dtsi'.

Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Tested-by: Jordan Crouse <jorcrous@amazon.com>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index a5b62cadb129..7b3af34f8486 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2188,6 +2188,34 @@ ufs_mem_phy_lanes: phy@1d87400 {
 			};
 		};
 
+		cryptobam: dma-controller@1dc4000 {
+			compatible = "qcom,bam-v1.7.0";
+			reg = <0 0x01dc4000 0 0x24000>;
+			interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			qcom,ee = <0>;
+			qcom,controlled-remotely;
+			iommus = <&apps_smmu 0x584 0x0011>,
+				 <&apps_smmu 0x586 0x0011>,
+				 <&apps_smmu 0x594 0x0011>,
+				 <&apps_smmu 0x596 0x0011>;
+			interconnects = <&aggre2_noc MASTER_CRYPTO_CORE_0 &mc_virt SLAVE_EBI_CH0>;
+			interconnect-names = "memory";
+		};
+
+		crypto: crypto@1dfa000 {
+			compatible = "qcom,sm8250-qce";
+			reg = <0 0x01dfa000 0 0x6000>;
+			dmas = <&cryptobam 4>, <&cryptobam 5>;
+			dma-names = "rx", "tx";
+			iommus = <&apps_smmu 0x584 0x0011>,
+				 <&apps_smmu 0x586 0x0011>,
+				 <&apps_smmu 0x594 0x0011>,
+				 <&apps_smmu 0x596 0x0011>;
+			interconnects = <&aggre2_noc MASTER_CRYPTO_CORE_0 &mc_virt SLAVE_EBI_CH0>;
+			interconnect-names = "memory";
+		};
+
 		ipa_virt: interconnect@1e00000 {
 			compatible = "qcom,sm8250-ipa-virt";
 			reg = <0 0x01e00000 0 0x1000>;
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v6 3/4] arm64: dts: qcom: sm8150: Add dt entries to support crypto engine.
  2022-09-19 22:08 [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
  2022-09-19 22:08 ` [PATCH v6 1/4] ARM: dts: qcom: Use new compatibles for crypto nodes Bhupesh Sharma
  2022-09-19 22:08 ` [PATCH v6 2/4] arm64: dts: qcom: sm8250: Add dt entries to support crypto engine Bhupesh Sharma
@ 2022-09-19 22:08 ` Bhupesh Sharma
  2022-09-19 22:08 ` [PATCH v6 4/4] arm64: defconfig: Enable Qualcomm QCE crypto Bhupesh Sharma
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 11+ messages in thread
From: Bhupesh Sharma @ 2022-09-19 22:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-arm-msm
  Cc: agross, linux-kernel, robh+dt, thara.gopinath, devicetree, robh,
	krzysztof.kozlowski, andersson, bhupesh.sharma, bhupesh.linux,
	Jordan Crouse

Add crypto engine (CE) and CE BAM related nodes and definitions to
'sm8150.dtsi'.

Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Tested-by: Jordan Crouse <jorcrous@amazon.com>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index cef8c4f4f0ff..6e21352a158c 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -2041,6 +2041,34 @@ ufs_mem_phy_lanes: phy@1d87400 {
 			};
 		};
 
+		cryptobam: dma-controller@1dc4000 {
+			compatible = "qcom,bam-v1.7.0";
+			reg = <0 0x01dc4000 0 0x24000>;
+			interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			qcom,ee = <0>;
+			qcom,controlled-remotely;
+			iommus = <&apps_smmu 0x504 0x0011>,
+				 <&apps_smmu 0x506 0x0011>,
+				 <&apps_smmu 0x514 0x0011>,
+				 <&apps_smmu 0x516 0x0011>;
+			interconnects = <&aggre2_noc MASTER_CRYPTO_CORE_0 &mc_virt SLAVE_EBI_CH0>;
+			interconnect-names = "memory";
+		};
+
+		crypto: crypto@1dfa000 {
+			compatible = "qcom,sm8150-qce";
+			reg = <0 0x01dfa000 0 0x6000>;
+			dmas = <&cryptobam 4>, <&cryptobam 5>;
+			dma-names = "rx", "tx";
+			iommus = <&apps_smmu 0x504 0x0011>,
+				 <&apps_smmu 0x506 0x0011>,
+				 <&apps_smmu 0x514 0x0011>,
+				 <&apps_smmu 0x516 0x0011>;
+			interconnects = <&aggre2_noc MASTER_CRYPTO_CORE_0 &mc_virt SLAVE_EBI_CH0>;
+			interconnect-names = "memory";
+		};
+
 		ipa_virt: interconnect@1e00000 {
 			compatible = "qcom,sm8150-ipa-virt";
 			reg = <0 0x01e00000 0 0x1000>;
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v6 4/4] arm64: defconfig: Enable Qualcomm QCE crypto
  2022-09-19 22:08 [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
                   ` (2 preceding siblings ...)
  2022-09-19 22:08 ` [PATCH v6 3/4] arm64: dts: qcom: sm8150: " Bhupesh Sharma
@ 2022-09-19 22:08 ` Bhupesh Sharma
  2022-09-19 22:11 ` [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
  2022-09-20  7:28 ` Krzysztof Kozlowski
  5 siblings, 0 replies; 11+ messages in thread
From: Bhupesh Sharma @ 2022-09-19 22:08 UTC (permalink / raw)
  To: linux-arm-kernel, linux-arm-msm
  Cc: agross, linux-kernel, robh+dt, thara.gopinath, devicetree, robh,
	krzysztof.kozlowski, andersson, bhupesh.sharma, bhupesh.linux,
	Catalin Marinas, Will Deacon, Arnd Bergmann

Now that the QCE crypto block is supported on several
Qualcomm SoCs upstream, enable the same as a module in the
arm64 defconfig.

Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5a4ba141d15c..46d6c95b8d25 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1321,6 +1321,7 @@ CONFIG_CRYPTO_USER_API_RNG=m
 CONFIG_CRYPTO_DEV_SUN8I_CE=m
 CONFIG_CRYPTO_DEV_FSL_CAAM=m
 CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM=m
+CONFIG_CRYPTO_DEV_QCE=m
 CONFIG_CRYPTO_DEV_QCOM_RNG=m
 CONFIG_CRYPTO_DEV_CCREE=m
 CONFIG_CRYPTO_DEV_HISI_SEC2=m
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes
  2022-09-19 22:08 [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
                   ` (3 preceding siblings ...)
  2022-09-19 22:08 ` [PATCH v6 4/4] arm64: defconfig: Enable Qualcomm QCE crypto Bhupesh Sharma
@ 2022-09-19 22:11 ` Bhupesh Sharma
  2022-09-20  7:28 ` Krzysztof Kozlowski
  5 siblings, 0 replies; 11+ messages in thread
From: Bhupesh Sharma @ 2022-09-19 22:11 UTC (permalink / raw)
  To: linux-arm-kernel, linux-arm-msm
  Cc: agross, linux-kernel, robh+dt, thara.gopinath, devicetree, robh,
	krzysztof.kozlowski, andersson, bhupesh.linux, Jordan Crouse

On Tue, 20 Sept 2022 at 03:38, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
>
> Changes since v5:
> =================
> - v5 can be seen here: https://lore.kernel.org/lkml/20211110105922.217895-1-bhupesh.sharma@linaro.org/
> - As per Bjorn's suggestion on irc, broke down the patchset into 4
>   separate patchsets, one each for the following areas to allow easier
>   review and handling from the respective maintainer(s):
>         'arm-msm', 'crypto', 'dma' and 'devicetree'
>   This patchset is directed for the 'arm-msm' tree / area.
> - Addressed Rob's, Vladimir's and Bjorn's review comments on v5.
> - Added Tested-by from Jordan received on the v5.
> - Also added a 'defconfig' change where I enabled the QCE block as a module.
>
> Changes since v4:
> =================
> - v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@linaro.org/
> - v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@linaro.org/
> - Merged the sm8150 and sm8250 enablement patches in the same patchset,
>   as per suggestions from Bjorn.
> - Dropped a couple of patches from v4, as these have been picked by
>   Bjorn already via his tree.
> - Addressed review comments from Vladimir, Thara and Rob.
> - Collect Reviewed-by from Rob and Thara on some of the patches from the
>   v4 patchset.
>
> Changes since v3:
> =================
> - v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@linaro.org/
> - Dropped a couple of patches from v3, on basis of the review comments:
>    ~ [PATCH 13/17] crypto: qce: core: Make clocks optional
>    ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info()
> - Addressed review comments from Thara, Rob and Stephan Gerhold.
> - Collect Reviewed-by from Rob and Thara on some of the patches from the
>   v3 patchset.
>
> Changes since v2:
> =================
> - v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@linaro.org/
> - Drop a couple of patches from v1, which tried to address the defered
>   probing of qce driver in case bam dma driver is not yet probed.
>   Replace it instead with a single (simpler) patch [PATCH 16/17].
> - Convert bam dma and qce crypto dt-bindings to YAML.
> - Addressed review comments from Thara, Bjorn, Vinod and Rob.
>
> Changes since v1:
> =================
> - v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@linaro.org/
> - v1 did not work well as reported earlier by Dmitry, so v2 contains the following
>   changes/fixes:
>   ~ Enable the interconnect path b/w BAM DMA and main memory first
>     before trying to access the BAM DMA registers.
>   ~ Enable the interconnect path b/w qce crytpo and main memory first
>     before trying to access the qce crypto registers.
>   ~ Make sure to document the required and optional properties for both
>     BAM DMA and qce crypto drivers.
>   ~ Add a few debug related print messages in case the qce crypto driver
>     passes or fails to probe.
>   ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA
>     or the interconnect driver(s) (needed on specific Qualcomm parts) are not
>     yet probed.
>
> Qualcomm crypto engine (qce) is available on several Snapdragon SoCs.
> The qce block supports hardware accelerated algorithms for encryption
> and authentication. It also provides support for aes, des, 3des
> encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256)
> authentication algorithms.
>
> Note that this patchset is dependent on the dt-bindings patchset (see [1]) sent to devicetree list.
>
> [1]. https://lore.kernel.org/linux-arm-msm/20220919195618.926227-1-bhupesh.sharma@linaro.org/
>
> Cc: thara.gopinath@gmail.com
> Cc: robh@kernel.org
> Cc: andersson@kernel.org
> Tested-by: Jordan Crouse <jorcrous@amazon.com>
>
> Bhupesh Sharma (4):
>   ARM: dts: qcom: Use new compatibles for crypto nodes
>   arm64: dts: qcom: sm8250: Add dt entries to support crypto engine.
>   arm64: dts: qcom: sm8150: Add dt entries to support crypto engine.
>   arm64: defconfig: Enable Qualcomm QCE crypto
>
>  arch/arm/boot/dts/qcom-ipq4019.dtsi   |  2 +-
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi |  2 +-
>  arch/arm64/boot/dts/qcom/ipq8074.dtsi |  2 +-
>  arch/arm64/boot/dts/qcom/msm8996.dtsi |  2 +-
>  arch/arm64/boot/dts/qcom/sdm845.dtsi  |  2 +-
>  arch/arm64/boot/dts/qcom/sm8150.dtsi  | 28 +++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/sm8250.dtsi  | 28 +++++++++++++++++++++++++++
>  arch/arm64/configs/defconfig          |  1 +
>  8 files changed, 62 insertions(+), 5 deletions(-)
>
> --
> 2.37.1

Please ignore this patchset as I made some typos in the cover-letter
while sending it out. I will send a revised version shortly.

Thanks,
Bhupesh

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes
  2022-09-19 22:08 [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
                   ` (4 preceding siblings ...)
  2022-09-19 22:11 ` [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
@ 2022-09-20  7:28 ` Krzysztof Kozlowski
  2022-09-20  8:48   ` Bhupesh Sharma
  5 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-20  7:28 UTC (permalink / raw)
  To: Bhupesh Sharma, linux-arm-kernel, linux-arm-msm
  Cc: agross, linux-kernel, robh+dt, thara.gopinath, devicetree, robh,
	andersson, bhupesh.linux, Jordan Crouse

On 20/09/2022 00:08, Bhupesh Sharma wrote:

(...)


> 
> Qualcomm crypto engine (qce) is available on several Snapdragon SoCs.
> The qce block supports hardware accelerated algorithms for encryption
> and authentication. It also provides support for aes, des, 3des
> encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256)
> authentication algorithms.
> 
> Note that this patchset is dependent on the dt-bindings patchset (see [1]) sent to devicetree list.
> 
> [1]. https://lore.kernel.org/linux-arm-msm/20220919195618.926227-1-bhupesh.sharma@linaro.org/

If it is dependent on the bindings only, keep them together. However I
don't think this is the only dependency. You add here several
compatibles which are not supported.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes
  2022-09-20  7:28 ` Krzysztof Kozlowski
@ 2022-09-20  8:48   ` Bhupesh Sharma
  2022-09-20  8:54     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 11+ messages in thread
From: Bhupesh Sharma @ 2022-09-20  8:48 UTC (permalink / raw)
  To: Krzysztof Kozlowski, linux-arm-kernel, linux-arm-msm
  Cc: agross, linux-kernel, robh+dt, thara.gopinath, devicetree, robh,
	andersson, bhupesh.linux, Jordan Crouse


On 9/20/22 12:58 PM, Krzysztof Kozlowski wrote:
> On 20/09/2022 00:08, Bhupesh Sharma wrote:
> 
> (...)
> 
> 
>>
>> Qualcomm crypto engine (qce) is available on several Snapdragon SoCs.
>> The qce block supports hardware accelerated algorithms for encryption
>> and authentication. It also provides support for aes, des, 3des
>> encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256)
>> authentication algorithms.
>>
>> Note that this patchset is dependent on the dt-bindings patchset (see [1]) sent to devicetree list.
>>
>> [1]. https://lore.kernel.org/linux-arm-msm/20220919195618.926227-1-bhupesh.sharma@linaro.org/
> 
> If it is dependent on the bindings only, keep them together. However I
> don't think this is the only dependency. You add here several
> compatibles which are not supported.


Please go through the cover letter where I mentioned that:
   'As per Bjorn's suggestion on irc, broke down the patchset into 4
   separate patchsets, one each for the following areas to allow easier
   review and handling from the respective maintainer(s):
         'arm-msm', 'crypto', 'dma' and 'devicetree'
   This patchset is directed for the 'devicetree' tree / area.'

Basically now the patchset which had around 23 patches in v5 will send 
out as 4 separate patchsets one each for 'arm-msm', 'crypto', 'dma' and 
'devicetree' trees.

So when all the respective subsets are picked up, all the compatibles 
are in place.

Thanks,
Bhupesh

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes
  2022-09-20  8:48   ` Bhupesh Sharma
@ 2022-09-20  8:54     ` Krzysztof Kozlowski
  2022-09-20  9:13       ` Bhupesh Sharma
  0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-20  8:54 UTC (permalink / raw)
  To: Bhupesh Sharma, linux-arm-kernel, linux-arm-msm
  Cc: agross, linux-kernel, robh+dt, thara.gopinath, devicetree, robh,
	andersson, bhupesh.linux, Jordan Crouse

On 20/09/2022 10:48, Bhupesh Sharma wrote:
> 
> On 9/20/22 12:58 PM, Krzysztof Kozlowski wrote:
>> On 20/09/2022 00:08, Bhupesh Sharma wrote:
>>
>> (...)
>>
>>
>>>
>>> Qualcomm crypto engine (qce) is available on several Snapdragon SoCs.
>>> The qce block supports hardware accelerated algorithms for encryption
>>> and authentication. It also provides support for aes, des, 3des
>>> encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256)
>>> authentication algorithms.
>>>
>>> Note that this patchset is dependent on the dt-bindings patchset (see [1]) sent to devicetree list.
>>>
>>> [1]. https://lore.kernel.org/linux-arm-msm/20220919195618.926227-1-bhupesh.sharma@linaro.org/
>>
>> If it is dependent on the bindings only, keep them together. However I
>> don't think this is the only dependency. You add here several
>> compatibles which are not supported.
> 
> 
> Please go through the cover letter where I mentioned that:
>    'As per Bjorn's suggestion on irc, broke down the patchset into 4
>    separate patchsets, one each for the following areas to allow easier
>    review and handling from the respective maintainer(s):
>          'arm-msm', 'crypto', 'dma' and 'devicetree'
>    This patchset is directed for the 'devicetree' tree / area.'
> 
> Basically now the patchset which had around 23 patches in v5 will send 
> out as 4 separate patchsets one each for 'arm-msm', 'crypto', 'dma' and 
> 'devicetree' trees.
> 
> So when all the respective subsets are picked up, all the compatibles 
> are in place.

and none of reviewers can find them, because you linked only bindings.
Keeping bindings separate from everything is not good approach. Either
they should be with DTS or with driver changes. Otherwise how can we
even look that they are matching DTS?

Keeping them separate even makes impression there are no ABI breaks and
bisectability issues...


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes
  2022-09-20  8:54     ` Krzysztof Kozlowski
@ 2022-09-20  9:13       ` Bhupesh Sharma
  0 siblings, 0 replies; 11+ messages in thread
From: Bhupesh Sharma @ 2022-09-20  9:13 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: linux-arm-kernel, linux-arm-msm, agross, linux-kernel, robh+dt,
	thara.gopinath, devicetree, robh, andersson, bhupesh.linux,
	Jordan Crouse

On Tue, 20 Sept 2022 at 14:24, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/09/2022 10:48, Bhupesh Sharma wrote:
> >
> > On 9/20/22 12:58 PM, Krzysztof Kozlowski wrote:
> >> On 20/09/2022 00:08, Bhupesh Sharma wrote:
> >>
> >> (...)
> >>
> >>
> >>>
> >>> Qualcomm crypto engine (qce) is available on several Snapdragon SoCs.
> >>> The qce block supports hardware accelerated algorithms for encryption
> >>> and authentication. It also provides support for aes, des, 3des
> >>> encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256)
> >>> authentication algorithms.
> >>>
> >>> Note that this patchset is dependent on the dt-bindings patchset (see [1]) sent to devicetree list.
> >>>
> >>> [1]. https://lore.kernel.org/linux-arm-msm/20220919195618.926227-1-bhupesh.sharma@linaro.org/
> >>
> >> If it is dependent on the bindings only, keep them together. However I
> >> don't think this is the only dependency. You add here several
> >> compatibles which are not supported.
> >
> >
> > Please go through the cover letter where I mentioned that:
> >    'As per Bjorn's suggestion on irc, broke down the patchset into 4
> >    separate patchsets, one each for the following areas to allow easier
> >    review and handling from the respective maintainer(s):
> >          'arm-msm', 'crypto', 'dma' and 'devicetree'
> >    This patchset is directed for the 'devicetree' tree / area.'
> >
> > Basically now the patchset which had around 23 patches in v5 will send
> > out as 4 separate patchsets one each for 'arm-msm', 'crypto', 'dma' and
> > 'devicetree' trees.
> >
> > So when all the respective subsets are picked up, all the compatibles
> > are in place.
>
> and none of reviewers can find them, because you linked only bindings.
> Keeping bindings separate from everything is not good approach. Either
> they should be with DTS or with driver changes. Otherwise how can we
> even look that they are matching DTS?
>
> Keeping them separate even makes impression there are no ABI breaks and
> bisectability issues...

I see your point, but as I mentioned this was as per suggestions from
other maintainers only :)
Perhaps a good topic for the next LPC maintainers meetup - i.e. would
maintainers be more happy with subpatches for their specific area v/s
being cc'ed on a single patchset which touches other areas as well
(but are required for enabling a feature in its entirety).

Thanks,
Bhupesh

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes
@ 2022-09-19 19:56 Bhupesh Sharma
  0 siblings, 0 replies; 11+ messages in thread
From: Bhupesh Sharma @ 2022-09-19 19:56 UTC (permalink / raw)
  To: linux-kernel, devicetree
  Cc: agross, robh+dt, linux-arm-msm, thara.gopinath, robh,
	krzysztof.kozlowski, andersson, bhupesh.sharma, bhupesh.linux,
	Jordan Crouse

Changes since v5:
=================
- v5 can be seen here: https://lore.kernel.org/lkml/20211110105922.217895-1-bhupesh.sharma@linaro.org/
- As per Bjorn's suggestion on irc, broke down the patchset into 4
  separate patchsets, one each for the following areas to allow easier
  review and handling from the respective maintainer(s):
	'arm-msm', 'crypto', 'dma' and 'devicetree' 
  This patchset is directed for the 'devicetree' tree / area.
- Addressed Rob's, Vladimir's and Bjorn's review comments and Acks received on
  v5.
- Added Tested-by from Jordan received on the v5.
- Dropped '[PATCH v5 09/22] dt-bindings: qcom-qce: Move 'clocks' to optional properties'
  from this series as per Bjorn's suggestions.

Changes since v4:
=================
- v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@linaro.org/
- v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@linaro.org/
- Merged the sm8150 and sm8250 enablement patches in the same patchset,
  as per suggestions from Bjorn.
- Dropped a couple of patches from v4, as these have been picked by
  Bjorn already via his tree.
- Addressed review comments from Vladimir, Thara and Rob.
- Collect Reviewed-by from Rob and Thara on some of the patches from the
  v4 patchset.

Changes since v3:
=================
- v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@linaro.org/
- Dropped a couple of patches from v3, on basis of the review comments:
   ~ [PATCH 13/17] crypto: qce: core: Make clocks optional
   ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info()
- Addressed review comments from Thara, Rob and Stephan Gerhold.
- Collect Reviewed-by from Rob and Thara on some of the patches from the
  v3 patchset.

Changes since v2:
=================
- v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@linaro.org/
- Drop a couple of patches from v1, which tried to address the defered
  probing of qce driver in case bam dma driver is not yet probed.
  Replace it instead with a single (simpler) patch [PATCH 16/17].
- Convert bam dma and qce crypto dt-bindings to YAML.
- Addressed review comments from Thara, Bjorn, Vinod and Rob.

Changes since v1:
=================
- v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@linaro.org/ 
- v1 did not work well as reported earlier by Dmitry, so v2 contains the following
  changes/fixes:
  ~ Enable the interconnect path b/w BAM DMA and main memory first
    before trying to access the BAM DMA registers.
  ~ Enable the interconnect path b/w qce crytpo and main memory first
    before trying to access the qce crypto registers.
  ~ Make sure to document the required and optional properties for both
    BAM DMA and qce crypto drivers.
  ~ Add a few debug related print messages in case the qce crypto driver
    passes or fails to probe.
  ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA
    or the interconnect driver(s) (needed on specific Qualcomm parts) are not
    yet probed.

Qualcomm crypto engine (qce) is available on several Snapdragon SoCs.
The qce block supports hardware accelerated algorithms for encryption
and authentication. It also provides support for aes, des, 3des
encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256)
authentication algorithms.

Cc: thara.gopinath@gmail.com
Cc: robh@kernel.org
Cc: andersson@kernel.org
Cc: krzysztof.kozlowski@linaro.org
Tested-by: Jordan Crouse <jorcrous@amazon.com>

Bhupesh Sharma (4):
  dt-bindings: qcom-qce: Convert bindings to yaml
  dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names'
  dt-bindings: qcom-qce: Add 'iommus' to optional properties
  dt-bindings: qcom-qce: Add new SoC compatible strings in dt-binding
    doc

 .../devicetree/bindings/crypto/qcom-qce.txt   | 25 -----
 .../devicetree/bindings/crypto/qcom-qce.yaml  | 93 +++++++++++++++++++
 2 files changed, 93 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.txt
 create mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.yaml

-- 
2.37.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-09-20  9:15 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 22:08 [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
2022-09-19 22:08 ` [PATCH v6 1/4] ARM: dts: qcom: Use new compatibles for crypto nodes Bhupesh Sharma
2022-09-19 22:08 ` [PATCH v6 2/4] arm64: dts: qcom: sm8250: Add dt entries to support crypto engine Bhupesh Sharma
2022-09-19 22:08 ` [PATCH v6 3/4] arm64: dts: qcom: sm8150: " Bhupesh Sharma
2022-09-19 22:08 ` [PATCH v6 4/4] arm64: defconfig: Enable Qualcomm QCE crypto Bhupesh Sharma
2022-09-19 22:11 ` [PATCH v6 0/4] dt-bindings: qcom-qce: Convert bindings to yaml & related changes Bhupesh Sharma
2022-09-20  7:28 ` Krzysztof Kozlowski
2022-09-20  8:48   ` Bhupesh Sharma
2022-09-20  8:54     ` Krzysztof Kozlowski
2022-09-20  9:13       ` Bhupesh Sharma
  -- strict thread matches above, loose matches on Subject: below --
2022-09-19 19:56 Bhupesh Sharma

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).