* [PATCH blktests] nbd/003: improve the test
@ 2020-02-24 4:27 Sun Ke
2020-03-05 1:35 ` Omar Sandoval
0 siblings, 1 reply; 3+ messages in thread
From: Sun Ke @ 2020-02-24 4:27 UTC (permalink / raw)
To: linux-block, osandov; +Cc: sunke32
Modify the DESCRIPTION, remove the umount and add rm.
Signed-off-by: Sun Ke <sunke32@huawei.com>
---
tests/nbd/003 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/nbd/003 b/tests/nbd/003
index 57fb63a..49ca30e 100644
--- a/tests/nbd/003
+++ b/tests/nbd/003
@@ -7,7 +7,7 @@
. tests/nbd/rc
-DESCRIPTION="mount/unmount concurrently with NBD_CLEAR_SOCK"
+DESCRIPTION="connected by ioctl, mount/unmount concurrently with NBD_CLEAR_SOCK"
QUICK=1
requires() {
@@ -23,8 +23,8 @@ test() {
mkdir -p "${TMPDIR}/mnt"
src/mount_clear_sock /dev/nbd0 "${TMPDIR}/mnt" ext4 5000
- umount "${TMPDIR}/mnt" > /dev/null 2>&1
nbd-client -d /dev/nbd0 >> "$FULL" 2>&1
+ rm -rf "${TMPDIR}/mnt"
_stop_nbd_server
}
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH blktests] nbd/003: improve the test
2020-02-24 4:27 [PATCH blktests] nbd/003: improve the test Sun Ke
@ 2020-03-05 1:35 ` Omar Sandoval
2020-03-05 8:43 ` sunke (E)
0 siblings, 1 reply; 3+ messages in thread
From: Omar Sandoval @ 2020-03-05 1:35 UTC (permalink / raw)
To: Sun Ke; +Cc: linux-block, osandov
On Mon, Feb 24, 2020 at 12:27:28PM +0800, Sun Ke wrote:
> Modify the DESCRIPTION, remove the umount and add rm.
>
> Signed-off-by: Sun Ke <sunke32@huawei.com>
> ---
> tests/nbd/003 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/nbd/003 b/tests/nbd/003
> index 57fb63a..49ca30e 100644
> --- a/tests/nbd/003
> +++ b/tests/nbd/003
> @@ -7,7 +7,7 @@
>
> . tests/nbd/rc
>
> -DESCRIPTION="mount/unmount concurrently with NBD_CLEAR_SOCK"
> +DESCRIPTION="connected by ioctl, mount/unmount concurrently with NBD_CLEAR_SOCK"
> QUICK=1
>
> requires() {
> @@ -23,8 +23,8 @@ test() {
>
> mkdir -p "${TMPDIR}/mnt"
> src/mount_clear_sock /dev/nbd0 "${TMPDIR}/mnt" ext4 5000
> - umount "${TMPDIR}/mnt" > /dev/null 2>&1
Is the umount causing problems?
>
> nbd-client -d /dev/nbd0 >> "$FULL" 2>&1
> + rm -rf "${TMPDIR}/mnt"
The test harness already removes the TMPDIR directory. Why is this
necessary?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH blktests] nbd/003: improve the test
2020-03-05 1:35 ` Omar Sandoval
@ 2020-03-05 8:43 ` sunke (E)
0 siblings, 0 replies; 3+ messages in thread
From: sunke (E) @ 2020-03-05 8:43 UTC (permalink / raw)
To: Omar Sandoval; +Cc: linux-block, osandov
在 2020/3/5 9:35, Omar Sandoval 写道:
> On Mon, Feb 24, 2020 at 12:27:28PM +0800, Sun Ke wrote:
>> Modify the DESCRIPTION, remove the umount and add rm.
>>
>> Signed-off-by: Sun Ke <sunke32@huawei.com>
>> ---
>> tests/nbd/003 | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/nbd/003 b/tests/nbd/003
>> index 57fb63a..49ca30e 100644
>> --- a/tests/nbd/003
>> +++ b/tests/nbd/003
>> @@ -7,7 +7,7 @@
>>
>> . tests/nbd/rc
>>
>> -DESCRIPTION="mount/unmount concurrently with NBD_CLEAR_SOCK"
>> +DESCRIPTION="connected by ioctl, mount/unmount concurrently with NBD_CLEAR_SOCK"
>> QUICK=1
>>
>> requires() {
>> @@ -23,8 +23,8 @@ test() {
>>
>> mkdir -p "${TMPDIR}/mnt"
>> src/mount_clear_sock /dev/nbd0 "${TMPDIR}/mnt" ext4 5000
>> - umount "${TMPDIR}/mnt" > /dev/null 2>&1
>
> Is the umount causing problems?
No, it do not cause problems, but it is redundant.
>
>>
>> nbd-client -d /dev/nbd0 >> "$FULL" 2>&1
>> + rm -rf "${TMPDIR}/mnt"
>
> The test harness already removes the TMPDIR directory. Why is this
> necessary?
>
I see.
Thanks,
Sun Ke
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-05 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 4:27 [PATCH blktests] nbd/003: improve the test Sun Ke
2020-03-05 1:35 ` Omar Sandoval
2020-03-05 8:43 ` sunke (E)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).