[PATCH blktests] nbd/003: improve the test

[PATCH blktests] nbd/003: improve the test

[Sun Ke]

Modify the DESCRIPTION, remove the umount and add rm.

Signed-off-by: Sun Ke <sunke32@huawei.com>
---
 tests/nbd/003 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/nbd/003 b/tests/nbd/003
index 57fb63a..49ca30e 100644
--- a/tests/nbd/003
+++ b/tests/nbd/003
@@ -7,7 +7,7 @@
 
 . tests/nbd/rc
 
-DESCRIPTION="mount/unmount concurrently with NBD_CLEAR_SOCK"
+DESCRIPTION="connected by ioctl, mount/unmount concurrently with NBD_CLEAR_SOCK"
 QUICK=1
 
 requires() {
@@ -23,8 +23,8 @@ test() {
 
 	mkdir -p "${TMPDIR}/mnt"
 	src/mount_clear_sock /dev/nbd0 "${TMPDIR}/mnt" ext4 5000
-	umount "${TMPDIR}/mnt" > /dev/null 2>&1
 
 	nbd-client -d /dev/nbd0 >> "$FULL" 2>&1
+	rm -rf "${TMPDIR}/mnt"
 	_stop_nbd_server
 }
-- 
2.13.6

Re: [PATCH blktests] nbd/003: improve the test

[Omar Sandoval]

On Mon, Feb 24, 2020 at 12:27:28PM +0800, Sun Ke wrote:
> Modify the DESCRIPTION, remove the umount and add rm.
> 
> Signed-off-by: Sun Ke <sunke32@huawei.com>
> ---
>  tests/nbd/003 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/nbd/003 b/tests/nbd/003
> index 57fb63a..49ca30e 100644
> --- a/tests/nbd/003
> +++ b/tests/nbd/003
> @@ -7,7 +7,7 @@
>  
>  . tests/nbd/rc
>  
> -DESCRIPTION="mount/unmount concurrently with NBD_CLEAR_SOCK"
> +DESCRIPTION="connected by ioctl, mount/unmount concurrently with NBD_CLEAR_SOCK"
>  QUICK=1
>  
>  requires() {
> @@ -23,8 +23,8 @@ test() {
>  
>  	mkdir -p "${TMPDIR}/mnt"
>  	src/mount_clear_sock /dev/nbd0 "${TMPDIR}/mnt" ext4 5000
> -	umount "${TMPDIR}/mnt" > /dev/null 2>&1

Is the umount causing problems?

>  
>  	nbd-client -d /dev/nbd0 >> "$FULL" 2>&1
> +	rm -rf "${TMPDIR}/mnt"

The test harness already removes the TMPDIR directory. Why is this
necessary?

Re: [PATCH blktests] nbd/003: improve the test

[sunke (E)]

在 2020/3/5 9:35, Omar Sandoval 写道:
> On Mon, Feb 24, 2020 at 12:27:28PM +0800, Sun Ke wrote:
>> Modify the DESCRIPTION, remove the umount and add rm.
>>
>> Signed-off-by: Sun Ke <sunke32@huawei.com>
>> ---
>>   tests/nbd/003 | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/nbd/003 b/tests/nbd/003
>> index 57fb63a..49ca30e 100644
>> --- a/tests/nbd/003
>> +++ b/tests/nbd/003
>> @@ -7,7 +7,7 @@
>>   
>>   . tests/nbd/rc
>>   
>> -DESCRIPTION="mount/unmount concurrently with NBD_CLEAR_SOCK"
>> +DESCRIPTION="connected by ioctl, mount/unmount concurrently with NBD_CLEAR_SOCK"
>>   QUICK=1
>>   
>>   requires() {
>> @@ -23,8 +23,8 @@ test() {
>>   
>>   	mkdir -p "${TMPDIR}/mnt"
>>   	src/mount_clear_sock /dev/nbd0 "${TMPDIR}/mnt" ext4 5000
>> -	umount "${TMPDIR}/mnt" > /dev/null 2>&1
> 
> Is the umount causing problems?
No, it do not cause problems, but it is redundant.
> 
>>   
>>   	nbd-client -d /dev/nbd0 >> "$FULL" 2>&1
>> +	rm -rf "${TMPDIR}/mnt"
> 
> The test harness already removes the TMPDIR directory. Why is this
> necessary?
>
I see.

Thanks,
Sun Ke