Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq()
@ 2020-04-27 13:12 Hou Tao
  2020-04-27 17:27 ` Bart Van Assche
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Hou Tao @ 2020-04-27 13:12 UTC (permalink / raw)
  To: linux-block; +Cc: Jens Axboe, Bart Van Assche

And use rq directly.

Signed-off-by: Hou Tao <houtao1@huawei.com>
---
 block/blk-mq-debugfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index b3f2ba483992..7a79db81a63f 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -400,8 +400,7 @@ static bool hctx_show_busy_rq(struct request *rq, void *data, bool reserved)
 	const struct show_busy_params *params = data;
 
 	if (rq->mq_hctx == params->hctx)
-		__blk_mq_debugfs_rq_show(params->m,
-					 list_entry_rq(&rq->queuelist));
+		__blk_mq_debugfs_rq_show(params->m, rq);
 
 	return true;
 }
-- 
2.21.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq()
  2020-04-27 13:12 [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq() Hou Tao
@ 2020-04-27 17:27 ` Bart Van Assche
  2020-05-25  6:32   ` Hou Tao
  2020-07-01  4:00 ` Ming Lei
  2020-07-01 13:26 ` Jens Axboe
  2 siblings, 1 reply; 6+ messages in thread
From: Bart Van Assche @ 2020-04-27 17:27 UTC (permalink / raw)
  To: Hou Tao, linux-block; +Cc: Jens Axboe

On 2020-04-27 06:12, Hou Tao wrote:
> And use rq directly.
> 
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
>  block/blk-mq-debugfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index b3f2ba483992..7a79db81a63f 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -400,8 +400,7 @@ static bool hctx_show_busy_rq(struct request *rq, void *data, bool reserved)
>  	const struct show_busy_params *params = data;
>  
>  	if (rq->mq_hctx == params->hctx)
> -		__blk_mq_debugfs_rq_show(params->m,
> -					 list_entry_rq(&rq->queuelist));
> +		__blk_mq_debugfs_rq_show(params->m, rq);
>  
>  	return true;
>  }

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq()
  2020-04-27 17:27 ` Bart Van Assche
@ 2020-05-25  6:32   ` Hou Tao
  2020-07-01  1:24     ` Hou Tao
  0 siblings, 1 reply; 6+ messages in thread
From: Hou Tao @ 2020-05-25  6:32 UTC (permalink / raw)
  To: linux-block, Jens Axboe; +Cc: Bart Van Assche

ping ?

On 2020/4/28 1:27, Bart Van Assche wrote:
> On 2020-04-27 06:12, Hou Tao wrote:
>> And use rq directly.
>>
>> Signed-off-by: Hou Tao <houtao1@huawei.com>
>> ---
>>  block/blk-mq-debugfs.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
>> index b3f2ba483992..7a79db81a63f 100644
>> --- a/block/blk-mq-debugfs.c
>> +++ b/block/blk-mq-debugfs.c
>> @@ -400,8 +400,7 @@ static bool hctx_show_busy_rq(struct request *rq, void *data, bool reserved)
>>  	const struct show_busy_params *params = data;
>>  
>>  	if (rq->mq_hctx == params->hctx)
>> -		__blk_mq_debugfs_rq_show(params->m,
>> -					 list_entry_rq(&rq->queuelist));
>> +		__blk_mq_debugfs_rq_show(params->m, rq);
>>  
>>  	return true;
>>  }
> 
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> 
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq()
  2020-05-25  6:32   ` Hou Tao
@ 2020-07-01  1:24     ` Hou Tao
  0 siblings, 0 replies; 6+ messages in thread
From: Hou Tao @ 2020-07-01  1:24 UTC (permalink / raw)
  To: linux-block, Jens Axboe; +Cc: Bart Van Assche, Ming Lei

ping ?

On 2020/5/25 14:32, Hou Tao wrote:
> ping ?
> 
> On 2020/4/28 1:27, Bart Van Assche wrote:
>> On 2020-04-27 06:12, Hou Tao wrote:
>>> And use rq directly.
>>>
>>> Signed-off-by: Hou Tao <houtao1@huawei.com>
>>> ---
>>>  block/blk-mq-debugfs.c | 3 +--
>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
>>> index b3f2ba483992..7a79db81a63f 100644
>>> --- a/block/blk-mq-debugfs.c
>>> +++ b/block/blk-mq-debugfs.c
>>> @@ -400,8 +400,7 @@ static bool hctx_show_busy_rq(struct request *rq, void *data, bool reserved)
>>>  	const struct show_busy_params *params = data;
>>>  
>>>  	if (rq->mq_hctx == params->hctx)
>>> -		__blk_mq_debugfs_rq_show(params->m,
>>> -					 list_entry_rq(&rq->queuelist));
>>> +		__blk_mq_debugfs_rq_show(params->m, rq);
>>>  
>>>  	return true;
>>>  }
>>
>> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>>
>>
> 
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq()
  2020-04-27 13:12 [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq() Hou Tao
  2020-04-27 17:27 ` Bart Van Assche
@ 2020-07-01  4:00 ` Ming Lei
  2020-07-01 13:26 ` Jens Axboe
  2 siblings, 0 replies; 6+ messages in thread
From: Ming Lei @ 2020-07-01  4:00 UTC (permalink / raw)
  To: Hou Tao; +Cc: linux-block, Jens Axboe, Bart Van Assche

On Mon, Apr 27, 2020 at 8:44 PM Hou Tao <houtao1@huawei.com> wrote:
>
> And use rq directly.
>
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
>  block/blk-mq-debugfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index b3f2ba483992..7a79db81a63f 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -400,8 +400,7 @@ static bool hctx_show_busy_rq(struct request *rq, void *data, bool reserved)
>         const struct show_busy_params *params = data;
>
>         if (rq->mq_hctx == params->hctx)
> -               __blk_mq_debugfs_rq_show(params->m,
> -                                        list_entry_rq(&rq->queuelist));
> +               __blk_mq_debugfs_rq_show(params->m, rq);

Reviewed-by: Ming Lei <ming.lei@redhat.com>


-- 
Ming Lei

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq()
  2020-04-27 13:12 [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq() Hou Tao
  2020-04-27 17:27 ` Bart Van Assche
  2020-07-01  4:00 ` Ming Lei
@ 2020-07-01 13:26 ` Jens Axboe
  2 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2020-07-01 13:26 UTC (permalink / raw)
  To: Hou Tao, linux-block; +Cc: Bart Van Assche

On 4/27/20 7:12 AM, Hou Tao wrote:
> And use rq directly.

I re-wrote your commit message a bit - but otherwise, thanks, applied.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 13:12 [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq() Hou Tao
2020-04-27 17:27 ` Bart Van Assche
2020-05-25  6:32   ` Hou Tao
2020-07-01  1:24     ` Hou Tao
2020-07-01  4:00 ` Ming Lei
2020-07-01 13:26 ` Jens Axboe

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git