From: Marcel Holtmann <marcel@holtmann.org>
To: Sonny Sasaka <sonnysasaka@chromium.org>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>,
Eric Caruso <ejcaruso@chromium.org>
Subject: Re: [PATCH] device: Add device type property
Date: Wed, 20 May 2020 08:49:40 +0200 [thread overview]
Message-ID: <6C21A2C1-6224-4FB6-B483-27B1C89864BE@holtmann.org> (raw)
In-Reply-To: <CAOxioNkw8g90tVwQjqgdpX38__f17JHHTTsqBZwCjEkjME0Zyg@mail.gmail.com>
Hi Sonny,
> After giving it more thought, I would like to propose that this
> additional property corresponds with Device Type as defined in Generic
> Access Profile:
>
> As stated in Bluetooth Core Specification Version 5.2, Vol 3, Part C
> (Generic Access Profile):
> This profile defines three device types based on the supported Core
> Configurations as defined in [Vol 0] Part B, Section 3.1. The device
> types are shown in Table 1.1:
> * BR/EDR
> * LE only
> * BR/EDR/LE
>
> Therefore, to be as close to the spec as possible, I propose that the
> property be named GAPDeviceType, and the possible values be "br/edr",
> "le-only", "br/edr/le".
>
> What do you think? Thanks for reviewing this proposal!
maybe we should do SupportedTypes = [“le”, “bredr”, “hs”] since that also maps to what we expose in MGMT. And then add a Types = [ .. ] property with the same values. I don’t like using GAP in property names and repeating Device is also not needed since we are already in the Device interface. In addition I have a reservation with spec naming in this area since it has changed over time and there is a chance it might change again in future specs when new features come along.
If you know the supported types of the hardware and the selected types, you can easily get to the GAP Device Type from the spec if you actually want to show it. If you wanted to, you could make the Types property writeable as well and users could change their device type via D-Bus.
Regards
Marcel
next prev parent reply other threads:[~2020-05-20 6:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 22:13 [PATCH] device: Add device type property Sonny Sasaka
2020-04-09 18:11 ` Marcel Holtmann
2020-04-09 21:05 ` Sonny Sasaka
2020-04-10 6:51 ` Marcel Holtmann
2020-05-19 23:12 ` Sonny Sasaka
2020-05-20 6:49 ` Marcel Holtmann [this message]
2020-05-21 1:07 ` Sonny Sasaka
2020-05-21 7:01 ` Marcel Holtmann
2020-05-21 16:24 ` Sonny Sasaka
-- strict thread matches above, loose matches on Subject: below --
2017-02-09 1:05 mcchou
2017-02-09 7:37 ` Marcel Holtmann
2017-02-09 8:07 ` Szymon Janc
2017-02-09 9:40 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6C21A2C1-6224-4FB6-B483-27B1C89864BE@holtmann.org \
--to=marcel@holtmann.org \
--cc=ejcaruso@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sonnysasaka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).