From: Sonny Sasaka <sonnysasaka@chromium.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Bluez mailing list <linux-bluetooth@vger.kernel.org>,
Eric Caruso <ejcaruso@chromium.org>
Subject: Re: [PATCH] device: Add device type property
Date: Thu, 21 May 2020 09:24:37 -0700 [thread overview]
Message-ID: <CAOxioN=D2NVQn7YifUk=oATn-T0mcpQ3ABp1vPFQ_O1=Bup3sw@mail.gmail.com> (raw)
In-Reply-To: <EB4FAB97-6425-419D-89B8-D31A7D553BB8@holtmann.org>
Thanks for confirming, Marcel. I will come back with the modified
patch based on your feedback.
On Thu, May 21, 2020 at 12:02 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sonny,
>
> > I am okay with Types = ["le", "bredr"]. However, I don't understand
> > why a user should be able to change the Type, since this property
> > describes the fact about a peer device, not a local adapter. What does
> > it mean by a user changing the type of a peer device? Also, I don't
> > understand why HS needs to be considered in that property, since I see
> > org.bluez.Device1 objects as discovered devices either through Inquiry
> > (in which case it'd be "bredr") or Advertisement (in which case it'd
> > be "le"), or both. HS seems to be one of remote features rather than a
> > type. Also the HS information is also not readily available in the
> > struct btd_device, or even src/device.c, which suggests that it has
> > been treated differently.
>
> you are correct. I was thinking about the local role. My bad.
>
> Regards
>
> Marcel
>
next prev parent reply other threads:[~2020-05-21 16:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 22:13 [PATCH] device: Add device type property Sonny Sasaka
2020-04-09 18:11 ` Marcel Holtmann
2020-04-09 21:05 ` Sonny Sasaka
2020-04-10 6:51 ` Marcel Holtmann
2020-05-19 23:12 ` Sonny Sasaka
2020-05-20 6:49 ` Marcel Holtmann
2020-05-21 1:07 ` Sonny Sasaka
2020-05-21 7:01 ` Marcel Holtmann
2020-05-21 16:24 ` Sonny Sasaka [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-09 1:05 mcchou
2017-02-09 7:37 ` Marcel Holtmann
2017-02-09 8:07 ` Szymon Janc
2017-02-09 9:40 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOxioN=D2NVQn7YifUk=oATn-T0mcpQ3ABp1vPFQ_O1=Bup3sw@mail.gmail.com' \
--to=sonnysasaka@chromium.org \
--cc=ejcaruso@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).