Re: [PATCH] can: dev: fix crtlmode_supported check

Re: [PATCH] can: dev: fix crtlmode_supported check

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

On 01/27/2015 08:12 PM, Oliver Hartkopp wrote:
> When changing flags in the CAN drivers ctrlmode the provided new content has to
> be checked whether the bits are allowed to be changed. The bits that are to be
> changed are given as a bitfield in cm->mask. Therefore checking against
> cm->flags is wrong as the content can hold any kind of values.
> 
> The iproute2 tool sets the bits in cm->mask and cm->flags depending on the
> detected command line options. To be robust against bogus user space
> applications additionally sanitize the provided flags with the provided mask.
> 
> (Backport of upstream commit 9b1087aa5e86448fe6ad40a58964e35f3ba423d5 for
> Linux 3.2 .. Linux 3.14)

Zefan Li <lizefan@huawei.com> is taking care of v3.4

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] can: dev: fix crtlmode_supported check

[Oliver Hartkopp]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

Oh yes.

I got the entire thread twice.
I was assuming this to be the groundhog day :-)

See picture.

Regards,
Oliver

On 28.01.2015 09:25, Marc Kleine-Budde wrote:
> On 01/27/2015 08:12 PM, Oliver Hartkopp wrote:
>> When changing flags in the CAN drivers ctrlmode the provided new content has to
>> be checked whether the bits are allowed to be changed. The bits that are to be
>> changed are given as a bitfield in cm->mask. Therefore checking against
>> cm->flags is wrong as the content can hold any kind of values.
>>
>> The iproute2 tool sets the bits in cm->mask and cm->flags depending on the
>> detected command line options. To be robust against bogus user space
>> applications additionally sanitize the provided flags with the provided mask.
>>
>> (Backport of upstream commit 9b1087aa5e86448fe6ad40a58964e35f3ba423d5 for
>> Linux 3.2 .. Linux 3.14)
>
> Zefan Li <lizefan@huawei.com> is taking care of v3.4
>
> Marc
>

[-- Attachment #2: Bildschirmfoto - 28.01.2015 - 16:25:33.png --]
[-- Type: image/png, Size: 37967 bytes --]

Re: [PATCH] can: dev: fix crtlmode_supported check

[Oliver Hartkopp]

Hello all,

just in the case you are interested to pick these patches up for 3.2 and 3.4 
stable:

The backported patch for Linux 3.2 ... 3.14 has been queued by GregKH for the 
3.10 kernel here:

http://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git/tree/queue-3.10/can-dev-fix-crtlmode_supported-check.patch?id=332373aa9a50a1c18027be7352d6138fa74263d0

Best regards,
Oliver

On 28.01.2015 09:25, Marc Kleine-Budde wrote:
> On 01/27/2015 08:12 PM, Oliver Hartkopp wrote:
>> When changing flags in the CAN drivers ctrlmode the provided new content has to
>> be checked whether the bits are allowed to be changed. The bits that are to be
>> changed are given as a bitfield in cm->mask. Therefore checking against
>> cm->flags is wrong as the content can hold any kind of values.
>>
>> The iproute2 tool sets the bits in cm->mask and cm->flags depending on the
>> detected command line options. To be robust against bogus user space
>> applications additionally sanitize the provided flags with the provided mask.
>>
>> (Backport of upstream commit 9b1087aa5e86448fe6ad40a58964e35f3ba423d5 for
>> Linux 3.2 .. Linux 3.14)
>
> Zefan Li <lizefan@huawei.com> is taking care of v3.4
>
> Marc
>

Re: [PATCH] can: dev: fix crtlmode_supported check

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

On Wed, 2015-01-28 at 16:38 +0100, Oliver Hartkopp wrote:
> Hello all,
> 
> just in the case you are interested to pick these patches up for 3.2 and 3.4 
> stable:
> 
> The backported patch for Linux 3.2 ... 3.14 has been queued by GregKH for the 
> 3.10 kernel here:
> 
> http://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git/tree/queue-3.10/can-dev-fix-crtlmode_supported-check.patch?id=332373aa9a50a1c18027be7352d6138fa74263d0

I already queued this up while going through commits with 'cc: stable',
thanks.

Ben.

-- 
Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

Re: [PATCH] can: dev: fix crtlmode_supported check

[Zefan Li]

On 2015/1/28 23:38, Oliver Hartkopp wrote:
> Hello all,
> 
> just in the case you are interested to pick these patches up for 3.2 and 3.4 stable:
> 
> The backported patch for Linux 3.2 ... 3.14 has been queued by GregKH for the 3.10 kernel here:
> 

Queued up already, as it has stable tag. Thanks!

> http://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git/tree/queue-3.10/can-dev-fix-crtlmode_supported-check.patch?id=332373aa9a50a1c18027be7352d6138fa74263d0
>