From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Cc: linux-can@vger.kernel.org, Pankaj Sharma <pankj.sharma@samsung.com>
Subject: Re: PATCH [0/4] can: m_can: various regmask-related cleanup
Date: Tue, 4 May 2021 13:27:56 +0200 [thread overview]
Message-ID: <20210504112756.mqidrskk4mswgxvs@pengutronix.de> (raw)
In-Reply-To: <20210504112035.336424-1-torin@maxiluxsystems.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On 04.05.2021 12:20:31, Torin Cooper-Bennun wrote:
> 1/4 modernises m_can.c, using GENMASK for all regmasks and
> FIELD_{GET,PREP,MAX} for ops. Maintainable, consistent and concise.
>
> 2/4 makes clear all the differences in CCCR between M_CAN spec revisions,
> and orders the defs by revision, ascending.
>
> 3/4 makes explicit the config of RX & TX buffer sizes, making it a bit
> more readable, especially against the spec.
>
> 4/4 fixes whitespace in a few comments.
Well done! A really nice cleanup series.
Please repost with your Signed-off-by: added.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-04 11:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 11:20 PATCH [0/4] can: m_can: various regmask-related cleanup Torin Cooper-Bennun
2021-05-04 11:20 ` [PATCH 1/4] can: m_can: use bits.h macros for all regmasks Torin Cooper-Bennun
2021-05-04 11:20 ` [PATCH 2/4] can: m_can: clean up CCCR reg defs, order by revs Torin Cooper-Bennun
2021-05-04 11:20 ` [PATCH 3/4] can: m_can: make TXESC, RXESC config more explicit Torin Cooper-Bennun
2021-05-04 11:20 ` [PATCH 4/4] can: m_can: fix whitespace in a few comments Torin Cooper-Bennun
2021-05-04 11:27 ` Marc Kleine-Budde [this message]
2021-05-04 11:39 ` PATCH [0/4] can: m_can: various regmask-related cleanup Torin Cooper-Bennun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504112756.mqidrskk4mswgxvs@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=pankj.sharma@samsung.com \
--cc=torin@maxiluxsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).