From: "Aurélien Aptel" <aaptel@suse.com>
To: Shyam Prasad N <nspmangalore@gmail.com>,
Steve French <smfrench@gmail.com>,
CIFS <linux-cifs@vger.kernel.org>,
sribhat.msa@outlook.com, rohiths msft <rohiths.msft@gmail.com>
Subject: Re: Multichannel patches
Date: Wed, 02 Jun 2021 17:57:19 +0200 [thread overview]
Message-ID: <874kegtg2o.fsf@suse.com> (raw)
In-Reply-To: <CANT5p=oMLZei+OhXZ-8Hr2NCx=pRYWF1zQ0vRQ5D_NkvLGwJDg@mail.gmail.com>
Hi Shyam,
We've already discussed how to go about it so your changes LGTM.
I've added some minor comments on your github pull request.
Shyam Prasad N <nspmangalore@gmail.com> writes:
> P.S. There is a logic in cifs_reconnect to switch between the targets
> for the server. I don't think these changes will break the DFS
> scenario. The code will likely take effect only for when the primary
> channel reconnects (as DFS server entries are cached with super block
> as the key). Perhaps more changes will be needed there to also switch
> between the targets for individual channels (maybe use superblock +
> channel num as the key for caching entries?). Folks with better
> knowledge than me with this code may want to check on this?
You need to talk with Paulo for this. He has just sent a rewrite of the
cache yday.
> @Steve French It'll be good to let a few cycles of buildbot to run
> with this code, before submitting to upstream. I have run a bunch of
> tests with this. However, more soak time will be safer.
We need more tests on the buildbot so if you have things for mchan we
can run on it please add it there.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2021-06-02 15:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 12:43 Multichannel patches Shyam Prasad N
2021-06-02 15:57 ` Aurélien Aptel [this message]
2021-06-02 18:55 ` Steve French
2021-06-02 16:45 ` Paulo Alcantara
2021-06-04 9:13 ` Shyam Prasad N
2021-06-04 15:10 ` Steve French
2021-06-04 15:25 ` Paulo Alcantara
2021-06-05 14:08 ` Shyam Prasad N
2021-06-05 17:43 ` Steve French
2021-06-05 17:57 ` Steve French
2021-06-08 9:54 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kegtg2o.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=smfrench@gmail.com \
--cc=sribhat.msa@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).