From: Paulo Alcantara <pc@cjr.nz>
To: "Shyam Prasad N" <nspmangalore@gmail.com>,
"Steve French" <smfrench@gmail.com>,
"Aurélien Aptel" <aaptel@suse.com>,
CIFS <linux-cifs@vger.kernel.org>,
sribhat.msa@outlook.com, "rohiths msft" <rohiths.msft@gmail.com>
Subject: Re: Multichannel patches
Date: Wed, 02 Jun 2021 13:45:38 -0300 [thread overview]
Message-ID: <875yywp64t.fsf@cjr.nz> (raw)
In-Reply-To: <CANT5p=oMLZei+OhXZ-8Hr2NCx=pRYWF1zQ0vRQ5D_NkvLGwJDg@mail.gmail.com>
Shyam Prasad N <nspmangalore@gmail.com> writes:
> P.S. There is a logic in cifs_reconnect to switch between the targets
> for the server. I don't think these changes will break the DFS
> scenario. The code will likely take effect only for when the primary
> channel reconnects (as DFS server entries are cached with super block
> as the key). Perhaps more changes will be needed there to also switch
> between the targets for individual channels (maybe use superblock +
> channel num as the key for caching entries?). Folks with better
> knowledge than me with this code may want to check on this?
I don't think your changes would break it as well. The super is only
used for providing cifs_sb_info::origin_fullpath as key to find the
corresponding failover targets in referral cache.
I can help you testing your changes with some DFS+multichannel failover
scenarios.
next prev parent reply other threads:[~2021-06-02 16:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 12:43 Multichannel patches Shyam Prasad N
2021-06-02 15:57 ` Aurélien Aptel
2021-06-02 18:55 ` Steve French
2021-06-02 16:45 ` Paulo Alcantara [this message]
2021-06-04 9:13 ` Shyam Prasad N
2021-06-04 15:10 ` Steve French
2021-06-04 15:25 ` Paulo Alcantara
2021-06-05 14:08 ` Shyam Prasad N
2021-06-05 17:43 ` Steve French
2021-06-05 17:57 ` Steve French
2021-06-08 9:54 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yywp64t.fsf@cjr.nz \
--to=pc@cjr.nz \
--cc=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=smfrench@gmail.com \
--cc=sribhat.msa@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).