From: Stephen Boyd <sboyd@kernel.org>
To: Sivaprakash Murugesan <sivaprak@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
mturquette@baylibre.com, robh+dt@kernel.org
Cc: Sivaprakash Murugesan <sivaprak@codeaurora.org>
Subject: Re: [PATCH V6 5/5] arm64: dts: ipq6018: Add support for apss pll
Date: Wed, 27 May 2020 18:56:52 -0700 [thread overview]
Message-ID: <159063101240.69627.8166973936029543160@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1590582292-13314-6-git-send-email-sivaprak@codeaurora.org>
Quoting Sivaprakash Murugesan (2020-05-27 05:24:52)
> Enable apss pll support.
>
> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
> ---
> [V6]
> * split the mailbox driver from this patch
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 1aa8d85..3956e44 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -300,6 +300,14 @@
> #mbox-cells = <1>;
> };
>
> + apsspll: clock@b116000 {
> + compatible = "qcom,ipq6018-a53pll";
> + reg = <0x0b116000 0x40>;
> + #clock-cells = <0>;
> + clocks = <&xo>;
> + clock-names = "xo";
> + };
> +
I'd expect to see this inside an soc node. Also this doesn't go via clk
tree so don't send it with the clk patches.
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
prev parent reply other threads:[~2020-05-28 1:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 12:24 [PATCH V6 0/5] Add APSS clock controller support for IPQ6018 Sivaprakash Murugesan
2020-05-27 12:24 ` [PATCH V6 1/5] dt-bindings: clock: add ipq6018 a53 pll compatible Sivaprakash Murugesan
2020-05-29 18:08 ` Rob Herring
2020-05-27 12:24 ` [PATCH V6 2/5] clk: qcom: Add ipq apss pll driver Sivaprakash Murugesan
2020-05-27 12:24 ` [PATCH V6 3/5] clk: qcom: Add DT bindings for ipq6018 apss clock controller Sivaprakash Murugesan
2020-05-29 18:08 ` Rob Herring
2020-05-27 12:24 ` [PATCH V6 4/5] clk: qcom: Add " Sivaprakash Murugesan
2020-05-28 1:59 ` Stephen Boyd
2020-06-01 12:41 ` Sivaprakash Murugesan
2020-06-01 19:36 ` Stephen Boyd
2020-06-02 10:47 ` Sivaprakash Murugesan
2020-06-03 5:31 ` Stephen Boyd
2020-05-27 12:24 ` [PATCH V6 5/5] arm64: dts: ipq6018: Add support for apss pll Sivaprakash Murugesan
2020-05-28 1:56 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159063101240.69627.8166973936029543160@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sivaprak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).