From: Stephen Boyd <sboyd@kernel.org>
To: Sivaprakash Murugesan <sivaprak@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
mturquette@baylibre.com, robh+dt@kernel.org
Subject: Re: [PATCH V6 4/5] clk: qcom: Add ipq6018 apss clock controller
Date: Tue, 02 Jun 2020 22:31:56 -0700 [thread overview]
Message-ID: <159116231690.69627.14045441534011952150@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <4266555a-5e4f-4340-1b3c-487a70805751@codeaurora.org>
Quoting Sivaprakash Murugesan (2020-06-02 03:47:20)
>
> On 6/2/2020 1:06 AM, Stephen Boyd wrote:
> > Quoting Sivaprakash Murugesan (2020-06-01 05:41:15)
> >> On 5/28/2020 7:29 AM, Stephen Boyd wrote:
> >>> Quoting Sivaprakash Murugesan (2020-05-27 05:24:51)
> >>>> diff --git a/drivers/clk/qcom/apss-ipq6018.c b/drivers/clk/qcom/apss-ipq6018.c
> >>>> new file mode 100644
> >>>> index 0000000..004f7e1
> >>>> --- /dev/null
> >>>> +++ b/drivers/clk/qcom/apss-ipq6018.c
> >>>> @@ -0,0 +1,106 @@
> >>>> + P_XO,
> >>>> + P_APSS_PLL_EARLY,
> >>>> +};
> >>>> +
> >>>> +static const struct clk_parent_data parents_apcs_alias0_clk_src[] = {
> >>>> + { .fw_name = "xo" },
> >>>> + { .fw_name = "pll" },
> >>> This pll clk is not described in the binding. Please add it there.
> >> Sorry I did not get this, this PLL is not directly defined in this
> >> driver and it comes
> >>
> >> from dts. do you still want to describe it in binding?
> >>
> > Yes, there should be a clock-names property for "pll" and a clocks
> > property in the binding document. I didn't see that.
>
> These are defined in
>
> https://lkml.org/lkml/2020/5/27/658and
>
> https://lkml.org/lkml/2020/5/27/659
>
> it has been defined as part of mailbox binding, since this driver does
>
> not have a dts node and it is child of apcs mailbox driver.
>
Ah alright. Sounds good.
next prev parent reply other threads:[~2020-06-03 5:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 12:24 [PATCH V6 0/5] Add APSS clock controller support for IPQ6018 Sivaprakash Murugesan
2020-05-27 12:24 ` [PATCH V6 1/5] dt-bindings: clock: add ipq6018 a53 pll compatible Sivaprakash Murugesan
2020-05-29 18:08 ` Rob Herring
2020-05-27 12:24 ` [PATCH V6 2/5] clk: qcom: Add ipq apss pll driver Sivaprakash Murugesan
2020-05-27 12:24 ` [PATCH V6 3/5] clk: qcom: Add DT bindings for ipq6018 apss clock controller Sivaprakash Murugesan
2020-05-29 18:08 ` Rob Herring
2020-05-27 12:24 ` [PATCH V6 4/5] clk: qcom: Add " Sivaprakash Murugesan
2020-05-28 1:59 ` Stephen Boyd
2020-06-01 12:41 ` Sivaprakash Murugesan
2020-06-01 19:36 ` Stephen Boyd
2020-06-02 10:47 ` Sivaprakash Murugesan
2020-06-03 5:31 ` Stephen Boyd [this message]
2020-05-27 12:24 ` [PATCH V6 5/5] arm64: dts: ipq6018: Add support for apss pll Sivaprakash Murugesan
2020-05-28 1:56 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159116231690.69627.14045441534011952150@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sivaprak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).