From: Rob Herring <robh@kernel.org>
To: Sivaprakash Murugesan <sivaprak@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 1/5] dt-bindings: clock: add ipq6018 a53 pll compatible
Date: Fri, 29 May 2020 12:08:14 -0600 [thread overview]
Message-ID: <20200529180814.GA2672742@bogus> (raw)
In-Reply-To: <1590582292-13314-2-git-send-email-sivaprak@codeaurora.org>
On Wed, May 27, 2020 at 05:54:48PM +0530, Sivaprakash Murugesan wrote:
> cpus on ipq6018 are clocked by a53 pll, add device compatible for a53
> pll found on ipq6018 devices.
>
> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
> ---
> * [V6]
> re-ordered compatible string, dropped Rob's review tag for this change.
Not really significant enough to drop it, but if you really want me to
stare at this again...
> .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> index 20d2638..a4f2d01 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> @@ -15,6 +15,7 @@ description:
>
> properties:
> compatible:
> + const: qcom,ipq6018-a53pll
> const: qcom,msm8916-a53pll
>
> reg:
> @@ -23,6 +24,14 @@ properties:
> '#clock-cells':
> const: 0
>
> + clocks:
> + items:
> + - description: board XO clock
> +
> + clock-names:
> + items:
> + - const: xo
> +
> required:
> - compatible
> - reg
> @@ -38,3 +47,12 @@ examples:
> reg = <0xb016000 0x40>;
> #clock-cells = <0>;
> };
> + #Example 2 - A53 PLL found on IPQ6018 devices
> + - |
> + a53pll_ipq: clock@b116000 {
clock-controller@...
> + compatible = "qcom,ipq6018-a53pll";
> + reg = <0x0b116000 0x40>;
> + #clock-cells = <0>;
> + clocks = <&xo>;
> + clock-names = "xo";
> + };
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-05-29 18:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 12:24 [PATCH V6 0/5] Add APSS clock controller support for IPQ6018 Sivaprakash Murugesan
2020-05-27 12:24 ` [PATCH V6 1/5] dt-bindings: clock: add ipq6018 a53 pll compatible Sivaprakash Murugesan
2020-05-29 18:08 ` Rob Herring [this message]
2020-05-27 12:24 ` [PATCH V6 2/5] clk: qcom: Add ipq apss pll driver Sivaprakash Murugesan
2020-05-27 12:24 ` [PATCH V6 3/5] clk: qcom: Add DT bindings for ipq6018 apss clock controller Sivaprakash Murugesan
2020-05-29 18:08 ` Rob Herring
2020-05-27 12:24 ` [PATCH V6 4/5] clk: qcom: Add " Sivaprakash Murugesan
2020-05-28 1:59 ` Stephen Boyd
2020-06-01 12:41 ` Sivaprakash Murugesan
2020-06-01 19:36 ` Stephen Boyd
2020-06-02 10:47 ` Sivaprakash Murugesan
2020-06-03 5:31 ` Stephen Boyd
2020-05-27 12:24 ` [PATCH V6 5/5] arm64: dts: ipq6018: Add support for apss pll Sivaprakash Murugesan
2020-05-28 1:56 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529180814.GA2672742@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=sivaprak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).