linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Chunyan Zhang <chunyan.zhang@unisoc.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Orson Zhai <orsonzhai@gmail.com>,
	Baolin Wang <baolin.wang7@gmail.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH 3/5] dt-bindings: clk: sprd: add bindings for sc9863a clock controller
Date: Tue, 29 Oct 2019 17:01:39 -0500	[thread overview]
Message-ID: <20191029220139.GA24212@bogus> (raw)
In-Reply-To: <20191025111338.27324-4-chunyan.zhang@unisoc.com>

On Fri, Oct 25, 2019 at 07:13:36PM +0800, Chunyan Zhang wrote:
> 
> add a new bindings to describe sc9863a clock compatible string.
> 
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
>  .../bindings/clock/sprd,sc9863a-clk.txt       | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.txt

Please make this a DT schema.

> diff --git a/Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.txt b/Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.txt
> new file mode 100644
> index 000000000000..a73ae5574c82
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.txt
> @@ -0,0 +1,59 @@
> +Unisoc SC9863A Clock Binding
> +------------------------
> +
> +Required properties:
> +- compatible: should contain the following compatible strings:
> +	- "sprd,sc9863a-ap-clk"
> +	- "sprd,sc9863a-pmu-gate"
> +	- "sprd,sc9863a-pll"
> +	- "sprd,sc9863a-mpll"
> +	- "sprd,sc9863a-rpll"
> +	- "sprd,sc9863a-dpll"
> +	- "sprd,sc9863a-aon-clk"
> +	- "sprd,sc9863a-apahb-gate"
> +	- "sprd,sc9863a-aonapb-gate"
> +	- "sprd,sc9863a-mm-gate"
> +	- "sprd,sc9863a-mm-clk"
> +	- "sprd,sc9863a-vspahb-gate"
> +	- "sprd,sc9863a-apapb-gate"
> +
> +- #clock-cells: must be 1
> +
> +- clocks : Should be the input parent clock(s) phandle for the clock, this
> +	   property here just simply shows which clock group the clocks'
> +	   parents are in, since each clk node would represent many clocks
> +	   which are defined in the driver.  The detailed dependency
> +	   relationship (i.e. how many parents and which are the parents)
> +	   are implemented in driver code.

You need to define how many clocks for each block.

> +
> +Optional properties:
> +
> +- reg:	Contain the registers base address and length. It must be configured
> +	only if no 'sprd,syscon' under the node.
> +
> +- sprd,syscon: phandle to the syscon which is in the same address area with
> +	       the clock, and so we can get regmap for the clocks from the
> +	       syscon device.

Can't these be child nodes of the syscon instead?

> +
> +Example:
> +	ap_clk: clock-controller@21500000 {
> +		compatible = "sprd,sc9863a-ap-clk";
> +		reg = <0 0x21500000 0 0x1000>;
> +		clocks = <&ext_32k>, <&ext_26m>,
> +			 <&pll 0>, <&rpll 0>;
> +		#clock-cells = <1>;
> +	};
> +
> +	pmu_gate: pmu-gate {
> +		compatible = "sprd,sc9863a-pmu-gate";
> +		sprd,syscon = <&pmu_regs>; /* 0x402b0000 */
> +		clocks = <&ext_26m>;
> +		#clock-cells = <1>;
> +	};
> +
> +	pll: pll {
> +		compatible = "sprd,sc9863a-pll";
> +		sprd,syscon = <&anlg_phy_g2_regs>; /* 0x40353000 */
> +		clocks = <&pmu_gate 0>;
> +		#clock-cells = <1>;
> +	};
> -- 
> 2.20.1
> 
> 

  reply	other threads:[~2019-10-29 22:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 11:13 [PATCH 0/5] Add clocks for Unisoc's SC9863A Chunyan Zhang
2019-10-25 11:13 ` [PATCH 1/5] clk: sprd: add gate for pll clocks Chunyan Zhang
2019-11-13 22:15   ` Stephen Boyd
2019-10-25 11:13 ` [PATCH 2/5] dt-bindings: clk: sprd: rename the common file name sprd.txt to SoC specific Chunyan Zhang
2019-10-29 21:46   ` Rob Herring
2019-10-25 11:13 ` [PATCH 3/5] dt-bindings: clk: sprd: add bindings for sc9863a clock controller Chunyan Zhang
2019-10-29 22:01   ` Rob Herring [this message]
2019-10-25 11:13 ` [PATCH 4/5] clk: sprd: Add dt-bindings include file for SC9863A Chunyan Zhang
2019-10-29 22:03   ` Rob Herring
2019-10-25 11:13 ` [PATCH 5/5] clk: sprd: add clocks support " Chunyan Zhang
2019-11-13 22:19   ` Stephen Boyd
2019-11-14  7:13     ` Chunyan Zhang
2019-11-17 11:27     ` Chunyan Zhang
2019-11-25  1:33       ` Stephen Boyd
2019-11-25  2:10         ` Chunyan Zhang
2019-11-25 16:35           ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029220139.GA24212@bogus \
    --to=robh@kernel.org \
    --cc=baolin.wang7@gmail.com \
    --cc=chunyan.zhang@unisoc.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=orsonzhai@gmail.com \
    --cc=sboyd@kernel.org \
    --cc=zhang.lyra@gmail.com \
    --subject='Re: [PATCH 3/5] dt-bindings: clk: sprd: add bindings for sc9863a clock controller' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).