Re: [PATCH 6/6] ARM: dts: Configure rstctrl reset for SGX

From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux-OMAP <linux-omap@vger.kernel.org>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	devicetree <devicetree@vger.kernel.org>,
	"Adam Ford" <aford173@gmail.com>,
	"Filip Matijević" <filip.matijevic.pz@gmail.com>,
	"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
	"moaz korena" <moaz@korena.xyz>,
	"Merlijn Wajer" <merlijn@wizzup.org>,
	"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
	"Philipp Rossak" <embed3d@gmail.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Tero Kristo" <t-kristo@ti.com>,
	linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 6/6] ARM: dts: Configure rstctrl reset for SGX
Date: Mon, 16 Sep 2019 20:12:41 +0200	[thread overview]
Message-ID: <6CF46DDB-2EC1-454E-83A1-30CC7BFC335D@goldelico.com> (raw)
In-Reply-To: <20190916180418.GH52127@atomide.com>

> Am 16.09.2019 um 20:04 schrieb Tony Lindgren <tony@atomide.com>:
> 
> Hi,
> 
> * Tony Lindgren <tony@atomide.com> [190916 15:18]:
>> * H. Nikolaus Schaller <hns@goldelico.com> [190913 09:50]:
>>> Hi Tony,
>>> 
>>>> Am 14.08.2019 um 15:14 schrieb Tony Lindgren <tony@atomide.com>:
>>>> 
>>>> The following can be tested via sysfs with the following to ensure the SGX
>>>> module gets enabled and disabled properly:
>>>> 
>>>> # echo on > /sys/bus/platform/devices/5600fe00.target-module/power/control
>>>> # rwmem 0x5600fe00		# revision register
>>>> 0x5600fe00 = 0x40000000
>>>> # echo auto > /sys/bus/platform/devices/5600fe00.target-module/power/control
>>>> # rwmem 0x5000fe00
>>>> Bus error
>>>> 
>>>> Note that this patch depends on the PRM rstctrl driver that has
>>>> been recently posted.
>>> 
>>> Do you have a list of these patches or a git for pulling the complete set
>>> of changes? Does it depend on mainline or linux-next?
>> 
>> You need the drivers/bus/ti-sysc.c changes from Linux next,
>> and the most recent clkctrl and rstctrl patches posted by
>> Tero.
>> 
>>> I tried to find the correct patches but it does not seem to work for
>>> me on beaglebone.
>> 
>> OK can you please check the dependencies again and let me know
>> if you still have issues?
> 
> To make things easier to test, I pushed out a test branch with
> all the pending dependencies :)
> 
> It's basically v5.3 + ti-sysc changes in Linux next, and
> the following patches posted by Tero:
> 
> [PATCHv5 00/10] soc: ti: add OMAP PRM driver (for reset)
> [PATCHv3 00/10] clk: ti: remoteproc / iommu support patches
> [PATCH 00/10] ARM: dts: omap changes for IOMMU / reset support
> 
> And then finally the $subject patch applied on top, and the
> tests above still work for me.

Ok, fine!

> 
> The test branch is test-pending-ti-sysc-clkctrl-rstctrl-v5.3
> at [0] and [1] below.
> 
> Can you please test and see if that works for you?
> 
> Regards,
> 
> Tony
> 
> [0] git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git test-pending-ti-sysc-clkctrl-rstctrl-v5.3
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=test-pending-ti-sysc-clkctrl-rstctrl-v5.3

I'll check out and try to locate missing pieces.

BR and thanks,
Nikolaus