From: Adam Ford <aford173@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux-OMAP <linux-omap@vger.kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree <devicetree@vger.kernel.org>,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"moaz korena" <moaz@korena.xyz>,
"Merlijn Wajer" <merlijn@wizzup.org>,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
"Philipp Rossak" <embed3d@gmail.com>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Tero Kristo" <t-kristo@ti.com>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 5/6] ARM: dts: Configure interconnect target module for omap3 sgx
Date: Mon, 19 Aug 2019 14:12:34 -0500 [thread overview]
Message-ID: <CAHCN7x+WxFSU4e72ESu0UUKj_RGfNCOkHS4zvjmwQVoZ_t13Nw@mail.gmail.com> (raw)
In-Reply-To: <20190814131408.57162-6-tony@atomide.com>
On Wed, Aug 14, 2019 at 8:14 AM Tony Lindgren <tony@atomide.com> wrote:
>
> Looks like omap34xx OCP registers are not readable unlike on omap36xx.
> We use SGX revision register instead of the OCP revision register for
> 34xx and do not configure any SYSCONFIG register unlike for 36xx.
>
> I've tested that the interconnect target module enables and idles
> just fine with PM runtime control via sys:
>
> # echo on > $(find /sys -name control | grep \/5000); rwmem 0x5000fe10
> # rwmem 0x50000014 # SGX revision register on 36xx
> 0x50000014 = 0x00010205
For an OMAP3530, I got:
# echo on > $(find /sys -name control | grep \/5000)
# devmem 0x50000014
0x00010201
Does 0x00010201 seem reasonable? I am not sure where to find this in
the TRM unless it's located elsewhere, but [1] seems to lead me to
believe this is correct.
> # echo auto > $(find /sys -name control | grep \/5000)
> # rwmem 0x5000fe00
I assume the above address should be 0x50000014 for OMAP34/35, is that
correct? It was listed as 0x50000014 above.
If my assumption if correct, it appears to work for me as well.
[1] - http://processors.wiki.ti.com/index.php/GSG:_AM35x_and_OMAP35x_Rebuilding_the_Software#How_to_check_for_SGX_core_revision
> And when idled, it will produce "Bus error" as expected.
>
> Cc: Adam Ford <aford173@gmail.com>
> Cc: Filip Matijević <filip.matijevic.pz@gmail.com>
> Cc: "H. Nikolaus Schaller" <hns@goldelico.com>
> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Cc: moaz korena <moaz@korena.xyz>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> Cc: Philipp Rossak <embed3d@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
If my assumptions are correct, then you can mark it as
Tested-by: Adam Ford <aford173@gmail.com> #logicpd-som-lv-35xx-devkit
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/omap34xx.dtsi | 26 ++++++++++++++++++++++++++
> arch/arm/boot/dts/omap36xx.dtsi | 27 +++++++++++++++++++++++++++
> 2 files changed, 53 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> --- a/arch/arm/boot/dts/omap34xx.dtsi
> +++ b/arch/arm/boot/dts/omap34xx.dtsi
> @@ -100,6 +100,32 @@
> interrupts = <18>;
> };
> };
> +
> + /*
> + * On omap34xx the OCP registers do not seem to be accessible
> + * at all unlike on 36xx. Maybe SGX is permanently set to
> + * "OCP bypass mode", or maybe there is OCP_SYSCONFIG that is
> + * write-only at 0x50000e10. We detect SGX based on the SGX
> + * revision register instead of the unreadable OCP revision
> + * register. Also note that on early 34xx es1 revision there
> + * are also different clocks, but we do not have any dts users
> + * for it.
> + */
> + sgx_module: target-module@50000000 {
> + compatible = "ti,sysc-omap2", "ti,sysc";
> + reg = <0x50000014 0x4>;
> + reg-names = "rev";
> + clocks = <&sgx_fck>, <&sgx_ick>;
> + clock-names = "fck", "ick";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x50000000 0x4000>;
> +
> + /*
> + * Closed source PowerVR driver, no cnhild device
> + * binding or driver in mainline
> + */
> + };
> };
>
> thermal_zones: thermal-zones {
> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> --- a/arch/arm/boot/dts/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> @@ -139,6 +139,33 @@
> interrupts = <18>;
> };
> };
> +
> + /*
> + * The OCP register layout seems to be a subset of the
> + * "ti,sysc-omap4" with just sidle and midle bits.
> + */
> + sgx_module: target-module@50000000 {
> + compatible = "ti,sysc-omap4", "ti,sysc";
> + reg = <0x5000fe00 0x4>,
> + <0x5000fe10 0x4>;
> + reg-names = "rev", "sysc";
> + ti,sysc-midle = <SYSC_IDLE_FORCE>,
> + <SYSC_IDLE_NO>,
> + <SYSC_IDLE_SMART>;
> + ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> + <SYSC_IDLE_NO>,
> + <SYSC_IDLE_SMART>;
> + clocks = <&sgx_fck>, <&sgx_ick>;
> + clock-names = "fck", "ick";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x50000000 0x2000000>;
> +
> + /*
> + * Closed source PowerVR driver, no cnhild device
> + * binding or driver in mainline
> + */
> + };
> };
>
> thermal_zones: thermal-zones {
> --
> 2.21.0
next prev parent reply other threads:[~2019-08-19 19:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 13:14 [PATCH 0/6] Configure sgx interconnect data for some omap variants Tony Lindgren
2019-08-14 13:14 ` [PATCH 1/6] ARM: OMAP2+: Drop legacy platform data for omap4 gpu Tony Lindgren
2019-08-14 13:14 ` [PATCH 2/6] bus: ti-sysc: Add module enable quirk for SGX on omap36xx Tony Lindgren
2019-08-14 13:14 ` [PATCH 3/6] clk: ti: add clkctrl data omap5 sgx Tony Lindgren
2019-08-14 13:14 ` [PATCH 4/6] ARM: dts: Configure sgx for omap5 Tony Lindgren
[not found] ` <20190815182348.8A1BA2063F@mail.kernel.org>
2019-08-17 6:56 ` Tony Lindgren
2019-08-26 14:55 ` Tony Lindgren
2019-09-05 15:03 ` H. Nikolaus Schaller
2019-09-05 15:28 ` Tony Lindgren
2019-10-05 16:20 ` H. Nikolaus Schaller
2019-08-14 13:14 ` [PATCH 5/6] ARM: dts: Configure interconnect target module for omap3 sgx Tony Lindgren
2019-08-14 14:46 ` Andrew F. Davis
2019-08-19 19:12 ` Adam Ford [this message]
2019-09-07 11:51 ` H. Nikolaus Schaller
2019-08-14 13:14 ` [PATCH 6/6] ARM: dts: Configure rstctrl reset for SGX Tony Lindgren
2019-09-13 9:49 ` H. Nikolaus Schaller
2019-09-16 15:17 ` Tony Lindgren
2019-09-16 18:04 ` Tony Lindgren
2019-09-16 18:12 ` H. Nikolaus Schaller
2019-09-16 19:15 ` H. Nikolaus Schaller
2019-09-16 19:20 ` Adam Ford
2019-09-16 19:45 ` H. Nikolaus Schaller
2019-08-14 19:13 ` [PATCH 0/6] Configure sgx interconnect data for some omap variants Adam Ford
2019-08-15 4:02 ` Tony Lindgren
2019-08-15 4:15 ` Tony Lindgren
2019-08-15 13:05 ` Adam Ford
2019-08-17 7:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHCN7x+WxFSU4e72ESu0UUKj_RGfNCOkHS4zvjmwQVoZ_t13Nw@mail.gmail.com \
--to=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=embed3d@gmail.com \
--cc=filip.matijevic.pz@gmail.com \
--cc=hns@goldelico.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=moaz@korena.xyz \
--cc=mturquette@baylibre.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).