From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux-OMAP <linux-omap@vger.kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree <devicetree@vger.kernel.org>,
"Adam Ford" <aford173@gmail.com>,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"moaz korena" <moaz@korena.xyz>,
"Merlijn Wajer" <merlijn@wizzup.org>,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
"Philipp Rossak" <embed3d@gmail.com>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Tero Kristo" <t-kristo@ti.com>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 6/6] ARM: dts: Configure rstctrl reset for SGX
Date: Fri, 13 Sep 2019 11:49:56 +0200 [thread overview]
Message-ID: <92652315-A763-485F-A4FA-CB868016E045@goldelico.com> (raw)
In-Reply-To: <20190814131408.57162-7-tony@atomide.com>
Hi Tony,
> Am 14.08.2019 um 15:14 schrieb Tony Lindgren <tony@atomide.com>:
>
> The following can be tested via sysfs with the following to ensure the SGX
> module gets enabled and disabled properly:
>
> # echo on > /sys/bus/platform/devices/5600fe00.target-module/power/control
> # rwmem 0x5600fe00 # revision register
> 0x5600fe00 = 0x40000000
> # echo auto > /sys/bus/platform/devices/5600fe00.target-module/power/control
> # rwmem 0x5000fe00
> Bus error
>
> Note that this patch depends on the PRM rstctrl driver that has
> been recently posted.
Do you have a list of these patches or a git for pulling the complete set
of changes? Does it depend on mainline or linux-next?
I tried to find the correct patches but it does not seem to work for
me on beaglebone.
> If the child device driver(s) need to prevent
> rstctrl reset on PM runtime suspend, the drivers need to increase
> the usecount for the shared rstctrl reset that can be mapped also
> for the child device(s) or accessed via dev->parent.
>
> Cc: Adam Ford <aford173@gmail.com>
> Cc: Filip Matijević <filip.matijevic.pz@gmail.com>
> Cc: "H. Nikolaus Schaller" <hns@goldelico.com>
> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Cc: moaz korena <moaz@korena.xyz>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> Cc: Philipp Rossak <embed3d@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -460,6 +460,31 @@
> <&edma 5 0>;
> dma-names = "tx", "rx";
> };
> +
> + target-module@56000000 {
> + compatible = "ti,sysc-omap4", "ti,sysc";
> + reg = <0x5600fe00 0x4>,
> + <0x5600fe10 0x4>;
> + reg-names = "rev", "sysc";
> + ti,sysc-midle = <SYSC_IDLE_FORCE>,
> + <SYSC_IDLE_NO>,
> + <SYSC_IDLE_SMART>;
> + ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> + <SYSC_IDLE_NO>,
> + <SYSC_IDLE_SMART>;
> + clocks = <&gfx_l3_clkctrl AM3_GFX_L3_GFX_CLKCTRL 0>;
> + clock-names = "fck";
> + resets = <&prm_gfx 0>;
> + reset-names = "rstctrl";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x56000000 0x1000000>;
> +
> + /*
> + * Closed source PowerVR driver, no child device
> + * binding or driver in mainline
> + */
> + };
> };
> };
>
> --
> 2.21.0
BR and thanks,
next prev parent reply other threads:[~2019-09-13 9:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 13:14 [PATCH 0/6] Configure sgx interconnect data for some omap variants Tony Lindgren
2019-08-14 13:14 ` [PATCH 1/6] ARM: OMAP2+: Drop legacy platform data for omap4 gpu Tony Lindgren
2019-08-14 13:14 ` [PATCH 2/6] bus: ti-sysc: Add module enable quirk for SGX on omap36xx Tony Lindgren
2019-08-14 13:14 ` [PATCH 3/6] clk: ti: add clkctrl data omap5 sgx Tony Lindgren
2019-08-14 13:14 ` [PATCH 4/6] ARM: dts: Configure sgx for omap5 Tony Lindgren
[not found] ` <20190815182348.8A1BA2063F@mail.kernel.org>
2019-08-17 6:56 ` Tony Lindgren
2019-08-26 14:55 ` Tony Lindgren
2019-09-05 15:03 ` H. Nikolaus Schaller
2019-09-05 15:28 ` Tony Lindgren
2019-10-05 16:20 ` H. Nikolaus Schaller
2019-08-14 13:14 ` [PATCH 5/6] ARM: dts: Configure interconnect target module for omap3 sgx Tony Lindgren
2019-08-14 14:46 ` Andrew F. Davis
2019-08-19 19:12 ` Adam Ford
2019-09-07 11:51 ` H. Nikolaus Schaller
2019-08-14 13:14 ` [PATCH 6/6] ARM: dts: Configure rstctrl reset for SGX Tony Lindgren
2019-09-13 9:49 ` H. Nikolaus Schaller [this message]
2019-09-16 15:17 ` Tony Lindgren
2019-09-16 18:04 ` Tony Lindgren
2019-09-16 18:12 ` H. Nikolaus Schaller
2019-09-16 19:15 ` H. Nikolaus Schaller
2019-09-16 19:20 ` Adam Ford
2019-09-16 19:45 ` H. Nikolaus Schaller
2019-08-14 19:13 ` [PATCH 0/6] Configure sgx interconnect data for some omap variants Adam Ford
2019-08-15 4:02 ` Tony Lindgren
2019-08-15 4:15 ` Tony Lindgren
2019-08-15 13:05 ` Adam Ford
2019-08-17 7:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92652315-A763-485F-A4FA-CB868016E045@goldelico.com \
--to=hns@goldelico.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=embed3d@gmail.com \
--cc=filip.matijevic.pz@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=moaz@korena.xyz \
--cc=mturquette@baylibre.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).