linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anson Huang <anson.huang@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Dong Aisheng <dongas86@gmail.com>
Cc: Peng Fan <peng.fan@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	"oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	linux-clk <linux-clk@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Abel Vesa <abel.vesa@nxp.com>, YueHaibing <yuehaibing@huawei.com>,
	Russell King <linux@armlinux.org.uk>,
	Allison Randal <allison@lohutok.net>,
	dl-linux-imx <linux-imx@nxp.com>,
	Stefan Agner <stefan.agner@toradex.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	ARM/FREESCALE IMX / MXC ARM ARCHITECTURE 
	<linux-arm-kernel@lists.infradead.org>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	Andy Duan <fugang.duan@nxp.com>,
	gregkh <gregkh@linuxfoundation.org>,
	open list <linux-kernel@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Enrico Weigelt <info@metux.net>
Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module
Date: Thu, 2 Jul 2020 06:15:05 +0000	[thread overview]
Message-ID: <AM6PR0402MB391135EDF34C7207AC37D42DF56D0@AM6PR0402MB3911.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <159346473301.62212.686512161256425690@swboyd.mtv.corp.google.com>

Hi, Arnd/Stephen

> Subject: Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as
> module
> 
> Quoting Arnd Bergmann (2020-06-29 01:19:44)
> > On Mon, Jun 29, 2020 at 9:18 AM Dong Aisheng <dongas86@gmail.com>
> wrote:
> > > On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd <sboyd@kernel.org>
> wrote:
> > > > Quoting Aisheng Dong (2020-06-23 19:59:09) Why aren't there
> > > > options to enable clk-imx6q and clk-imx6sl in the clk/imx/Kconfig
> > > > file? Those can be bool or tristate depending on if the SoC
> > > > drivers use CLK_OF_DECLARE or not and depend on the mxc-clk
> > > > library and SoC config we have in the makefile today.
> > >
> > > Yes, we can do that in clk/imx/Kconfig as follows theoretically.
> > > config CLK_IMX6Q
> > >         bool
> > >         def_bool ARCH_MXC && ARM
> > >         select MXC_CLK
> > >
> > > But we have totally 15 platforms that need to change.
> >
> > I would make that
> >
> > config CLK_IMX6Q
> >          bool "Clock driver for NXP i.MX6Q"
> >          depends on SOC_IMX6Q || COMPILE_TEST
> >          default SOC_IMX6Q
> >          select MXC_CLK
> 
> Yes, do this.

The COMPILE_TEST existing on the config will introduce some build error
on other ARCH's allyesconfig build on i.MX2/3 platforms, I received some build error report.
So in next patch series, I will drop the COMPILE_TEST for these new added clock configurations,
as I think it is NOT worth to support the COMPILE_TEST for these old legacy platforms which are
NOT supported before.

Thanks,
Anson



  parent reply	other threads:[~2020-07-02  6:15 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  7:32 [PATCH V2 0/9] Support building i.MX8 SoCs clock driver as module Anson Huang
2020-06-09  7:32 ` [PATCH V2 1/9] clk: composite: Export clk_hw_register_composite() Anson Huang
2020-06-17 10:10   ` Aisheng Dong
2020-06-17 12:31     ` Anson Huang
2020-06-18  2:05       ` Aisheng Dong
2020-06-20  3:22   ` Stephen Boyd
2020-06-09  7:32 ` [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC Anson Huang
2020-06-17 10:34   ` Aisheng Dong
2020-06-17 12:36     ` Anson Huang
2020-06-18  3:09       ` Aisheng Dong
2020-06-18  3:18         ` Anson Huang
2020-06-18  3:58           ` Aisheng Dong
2020-06-09  7:32 ` [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module Anson Huang
2020-06-17 10:44   ` Aisheng Dong
2020-06-17 12:26     ` Anson Huang
2020-06-18  1:58       ` Aisheng Dong
2020-06-20  3:27         ` Stephen Boyd
2020-06-23  3:42           ` Aisheng Dong
2020-06-23  8:34             ` Stephen Boyd
2020-06-23  9:00               ` Aisheng Dong
2020-06-24  0:57                 ` Stephen Boyd
2020-06-24  2:19                   ` Aisheng Dong
2020-06-24  2:36                     ` Anson Huang
2020-06-24  2:59                       ` Aisheng Dong
2020-06-24 22:43                         ` Stephen Boyd
2020-06-29  7:04                           ` Dong Aisheng
2020-06-29  8:19                             ` Arnd Bergmann
2020-06-30  3:01                               ` Aisheng Dong
2020-06-30  4:41                                 ` Anson Huang
     [not found]                               ` <159346473301.62212.686512161256425690@swboyd.mtv.corp.google.com>
2020-07-02  6:15                                 ` Anson Huang [this message]
2020-06-24  7:46                     ` Arnd Bergmann
2020-06-24  9:18                       ` Aisheng Dong
2020-06-09  7:32 ` [PATCH V2 4/9] clk: imx: Support building i.MX common " Anson Huang
2020-06-22  7:05   ` Stephen Boyd
2020-06-09  7:32 ` [PATCH V2 5/9] clk: imx8mm: Support module build Anson Huang
2020-06-09  7:32 ` [PATCH V2 6/9] clk: imx8mn: " Anson Huang
2020-06-09  7:32 ` [PATCH V2 7/9] clk: imx8mp: " Anson Huang
2020-06-09  7:32 ` [PATCH V2 8/9] clk: imx8mq: " Anson Huang
2020-06-09  7:32 ` [PATCH V2 9/9] clk: imx8qxp: " Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR0402MB391135EDF34C7207AC37D42DF56D0@AM6PR0402MB3911.eurprd04.prod.outlook.com \
    --to=anson.huang@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=allison@lohutok.net \
    --cc=arnd@arndb.de \
    --cc=daniel.baluta@nxp.com \
    --cc=dongas86@gmail.com \
    --cc=festevam@gmail.com \
    --cc=fugang.duan@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=info@metux.net \
    --cc=kernel@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mturquette@baylibre.com \
    --cc=oleksandr.suvorov@toradex.com \
    --cc=peng.fan@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=shawnguo@kernel.org \
    --cc=stefan.agner@toradex.com \
    --cc=tglx@linutronix.de \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).