From: Anson Huang <anson.huang@nxp.com>
To: Aisheng Dong <aisheng.dong@nxp.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"oleksandr.suvorov@toradex.com" <oleksandr.suvorov@toradex.com>,
Stefan Agner <stefan.agner@toradex.com>,
"arnd@arndb.de" <arnd@arndb.de>, Abel Vesa <abel.vesa@nxp.com>,
Peng Fan <peng.fan@nxp.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"allison@lohutok.net" <allison@lohutok.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"info@metux.net" <info@metux.net>,
Leonard Crestez <leonard.crestez@nxp.com>,
Andy Duan <fugang.duan@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC
Date: Thu, 18 Jun 2020 03:18:25 +0000 [thread overview]
Message-ID: <DB3PR0402MB3916B3474CF0014B490C78BBF59B0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM6PR04MB496647CBE140DFF73DCBBEED809B0@AM6PR04MB4966.eurprd04.prod.outlook.com>
> -----Original Message-----
> From: Aisheng Dong <aisheng.dong@nxp.com>
> Sent: 2020年6月18日 11:09
> To: Anson Huang <anson.huang@nxp.com>; linux@armlinux.org.uk;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; mturquette@baylibre.com; sboyd@kernel.org;
> oleksandr.suvorov@toradex.com; Stefan Agner <stefan.agner@toradex.com>;
> arnd@arndb.de; Abel Vesa <abel.vesa@nxp.com>; Peng Fan
> <peng.fan@nxp.com>; tglx@linutronix.de; allison@lohutok.net;
> gregkh@linuxfoundation.org; info@metux.net; Leonard Crestez
> <leonard.crestez@nxp.com>; Andy Duan <fugang.duan@nxp.com>; Daniel
> Baluta <daniel.baluta@nxp.com>; yuehaibing@huawei.com;
> sfr@canb.auug.org.au; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: RE: [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC
>
> > From: Anson Huang <anson.huang@nxp.com>
> > Sent: Wednesday, June 17, 2020 8:36 PM
> >
> > > Subject: RE: [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC
> > >
> > > > From: Anson Huang <Anson.Huang@nxp.com>
> > > > Sent: Tuesday, June 9, 2020 3:32 PM
> > > >
> > > > i.MX common clock drivers may support module build, so it is NOT
> > > > selected by default, for ARCH_MXC ARMv7 platforms, need to select
> > > > it manually to make build pass.
> > > >
> > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > >
> > > Can't the original def_xxx work?
> > >
> > > config MXC_CLK
> > > tristate
> > > def_tristate ARCH_MXC
> >
> > Such change will make MXC_CLK=y even all i.MX8 SoCs clock drivers are
> > selected as module, so it does NOT meet the requirement of module
> > support. Below is from .config when all
> > i.MX8 SoCs clock drivers are configured to module.
> >
> > CONFIG_MXC_CLK=y
> > CONFIG_MXC_CLK_SCU=m
> > CONFIG_CLK_IMX8MM=m
> > CONFIG_CLK_IMX8MN=m
> > CONFIG_CLK_IMX8MP=m
> > CONFIG_CLK_IMX8MQ=m
> > CONFIG_CLK_IMX8QXP=m
> >
>
> It works at my side.
> Below is my changes based on your patchset:
> $ git diff
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index
> 47b10d20f411..e7d7b90e2cf8 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -4,7 +4,6 @@ menuconfig ARCH_MXC
> depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7 ||
> ARM_SINGLE_ARMV7M
> select ARCH_SUPPORTS_BIG_ENDIAN
> select CLKSRC_IMX_GPT
> - select MXC_CLK
> select GENERIC_IRQ_CHIP
> select GPIOLIB
> select PINCTRL
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index
> 26cedbfe386c..f7b3e3a2cb9f 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -3,6 +3,7 @@
> config MXC_CLK
> tristate "IMX clock"
> depends on ARCH_MXC
> + def_tristate ARCH_MXC
>
> config MXC_CLK_SCU
> tristate "IMX SCU clock"
>
I guess you tried imx_v6_v7_defconfig? It does NOT work for ARM64 defconfig when we try to make
CONFIG_MXC_CLK=m, Below are my change, you can see in .config, even all i.MX8 SoCs clock drivers
are configured to module, the CONFIG_MXC_CLK is still =y, but the expected result is =m.
BTW, all i.MX8 SoCs select MXC_CLK in their kconfig, this patch just does the same thing for i.MX6/7
in common place.
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 47b10d2..e7d7b90 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -4,7 +4,6 @@ menuconfig ARCH_MXC
depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7 || ARM_SINGLE_ARMV7M
select ARCH_SUPPORTS_BIG_ENDIAN
select CLKSRC_IMX_GPT
- select MXC_CLK
select GENERIC_IRQ_CHIP
select GPIOLIB
select PINCTRL
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 8222e4b..21e2dbb 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -799,11 +799,11 @@ CONFIG_COMMON_CLK_S2MPS11=y
CONFIG_COMMON_CLK_PWM=y
CONFIG_COMMON_CLK_VC5=y
CONFIG_CLK_RASPBERRYPI=m
-CONFIG_CLK_IMX8MM=y
-CONFIG_CLK_IMX8MN=y
-CONFIG_CLK_IMX8MP=y
-CONFIG_CLK_IMX8MQ=y
-CONFIG_CLK_IMX8QXP=y
+CONFIG_CLK_IMX8MM=m
+CONFIG_CLK_IMX8MN=m
+CONFIG_CLK_IMX8MP=m
+CONFIG_CLK_IMX8MQ=m
+CONFIG_CLK_IMX8QXP=m
CONFIG_TI_SCI_CLK=y
CONFIG_COMMON_CLK_QCOM=y
CONFIG_QCOM_A53PLL=y
diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index 26cedbf..f7b3e3a 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -3,6 +3,7 @@
config MXC_CLK
tristate "IMX clock"
depends on ARCH_MXC
+ def_tristate ARCH_MXC
config MXC_CLK_SCU
tristate "IMX SCU clock"
.config:
CONFIG_MXC_CLK=y
CONFIG_MXC_CLK_SCU=m
CONFIG_CLK_IMX8MM=m
CONFIG_CLK_IMX8MN=m
CONFIG_CLK_IMX8MP=m
CONFIG_CLK_IMX8MQ=m
CONFIG_CLK_IMX8QXP=m
Anson
next prev parent reply other threads:[~2020-06-18 3:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 7:32 [PATCH V2 0/9] Support building i.MX8 SoCs clock driver as module Anson Huang
2020-06-09 7:32 ` [PATCH V2 1/9] clk: composite: Export clk_hw_register_composite() Anson Huang
2020-06-17 10:10 ` Aisheng Dong
2020-06-17 12:31 ` Anson Huang
2020-06-18 2:05 ` Aisheng Dong
2020-06-20 3:22 ` Stephen Boyd
2020-06-09 7:32 ` [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC Anson Huang
2020-06-17 10:34 ` Aisheng Dong
2020-06-17 12:36 ` Anson Huang
2020-06-18 3:09 ` Aisheng Dong
2020-06-18 3:18 ` Anson Huang [this message]
2020-06-18 3:58 ` Aisheng Dong
2020-06-09 7:32 ` [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module Anson Huang
2020-06-17 10:44 ` Aisheng Dong
2020-06-17 12:26 ` Anson Huang
2020-06-18 1:58 ` Aisheng Dong
2020-06-20 3:27 ` Stephen Boyd
2020-06-23 3:42 ` Aisheng Dong
2020-06-23 8:34 ` Stephen Boyd
2020-06-23 9:00 ` Aisheng Dong
2020-06-24 0:57 ` Stephen Boyd
2020-06-24 2:19 ` Aisheng Dong
2020-06-24 2:36 ` Anson Huang
2020-06-24 2:59 ` Aisheng Dong
2020-06-24 22:43 ` Stephen Boyd
2020-06-29 7:04 ` Dong Aisheng
2020-06-29 8:19 ` Arnd Bergmann
2020-06-30 3:01 ` Aisheng Dong
2020-06-30 4:41 ` Anson Huang
[not found] ` <159346473301.62212.686512161256425690@swboyd.mtv.corp.google.com>
2020-07-02 6:15 ` Anson Huang
2020-06-24 7:46 ` Arnd Bergmann
2020-06-24 9:18 ` Aisheng Dong
2020-06-09 7:32 ` [PATCH V2 4/9] clk: imx: Support building i.MX common " Anson Huang
2020-06-22 7:05 ` Stephen Boyd
2020-06-09 7:32 ` [PATCH V2 5/9] clk: imx8mm: Support module build Anson Huang
2020-06-09 7:32 ` [PATCH V2 6/9] clk: imx8mn: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 7/9] clk: imx8mp: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 8/9] clk: imx8mq: " Anson Huang
2020-06-09 7:32 ` [PATCH V2 9/9] clk: imx8qxp: " Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB3916B3474CF0014B490C78BBF59B0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=allison@lohutok.net \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shawnguo@kernel.org \
--cc=stefan.agner@toradex.com \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).