[linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI

[linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI

[codekipper-Re5JQEeQqe8AvxtiuMwx3w]

From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Add the new DAI block for I2S2 which is used for HDMI audio.

Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 7a83b15225c7..238e7007d5b9 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -568,6 +568,19 @@
 			status = "disabled";
 		};
 
+		i2s2: i2s@1c22800 {
+			#sound-dai-cells = <0>;
+			compatible = "allwinner,sun8i-h3-i2s";
+			reg = <0x01c22800 0x400>;
+			interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>;
+			clock-names = "apb", "mod";
+			dmas = <&dma 27>;
+			resets = <&ccu RST_BUS_I2S2>;
+			dma-names = "tx";
+			status = "disabled";
+		};
+
 		codec: codec@1c22c00 {
 			#sound-dai-cells = <0>;
 			compatible = "allwinner,sun8i-h3-codec";
-- 
2.16.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Add the new DAI block for I2S2 which is used for HDMI audio.
> 
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

queued for 4.17, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI

[Jernej Škrabec]

Hi Maxime,

(previously I respond only to linux-sunxi mailing list)

>On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> 
>> Add the new DAI block for I2S2 which is used for HDMI audio.
>> 
>> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
>queued for 4.17, thanks!
>Maxime

Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
supports 8 channel audio. As Marcus said, other blocks probably
support them too, they are just not wired out on pins.

Should we change compatible for HDMI?

Best regards,
Jernej

Re: [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI

[maxime ripard]

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej Škrabec wrote:
> Hi Maxime,
> 
> (previously I respond only to linux-sunxi mailing list)
> 
> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> 
> >> Add the new DAI block for I2S2 which is used for HDMI audio.
> >> 
> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> >queued for 4.17, thanks!
> >Maxime
> 
> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
> supports 8 channel audio. As Marcus said, other blocks probably
> support them too, they are just not wired out on pins.

I've dropped those patches for now.

> Should we change compatible for HDMI?

I guess, another way of doing things if they are strictly identical
but for the number of lanes they support would be to add a DT property
for that number of lanes.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI

[Code Kipper]

On 31 January 2018 at 08:16, maxime ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej Škrabec wrote:
>> Hi Maxime,
>>
>> (previously I respond only to linux-sunxi mailing list)
>>
>> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >>
>> >> Add the new DAI block for I2S2 which is used for HDMI audio.
>> >>
>> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> >
>> >queued for 4.17, thanks!
>> >Maxime
>>
>> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
>> supports 8 channel audio. As Marcus said, other blocks probably
>> support them too, they are just not wired out on pins.
>
> I've dropped those patches for now.
>
>> Should we change compatible for HDMI?
>
> I guess, another way of doing things if they are strictly identical
> but for the number of lanes they support would be to add a DT property
> for that number of lanes.
>
That's fine...I'll look into adding a dt property and how we would map
channels to lanes.
Do you know of any examples?,
BR,
CK
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI

[maxime ripard]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

On Wed, Jan 31, 2018 at 10:54:29AM +0100, Code Kipper wrote:
> On 31 January 2018 at 08:16, maxime ripard
> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej Škrabec wrote:
> >> Hi Maxime,
> >>
> >> (previously I respond only to linux-sunxi mailing list)
> >>
> >> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> >> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> >>
> >> >> Add the new DAI block for I2S2 which is used for HDMI audio.
> >> >>
> >> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> >
> >> >queued for 4.17, thanks!
> >> >Maxime
> >>
> >> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
> >> supports 8 channel audio. As Marcus said, other blocks probably
> >> support them too, they are just not wired out on pins.
> >
> > I've dropped those patches for now.
> >
> >> Should we change compatible for HDMI?
> >
> > I guess, another way of doing things if they are strictly identical
> > but for the number of lanes they support would be to add a DT property
> > for that number of lanes.
> >
> That's fine...I'll look into adding a dt property and how we would map
> channels to lanes.
> Do you know of any examples?,

Grepping for of_property_read_u32 should give you plenty of examples :)

maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]