* [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI @ 2018-01-29 9:22 codekipper-Re5JQEeQqe8AvxtiuMwx3w [not found] ` <20180129092223.12423-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: codekipper-Re5JQEeQqe8AvxtiuMwx3w @ 2018-01-29 9:22 UTC (permalink / raw) To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Marcus Cooper From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Add the new DAI block for I2S2 which is used for HDMI audio. Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi index 7a83b15225c7..238e7007d5b9 100644 --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi @@ -568,6 +568,19 @@ status = "disabled"; }; + i2s2: i2s@1c22800 { + #sound-dai-cells = <0>; + compatible = "allwinner,sun8i-h3-i2s"; + reg = <0x01c22800 0x400>; + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>; + clock-names = "apb", "mod"; + dmas = <&dma 27>; + resets = <&ccu RST_BUS_I2S2>; + dma-names = "tx"; + status = "disabled"; + }; + codec: codec@1c22c00 { #sound-dai-cells = <0>; compatible = "allwinner,sun8i-h3-codec"; -- 2.16.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <20180129092223.12423-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI [not found] ` <20180129092223.12423-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2018-01-29 10:22 ` Maxime Ripard [not found] ` <20180129102227.ejmbifzjqmba3yja-ZC1Zs529Oq4@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Maxime Ripard @ 2018-01-29 10:22 UTC (permalink / raw) To: codekipper-Re5JQEeQqe8AvxtiuMwx3w Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 474 bytes --] On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Add the new DAI block for I2S2 which is used for HDMI audio. > > Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> queued for 4.17, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20180129102227.ejmbifzjqmba3yja-ZC1Zs529Oq4@public.gmane.org>]
* Re: [PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI [not found] ` <20180129102227.ejmbifzjqmba3yja-ZC1Zs529Oq4@public.gmane.org> @ 2018-01-29 10:35 ` Jernej Škrabec [not found] ` <27087126.4975652.1517222127863.JavaMail.zimbra-uhf9zSJETnQdlpnTk8+5LA@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Jernej Škrabec @ 2018-01-29 10:35 UTC (permalink / raw) To: maxime ripard Cc: codekipper-Re5JQEeQqe8AvxtiuMwx3w, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw Hi Maxime, (previously I respond only to linux-sunxi mailing list) >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> >> Add the new DAI block for I2S2 which is used for HDMI audio. >> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >queued for 4.17, thanks! >Maxime Please note that HDMI I2S has usable 4 I2S lanes, since HDMI supports 8 channel audio. As Marcus said, other blocks probably support them too, they are just not wired out on pins. Should we change compatible for HDMI? Best regards, Jernej ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <27087126.4975652.1517222127863.JavaMail.zimbra-uhf9zSJETnQdlpnTk8+5LA@public.gmane.org>]
* Re: [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI [not found] ` <27087126.4975652.1517222127863.JavaMail.zimbra-uhf9zSJETnQdlpnTk8+5LA@public.gmane.org> @ 2018-01-31 7:16 ` maxime ripard [not found] ` <20180131071616.jrkd465cq4mgyyvm-ZC1Zs529Oq4@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: maxime ripard @ 2018-01-31 7:16 UTC (permalink / raw) To: Jernej Škrabec Cc: codekipper-Re5JQEeQqe8AvxtiuMwx3w, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw [-- Attachment #1: Type: text/plain, Size: 1103 bytes --] On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej Škrabec wrote: > Hi Maxime, > > (previously I respond only to linux-sunxi mailing list) > > >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> > >> Add the new DAI block for I2S2 which is used for HDMI audio. > >> > >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > > >queued for 4.17, thanks! > >Maxime > > Please note that HDMI I2S has usable 4 I2S lanes, since HDMI > supports 8 channel audio. As Marcus said, other blocks probably > support them too, they are just not wired out on pins. I've dropped those patches for now. > Should we change compatible for HDMI? I guess, another way of doing things if they are strictly identical but for the number of lanes they support would be to add a DT property for that number of lanes. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20180131071616.jrkd465cq4mgyyvm-ZC1Zs529Oq4@public.gmane.org>]
* Re: [PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI [not found] ` <20180131071616.jrkd465cq4mgyyvm-ZC1Zs529Oq4@public.gmane.org> @ 2018-01-31 9:54 ` Code Kipper [not found] ` <CAEKpxBmVzeUN=1F=APVomu4s4h2s83R4JX3EG1=1Mu_ZBSF96g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Code Kipper @ 2018-01-31 9:54 UTC (permalink / raw) To: maxime ripard Cc: Jernej Škrabec, linux-arm-kernel, devicetree, linux-sunxi On 31 January 2018 at 08:16, maxime ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej Škrabec wrote: >> Hi Maxime, >> >> (previously I respond only to linux-sunxi mailing list) >> >> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: >> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> >> >> >> Add the new DAI block for I2S2 which is used for HDMI audio. >> >> >> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> > >> >queued for 4.17, thanks! >> >Maxime >> >> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI >> supports 8 channel audio. As Marcus said, other blocks probably >> support them too, they are just not wired out on pins. > > I've dropped those patches for now. > >> Should we change compatible for HDMI? > > I guess, another way of doing things if they are strictly identical > but for the number of lanes they support would be to add a DT property > for that number of lanes. > That's fine...I'll look into adding a dt property and how we would map channels to lanes. Do you know of any examples?, BR, CK > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAEKpxBmVzeUN=1F=APVomu4s4h2s83R4JX3EG1=1Mu_ZBSF96g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI [not found] ` <CAEKpxBmVzeUN=1F=APVomu4s4h2s83R4JX3EG1=1Mu_ZBSF96g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2018-01-31 15:57 ` maxime ripard 0 siblings, 0 replies; 6+ messages in thread From: maxime ripard @ 2018-01-31 15:57 UTC (permalink / raw) To: Code Kipper Cc: Jernej Škrabec, linux-arm-kernel, devicetree, linux-sunxi [-- Attachment #1: Type: text/plain, Size: 1896 bytes --] On Wed, Jan 31, 2018 at 10:54:29AM +0100, Code Kipper wrote: > On 31 January 2018 at 08:16, maxime ripard > <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej Škrabec wrote: > >> Hi Maxime, > >> > >> (previously I respond only to linux-sunxi mailing list) > >> > >> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > >> >> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> >> > >> >> Add the new DAI block for I2S2 which is used for HDMI audio. > >> >> > >> >> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> > > >> >queued for 4.17, thanks! > >> >Maxime > >> > >> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI > >> supports 8 channel audio. As Marcus said, other blocks probably > >> support them too, they are just not wired out on pins. > > > > I've dropped those patches for now. > > > >> Should we change compatible for HDMI? > > > > I guess, another way of doing things if they are strictly identical > > but for the number of lanes they support would be to add a DT property > > for that number of lanes. > > > That's fine...I'll look into adding a dt property and how we would map > channels to lanes. > Do you know of any examples?, Grepping for of_property_read_u32 should give you plenty of examples :) maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-31 15:57 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-01-29 9:22 [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI codekipper-Re5JQEeQqe8AvxtiuMwx3w [not found] ` <20180129092223.12423-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2018-01-29 10:22 ` Maxime Ripard [not found] ` <20180129102227.ejmbifzjqmba3yja-ZC1Zs529Oq4@public.gmane.org> 2018-01-29 10:35 ` [PATCH] " Jernej Škrabec [not found] ` <27087126.4975652.1517222127863.JavaMail.zimbra-uhf9zSJETnQdlpnTk8+5LA@public.gmane.org> 2018-01-31 7:16 ` [linux-sunxi][PATCH] " maxime ripard [not found] ` <20180131071616.jrkd465cq4mgyyvm-ZC1Zs529Oq4@public.gmane.org> 2018-01-31 9:54 ` [PATCH] " Code Kipper [not found] ` <CAEKpxBmVzeUN=1F=APVomu4s4h2s83R4JX3EG1=1Mu_ZBSF96g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-01-31 15:57 ` maxime ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).