* [PATCH] dt-bindings: fpga: Consolidate bridge properties
@ 2018-02-21 17:33 Moritz Fischer
2018-02-21 18:47 ` Alan Tull
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Moritz Fischer @ 2018-02-21 17:33 UTC (permalink / raw)
To: linux-fpga
Cc: linux-kernel, atull, robh+dt, mark.rutland, michal.simek,
devicetree, Moritz Fischer
Consolidate bridge properties in a single file, instead of duplicating
the same optional property over and over again.
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Cc: Alan Tull <atull@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
---
.../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +----
.../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +----
.../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +----
Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++
.../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------
5 files changed, 20 insertions(+), 18 deletions(-)
create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txt
diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
index 817a8d4bf903..5dd0ff0f7b4e 100644
--- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
+++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
@@ -3,10 +3,7 @@ Altera FPGA To SDRAM Bridge Driver
Required properties:
- compatible : Should contain "altr,socfpga-fpga2sdram-bridge"
-Optional properties:
-- bridge-enable : 0 if driver should disable bridge at startup
- 1 if driver should enable bridge at startup
- Default is to leave bridge in current state.
+See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
Example:
fpga_bridge3: fpga-bridge@ffc25080 {
diff --git a/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
index f8e288c71b2d..8b26fbcff3c6 100644
--- a/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
+++ b/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
@@ -10,10 +10,7 @@ Required properties:
- compatible : Should contain "altr,freeze-bridge-controller"
- regs : base address and size for freeze bridge module
-Optional properties:
-- bridge-enable : 0 if driver should disable bridge at startup
- 1 if driver should enable bridge at startup
- Default is to leave bridge in current state.
+See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
Example:
freeze-controller@100000450 {
diff --git a/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
index 6406f9337eeb..68cce3945b10 100644
--- a/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
+++ b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
@@ -9,10 +9,7 @@ Required properties:
- resets : Phandle and reset specifier for this bridge's reset
- clocks : Clocks used by this module.
-Optional properties:
-- bridge-enable : 0 if driver should disable bridge at startup.
- 1 if driver should enable bridge at startup.
- Default is to leave bridge in its current state.
+See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
Example:
fpga_bridge0: fpga-bridge@ff400000 {
diff --git a/Documentation/devicetree/bindings/fpga/fpga-bridge.txt b/Documentation/devicetree/bindings/fpga/fpga-bridge.txt
new file mode 100644
index 000000000000..82607b23a287
--- /dev/null
+++ b/Documentation/devicetree/bindings/fpga/fpga-bridge.txt
@@ -0,0 +1,15 @@
+FPGA Bridge Device Tree Binding
+
+Moritz Fischer 2018 (Consolidated from previous bindings)
+
+Optional properties:
+- bridge-enable : 0 if driver should disable bridge at startup
+ 1 if driver should enable bridge at startup
+ Default is to leave bridge in current state.
+
+Example:
+ fpga_bridge3: fpga-bridge@ffc25080 {
+ compatible = "altr,socfpga-fpga2sdram-bridge";
+ reg = <0xffc25080 0x4>;
+ bridge-enable = <0>;
+ };
diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
index 8dcfba926bc7..4284d293fa61 100644
--- a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
+++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
@@ -18,12 +18,8 @@ Required properties:
- clocks : input clock to IP
- clock-names : should contain "aclk"
-Optional properties:
-- bridge-enable : 0 if driver should disable bridge at startup
- 1 if driver should enable bridge at startup
- Default is to leave bridge in current state.
-
-See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings.
+See Documentation/devicetree/bindings/fpga/fpga-region.txt and
+Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
Example:
fpga-bridge@100000450 {
--
2.16.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: fpga: Consolidate bridge properties
2018-02-21 17:33 [PATCH] dt-bindings: fpga: Consolidate bridge properties Moritz Fischer
@ 2018-02-21 18:47 ` Alan Tull
2018-02-22 7:12 ` Michal Simek
2018-03-01 22:41 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Alan Tull @ 2018-02-21 18:47 UTC (permalink / raw)
To: Moritz Fischer
Cc: linux-fpga, linux-kernel, Rob Herring, Mark Rutland,
Michal Simek,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Wed, Feb 21, 2018 at 11:33 AM, Moritz Fischer <mdf@kernel.org> wrote:
Hi Moritz,
Thanks!
> Consolidate bridge properties in a single file, instead of duplicating
> the same optional property over and over again.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +----
> .../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +----
> .../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +----
> Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++
> .../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------
> 5 files changed, 20 insertions(+), 18 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txt
>
> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> index 817a8d4bf903..5dd0ff0f7b4e 100644
> --- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> @@ -3,10 +3,7 @@ Altera FPGA To SDRAM Bridge Driver
> Required properties:
> - compatible : Should contain "altr,socfpga-fpga2sdram-bridge"
>
> -Optional properties:
> -- bridge-enable : 0 if driver should disable bridge at startup
> - 1 if driver should enable bridge at startup
> - Default is to leave bridge in current state.
> +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
>
> Example:
> fpga_bridge3: fpga-bridge@ffc25080 {
> diff --git a/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
> index f8e288c71b2d..8b26fbcff3c6 100644
> --- a/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
> +++ b/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
> @@ -10,10 +10,7 @@ Required properties:
> - compatible : Should contain "altr,freeze-bridge-controller"
> - regs : base address and size for freeze bridge module
>
> -Optional properties:
> -- bridge-enable : 0 if driver should disable bridge at startup
> - 1 if driver should enable bridge at startup
> - Default is to leave bridge in current state.
> +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
>
> Example:
> freeze-controller@100000450 {
> diff --git a/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
> index 6406f9337eeb..68cce3945b10 100644
> --- a/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
> +++ b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
> @@ -9,10 +9,7 @@ Required properties:
> - resets : Phandle and reset specifier for this bridge's reset
> - clocks : Clocks used by this module.
>
> -Optional properties:
> -- bridge-enable : 0 if driver should disable bridge at startup.
> - 1 if driver should enable bridge at startup.
> - Default is to leave bridge in its current state.
> +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
>
> Example:
> fpga_bridge0: fpga-bridge@ff400000 {
> diff --git a/Documentation/devicetree/bindings/fpga/fpga-bridge.txt b/Documentation/devicetree/bindings/fpga/fpga-bridge.txt
> new file mode 100644
> index 000000000000..82607b23a287
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/fpga-bridge.txt
> @@ -0,0 +1,15 @@
> +FPGA Bridge Device Tree Binding
> +
> +Moritz Fischer 2018 (Consolidated from previous bindings)
> +
> +Optional properties:
> +- bridge-enable : 0 if driver should disable bridge at startup
> + 1 if driver should enable bridge at startup
> + Default is to leave bridge in current state.
> +
> +Example:
> + fpga_bridge3: fpga-bridge@ffc25080 {
> + compatible = "altr,socfpga-fpga2sdram-bridge";
> + reg = <0xffc25080 0x4>;
> + bridge-enable = <0>;
> + };
> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> index 8dcfba926bc7..4284d293fa61 100644
> --- a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> @@ -18,12 +18,8 @@ Required properties:
> - clocks : input clock to IP
> - clock-names : should contain "aclk"
>
> -Optional properties:
> -- bridge-enable : 0 if driver should disable bridge at startup
> - 1 if driver should enable bridge at startup
> - Default is to leave bridge in current state.
> -
> -See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings.
> +See Documentation/devicetree/bindings/fpga/fpga-region.txt and
> +Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
>
> Example:
> fpga-bridge@100000450 {
> --
> 2.16.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: fpga: Consolidate bridge properties
2018-02-21 17:33 [PATCH] dt-bindings: fpga: Consolidate bridge properties Moritz Fischer
2018-02-21 18:47 ` Alan Tull
@ 2018-02-22 7:12 ` Michal Simek
2018-02-22 17:30 ` Moritz Fischer
2018-03-01 22:41 ` Rob Herring
2 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2018-02-22 7:12 UTC (permalink / raw)
To: Moritz Fischer, linux-fpga
Cc: linux-kernel, atull, robh+dt, mark.rutland, michal.simek, devicetree
On 21.2.2018 18:33, Moritz Fischer wrote:
> Consolidate bridge properties in a single file, instead of duplicating
> the same optional property over and over again.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +----
> .../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +----
> .../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +----
> Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++
> .../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------
> 5 files changed, 20 insertions(+), 18 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txt
>
> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> index 817a8d4bf903..5dd0ff0f7b4e 100644
> --- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> @@ -3,10 +3,7 @@ Altera FPGA To SDRAM Bridge Driver
> Required properties:
> - compatible : Should contain "altr,socfpga-fpga2sdram-bridge"
>
> -Optional properties:
> -- bridge-enable : 0 if driver should disable bridge at startup
> - 1 if driver should enable bridge at startup
> - Default is to leave bridge in current state.
> +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
>
> Example:
> fpga_bridge3: fpga-bridge@ffc25080 {
> diff --git a/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
> index f8e288c71b2d..8b26fbcff3c6 100644
> --- a/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
> +++ b/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
> @@ -10,10 +10,7 @@ Required properties:
> - compatible : Should contain "altr,freeze-bridge-controller"
> - regs : base address and size for freeze bridge module
>
> -Optional properties:
> -- bridge-enable : 0 if driver should disable bridge at startup
> - 1 if driver should enable bridge at startup
> - Default is to leave bridge in current state.
> +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
>
> Example:
> freeze-controller@100000450 {
> diff --git a/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
> index 6406f9337eeb..68cce3945b10 100644
> --- a/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
> +++ b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
> @@ -9,10 +9,7 @@ Required properties:
> - resets : Phandle and reset specifier for this bridge's reset
> - clocks : Clocks used by this module.
>
> -Optional properties:
> -- bridge-enable : 0 if driver should disable bridge at startup.
> - 1 if driver should enable bridge at startup.
> - Default is to leave bridge in its current state.
> +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
>
> Example:
> fpga_bridge0: fpga-bridge@ff400000 {
> diff --git a/Documentation/devicetree/bindings/fpga/fpga-bridge.txt b/Documentation/devicetree/bindings/fpga/fpga-bridge.txt
> new file mode 100644
> index 000000000000..82607b23a287
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/fpga-bridge.txt
> @@ -0,0 +1,15 @@
> +FPGA Bridge Device Tree Binding
> +
> +Moritz Fischer 2018 (Consolidated from previous bindings)
nit: I would remove your name and year - it is visible from git log.
> +
> +Optional properties:
> +- bridge-enable : 0 if driver should disable bridge at startup
> + 1 if driver should enable bridge at startup
> + Default is to leave bridge in current state.
> +
> +Example:
> + fpga_bridge3: fpga-bridge@ffc25080 {
> + compatible = "altr,socfpga-fpga2sdram-bridge";
> + reg = <0xffc25080 0x4>;
> + bridge-enable = <0>;
> + };
> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> index 8dcfba926bc7..4284d293fa61 100644
> --- a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> @@ -18,12 +18,8 @@ Required properties:
> - clocks : input clock to IP
> - clock-names : should contain "aclk"
>
> -Optional properties:
> -- bridge-enable : 0 if driver should disable bridge at startup
> - 1 if driver should enable bridge at startup
> - Default is to leave bridge in current state.
> -
> -See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings.
> +See Documentation/devicetree/bindings/fpga/fpga-region.txt and
> +Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
>
> Example:
> fpga-bridge@100000450 {
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: fpga: Consolidate bridge properties
2018-02-22 7:12 ` Michal Simek
@ 2018-02-22 17:30 ` Moritz Fischer
0 siblings, 0 replies; 5+ messages in thread
From: Moritz Fischer @ 2018-02-22 17:30 UTC (permalink / raw)
To: Michal Simek
Cc: Moritz Fischer, linux-fpga, linux-kernel, atull, robh+dt,
mark.rutland, devicetree
[-- Attachment #1: Type: text/plain, Size: 5802 bytes --]
On Thu, Feb 22, 2018 at 08:12:19AM +0100, Michal Simek wrote:
> On 21.2.2018 18:33, Moritz Fischer wrote:
> > Consolidate bridge properties in a single file, instead of duplicating
> > the same optional property over and over again.
> >
> > Signed-off-by: Moritz Fischer <mdf@kernel.org>
> > Cc: Alan Tull <atull@kernel.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > ---
> > .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +----
> > .../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +----
> > .../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +----
> > Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++
> > .../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------
> > 5 files changed, 20 insertions(+), 18 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txt
> >
> > diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> > index 817a8d4bf903..5dd0ff0f7b4e 100644
> > --- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> > +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> > @@ -3,10 +3,7 @@ Altera FPGA To SDRAM Bridge Driver
> > Required properties:
> > - compatible : Should contain "altr,socfpga-fpga2sdram-bridge"
> >
> > -Optional properties:
> > -- bridge-enable : 0 if driver should disable bridge at startup
> > - 1 if driver should enable bridge at startup
> > - Default is to leave bridge in current state.
> > +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
> >
> > Example:
> > fpga_bridge3: fpga-bridge@ffc25080 {
> > diff --git a/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
> > index f8e288c71b2d..8b26fbcff3c6 100644
> > --- a/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
> > +++ b/Documentation/devicetree/bindings/fpga/altera-freeze-bridge.txt
> > @@ -10,10 +10,7 @@ Required properties:
> > - compatible : Should contain "altr,freeze-bridge-controller"
> > - regs : base address and size for freeze bridge module
> >
> > -Optional properties:
> > -- bridge-enable : 0 if driver should disable bridge at startup
> > - 1 if driver should enable bridge at startup
> > - Default is to leave bridge in current state.
> > +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
> >
> > Example:
> > freeze-controller@100000450 {
> > diff --git a/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
> > index 6406f9337eeb..68cce3945b10 100644
> > --- a/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
> > +++ b/Documentation/devicetree/bindings/fpga/altera-hps2fpga-bridge.txt
> > @@ -9,10 +9,7 @@ Required properties:
> > - resets : Phandle and reset specifier for this bridge's reset
> > - clocks : Clocks used by this module.
> >
> > -Optional properties:
> > -- bridge-enable : 0 if driver should disable bridge at startup.
> > - 1 if driver should enable bridge at startup.
> > - Default is to leave bridge in its current state.
> > +See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
> >
> > Example:
> > fpga_bridge0: fpga-bridge@ff400000 {
> > diff --git a/Documentation/devicetree/bindings/fpga/fpga-bridge.txt b/Documentation/devicetree/bindings/fpga/fpga-bridge.txt
> > new file mode 100644
> > index 000000000000..82607b23a287
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/fpga/fpga-bridge.txt
> > @@ -0,0 +1,15 @@
> > +FPGA Bridge Device Tree Binding
> > +
> > +Moritz Fischer 2018 (Consolidated from previous bindings)
>
> nit: I would remove your name and year - it is visible from git log.
Yeah can get rid of that, I copied from fpga-region.txt :)
>
> > +
> > +Optional properties:
> > +- bridge-enable : 0 if driver should disable bridge at startup
> > + 1 if driver should enable bridge at startup
> > + Default is to leave bridge in current state.
> > +
> > +Example:
> > + fpga_bridge3: fpga-bridge@ffc25080 {
> > + compatible = "altr,socfpga-fpga2sdram-bridge";
> > + reg = <0xffc25080 0x4>;
> > + bridge-enable = <0>;
> > + };
> > diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> > index 8dcfba926bc7..4284d293fa61 100644
> > --- a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> > +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> > @@ -18,12 +18,8 @@ Required properties:
> > - clocks : input clock to IP
> > - clock-names : should contain "aclk"
> >
> > -Optional properties:
> > -- bridge-enable : 0 if driver should disable bridge at startup
> > - 1 if driver should enable bridge at startup
> > - Default is to leave bridge in current state.
> > -
> > -See Documentation/devicetree/bindings/fpga/fpga-region.txt for generic bindings.
> > +See Documentation/devicetree/bindings/fpga/fpga-region.txt and
> > +Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
> >
> > Example:
> > fpga-bridge@100000450 {
> >
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
- Moritz
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: fpga: Consolidate bridge properties
2018-02-21 17:33 [PATCH] dt-bindings: fpga: Consolidate bridge properties Moritz Fischer
2018-02-21 18:47 ` Alan Tull
2018-02-22 7:12 ` Michal Simek
@ 2018-03-01 22:41 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2018-03-01 22:41 UTC (permalink / raw)
To: Moritz Fischer
Cc: linux-fpga, linux-kernel, atull, mark.rutland, michal.simek, devicetree
On Wed, Feb 21, 2018 at 09:33:06AM -0800, Moritz Fischer wrote:
> Consolidate bridge properties in a single file, instead of duplicating
> the same optional property over and over again.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> Cc: Alan Tull <atull@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 +----
> .../devicetree/bindings/fpga/altera-freeze-bridge.txt | 5 +----
> .../devicetree/bindings/fpga/altera-hps2fpga-bridge.txt | 5 +----
> Documentation/devicetree/bindings/fpga/fpga-bridge.txt | 15 +++++++++++++++
> .../devicetree/bindings/fpga/xilinx-pr-decoupler.txt | 8 ++------
> 5 files changed, 20 insertions(+), 18 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/fpga/fpga-bridge.txt
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-01 22:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-21 17:33 [PATCH] dt-bindings: fpga: Consolidate bridge properties Moritz Fischer
2018-02-21 18:47 ` Alan Tull
2018-02-22 7:12 ` Michal Simek
2018-02-22 17:30 ` Moritz Fischer
2018-03-01 22:41 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).