Re: [PATCH V5 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

Re: [PATCH V5 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel

[Tony Lindgren]

* Adam Ford <aford173@gmail.com> [191016 06:53]:
> With the removal of the panel-dpi from the omap drivers, the
> LCD no longer works.  This patch points the device tree to
> a newly created panel named "logicpd,type28"
> 
> Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> V5:  No Change
> V4:  No Change
> V3:  No change
> V2:  Remove legacy 'label' from binding

I'm picking this patch into omap-for-v5.5/dt thanks.

Regards,

Tony

> diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
> index 07ac99b9cda6..cdb89b3e2a9b 100644
> --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
> +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts
> @@ -11,22 +11,6 @@
>  #include "logicpd-torpedo-37xx-devkit.dts"
>  
>  &lcd0 {
> -
> -	label = "28";
> -
> -	panel-timing {
> -		clock-frequency = <9000000>;
> -		hactive = <480>;
> -		vactive = <272>;
> -		hfront-porch = <3>;
> -		hback-porch = <2>;
> -		hsync-len = <42>;
> -		vback-porch = <3>;
> -		vfront-porch = <2>;
> -		vsync-len = <11>;
> -		hsync-active = <1>;
> -		vsync-active = <1>;
> -		de-active = <1>;
> -		pixelclk-active = <0>;
> -	};
> +	/* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */
> +	compatible = "logicpd,type28";
>  };
> -- 
> 2.17.1
> 

Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

[Adam Ford]

On Wed, Oct 16, 2019 at 8:52 AM Adam Ford <aford173@gmail.com> wrote:
>
> Previously, there was an omap panel-dpi driver that would
> read generic timings from the device tree and set the display
> timing accordingly.  This driver was removed so the screen
> no longer functions.  This patch modifies the panel-simple
> file to setup the timings to the same values previously used.
>
> Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
>

Will this be able to make it into linux-next for the 5.5 merge window?
 I believe Tony has picked up the device tree portion in his omap
tree, but I haven't seen any notifications on this series on whether
or not it's being applied.  I also don't know which tree I need to
look if it's already been applied.

This fixes a regression introduced a while ago where the driver I was
using for the display was removed.

thank you,

adam

> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> V5:  No Change
> V4:  No Change
> V3:  No Change
> V2:  No Change
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 5d487686d25c..72f69709f349 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
>         .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
>  };
>
> +static const struct drm_display_mode logicpd_type_28_mode = {
> +       .clock = 9000,
> +       .hdisplay = 480,
> +       .hsync_start = 480 + 3,
> +       .hsync_end = 480 + 3 + 42,
> +       .htotal = 480 + 3 + 42 + 2,
> +
> +       .vdisplay = 272,
> +       .vsync_start = 272 + 2,
> +       .vsync_end = 272 + 2 + 11,
> +       .vtotal = 272 + 2 + 11 + 3,
> +       .vrefresh = 60,
> +       .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> +};
> +
> +static const struct panel_desc logicpd_type_28 = {
> +       .modes = &logicpd_type_28_mode,
> +       .num_modes = 1,
> +       .bpc = 8,
> +       .size = {
> +               .width = 105,
> +               .height = 67,
> +       },
> +       .delay = {
> +               .prepare = 200,
> +               .enable = 200,
> +               .unprepare = 200,
> +               .disable = 200,
> +       },
> +       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +       .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |
> +                    DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE,
> +};
> +
>  static const struct panel_desc mitsubishi_aa070mc01 = {
>         .modes = &mitsubishi_aa070mc01_mode,
>         .num_modes = 1,
> @@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = {
>         }, {
>                 .compatible = "lg,lp129qe",
>                 .data = &lg_lp129qe,
> +       }, {
> +               .compatible = "logicpd,type28",
> +               .data = &logicpd_type_28,
>         }, {
>                 .compatible = "mitsubishi,aa070mc01-ca1",
>                 .data = &mitsubishi_aa070mc01,
> --
> 2.17.1
>

Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

[Laurent Pinchart]

On Wed, Oct 30, 2019 at 09:44:20AM -0500, Adam Ford wrote:
> On Wed, Oct 16, 2019 at 8:52 AM Adam Ford <aford173@gmail.com> wrote:
> >
> > Previously, there was an omap panel-dpi driver that would
> > read generic timings from the device tree and set the display
> > timing accordingly.  This driver was removed so the screen
> > no longer functions.  This patch modifies the panel-simple
> > file to setup the timings to the same values previously used.
> >
> > Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
> 
> Will this be able to make it into linux-next for the 5.5 merge window?
> I believe Tony has picked up the device tree portion in his omap
> tree, but I haven't seen any notifications on this series on whether
> or not it's being applied.  I also don't know which tree I need to
> look if it's already been applied.
> 
> This fixes a regression introduced a while ago where the driver I was
> using for the display was removed.

Sam, would you be able to pick this up ?

> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > ---
> > V5:  No Change
> > V4:  No Change
> > V3:  No Change
> > V2:  No Change
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 5d487686d25c..72f69709f349 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> >         .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> >  };
> >
> > +static const struct drm_display_mode logicpd_type_28_mode = {
> > +       .clock = 9000,
> > +       .hdisplay = 480,
> > +       .hsync_start = 480 + 3,
> > +       .hsync_end = 480 + 3 + 42,
> > +       .htotal = 480 + 3 + 42 + 2,
> > +
> > +       .vdisplay = 272,
> > +       .vsync_start = 272 + 2,
> > +       .vsync_end = 272 + 2 + 11,
> > +       .vtotal = 272 + 2 + 11 + 3,
> > +       .vrefresh = 60,
> > +       .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> > +};
> > +
> > +static const struct panel_desc logicpd_type_28 = {
> > +       .modes = &logicpd_type_28_mode,
> > +       .num_modes = 1,
> > +       .bpc = 8,
> > +       .size = {
> > +               .width = 105,
> > +               .height = 67,
> > +       },
> > +       .delay = {
> > +               .prepare = 200,
> > +               .enable = 200,
> > +               .unprepare = 200,
> > +               .disable = 200,
> > +       },
> > +       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > +       .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |
> > +                    DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE,
> > +};
> > +
> >  static const struct panel_desc mitsubishi_aa070mc01 = {
> >         .modes = &mitsubishi_aa070mc01_mode,
> >         .num_modes = 1,
> > @@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = {
> >         }, {
> >                 .compatible = "lg,lp129qe",
> >                 .data = &lg_lp129qe,
> > +       }, {
> > +               .compatible = "logicpd,type28",
> > +               .data = &logicpd_type_28,
> >         }, {
> >                 .compatible = "mitsubishi,aa070mc01-ca1",
> >                 .data = &mitsubishi_aa070mc01,

-- 
Regards,

Laurent Pinchart

Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

[Adam Ford]

On Fri, Nov 1, 2019 at 2:57 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> On Wed, Oct 30, 2019 at 09:44:20AM -0500, Adam Ford wrote:
> > On Wed, Oct 16, 2019 at 8:52 AM Adam Ford <aford173@gmail.com> wrote:
> > >
> > > Previously, there was an omap panel-dpi driver that would
> > > read generic timings from the device tree and set the display
> > > timing accordingly.  This driver was removed so the screen
> > > no longer functions.  This patch modifies the panel-simple
> > > file to setup the timings to the same values previously used.
> > >
> > > Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
> >
> > Will this be able to make it into linux-next for the 5.5 merge window?
> > I believe Tony has picked up the device tree portion in his omap
> > tree, but I haven't seen any notifications on this series on whether
> > or not it's being applied.  I also don't know which tree I need to
> > look if it's already been applied.
> >
> > This fixes a regression introduced a while ago where the driver I was
> > using for the display was removed.
>
> Sam, would you be able to pick this up ?

Gentle nudge with the merge window approaching.

Thank you,

adam

>
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > > ---
> > > V5:  No Change
> > > V4:  No Change
> > > V3:  No Change
> > > V2:  No Change
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > index 5d487686d25c..72f69709f349 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> > >         .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > >  };
> > >
> > > +static const struct drm_display_mode logicpd_type_28_mode = {
> > > +       .clock = 9000,
> > > +       .hdisplay = 480,
> > > +       .hsync_start = 480 + 3,
> > > +       .hsync_end = 480 + 3 + 42,
> > > +       .htotal = 480 + 3 + 42 + 2,
> > > +
> > > +       .vdisplay = 272,
> > > +       .vsync_start = 272 + 2,
> > > +       .vsync_end = 272 + 2 + 11,
> > > +       .vtotal = 272 + 2 + 11 + 3,
> > > +       .vrefresh = 60,
> > > +       .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> > > +};
> > > +
> > > +static const struct panel_desc logicpd_type_28 = {
> > > +       .modes = &logicpd_type_28_mode,
> > > +       .num_modes = 1,
> > > +       .bpc = 8,
> > > +       .size = {
> > > +               .width = 105,
> > > +               .height = 67,
> > > +       },
> > > +       .delay = {
> > > +               .prepare = 200,
> > > +               .enable = 200,
> > > +               .unprepare = 200,
> > > +               .disable = 200,
> > > +       },
> > > +       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > > +       .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |
> > > +                    DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE,
> > > +};
> > > +
> > >  static const struct panel_desc mitsubishi_aa070mc01 = {
> > >         .modes = &mitsubishi_aa070mc01_mode,
> > >         .num_modes = 1,
> > > @@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = {
> > >         }, {
> > >                 .compatible = "lg,lp129qe",
> > >                 .data = &lg_lp129qe,
> > > +       }, {
> > > +               .compatible = "logicpd,type28",
> > > +               .data = &logicpd_type_28,
> > >         }, {
> > >                 .compatible = "mitsubishi,aa070mc01-ca1",
> > >                 .data = &mitsubishi_aa070mc01,
>
> --
> Regards,
>
> Laurent Pinchart

Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

[Adam Ford]

On Mon, Nov 11, 2019 at 7:19 AM Adam Ford <aford173@gmail.com> wrote:
>
> On Fri, Nov 1, 2019 at 2:57 AM Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> >
> > On Wed, Oct 30, 2019 at 09:44:20AM -0500, Adam Ford wrote:
> > > On Wed, Oct 16, 2019 at 8:52 AM Adam Ford <aford173@gmail.com> wrote:
> > > >
> > > > Previously, there was an omap panel-dpi driver that would
> > > > read generic timings from the device tree and set the display
> > > > timing accordingly.  This driver was removed so the screen
> > > > no longer functions.  This patch modifies the panel-simple
> > > > file to setup the timings to the same values previously used.
> > > >
> > > > Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
> > >
> > > Will this be able to make it into linux-next for the 5.5 merge window?
> > > I believe Tony has picked up the device tree portion in his omap
> > > tree, but I haven't seen any notifications on this series on whether
> > > or not it's being applied.  I also don't know which tree I need to
> > > look if it's already been applied.
> > >
> > > This fixes a regression introduced a while ago where the driver I was
> > > using for the display was removed.
> >
> > Sam, would you be able to pick this up ?
>
Sam,

> Gentle nudge with the merge window approaching.

Is it too late for 5.5?  :-(

adam
>
> Thank you,
>
> adam
>
> >
> > > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > > > ---
> > > > V5:  No Change
> > > > V4:  No Change
> > > > V3:  No Change
> > > > V2:  No Change
> > > >
> > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > > > index 5d487686d25c..72f69709f349 100644
> > > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > > @@ -2061,6 +2061,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> > > >         .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > > >  };
> > > >
> > > > +static const struct drm_display_mode logicpd_type_28_mode = {
> > > > +       .clock = 9000,
> > > > +       .hdisplay = 480,
> > > > +       .hsync_start = 480 + 3,
> > > > +       .hsync_end = 480 + 3 + 42,
> > > > +       .htotal = 480 + 3 + 42 + 2,
> > > > +
> > > > +       .vdisplay = 272,
> > > > +       .vsync_start = 272 + 2,
> > > > +       .vsync_end = 272 + 2 + 11,
> > > > +       .vtotal = 272 + 2 + 11 + 3,
> > > > +       .vrefresh = 60,
> > > > +       .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> > > > +};
> > > > +
> > > > +static const struct panel_desc logicpd_type_28 = {
> > > > +       .modes = &logicpd_type_28_mode,
> > > > +       .num_modes = 1,
> > > > +       .bpc = 8,
> > > > +       .size = {
> > > > +               .width = 105,
> > > > +               .height = 67,
> > > > +       },
> > > > +       .delay = {
> > > > +               .prepare = 200,
> > > > +               .enable = 200,
> > > > +               .unprepare = 200,
> > > > +               .disable = 200,
> > > > +       },
> > > > +       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > > > +       .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |
> > > > +                    DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE,
> > > > +};
> > > > +
> > > >  static const struct panel_desc mitsubishi_aa070mc01 = {
> > > >         .modes = &mitsubishi_aa070mc01_mode,
> > > >         .num_modes = 1,
> > > > @@ -3287,6 +3321,9 @@ static const struct of_device_id platform_of_match[] = {
> > > >         }, {
> > > >                 .compatible = "lg,lp129qe",
> > > >                 .data = &lg_lp129qe,
> > > > +       }, {
> > > > +               .compatible = "logicpd,type28",
> > > > +               .data = &logicpd_type_28,
> > > >         }, {
> > > >                 .compatible = "mitsubishi,aa070mc01-ca1",
> > > >                 .data = &mitsubishi_aa070mc01,
> >
> > --
> > Regards,
> >
> > Laurent Pinchart

Re: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel

[Sam Ravnborg]

Hi Adam.
On Wed, Oct 16, 2019 at 08:51:46AM -0500, Adam Ford wrote:
> This patch adds documentation of device tree bindings for the WVGA panel
> Logic PD Type 28 display.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V5:  Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k
> V4:  Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1
> V3:  Correct build errors from 'make dt_binding_check'
> V2:  Use YAML instead of TXT for binding
> 

Applied to drm-misc-next.
It was applied before the driver changes so we had bindings
for the driver changes when applied.

	Sam

Re: [PATCH V5 1/3] drm/panel: simple: Add Logic PD Type 28 display support

[Sam Ravnborg]

Hi Adam.

On Wed, Oct 16, 2019 at 08:51:45AM -0500, Adam Ford wrote:
> Previously, there was an omap panel-dpi driver that would
> read generic timings from the device tree and set the display
> timing accordingly.  This driver was removed so the screen
> no longer functions.  This patch modifies the panel-simple
> file to setup the timings to the same values previously used.
> 
> Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> V5:  No Change
> V4:  No Change
> V3:  No Change
> V2:  No Change

Applied to drm-misc-next.
Sorry for the delay - has been absent for a while.

	Sam