* [PATCH 0/2] arm64: dts: add FlexCAN support to LS1028A and sl28 @ 2020-09-23 9:57 Michael Walle 2020-09-23 9:57 ` [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes Michael Walle 2020-09-23 9:57 ` [PATCH 2/2] arm64: dts: freescale: sl28: add CAN node Michael Walle 0 siblings, 2 replies; 9+ messages in thread From: Michael Walle @ 2020-09-23 9:57 UTC (permalink / raw) To: linux-arm-kernel, devicetree, linux-kernel, linux-can Cc: Shawn Guo, Li Yang, Rob Herring, Marc Kleine-Budde, Joakim Zhang, Michael Walle Now that FlexCAN support for newer IPs is finally hitting upstream [1], lets add the corresponding nodes for the LS1028A SoC and enable it for the Kontron sl28 board. [1] https://lore.kernel.org/netdev/20200923085418.2685858-1-mkl@pengutronix.de/ Michael Walle (2): arm64: dts: ls1028a: add missing CAN nodes arm64: dts: freescale: sl28: add CAN node .../dts/freescale/fsl-ls1028a-kontron-sl28.dts | 4 ++++ arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+) -- 2.20.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes 2020-09-23 9:57 [PATCH 0/2] arm64: dts: add FlexCAN support to LS1028A and sl28 Michael Walle @ 2020-09-23 9:57 ` Michael Walle 2020-09-24 0:35 ` Leo Li 2020-09-23 9:57 ` [PATCH 2/2] arm64: dts: freescale: sl28: add CAN node Michael Walle 1 sibling, 1 reply; 9+ messages in thread From: Michael Walle @ 2020-09-23 9:57 UTC (permalink / raw) To: linux-arm-kernel, devicetree, linux-kernel, linux-can Cc: Shawn Guo, Li Yang, Rob Herring, Marc Kleine-Budde, Joakim Zhang, Michael Walle The LS1028A has two FlexCAN controller. These are compatible with the ones from the LX2160A. Add the nodes. The first controller was tested on the Kontron sl28 board. Signed-off-by: Michael Walle <michael@walle.cc> --- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 0efeb8fa773e..807ee921ec12 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -386,6 +386,24 @@ status = "disabled"; }; + can0: can@2180000 { + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan"; + reg = <0x0 0x2180000 0x0 0x10000>; + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&sysclk>, <&clockgen 4 1>; + clock-names = "ipg", "per"; + status = "disabled"; + }; + + can1: can@2190000 { + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan"; + reg = <0x0 0x2190000 0x0 0x10000>; + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&sysclk>, <&clockgen 4 1>; + clock-names = "ipg", "per"; + status = "disabled"; + }; + duart0: serial@21c0500 { compatible = "fsl,ns16550", "ns16550a"; reg = <0x00 0x21c0500 0x0 0x100>; -- 2.20.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes 2020-09-23 9:57 ` [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes Michael Walle @ 2020-09-24 0:35 ` Leo Li 2020-09-24 11:31 ` Michael Walle 0 siblings, 1 reply; 9+ messages in thread From: Leo Li @ 2020-09-24 0:35 UTC (permalink / raw) To: Michael Walle, linux-arm-kernel, devicetree, linux-kernel, linux-can Cc: Shawn Guo, Rob Herring, Marc Kleine-Budde, Joakim Zhang > -----Original Message----- > From: Michael Walle <michael@walle.cc> > Sent: Wednesday, September 23, 2020 4:57 AM > To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-can@vger.kernel.org > Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob > Herring <robh+dt@kernel.org>; Marc Kleine-Budde <mkl@pengutronix.de>; > Joakim Zhang <qiangqing.zhang@nxp.com>; Michael Walle > <michael@walle.cc> > Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes > > The LS1028A has two FlexCAN controller. These are compatible with the ones > from the LX2160A. Add the nodes. > > The first controller was tested on the Kontron sl28 board. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 0efeb8fa773e..807ee921ec12 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -386,6 +386,24 @@ > status = "disabled"; > }; > > + can0: can@2180000 { > + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1- > flexcan"; The explicit compatible strings cannot be found in the binding, but matched by the "fsl,<processor>-flexcan" pattern in the binding. Is this considered to be acceptable now? > + reg = <0x0 0x2180000 0x0 0x10000>; > + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&sysclk>, <&clockgen 4 1>; > + clock-names = "ipg", "per"; > + status = "disabled"; > + }; > + > + can1: can@2190000 { > + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1- > flexcan"; > + reg = <0x0 0x2190000 0x0 0x10000>; > + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&sysclk>, <&clockgen 4 1>; > + clock-names = "ipg", "per"; > + status = "disabled"; > + }; > + > duart0: serial@21c0500 { > compatible = "fsl,ns16550", "ns16550a"; > reg = <0x00 0x21c0500 0x0 0x100>; > -- > 2.20.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes 2020-09-24 0:35 ` Leo Li @ 2020-09-24 11:31 ` Michael Walle 2020-09-24 15:53 ` Leo Li 0 siblings, 1 reply; 9+ messages in thread From: Michael Walle @ 2020-09-24 11:31 UTC (permalink / raw) To: Leo Li Cc: linux-arm-kernel, devicetree, linux-kernel, linux-can, Shawn Guo, Rob Herring, Marc Kleine-Budde, Joakim Zhang Am 2020-09-24 02:35, schrieb Leo Li: >> -----Original Message----- >> From: Michael Walle <michael@walle.cc> >> Sent: Wednesday, September 23, 2020 4:57 AM >> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; >> linux- >> kernel@vger.kernel.org; linux-can@vger.kernel.org >> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob >> Herring <robh+dt@kernel.org>; Marc Kleine-Budde <mkl@pengutronix.de>; >> Joakim Zhang <qiangqing.zhang@nxp.com>; Michael Walle >> <michael@walle.cc> >> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes >> >> The LS1028A has two FlexCAN controller. These are compatible with the >> ones >> from the LX2160A. Add the nodes. >> >> The first controller was tested on the Kontron sl28 board. >> >> Signed-off-by: Michael Walle <michael@walle.cc> >> --- >> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 >> ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> index 0efeb8fa773e..807ee921ec12 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> @@ -386,6 +386,24 @@ >> status = "disabled"; >> }; >> >> + can0: can@2180000 { >> + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1- >> flexcan"; > > The explicit compatible strings cannot be found in the binding, but > matched by the "fsl,<processor>-flexcan" pattern in the binding. Is > this considered to be acceptable now? What is the consequence if it is not acceptable? replacing the pattern with individual compatible strings? -michael ^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes 2020-09-24 11:31 ` Michael Walle @ 2020-09-24 15:53 ` Leo Li 2020-09-25 9:31 ` Michael Walle 0 siblings, 1 reply; 9+ messages in thread From: Leo Li @ 2020-09-24 15:53 UTC (permalink / raw) To: Michael Walle Cc: linux-arm-kernel, devicetree, linux-kernel, linux-can, Shawn Guo, Rob Herring, Marc Kleine-Budde, Joakim Zhang > -----Original Message----- > From: Michael Walle <michael@walle.cc> > Sent: Thursday, September 24, 2020 6:31 AM > To: Leo Li <leoyang.li@nxp.com> > Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-can@vger.kernel.org; Shawn Guo > <shawnguo@kernel.org>; Rob Herring <robh+dt@kernel.org>; Marc Kleine- > Budde <mkl@pengutronix.de>; Joakim Zhang <qiangqing.zhang@nxp.com> > Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes > > Am 2020-09-24 02:35, schrieb Leo Li: > >> -----Original Message----- > >> From: Michael Walle <michael@walle.cc> > >> Sent: Wednesday, September 23, 2020 4:57 AM > >> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > >> linux- > >> kernel@vger.kernel.org; linux-can@vger.kernel.org > >> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; > Rob > >> Herring <robh+dt@kernel.org>; Marc Kleine-Budde > <mkl@pengutronix.de>; > >> Joakim Zhang <qiangqing.zhang@nxp.com>; Michael Walle > >> <michael@walle.cc> > >> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes > >> > >> The LS1028A has two FlexCAN controller. These are compatible with the > >> ones > >> from the LX2160A. Add the nodes. > >> > >> The first controller was tested on the Kontron sl28 board. > >> > >> Signed-off-by: Michael Walle <michael@walle.cc> > >> --- > >> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 > >> ++++++++++++++++++ > >> 1 file changed, 18 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > >> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > >> index 0efeb8fa773e..807ee921ec12 100644 > >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > >> @@ -386,6 +386,24 @@ > >> status = "disabled"; > >> }; > >> > >> + can0: can@2180000 { > >> + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1- > >> flexcan"; > > > > The explicit compatible strings cannot be found in the binding, but > > matched by the "fsl,<processor>-flexcan" pattern in the binding. Is > > this considered to be acceptable now? > > What is the consequence if it is not acceptable? replacing the pattern > with individual compatible strings? There is a recommendation in the kernel documentation quoted below: 7) The wildcard "<chip>" may be used in compatible strings, as in the following example: - compatible: Must contain '"nvidia,<chip>-pcie", "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, ... As in the above example, the known values of "<chip>" should be documented if it is used. But I am not sure if this is still a hard requirement. If so, we should list the processors in the binding. Regards, Leo ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes 2020-09-24 15:53 ` Leo Li @ 2020-09-25 9:31 ` Michael Walle 2020-09-25 9:34 ` Marc Kleine-Budde 0 siblings, 1 reply; 9+ messages in thread From: Michael Walle @ 2020-09-25 9:31 UTC (permalink / raw) To: Leo Li Cc: linux-arm-kernel, devicetree, linux-kernel, linux-can, Shawn Guo, Rob Herring, Marc Kleine-Budde, Joakim Zhang Am 2020-09-24 17:53, schrieb Leo Li: >> -----Original Message----- >> From: Michael Walle <michael@walle.cc> >> Sent: Thursday, September 24, 2020 6:31 AM >> To: Leo Li <leoyang.li@nxp.com> >> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; >> linux- >> kernel@vger.kernel.org; linux-can@vger.kernel.org; Shawn Guo >> <shawnguo@kernel.org>; Rob Herring <robh+dt@kernel.org>; Marc Kleine- >> Budde <mkl@pengutronix.de>; Joakim Zhang <qiangqing.zhang@nxp.com> >> Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes >> >> Am 2020-09-24 02:35, schrieb Leo Li: >> >> -----Original Message----- >> >> From: Michael Walle <michael@walle.cc> >> >> Sent: Wednesday, September 23, 2020 4:57 AM >> >> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; >> >> linux- >> >> kernel@vger.kernel.org; linux-can@vger.kernel.org >> >> Cc: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; >> Rob >> >> Herring <robh+dt@kernel.org>; Marc Kleine-Budde >> <mkl@pengutronix.de>; >> >> Joakim Zhang <qiangqing.zhang@nxp.com>; Michael Walle >> >> <michael@walle.cc> >> >> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes >> >> >> >> The LS1028A has two FlexCAN controller. These are compatible with the >> >> ones >> >> from the LX2160A. Add the nodes. >> >> >> >> The first controller was tested on the Kontron sl28 board. >> >> >> >> Signed-off-by: Michael Walle <michael@walle.cc> >> >> --- >> >> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 >> >> ++++++++++++++++++ >> >> 1 file changed, 18 insertions(+) >> >> >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> >> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> >> index 0efeb8fa773e..807ee921ec12 100644 >> >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> >> @@ -386,6 +386,24 @@ >> >> status = "disabled"; >> >> }; >> >> >> >> + can0: can@2180000 { >> >> + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1- >> >> flexcan"; >> > >> > The explicit compatible strings cannot be found in the binding, but >> > matched by the "fsl,<processor>-flexcan" pattern in the binding. Is >> > this considered to be acceptable now? >> >> What is the consequence if it is not acceptable? replacing the pattern >> with individual compatible strings? > > There is a recommendation in the kernel documentation quoted below: > > 7) The wildcard "<chip>" may be used in compatible strings, as in > the following example: > > - compatible: Must contain '"nvidia,<chip>-pcie", > "nvidia,tegra20-pcie"' where <chip> is tegra30, tegra132, > ... > > As in the above example, the known values of "<chip>" should be > documented if it is used. > > But I am not sure if this is still a hard requirement. If so, we > should list the processors in the binding. Marc, I'd convert this to yaml format, may I put your name as the maintainer in the binding? -michael ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes 2020-09-25 9:31 ` Michael Walle @ 2020-09-25 9:34 ` Marc Kleine-Budde 2020-09-25 11:35 ` Michael Walle 0 siblings, 1 reply; 9+ messages in thread From: Marc Kleine-Budde @ 2020-09-25 9:34 UTC (permalink / raw) To: Michael Walle, Leo Li Cc: linux-arm-kernel, devicetree, linux-kernel, linux-can, Shawn Guo, Rob Herring, Joakim Zhang, Oleksij Rempel [-- Attachment #1.1: Type: text/plain, Size: 472 bytes --] On 9/25/20 11:31 AM, Michael Walle wrote: > Marc, I'd convert this to yaml format, Oleksij (CC'ed) is working already on this. > may I put your name as the maintainer in the binding? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes 2020-09-25 9:34 ` Marc Kleine-Budde @ 2020-09-25 11:35 ` Michael Walle 0 siblings, 0 replies; 9+ messages in thread From: Michael Walle @ 2020-09-25 11:35 UTC (permalink / raw) To: Marc Kleine-Budde Cc: Leo Li, linux-arm-kernel, devicetree, linux-kernel, linux-can, Shawn Guo, Rob Herring, Joakim Zhang, Oleksij Rempel Am 2020-09-25 11:34, schrieb Marc Kleine-Budde: > On 9/25/20 11:31 AM, Michael Walle wrote: >> Marc, I'd convert this to yaml format, > > Oleksij (CC'ed) is working already on this. Cool. Oleksij, if there will be individual compatible strings, could you already add the one for the LS1028A? i.e. "fsl,ls1028ar1-flexcan" followed by "fsl,lx2160ar1-flexcan" -michael ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: freescale: sl28: add CAN node 2020-09-23 9:57 [PATCH 0/2] arm64: dts: add FlexCAN support to LS1028A and sl28 Michael Walle 2020-09-23 9:57 ` [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes Michael Walle @ 2020-09-23 9:57 ` Michael Walle 1 sibling, 0 replies; 9+ messages in thread From: Michael Walle @ 2020-09-23 9:57 UTC (permalink / raw) To: linux-arm-kernel, devicetree, linux-kernel, linux-can Cc: Shawn Guo, Li Yang, Rob Herring, Marc Kleine-Budde, Joakim Zhang, Michael Walle The module supports one CAN controller. Enable it. Signed-off-by: Michael Walle <michael@walle.cc> --- arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts index 852dad8d70ab..360b3a168c10 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts @@ -27,6 +27,10 @@ }; }; +&can0 { + status = "okay"; +}; + &dspi2 { status = "okay"; }; -- 2.20.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-09-25 11:35 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-09-23 9:57 [PATCH 0/2] arm64: dts: add FlexCAN support to LS1028A and sl28 Michael Walle 2020-09-23 9:57 ` [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes Michael Walle 2020-09-24 0:35 ` Leo Li 2020-09-24 11:31 ` Michael Walle 2020-09-24 15:53 ` Leo Li 2020-09-25 9:31 ` Michael Walle 2020-09-25 9:34 ` Marc Kleine-Budde 2020-09-25 11:35 ` Michael Walle 2020-09-23 9:57 ` [PATCH 2/2] arm64: dts: freescale: sl28: add CAN node Michael Walle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).