* [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Krzysztof Kozlowski
@ 2020-09-27 16:59 ` Krzysztof Kozlowski
2020-10-07 12:51 ` Adam Ford
2020-09-27 16:59 ` [PATCH 3/6] arm64: dts: imx8mm-evk: " Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-27 16:59 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Adam Ford, Daniel Baluta,
Anson Huang, Peter Chen, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
The PMIC's interrupt is level low and should be pulled up. The PMIC's
device node had pinctrl-0 property but it lacked pinctrl-names which
is required to apply the pin configuration.
Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
index 6de86a4f0ec4..55b36bddd513 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
@@ -72,6 +72,7 @@
pmic@4b {
compatible = "rohm,bd71847";
reg = <0x4b>;
+ pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pmic>;
interrupt-parent = <&gpio1>;
interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 ` [PATCH 2/6] arm64: dts: imx8mm-beacon-som: " Krzysztof Kozlowski
@ 2020-10-07 12:51 ` Adam Ford
2020-10-30 12:25 ` Adam Ford
0 siblings, 1 reply; 13+ messages in thread
From: Adam Ford @ 2020-10-07 12:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Daniel Baluta, Anson Huang,
Peter Chen, devicetree, arm-soc, Linux Kernel Mailing List
On Sun, Sep 27, 2020 at 12:00 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The PMIC's interrupt is level low and should be pulled up. The PMIC's
> device node had pinctrl-0 property but it lacked pinctrl-names which
> is required to apply the pin configuration.
>
Thanks for the fixes!
> Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Adam Ford <aford173@gmail.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> index 6de86a4f0ec4..55b36bddd513 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> @@ -72,6 +72,7 @@
> pmic@4b {
> compatible = "rohm,bd71847";
> reg = <0x4b>;
> + pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_pmic>;
> interrupt-parent = <&gpio1>;
> interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up
2020-10-07 12:51 ` Adam Ford
@ 2020-10-30 12:25 ` Adam Ford
2020-10-30 12:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 13+ messages in thread
From: Adam Ford @ 2020-10-30 12:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Daniel Baluta, Anson Huang,
Peter Chen, devicetree, arm-soc, Linux Kernel Mailing List
On Wed, Oct 7, 2020 at 7:51 AM Adam Ford <aford173@gmail.com> wrote:
>
> On Sun, Sep 27, 2020 at 12:00 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > The PMIC's interrupt is level low and should be pulled up. The PMIC's
> > device node had pinctrl-0 property but it lacked pinctrl-names which
> > is required to apply the pin configuration.
> >
>
> Thanks for the fixes!
>
> > Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Tested-by: Adam Ford <aford173@gmail.com>
>
Shawn,
Any chance you can apply this series? Without this patch, the pmic
driver throws some splat due to a previous fix.
thanks
adam
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > index 6de86a4f0ec4..55b36bddd513 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > @@ -72,6 +72,7 @@
> > pmic@4b {
> > compatible = "rohm,bd71847";
> > reg = <0x4b>;
> > + pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_pmic>;
> > interrupt-parent = <&gpio1>;
> > interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up
2020-10-30 12:25 ` Adam Ford
@ 2020-10-30 12:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-30 12:27 UTC (permalink / raw)
To: Adam Ford
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Daniel Baluta, Anson Huang,
Peter Chen, devicetree, arm-soc, Linux Kernel Mailing List
On Fri, 30 Oct 2020 at 13:26, Adam Ford <aford173@gmail.com> wrote:
>
> On Wed, Oct 7, 2020 at 7:51 AM Adam Ford <aford173@gmail.com> wrote:
> >
> > On Sun, Sep 27, 2020 at 12:00 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > The PMIC's interrupt is level low and should be pulled up. The PMIC's
> > > device node had pinctrl-0 property but it lacked pinctrl-names which
> > > is required to apply the pin configuration.
> > >
> >
> > Thanks for the fixes!
> >
> > > Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> > > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > Tested-by: Adam Ford <aford173@gmail.com>
> >
>
> Shawn,
>
> Any chance you can apply this series? Without this patch, the pmic
> driver throws some splat due to a previous fix.
I think Shawn applied it already yesterday or today.
Thanks for checking back on this.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 2/6] arm64: dts: imx8mm-beacon-som: " Krzysztof Kozlowski
@ 2020-09-27 16:59 ` Krzysztof Kozlowski
2020-09-28 0:07 ` Peter Chen
2020-09-28 8:06 ` Robin Gong
2020-09-27 16:59 ` [PATCH 4/6] arm64: dts: imx8mn-var-som: " Krzysztof Kozlowski
` (3 subsequent siblings)
5 siblings, 2 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-27 16:59 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Adam Ford, Daniel Baluta,
Anson Huang, Peter Chen, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
The PMIC's interrupt is level low and should be pulled up. The PMIC's
device node had pinctrl-0 property but it lacked pinctrl-names which
is required to apply the pin configuration.
Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
Fixes: aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts to a common dtsi")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
index f305a530ff6f..521eb3a5a12e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
@@ -121,6 +121,7 @@
pmic@4b {
compatible = "rohm,bd71847";
reg = <0x4b>;
+ pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pmic>;
interrupt-parent = <&gpio1>;
interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 ` [PATCH 3/6] arm64: dts: imx8mm-evk: " Krzysztof Kozlowski
@ 2020-09-28 0:07 ` Peter Chen
2020-09-28 8:06 ` Robin Gong
1 sibling, 0 replies; 13+ messages in thread
From: Peter Chen @ 2020-09-28 0:07 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx, Adam Ford,
Daniel Baluta, Anson Huang, devicetree, linux-arm-kernel,
linux-kernel, Robin Gong
Add Robin Gong.
> Subject: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line
> pull-up
>
> The PMIC's interrupt is level low and should be pulled up. The PMIC's device
> node had pinctrl-0 property but it lacked pinctrl-names which is required to
> apply the pin configuration.
>
> Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> Fixes: aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts to
> a common dtsi")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index f305a530ff6f..521eb3a5a12e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -121,6 +121,7 @@
> pmic@4b {
> compatible = "rohm,bd71847";
> reg = <0x4b>;
> + pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_pmic>;
> interrupt-parent = <&gpio1>;
> interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.17.1
Peter
^ permalink raw reply [flat|nested] 13+ messages in thread* RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 ` [PATCH 3/6] arm64: dts: imx8mm-evk: " Krzysztof Kozlowski
2020-09-28 0:07 ` Peter Chen
@ 2020-09-28 8:06 ` Robin Gong
1 sibling, 0 replies; 13+ messages in thread
From: Robin Gong @ 2020-09-28 8:06 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx, Adam Ford,
Daniel Baluta, Anson Huang, Peter Chen, devicetree,
linux-arm-kernel, linux-kernel
On 2020/09/28 1:00 Krzysztof Kozlowski <krzk@kernel.org> wrote:
> The PMIC's interrupt is level low and should be pulled up. The PMIC's device
> node had pinctrl-0 property but it lacked pinctrl-names which is required to
> apply the pin configuration.
>
> Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> Fixes: aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts
> to a common dtsi")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Please tag me with the whole patch set, thanks.
Reviewed-by: Robin Gong <yibin.gong@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index f305a530ff6f..521eb3a5a12e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -121,6 +121,7 @@
> pmic@4b {
> compatible = "rohm,bd71847";
> reg = <0x4b>;
> + pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_pmic>;
> interrupt-parent = <&gpio1>;
> interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.17.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 4/6] arm64: dts: imx8mn-var-som: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 2/6] arm64: dts: imx8mm-beacon-som: " Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 3/6] arm64: dts: imx8mm-evk: " Krzysztof Kozlowski
@ 2020-09-27 16:59 ` Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: " Krzysztof Kozlowski
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-27 16:59 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Adam Ford, Daniel Baluta,
Anson Huang, Peter Chen, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
The PMIC's interrupt is level low and should be pulled up. The PMIC's
device node had pinctrl-0 property but it lacked pinctrl-names which
is required to apply the pin configuration. The actual problem in DTS
was pointed out by Felix Radensky from Variscite.
Reported-by: Felix Radensky <felix.r@variscite.com>
Fixes: ade0176dd8a0 ("arm64: dts: imx8mn-var-som: Add Variscite VAR-SOM-MX8MN System on Module")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
index a2d0190921e4..7f356edf9f91 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
@@ -116,13 +116,10 @@
pmic@4b {
compatible = "rohm,bd71847";
reg = <0x4b>;
+ pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pmic>;
interrupt-parent = <&gpio2>;
- /*
- * The interrupt is not correct. It should be level low,
- * however with internal pull up this causes IRQ storm.
- */
- interrupts = <8 IRQ_TYPE_EDGE_RISING>;
+ interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
rohm,reset-snvs-powered;
regulators {
@@ -388,7 +385,7 @@
pinctrl_pmic: pmicirqgrp {
fsl,pins = <
- MX8MN_IOMUXC_SD1_DATA6_GPIO2_IO8 0x101
+ MX8MN_IOMUXC_SD1_DATA6_GPIO2_IO8 0x141
>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Krzysztof Kozlowski
` (2 preceding siblings ...)
2020-09-27 16:59 ` [PATCH 4/6] arm64: dts: imx8mn-var-som: " Krzysztof Kozlowski
@ 2020-09-27 16:59 ` Krzysztof Kozlowski
2020-09-28 0:08 ` Peter Chen
2020-09-27 16:59 ` [PATCH 6/6] arm64: dts: imx8mn-evk: " Krzysztof Kozlowski
2020-10-30 0:26 ` [PATCH 1/6] arm64: dts: imx8mm-var-som: " Shawn Guo
5 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-27 16:59 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Adam Ford, Daniel Baluta,
Anson Huang, Peter Chen, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
The PMIC's interrupt is level low and should be pulled up. The PMIC's
device node had pinctrl-0 property but it lacked pinctrl-names which
is required to apply the pin configuration.
Fixes: 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")
Fixes: 3e44dd09736d ("arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMIC support")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
index 46e76cf32b2f..7dfee715a2c4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
@@ -53,6 +53,7 @@
pmic@4b {
compatible = "rohm,bd71847";
reg = <0x4b>;
+ pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pmic>;
interrupt-parent = <&gpio1>;
interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* RE: [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 ` [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: " Krzysztof Kozlowski
@ 2020-09-28 0:08 ` Peter Chen
0 siblings, 0 replies; 13+ messages in thread
From: Peter Chen @ 2020-09-28 0:08 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx, Adam Ford,
Daniel Baluta, Anson Huang, devicetree, linux-arm-kernel,
linux-kernel, Robin Gong
Add Robin Gong.
> Subject: [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's
> interrupt line pull-up
>
> The PMIC's interrupt is level low and should be pulled up. The PMIC's device
> node had pinctrl-0 property but it lacked pinctrl-names which is required to
> apply the pin configuration.
>
> Fixes: 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")
> Fixes: 3e44dd09736d ("arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMIC
> support")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> index 46e76cf32b2f..7dfee715a2c4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
> @@ -53,6 +53,7 @@
> pmic@4b {
> compatible = "rohm,bd71847";
> reg = <0x4b>;
> + pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_pmic>;
> interrupt-parent = <&gpio1>;
> interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.17.1
Peter
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 6/6] arm64: dts: imx8mn-evk: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Krzysztof Kozlowski
` (3 preceding siblings ...)
2020-09-27 16:59 ` [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: " Krzysztof Kozlowski
@ 2020-09-27 16:59 ` Krzysztof Kozlowski
2020-10-30 0:26 ` [PATCH 1/6] arm64: dts: imx8mm-var-som: " Shawn Guo
5 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-27 16:59 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Adam Ford, Daniel Baluta,
Anson Huang, Peter Chen, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
The PMIC's interrupt is level low and should be pulled up. The PMIC's
device node had pinctrl-0 property but it lacked pinctrl-names which
is required to apply the pin configuration.
Fixes: 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")
Fixes: 6386156eb279 ("arm64: dts: imx8mn-evk: add pca9450 for i.mx8mn-evk board")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
index 707d8486b4d8..8311b95dee49 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
@@ -18,6 +18,7 @@
pmic: pmic@25 {
compatible = "nxp,pca9450b";
reg = <0x25>;
+ pinctrl-names = "default";
pinctrl-0 = <&pinctrl_pmic>;
interrupt-parent = <&gpio1>;
interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up
2020-09-27 16:59 [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Krzysztof Kozlowski
` (4 preceding siblings ...)
2020-09-27 16:59 ` [PATCH 6/6] arm64: dts: imx8mn-evk: " Krzysztof Kozlowski
@ 2020-10-30 0:26 ` Shawn Guo
5 siblings, 0 replies; 13+ messages in thread
From: Shawn Guo @ 2020-10-30 0:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Adam Ford, Daniel Baluta,
Anson Huang, Peter Chen, devicetree, linux-arm-kernel,
linux-kernel
On Sun, Sep 27, 2020 at 06:59:42PM +0200, Krzysztof Kozlowski wrote:
> The PMIC's interrupt is level low and should be pulled up. The PMIC's
> device node had pinctrl-0 property but it lacked pinctrl-names which
> is required to apply the pin configuration. The actual problem in DTS
> was pointed out by Felix Radensky from Variscite.
>
> Reported-by: Felix Radensky <felix.r@variscite.com>
> Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied all, thanks.
^ permalink raw reply [flat|nested] 13+ messages in thread