* [PATCH] arm64: dts: marvell: espressobin: Add support for LED2
@ 2020-10-06 12:44 Pali Rohár
2020-10-19 8:04 ` Pali Rohár
2020-11-29 11:11 ` Gregory CLEMENT
0 siblings, 2 replies; 7+ messages in thread
From: Pali Rohár @ 2020-10-06 12:44 UTC (permalink / raw)
To: Gregory CLEMENT, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Andre Heider,
Gérald Kerma
Cc: devicetree, linux-kernel
LED2 is connected to MPP1_2 pin. It is working only on V7 boards.
V5 boards have hw bug which cause that LED2 is non-working.
So enable LED2 only for Espressobin V7 boards.
Note that LED1 is connected to LED_WLAN# pin on miniPCIe card and LED3 to
power supply. Therefore on Espressobin board only LED2 can be controlled
directly from the host. LED1 is possible to control via WiFi card inserted
in miniPCIe slot if driver for particular card supports it.
Signed-off-by: Pali Rohár <pali@kernel.org>
Tested-by: Gérald Kerma <gerald@gk2.net>
---
Previous version of this patch was sent by Uwe in March 2018, but it did
not work on any tested V5 board. Now we know it was due to V5 HW bug.
https://lore.kernel.org/linux-arm-kernel/20180321105005.18426-3-u.kleine-koenig@pengutronix.de/
---
.../dts/marvell/armada-3720-espressobin-v7-emmc.dts | 4 ++++
.../boot/dts/marvell/armada-3720-espressobin-v7.dts | 4 ++++
.../boot/dts/marvell/armada-3720-espressobin.dtsi | 13 +++++++++++++
3 files changed, 21 insertions(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
index 4775a7eda481..75401eab4d42 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
@@ -39,3 +39,7 @@
&sdhci0 {
status = "okay";
};
+
+&led2 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
index c47a93978386..48a7f50fb427 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
@@ -34,3 +34,7 @@
&switch0port3 {
label = "wan";
};
+
+&led2 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
index 8a1c678bea5f..daffe136c523 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
@@ -41,6 +41,19 @@
3300000 0x0>;
enable-active-high;
};
+
+ led2: gpio-led2 {
+ /* led2 is working only on v7 board */
+ status = "disabled";
+
+ compatible = "gpio-leds";
+
+ led2 {
+ label = "led2";
+ gpios = <&gpionb 2 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ };
};
/* J9 */
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2
2020-10-06 12:44 [PATCH] arm64: dts: marvell: espressobin: Add support for LED2 Pali Rohár
@ 2020-10-19 8:04 ` Pali Rohár
2020-10-19 12:25 ` Andrew Lunn
2020-10-21 15:01 ` Andre Heider
2020-11-29 11:11 ` Gregory CLEMENT
1 sibling, 2 replies; 7+ messages in thread
From: Pali Rohár @ 2020-10-19 8:04 UTC (permalink / raw)
To: Gregory CLEMENT, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Andre Heider,
Gérald Kerma
Cc: devicetree, linux-kernel
Hello! Gregory, I would like to remind you following patch.
Andre, if you have a time, could you test it too?
On Tuesday 06 October 2020 14:44:55 Pali Rohár wrote:
> LED2 is connected to MPP1_2 pin. It is working only on V7 boards.
> V5 boards have hw bug which cause that LED2 is non-working.
>
> So enable LED2 only for Espressobin V7 boards.
>
> Note that LED1 is connected to LED_WLAN# pin on miniPCIe card and LED3 to
> power supply. Therefore on Espressobin board only LED2 can be controlled
> directly from the host. LED1 is possible to control via WiFi card inserted
> in miniPCIe slot if driver for particular card supports it.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Tested-by: Gérald Kerma <gerald@gk2.net>
>
> ---
>
> Previous version of this patch was sent by Uwe in March 2018, but it did
> not work on any tested V5 board. Now we know it was due to V5 HW bug.
>
> https://lore.kernel.org/linux-arm-kernel/20180321105005.18426-3-u.kleine-koenig@pengutronix.de/
> ---
> .../dts/marvell/armada-3720-espressobin-v7-emmc.dts | 4 ++++
> .../boot/dts/marvell/armada-3720-espressobin-v7.dts | 4 ++++
> .../boot/dts/marvell/armada-3720-espressobin.dtsi | 13 +++++++++++++
> 3 files changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> index 4775a7eda481..75401eab4d42 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> @@ -39,3 +39,7 @@
> &sdhci0 {
> status = "okay";
> };
> +
> +&led2 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> index c47a93978386..48a7f50fb427 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> @@ -34,3 +34,7 @@
> &switch0port3 {
> label = "wan";
> };
> +
> +&led2 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index 8a1c678bea5f..daffe136c523 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -41,6 +41,19 @@
> 3300000 0x0>;
> enable-active-high;
> };
> +
> + led2: gpio-led2 {
> + /* led2 is working only on v7 board */
> + status = "disabled";
> +
> + compatible = "gpio-leds";
> +
> + led2 {
> + label = "led2";
> + gpios = <&gpionb 2 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> };
>
> /* J9 */
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2
2020-10-19 8:04 ` Pali Rohár
@ 2020-10-19 12:25 ` Andrew Lunn
2020-11-13 10:24 ` Pali Rohár
2020-10-21 15:01 ` Andre Heider
1 sibling, 1 reply; 7+ messages in thread
From: Andrew Lunn @ 2020-10-19 12:25 UTC (permalink / raw)
To: Pali Rohár
Cc: Gregory CLEMENT, Jason Cooper, Sebastian Hesselbarth,
Rob Herring, Andre Heider, Gérald Kerma, devicetree,
linux-kernel
On Mon, Oct 19, 2020 at 10:04:08AM +0200, Pali Rohár wrote:
> Hello! Gregory, I would like to remind you following patch.
Hi Pali
Since the merge window is open at the moment, no new patches will be
accepted until it closes.
You should resend once -rc1 is out.
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2
2020-10-19 12:25 ` Andrew Lunn
@ 2020-11-13 10:24 ` Pali Rohár
0 siblings, 0 replies; 7+ messages in thread
From: Pali Rohár @ 2020-11-13 10:24 UTC (permalink / raw)
To: Andrew Lunn
Cc: Gregory CLEMENT, Jason Cooper, Sebastian Hesselbarth,
Rob Herring, Andre Heider, Gérald Kerma, devicetree,
linux-kernel
On Monday 19 October 2020 14:25:37 Andrew Lunn wrote:
> On Mon, Oct 19, 2020 at 10:04:08AM +0200, Pali Rohár wrote:
> > Hello! Gregory, I would like to remind you following patch.
>
> Hi Pali
>
> Since the merge window is open at the moment, no new patches will be
> accepted until it closes.
>
> You should resend once -rc1 is out.
Hello! -rc1 was already released. And as there are no new changes in
https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/
repository since I sent this patch, I guess that I resending it not
needed.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2
2020-10-19 8:04 ` Pali Rohár
2020-10-19 12:25 ` Andrew Lunn
@ 2020-10-21 15:01 ` Andre Heider
2020-10-21 16:15 ` Pali Rohár
1 sibling, 1 reply; 7+ messages in thread
From: Andre Heider @ 2020-10-21 15:01 UTC (permalink / raw)
To: Pali Rohár, Gregory CLEMENT, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Gérald Kerma
Cc: devicetree, linux-kernel
On 19/10/2020 10:04, Pali Rohár wrote:
> Hello! Gregory, I would like to remind you following patch.
>
> Andre, if you have a time, could you test it too?
I would, but I desoldered all LEDs a long time ago because they're way
too bright...
Regards,
Andre
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2
2020-10-21 15:01 ` Andre Heider
@ 2020-10-21 16:15 ` Pali Rohár
0 siblings, 0 replies; 7+ messages in thread
From: Pali Rohár @ 2020-10-21 16:15 UTC (permalink / raw)
To: Andre Heider
Cc: Gregory CLEMENT, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Gérald Kerma,
devicetree, linux-kernel
On Wednesday 21 October 2020 17:01:19 Andre Heider wrote:
> On 19/10/2020 10:04, Pali Rohár wrote:
> > Hello! Gregory, I would like to remind you following patch.
> >
> > Andre, if you have a time, could you test it too?
>
> I would, but I desoldered all LEDs a long time ago because they're way too
> bright...
No, problem, on V5 is needed just to check that led2 is not exported in sysfs.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2
2020-10-06 12:44 [PATCH] arm64: dts: marvell: espressobin: Add support for LED2 Pali Rohár
2020-10-19 8:04 ` Pali Rohár
@ 2020-11-29 11:11 ` Gregory CLEMENT
1 sibling, 0 replies; 7+ messages in thread
From: Gregory CLEMENT @ 2020-11-29 11:11 UTC (permalink / raw)
To: Pali Rohár, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Rob Herring, Andre Heider,
Gérald Kerma
Cc: devicetree, linux-kernel
Hi Pali,
> LED2 is connected to MPP1_2 pin. It is working only on V7 boards.
> V5 boards have hw bug which cause that LED2 is non-working.
>
> So enable LED2 only for Espressobin V7 boards.
>
> Note that LED1 is connected to LED_WLAN# pin on miniPCIe card and LED3 to
> power supply. Therefore on Espressobin board only LED2 can be controlled
> directly from the host. LED1 is possible to control via WiFi card inserted
> in miniPCIe slot if driver for particular card supports it.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Tested-by: Gérald Kerma <gerald@gk2.net>
Applied on mvebu/dt64
Thanks,
Gregory
>
> ---
>
> Previous version of this patch was sent by Uwe in March 2018, but it did
> not work on any tested V5 board. Now we know it was due to V5 HW bug.
>
> https://lore.kernel.org/linux-arm-kernel/20180321105005.18426-3-u.kleine-koenig@pengutronix.de/
> ---
> .../dts/marvell/armada-3720-espressobin-v7-emmc.dts | 4 ++++
> .../boot/dts/marvell/armada-3720-espressobin-v7.dts | 4 ++++
> .../boot/dts/marvell/armada-3720-espressobin.dtsi | 13 +++++++++++++
> 3 files changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> index 4775a7eda481..75401eab4d42 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts
> @@ -39,3 +39,7 @@
> &sdhci0 {
> status = "okay";
> };
> +
> +&led2 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> index c47a93978386..48a7f50fb427 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts
> @@ -34,3 +34,7 @@
> &switch0port3 {
> label = "wan";
> };
> +
> +&led2 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> index 8a1c678bea5f..daffe136c523 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi
> @@ -41,6 +41,19 @@
> 3300000 0x0>;
> enable-active-high;
> };
> +
> + led2: gpio-led2 {
> + /* led2 is working only on v7 board */
> + status = "disabled";
> +
> + compatible = "gpio-leds";
> +
> + led2 {
> + label = "led2";
> + gpios = <&gpionb 2 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> + };
> };
>
> /* J9 */
> --
> 2.20.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-29 11:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 12:44 [PATCH] arm64: dts: marvell: espressobin: Add support for LED2 Pali Rohár
2020-10-19 8:04 ` Pali Rohár
2020-10-19 12:25 ` Andrew Lunn
2020-11-13 10:24 ` Pali Rohár
2020-10-21 15:01 ` Andre Heider
2020-10-21 16:15 ` Pali Rohár
2020-11-29 11:11 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).