* [PATCH 0/2] Two apcs-kpss-global.yaml fixes @ 2022-06-30 4:35 Bryan O'Donoghue 2022-06-30 4:35 ` [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries Bryan O'Donoghue 2022-06-30 4:35 ` [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names Bryan O'Donoghue 0 siblings, 2 replies; 8+ messages in thread From: Bryan O'Donoghue @ 2022-06-30 4:35 UTC (permalink / raw) To: agross, bjorn.andersson, jassisinghbrar, robh+dt, krzysztof.kozlowski+dt Cc: linux-arm-msm, devicetree, bryan.odonoghue Adding in msm8939.dtsi and running the binding checks is throwing up two errors for me. In the first instance we use syscon on the 8939 and should declare it in the compat list. Doing a quick grep it looks like that fix should be applied to a number of existing declarations too. In the second instance we just need to document clock-output-names for the a53 mux PLL. Bryan O'Donoghue (2): dt-bindings: mailbox: qcom: Add syscon const for relevant entries dt-bindings: mailbox: qcom: Add clock-output-names .../mailbox/qcom,apcs-kpss-global.yaml | 49 +++++++++++-------- 1 file changed, 29 insertions(+), 20 deletions(-) -- 2.36.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries 2022-06-30 4:35 [PATCH 0/2] Two apcs-kpss-global.yaml fixes Bryan O'Donoghue @ 2022-06-30 4:35 ` Bryan O'Donoghue 2022-06-30 13:44 ` Rob Herring 2022-06-30 18:37 ` Krzysztof Kozlowski 2022-06-30 4:35 ` [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names Bryan O'Donoghue 1 sibling, 2 replies; 8+ messages in thread From: Bryan O'Donoghue @ 2022-06-30 4:35 UTC (permalink / raw) To: agross, bjorn.andersson, jassisinghbrar, robh+dt, krzysztof.kozlowski+dt Cc: linux-arm-msm, devicetree, bryan.odonoghue msm8916, msm8939, msm8953, msm8994 and qcs404 already declare or should declare syscon as they have drivers that use syscon inside of the apcs-kpss block. grep apcs arch/arm64/boot/dts/qcom/* | grep syscon Add in the additional syscon in the documentation for the above mentioned parts. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../mailbox/qcom,apcs-kpss-global.yaml | 44 ++++++++++--------- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 3b5ba7ecc19d9..f342494fd6108 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -15,26 +15,30 @@ maintainers: properties: compatible: - enum: - - qcom,ipq6018-apcs-apps-global - - qcom,ipq8074-apcs-apps-global - - qcom,msm8916-apcs-kpss-global - - qcom,msm8939-apcs-kpss-global - - qcom,msm8953-apcs-kpss-global - - qcom,msm8976-apcs-kpss-global - - qcom,msm8994-apcs-kpss-global - - qcom,msm8996-apcs-hmss-global - - qcom,msm8998-apcs-hmss-global - - qcom,qcm2290-apcs-hmss-global - - qcom,qcs404-apcs-apps-global - - qcom,sc7180-apss-shared - - qcom,sc8180x-apss-shared - - qcom,sdm660-apcs-hmss-global - - qcom,sdm845-apss-shared - - qcom,sm6125-apcs-hmss-global - - qcom,sm6115-apcs-hmss-global - - qcom,sm8150-apss-shared - + oneOf: + - items: + - enum: + - qcom,ipq6018-apcs-apps-global + - qcom,ipq8074-apcs-apps-global + - qcom,msm8976-apcs-kpss-global + - qcom,msm8996-apcs-hmss-global + - qcom,msm8998-apcs-hmss-global + - qcom,qcm2290-apcs-hmss-global + - qcom,sc7180-apss-shared + - qcom,sc8180x-apss-shared + - qcom,sdm660-apcs-hmss-global + - qcom,sdm845-apss-shared + - qcom,sm6125-apcs-hmss-global + - qcom,sm6115-apcs-hmss-global + - qcom,sm8150-apss-shared + - items: + - enum: + - qcom,msm8916-apcs-kpss-global + - qcom,msm8939-apcs-kpss-global + - qcom,msm8953-apcs-kpss-global + - qcom,msm8994-apcs-kpss-global + - qcom,qcs404-apcs-apps-global + - const: syscon reg: maxItems: 1 -- 2.36.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries 2022-06-30 4:35 ` [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries Bryan O'Donoghue @ 2022-06-30 13:44 ` Rob Herring 2022-06-30 13:51 ` Bryan O'Donoghue 2022-06-30 18:37 ` Krzysztof Kozlowski 1 sibling, 1 reply; 8+ messages in thread From: Rob Herring @ 2022-06-30 13:44 UTC (permalink / raw) To: Bryan O'Donoghue Cc: bjorn.andersson, agross, devicetree, krzysztof.kozlowski+dt, robh+dt, jassisinghbrar, linux-arm-msm On Thu, 30 Jun 2022 05:35:35 +0100, Bryan O'Donoghue wrote: > msm8916, msm8939, msm8953, msm8994 and qcs404 already declare or should > declare syscon as they have drivers that use syscon inside of the apcs-kpss > block. > > grep apcs arch/arm64/boot/dts/qcom/* | grep syscon > > Add in the additional syscon in the documentation for the above mentioned > parts. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../mailbox/qcom,apcs-kpss-global.yaml | 44 ++++++++++--------- > 1 file changed, 24 insertions(+), 20 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.example.dtb: mailbox@b011000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,qcs404-apcs-apps-global'] is too short 'qcom,qcs404-apcs-apps-global' is not one of ['qcom,ipq6018-apcs-apps-global', 'qcom,ipq8074-apcs-apps-global', 'qcom,msm8976-apcs-kpss-global', 'qcom,msm8996-apcs-hmss-global', 'qcom,msm8998-apcs-hmss-global', 'qcom,qcm2290-apcs-hmss-global', 'qcom,sc7180-apss-shared', 'qcom,sc8180x-apss-shared', 'qcom,sdm660-apcs-hmss-global', 'qcom,sdm845-apss-shared', 'qcom,sm6125-apcs-hmss-global', 'qcom,sm6115-apcs-hmss-global', 'qcom,sm8150-apss-shared'] From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries 2022-06-30 13:44 ` Rob Herring @ 2022-06-30 13:51 ` Bryan O'Donoghue 0 siblings, 0 replies; 8+ messages in thread From: Bryan O'Donoghue @ 2022-06-30 13:51 UTC (permalink / raw) To: Rob Herring, Bryan O'Donoghue Cc: bjorn.andersson, agross, devicetree, krzysztof.kozlowski+dt, robh+dt, jassisinghbrar, linux-arm-msm On 30/06/2022 14:44, Rob Herring wrote: > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.example.dtb: mailbox@b011000: compatible: 'oneOf' conditional failed, one must be fixed: > ['qcom,qcs404-apcs-apps-global'] is too short ah... the example will fix --- bod ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries 2022-06-30 4:35 ` [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries Bryan O'Donoghue 2022-06-30 13:44 ` Rob Herring @ 2022-06-30 18:37 ` Krzysztof Kozlowski 1 sibling, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-06-30 18:37 UTC (permalink / raw) To: Bryan O'Donoghue, agross, bjorn.andersson, jassisinghbrar, robh+dt, krzysztof.kozlowski+dt Cc: linux-arm-msm, devicetree On 30/06/2022 06:35, Bryan O'Donoghue wrote: > msm8916, msm8939, msm8953, msm8994 and qcs404 already declare or should > declare syscon as they have drivers that use syscon inside of the apcs-kpss > block. > > grep apcs arch/arm64/boot/dts/qcom/* | grep syscon > > Add in the additional syscon in the documentation for the above mentioned > parts. Subject should have prefix: dt-bindings: mailbox: qcom,apcs-kpss-global: > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../mailbox/qcom,apcs-kpss-global.yaml | 44 ++++++++++--------- > 1 file changed, 24 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 3b5ba7ecc19d9..f342494fd6108 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -15,26 +15,30 @@ maintainers: > > properties: > compatible: > - enum: > - - qcom,ipq6018-apcs-apps-global > - - qcom,ipq8074-apcs-apps-global > - - qcom,msm8916-apcs-kpss-global > - - qcom,msm8939-apcs-kpss-global > - - qcom,msm8953-apcs-kpss-global > - - qcom,msm8976-apcs-kpss-global > - - qcom,msm8994-apcs-kpss-global > - - qcom,msm8996-apcs-hmss-global > - - qcom,msm8998-apcs-hmss-global > - - qcom,qcm2290-apcs-hmss-global > - - qcom,qcs404-apcs-apps-global > - - qcom,sc7180-apss-shared > - - qcom,sc8180x-apss-shared > - - qcom,sdm660-apcs-hmss-global > - - qcom,sdm845-apss-shared > - - qcom,sm6125-apcs-hmss-global > - - qcom,sm6115-apcs-hmss-global > - - qcom,sm8150-apss-shared > - > + oneOf: > + - items: > + - enum: > + - qcom,ipq6018-apcs-apps-global > + - qcom,ipq8074-apcs-apps-global > + - qcom,msm8976-apcs-kpss-global > + - qcom,msm8996-apcs-hmss-global > + - qcom,msm8998-apcs-hmss-global > + - qcom,qcm2290-apcs-hmss-global > + - qcom,sc7180-apss-shared > + - qcom,sc8180x-apss-shared > + - qcom,sdm660-apcs-hmss-global > + - qcom,sdm845-apss-shared > + - qcom,sm6125-apcs-hmss-global > + - qcom,sm6115-apcs-hmss-global > + - qcom,sm8150-apss-shared These are not items, but one item, so enum directly under oneOf. > + - items: > + - enum: > + - qcom,msm8916-apcs-kpss-global > + - qcom,msm8939-apcs-kpss-global > + - qcom,msm8953-apcs-kpss-global > + - qcom,msm8994-apcs-kpss-global > + - qcom,qcs404-apcs-apps-global > + - const: syscon > reg: > maxItems: 1 > Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names 2022-06-30 4:35 [PATCH 0/2] Two apcs-kpss-global.yaml fixes Bryan O'Donoghue 2022-06-30 4:35 ` [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries Bryan O'Donoghue @ 2022-06-30 4:35 ` Bryan O'Donoghue 2022-06-30 13:44 ` Rob Herring 2022-06-30 18:38 ` Krzysztof Kozlowski 1 sibling, 2 replies; 8+ messages in thread From: Bryan O'Donoghue @ 2022-06-30 4:35 UTC (permalink / raw) To: agross, bjorn.andersson, jassisinghbrar, robh+dt, krzysztof.kozlowski+dt Cc: linux-arm-msm, devicetree, bryan.odonoghue Add clock-output-names as optional so that SoCs such as the msm8939 which have multiple a53 PLLs can latch the appropriate output name in drivers/clk/qcom/apcs-msm8916.c. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index f342494fd6108..7f3816cbc0353 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -63,6 +63,11 @@ properties: - const: aux - const: ref + clock-output-names: + Usage: optional + Value type: <string> + Definition: Name of the output clock. + required: - compatible - reg -- 2.36.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names 2022-06-30 4:35 ` [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names Bryan O'Donoghue @ 2022-06-30 13:44 ` Rob Herring 2022-06-30 18:38 ` Krzysztof Kozlowski 1 sibling, 0 replies; 8+ messages in thread From: Rob Herring @ 2022-06-30 13:44 UTC (permalink / raw) To: Bryan O'Donoghue Cc: jassisinghbrar, agross, krzysztof.kozlowski+dt, bjorn.andersson, robh+dt, linux-arm-msm, devicetree On Thu, 30 Jun 2022 05:35:36 +0100, Bryan O'Donoghue wrote: > Add clock-output-names as optional so that SoCs such as the msm8939 which > have multiple a53 PLLs can latch the appropriate output name in > drivers/clk/qcom/apcs-msm8916.c. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml: properties:clock-output-names: 'Usage' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml: properties:clock-output-names: 'Value type' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml: properties:clock-output-names: 'Definition' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml: properties:clock-output-names: Additional properties are not allowed ('Definition', 'Usage', 'Value type' were unexpected) from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml: ignoring, error in schema: properties: clock-output-names Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.example.dtb:0:0: /example-0/mailbox@9820000: failed to match any schema with compatible: ['qcom,msm8996-apcs-hmss-global'] Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.example.dtb:0:0: /example-1/mailbox@b011000: failed to match any schema with compatible: ['qcom,qcs404-apcs-apps-global'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names 2022-06-30 4:35 ` [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names Bryan O'Donoghue 2022-06-30 13:44 ` Rob Herring @ 2022-06-30 18:38 ` Krzysztof Kozlowski 1 sibling, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-06-30 18:38 UTC (permalink / raw) To: Bryan O'Donoghue, agross, bjorn.andersson, jassisinghbrar, robh+dt, krzysztof.kozlowski+dt Cc: linux-arm-msm, devicetree On 30/06/2022 06:35, Bryan O'Donoghue wrote: > Add clock-output-names as optional so that SoCs such as the msm8939 which > have multiple a53 PLLs can latch the appropriate output name in > drivers/clk/qcom/apcs-msm8916.c. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index f342494fd6108..7f3816cbc0353 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -63,6 +63,11 @@ properties: > - const: aux > - const: ref > > + clock-output-names: > + Usage: optional > + Value type: <string> > + Definition: Name of the output clock. > + Not a proper DT schema syntax. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-06-30 18:38 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-06-30 4:35 [PATCH 0/2] Two apcs-kpss-global.yaml fixes Bryan O'Donoghue 2022-06-30 4:35 ` [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries Bryan O'Donoghue 2022-06-30 13:44 ` Rob Herring 2022-06-30 13:51 ` Bryan O'Donoghue 2022-06-30 18:37 ` Krzysztof Kozlowski 2022-06-30 4:35 ` [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names Bryan O'Donoghue 2022-06-30 13:44 ` Rob Herring 2022-06-30 18:38 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).