* [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml
@ 2020-12-03 19:13 Dmitry Baryshkov
2020-12-03 19:13 ` [PATCH 2/2] arm64: dts: qcom: sm8250: rename smem device node to follow schema Dmitry Baryshkov
2020-12-04 0:32 ` [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2020-12-03 19:13 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring; +Cc: linux-arm-msm, devicetree
Convert soc/qcom/qcom,smem.txt bindings to YAML format.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/soc/qcom/qcom,smem.txt | 57 --------------
.../bindings/soc/qcom/qcom,smem.yaml | 74 +++++++++++++++++++
2 files changed, 74 insertions(+), 57 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
deleted file mode 100644
index 9326cdf6e1b1..000000000000
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
+++ /dev/null
@@ -1,57 +0,0 @@
-Qualcomm Shared Memory Manager binding
-
-This binding describes the Qualcomm Shared Memory Manager, used to share data
-between various subsystems and OSes in Qualcomm platforms.
-
-- compatible:
- Usage: required
- Value type: <stringlist>
- Definition: must be:
- "qcom,smem"
-
-- memory-region:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: handle to memory reservation for main SMEM memory region.
-
-- qcom,rpm-msg-ram:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: handle to RPM message memory resource
-
-- hwlocks:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: reference to a hwspinlock used to protect allocations from
- the shared memory
-
-= EXAMPLE
-The following example shows the SMEM setup for MSM8974, with a main SMEM region
-at 0xfa00000 and the RPM message ram at 0xfc428000:
-
- reserved-memory {
- #address-cells = <1>;
- #size-cells = <1>;
- ranges;
-
- smem_region: smem@fa00000 {
- reg = <0xfa00000 0x200000>;
- no-map;
- };
- };
-
- smem@fa00000 {
- compatible = "qcom,smem";
-
- memory-region = <&smem_region>;
- qcom,rpm-msg-ram = <&rpm_msg_ram>;
-
- hwlocks = <&tcsr_mutex 3>;
- };
-
- soc {
- rpm_msg_ram: memory@fc428000 {
- compatible = "qcom,rpm-msg-ram";
- reg = <0xfc428000 0x4000>;
- };
- };
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
new file mode 100644
index 000000000000..1ddeb25cbdc1
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,smem.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Shared Memory Manager binding
+
+maintainers:
+ - Andy Gross <agross@kernel.org>
+ - Bjorn Andersson <bjorn.andersson@linaro.org>
+
+description: |
+ This binding describes the Qualcomm Shared Memory Manager, used to share data
+ between various subsystems and OSes in Qualcomm platforms.
+
+properties:
+ compatible:
+ enum:
+ - "qcom-smem"
+
+ memory-region:
+ maxItems: 1
+ description: handle to memory reservation for main SMEM memory region.
+
+ hwlocks:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: reference to a hwspinlock used to protect allocations from the shared memory
+
+ qcom,rpm-msg-ram:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: handle to RPM message memory resource
+
+required:
+ - compatible
+ - memory-region
+ - hwlocks
+
+additionalProperties: false
+
+examples:
+ - |
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ smem_region: smem@fa00000 {
+ reg = <0xfa00000 0x200000>;
+ no-map;
+ };
+ };
+
+ smem {
+ compatible = "qcom,smem";
+
+ memory-region = <&smem_region>;
+ qcom,rpm-msg-ram = <&rpm_msg_ram>;
+
+ hwlocks = <&tcsr_mutex 3>;
+ };
+
+ soc {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ rpm_msg_ram: memory@fc428000 {
+ compatible = "qcom,rpm-msg-ram";
+ reg = <0xfc428000 0x4000>;
+ };
+ };
+
+...
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sm8250: rename smem device node to follow schema
2020-12-03 19:13 [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Dmitry Baryshkov
@ 2020-12-03 19:13 ` Dmitry Baryshkov
2020-12-04 0:33 ` Bjorn Andersson
2020-12-04 0:32 ` [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2020-12-03 19:13 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring; +Cc: linux-arm-msm, devicetree
Rename 'qcom,smem' to just 'smem' to follow the rest of SoC (and device
schema).
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 4c472db2738e..bdd9bd303415 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -334,7 +334,7 @@ cdsp_secure_heap: memory@8bf00000 {
};
};
- smem: qcom,smem {
+ smem {
compatible = "qcom,smem";
memory-region = <&smem_mem>;
hwlocks = <&tcsr_mutex 3>;
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml
2020-12-03 19:13 [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Dmitry Baryshkov
2020-12-03 19:13 ` [PATCH 2/2] arm64: dts: qcom: sm8250: rename smem device node to follow schema Dmitry Baryshkov
@ 2020-12-04 0:32 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-12-04 0:32 UTC (permalink / raw)
To: Dmitry Baryshkov; +Cc: Andy Gross, Rob Herring, linux-arm-msm, devicetree
On Thu 03 Dec 13:13 CST 2020, Dmitry Baryshkov wrote:
[..]
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
> new file mode 100644
> index 000000000000..1ddeb25cbdc1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/qcom/qcom,smem.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm Shared Memory Manager binding
> +
> +maintainers:
> + - Andy Gross <agross@kernel.org>
> + - Bjorn Andersson <bjorn.andersson@linaro.org>
> +
> +description: |
> + This binding describes the Qualcomm Shared Memory Manager, used to share data
> + between various subsystems and OSes in Qualcomm platforms.
> +
> +properties:
> + compatible:
y/-/,/ in that compatible, and we only have one. So I think you should
instead do:
const: "qcom,smem"
Apart from that I think the binding looks good.
Regards,
Bjorn
> + enum:
> + - "qcom-smem"
> +
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8250: rename smem device node to follow schema
2020-12-03 19:13 ` [PATCH 2/2] arm64: dts: qcom: sm8250: rename smem device node to follow schema Dmitry Baryshkov
@ 2020-12-04 0:33 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2020-12-04 0:33 UTC (permalink / raw)
To: Dmitry Baryshkov; +Cc: Andy Gross, Rob Herring, linux-arm-msm, devicetree
On Thu 03 Dec 13:13 CST 2020, Dmitry Baryshkov wrote:
> Rename 'qcom,smem' to just 'smem' to follow the rest of SoC (and device
> schema).
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Applied, no need to include in v2.
Thanks,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 4c472db2738e..bdd9bd303415 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -334,7 +334,7 @@ cdsp_secure_heap: memory@8bf00000 {
> };
> };
>
> - smem: qcom,smem {
> + smem {
> compatible = "qcom,smem";
> memory-region = <&smem_mem>;
> hwlocks = <&tcsr_mutex 3>;
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-04 0:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 19:13 [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Dmitry Baryshkov
2020-12-03 19:13 ` [PATCH 2/2] arm64: dts: qcom: sm8250: rename smem device node to follow schema Dmitry Baryshkov
2020-12-04 0:33 ` Bjorn Andersson
2020-12-04 0:32 ` [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).