linux-edac.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	James Morse <james.morse@arm.com>,
	Robert Richter <rric@kernel.org>
Subject: Re: [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed
Date: Tue, 15 Jun 2021 17:18:50 +0200	[thread overview]
Message-ID: <YMjE2iwRFWVrfzLL@zn.tnic> (raw)
In-Reply-To: <20210615150846.GA409@aus-x-yghannam.amd.com>

On Tue, Jun 15, 2021 at 11:08:46AM -0400, Yazen Ghannam wrote:
> How about adding the the SMCA feature to the amd64_cpuids[] table in
> amd64_edac.c?
> 
> We can use X86_MATCH_VENDOR_FEATURE to match on AMD (and Hygon) systems
> with SMCA. And we can remove the X86_MATCH_VENDOR_FAM entries for
> families 17h-19h.

Sure. That'll alleviate the need to add new families which support SMCA
too.

> I'm assuming the issue is that amd64_edac_mod is autoloading due to the
> family-based device table, and this will load edac_mce_amd as a
> dependency.

Is it?

We have

early_initcall(mce_amd_init);

in mce_amd.c which attempts to load this thing unconditionally.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2021-06-15 15:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 21:21 Smita Koralahalli
2021-06-14 22:01 ` Borislav Petkov
2021-06-14 22:25   ` Luck, Tony
2021-06-15  9:16     ` Borislav Petkov
2021-06-15 15:08       ` Yazen Ghannam
2021-06-15 15:18         ` Borislav Petkov [this message]
2021-06-15 16:00           ` Yazen Ghannam
2021-06-15 16:11             ` Borislav Petkov
2021-06-15 16:32               ` Yazen Ghannam
2021-06-15 16:45                 ` [PATCH] EDAC/Intel: Do not load EDAC driver when running as a guest Luck, Tony
2021-06-15 17:00                   ` Borislav Petkov
2021-06-15 17:44                     ` [PATCH v2] " Luck, Tony
2021-06-15 17:25                 ` [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMjE2iwRFWVrfzLL@zn.tnic \
    --to=bp@alien8.de \
    --cc=Smita.KoralahalliChannabasappa@amd.com \
    --cc=james.morse@arm.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rric@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    --subject='Re: [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).