* Re: [f2fs-dev] [GIT PULL] f2fs for 5.6-rc6 [not found] <20200311162735.GA152176@google.com> @ 2020-03-11 17:20 ` Linus Torvalds 2020-03-11 17:35 ` Jaegeuk Kim 2020-04-07 21:05 ` pr-tracker-bot 1 sibling, 1 reply; 5+ messages in thread From: Linus Torvalds @ 2020-03-11 17:20 UTC (permalink / raw) To: Jaegeuk Kim; +Cc: Linux Kernel Mailing List, Linux F2FS Dev Mailing List On Wed, Mar 11, 2020 at 9:27 AM Jaegeuk Kim <jaegeuk@kernel.org> wrote: > > Sorry for late pull request. Could you please consider this? I pulled this, and then immediately unpulled. Most (all?) of the commits have been committed basically minutes before you sent the pull request. That's simply not acceptable. Not when we're in late rc, and with hundreds of lines of changes, and when there is no explanation for a late pull request that was very very recently generated. Linus _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [GIT PULL] f2fs for 5.6-rc6 2020-03-11 17:20 ` [f2fs-dev] [GIT PULL] f2fs for 5.6-rc6 Linus Torvalds @ 2020-03-11 17:35 ` Jaegeuk Kim 2020-03-11 17:41 ` Linus Torvalds 0 siblings, 1 reply; 5+ messages in thread From: Jaegeuk Kim @ 2020-03-11 17:35 UTC (permalink / raw) To: Linus Torvalds; +Cc: Linux Kernel Mailing List, Linux F2FS Dev Mailing List On 03/11, Linus Torvalds wrote: > On Wed, Mar 11, 2020 at 9:27 AM Jaegeuk Kim <jaegeuk@kernel.org> wrote: > > > > Sorry for late pull request. Could you please consider this? > > I pulled this, and then immediately unpulled. > > Most (all?) of the commits have been committed basically minutes > before you sent the pull request. > > That's simply not acceptable. Not when we're in late rc, and with > hundreds of lines of changes, and when there is no explanation for a > late pull request that was very very recently generated. I actually merged the last three patches which were introduced yesterday. I thought that it'd be fine to pull in, since they are quite trivial several lines of code changes. Others were merged over a week ago, and I've tested in the mean time. It seems the commit times were modified as recent date, when I reorganized there-in commits aligned to other branch, dev-test. Probably, I had to keep the commit date in somehow. Thanks, > > Linus _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [GIT PULL] f2fs for 5.6-rc6 2020-03-11 17:35 ` Jaegeuk Kim @ 2020-03-11 17:41 ` Linus Torvalds 2020-03-11 17:48 ` Jaegeuk Kim 0 siblings, 1 reply; 5+ messages in thread From: Linus Torvalds @ 2020-03-11 17:41 UTC (permalink / raw) To: Jaegeuk Kim; +Cc: Linux Kernel Mailing List, Linux F2FS Dev Mailing List On Wed, Mar 11, 2020 at 10:35 AM Jaegeuk Kim <jaegeuk@kernel.org> wrote: > > I actually merged the last three patches which were introduced yesterday. > > Others were merged over a week ago. No, three were done just before you sent the pull request, and then seven others were done yesterday. Yes, the rest were a week ago. But basically, by rc6, I want to get the warm and fuzzies that the code has been tested, seen review, and isn't some last-minute addition. Linus _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [GIT PULL] f2fs for 5.6-rc6 2020-03-11 17:41 ` Linus Torvalds @ 2020-03-11 17:48 ` Jaegeuk Kim 0 siblings, 0 replies; 5+ messages in thread From: Jaegeuk Kim @ 2020-03-11 17:48 UTC (permalink / raw) To: Linus Torvalds; +Cc: Linux Kernel Mailing List, Linux F2FS Dev Mailing List On 03/11, Linus Torvalds wrote: > On Wed, Mar 11, 2020 at 10:35 AM Jaegeuk Kim <jaegeuk@kernel.org> wrote: > > > > I actually merged the last three patches which were introduced yesterday. > > > > Others were merged over a week ago. > > No, three were done just before you sent the pull request, and then > seven others were done yesterday. Due to my rebase work. :( > > Yes, the rest were a week ago. > > But basically, by rc6, I want to get the warm and fuzzies that the > code has been tested, seen review, and isn't some last-minute > addition. Ok, I see. Let me prepare them for next merge window. Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [GIT PULL] f2fs for 5.6-rc6 [not found] <20200311162735.GA152176@google.com> 2020-03-11 17:20 ` [f2fs-dev] [GIT PULL] f2fs for 5.6-rc6 Linus Torvalds @ 2020-04-07 21:05 ` pr-tracker-bot 1 sibling, 0 replies; 5+ messages in thread From: pr-tracker-bot @ 2020-04-07 21:05 UTC (permalink / raw) To: Jaegeuk Kim Cc: Linus Torvalds, Linux Kernel Mailing List, Linux F2FS Dev Mailing List The pull request you sent on Wed, 11 Mar 2020 09:27:35 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git tags/f2fs-for-5.6-rc6 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c6d5789bea5187c2716959f8954a1e00b8a7835d Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-07 21:05 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200311162735.GA152176@google.com> 2020-03-11 17:20 ` [f2fs-dev] [GIT PULL] f2fs for 5.6-rc6 Linus Torvalds 2020-03-11 17:35 ` Jaegeuk Kim 2020-03-11 17:41 ` Linus Torvalds 2020-03-11 17:48 ` Jaegeuk Kim 2020-04-07 21:05 ` pr-tracker-bot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).