[PATCH] vpdma: Move firmware to the toplevel

[PATCH] vpdma: Move firmware to the toplevel

[Nikhil Devshatwar]

Move the vpdma firmware to the toplevel directory so
that the existing drivers can use it with the same path.

Fixes: 5b30b383ce ("linux-firmware: Add new VPDMA firmware 1b8.bin")
Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
---
 WHENCE                                         |   2 +-
 ti-connectivity/vpdma-1b8.bin => vpdma-1b8.bin | Bin
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename ti-connectivity/vpdma-1b8.bin => vpdma-1b8.bin (100%)

diff --git a/WHENCE b/WHENCE
index 473f6fb..347593c 100644
--- a/WHENCE
+++ b/WHENCE
@@ -2705,7 +2705,7 @@ Licence: Redistributable. See LICENCE.tda7706-firmware.txt for details.
 
 Driver: ti-vpe - Texas Instruments V4L2 driver for Video Processing Engine
 
-File: ti-connectivity/vpdma-1b8.bin
+File: vpdma-1b8.bin
 
 Licence: Redistributable. See LICENCE.ti-tspa for details.
 
diff --git a/ti-connectivity/vpdma-1b8.bin b/vpdma-1b8.bin
similarity index 100%
rename from ti-connectivity/vpdma-1b8.bin
rename to vpdma-1b8.bin
-- 
2.17.1

Re: [PATCH] vpdma: Move firmware to the toplevel

[Laurent Pinchart]

Hi Nikhil,

Thank you for the patch.

On Tue, Oct 27, 2020 at 01:39:22AM +0530, Nikhil Devshatwar wrote:
> Move the vpdma firmware to the toplevel directory so
> that the existing drivers can use it with the same path.
> 
> Fixes: 5b30b383ce ("linux-firmware: Add new VPDMA firmware 1b8.bin")
> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> ---
>  WHENCE                                         |   2 +-
>  ti-connectivity/vpdma-1b8.bin => vpdma-1b8.bin | Bin

I think Tomi meant moving the file to ti/ instead of ti-connectivity/. I
will let him comment on this.

>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename ti-connectivity/vpdma-1b8.bin => vpdma-1b8.bin (100%)
> 
> diff --git a/WHENCE b/WHENCE
> index 473f6fb..347593c 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2705,7 +2705,7 @@ Licence: Redistributable. See LICENCE.tda7706-firmware.txt for details.
>  
>  Driver: ti-vpe - Texas Instruments V4L2 driver for Video Processing Engine
>  
> -File: ti-connectivity/vpdma-1b8.bin
> +File: vpdma-1b8.bin
>  
>  Licence: Redistributable. See LICENCE.ti-tspa for details.
>  
> diff --git a/ti-connectivity/vpdma-1b8.bin b/vpdma-1b8.bin
> similarity index 100%
> rename from ti-connectivity/vpdma-1b8.bin
> rename to vpdma-1b8.bin

-- 
Regards,

Laurent Pinchart

Re: [PATCH] vpdma: Move firmware to the toplevel

[Tomi Valkeinen]

On 26/10/2020 23:08, Laurent Pinchart wrote:
> Hi Nikhil,
> 
> Thank you for the patch.
> 
> On Tue, Oct 27, 2020 at 01:39:22AM +0530, Nikhil Devshatwar wrote:
>> Move the vpdma firmware to the toplevel directory so
>> that the existing drivers can use it with the same path.
>>
>> Fixes: 5b30b383ce ("linux-firmware: Add new VPDMA firmware 1b8.bin")
>> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
>> ---
>>  WHENCE                                         |   2 +-
>>  ti-connectivity/vpdma-1b8.bin => vpdma-1b8.bin | Bin
> 
> I think Tomi meant moving the file to ti/ instead of ti-connectivity/. I
> will let him comment on this.

I don't really have a strong opinion here, as I don't know if there are some rules or guidelines
about file/dir naming in linux-firmware.

But my argument is:

The fw should either be at the root dir, where the linux driver is already looking for it, OR, if we
do move it somewhere, move it to a "right" place. Afaics "ti-connectivity" is totally wrong place,
as vpdma has nothing to do with connectivity.

The root dir is a bit bad as "vpdma-1b8.bin" doesn't have TI or such in its name, so even if name
conflict with some other fw feels quite unlikely, the name is still rather vague. And moving is a
bit bad as then the current driver won't find the fw...

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [PATCH] vpdma: Move firmware to the toplevel

[Nikhil Devshatwar]

On 09:41-20201028, Tomi Valkeinen wrote:
> On 26/10/2020 23:08, Laurent Pinchart wrote:
> > Hi Nikhil,
> > 
> > Thank you for the patch.
> > 
> > On Tue, Oct 27, 2020 at 01:39:22AM +0530, Nikhil Devshatwar wrote:
> >> Move the vpdma firmware to the toplevel directory so
> >> that the existing drivers can use it with the same path.
> >>
> >> Fixes: 5b30b383ce ("linux-firmware: Add new VPDMA firmware 1b8.bin")
> >> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> >> ---
> >>  WHENCE                                         |   2 +-
> >>  ti-connectivity/vpdma-1b8.bin => vpdma-1b8.bin | Bin
> > 
> > I think Tomi meant moving the file to ti/ instead of ti-connectivity/. I
> > will let him comment on this.
> 
> I don't really have a strong opinion here, as I don't know if there are some rules or guidelines
> about file/dir naming in linux-firmware.
> 
> But my argument is:
> 
> The fw should either be at the root dir, where the linux driver is already looking for it, OR, if we
> do move it somewhere, move it to a "right" place. Afaics "ti-connectivity" is totally wrong place,
> as vpdma has nothing to do with connectivity.
> 
> The root dir is a bit bad as "vpdma-1b8.bin" doesn't have TI or such in its name, so even if name

With this, I am more inclined to put it in ti/ directory.

> conflict with some other fw feels quite unlikely, the name is still rather vague. And moving is a
> bit bad as then the current driver won't find the fw...

Since the current driver is not getting any firmware anyways, it should
be fine to move it and update the driver accordingly.
I will send v2 with the firmware moved to ti/

> 
>  Tomi
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki