From: Peter Robinson <firstname.lastname@example.org> To: Josh Boyer <email@example.com> Cc: Jeremy Linton <firstname.lastname@example.org>, Linux Firmware <email@example.com>, Hans de Goede <firstname.lastname@example.org> Subject: Re: [PATCH] brcm: Link rpi4's wifi with newer DMI string Date: Sat, 9 Jan 2021 13:09:40 +0000 Message-ID: <CALeDE9P+KLXx4qhJs520K+AYkWwOgNEGgMEo2XnZgcLnr=hMuQ@mail.gmail.com> (raw) In-Reply-To: <CA+5PVA5uogMz53S+gaBGVC5E=miJjDoa+sbRjmubcFXPueOzGQ@mail.gmail.com> On Sat, Jan 9, 2021 at 12:34 PM Josh Boyer <email@example.com> wrote: > > On Fri, Jan 8, 2021 at 6:35 PM Peter Robinson <firstname.lastname@example.org> wrote: > > > > On Fri, Jan 8, 2021 at 8:49 PM Jeremy Linton <email@example.com> wrote: > > > > > > The rpi4 when booted with a full featured > > > firmware reports a machine id from SMBIOS/DMI. > > > Since that is used to select the firmware we > > > need to add a new symlink. > > > > Overall the patch is fine but the commit message is very opinionated > > for a wifi firmware support patch. For one it's not a newer DMI string > > for Raspberry Pi as all current strings are for device tree and in the > > context of supporting WiFi the difference between what ever the > > firmware you're referring to when you say "full featured firmware" is > > irrelevant and marketing, does that "full featured firmware" support > > more features of the wifi chipset than the other variants of firmware? > > > > Except for the commit message: > > Reviewed-by: Peter Robinson <firstname.lastname@example.org> > > Not sure what I'm going to do with that. Do you have a better commit > message you'd like to suggest, or are your objections not strong > enough to warrant a rewrite? How about: brcm: Add link for Raspberry Pi 4 for matching DMI string When the Raspberry Pi 4 is booted using a ACPI firmware the wireless driver matches against a DMI string so add a link to ensure the wireless works with that firmware variant as well.
next prev parent reply index Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-08 20:49 Jeremy Linton 2021-01-08 22:07 ` Hans de Goede 2021-01-08 23:18 ` Jeremy Linton 2021-01-08 23:35 ` Peter Robinson 2021-01-09 12:33 ` Josh Boyer 2021-01-09 13:09 ` Peter Robinson [this message] 2021-01-11 1:59 ` Jeremy Linton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CALeDE9P+KLXx4qhJs520K+AYkWwOgNEGgMEo2XnZgcLnr=hMuQ@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Firmware Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-firmware/0 linux-firmware/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-firmware linux-firmware/ https://lore.kernel.org/linux-firmware \ firstname.lastname@example.org public-inbox-index linux-firmware Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.lore.linux-firmware AGPL code for this site: git clone https://public-inbox.org/public-inbox.git