From: Karel Zak <kzak@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: David Howells <dhowells@redhat.com>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Andy Lutomirski <luto@amacapital.net>,
Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [git pull] new mount API
Date: Fri, 24 Aug 2018 16:26:49 +0200 [thread overview]
Message-ID: <20180824142649.be5tm6qvcq3o5k2s@ws.net.home> (raw)
In-Reply-To: <20180824141810.GA20975@veci.piliscsaba.redhat.com>
On Fri, Aug 24, 2018 at 04:18:10PM +0200, Miklos Szeredi wrote:
> I'm bothered by the fact that we use the same MS_ prefix in the old mount(2) api
> and the new fsmount(2) api. What happens if we introduce new flags for
> fsmount(2) and are already out of flags for mount(2)? I see a big mess that
> way.
>
> Also notice, how the old code just totally ignored MS_RELATIME? Bit of rot in
> the new interface already.
>
> So here's a patch. The MNT_ prefix is already used by libmount, and we don't
> want any confusion arising from that. So how about M_*? Short and sweet, just
> like O_* for open(2).
+1 Please.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2018-08-24 18:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 22:31 [git pull] new mount API Al Viro
2018-08-23 23:24 ` Andy Lutomirski
2018-08-24 0:08 ` David Howells
2018-08-24 0:16 ` Andy Lutomirski
2018-08-24 0:31 ` Al Viro
2018-08-24 2:36 ` Andy Lutomirski
2018-08-24 3:13 ` Al Viro
2018-08-24 4:51 ` Andy Lutomirski
2018-08-24 6:05 ` Theodore Y. Ts'o
2018-08-24 8:38 ` Miklos Szeredi
2018-08-24 8:56 ` Miklos Szeredi
2018-08-24 9:29 ` Miklos Szeredi
2018-08-24 9:45 ` David Howells
2018-08-24 10:06 ` Miklos Szeredi
2018-08-24 14:18 ` Miklos Szeredi
2018-08-24 14:26 ` Karel Zak [this message]
2018-08-24 14:26 ` David Howells
2018-08-24 14:30 ` Miklos Szeredi
2018-08-24 14:49 ` Andy Lutomirski
2018-08-24 15:02 ` Miklos Szeredi
2018-08-24 15:09 ` Andy Lutomirski
2018-08-24 17:08 ` Miklos Szeredi
2018-08-24 17:10 ` David Howells
2018-08-24 17:43 ` Andy Lutomirski
2018-08-24 19:25 ` Miklos Szeredi
2018-08-24 19:51 ` Al Viro
2018-08-29 12:32 ` Miklos Szeredi
2018-08-26 3:22 ` Eric W. Biederman
2018-08-26 20:42 ` David Howells
2018-08-26 20:46 ` David Howells
2018-08-26 21:03 ` [PATCH] mqueue: Fix bug from mount API conversion David Howells
2018-08-26 21:22 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824142649.be5tm6qvcq3o5k2s@ws.net.home \
--to=kzak@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).