From: David Howells <dhowells@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: dhowells@redhat.com, ebiederm@xmission.com (Eric W. Biederman),
Al Viro <viro@ZenIV.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [git pull] new mount API
Date: Sun, 26 Aug 2018 21:46:53 +0100 [thread overview]
Message-ID: <6161.1535316413@warthog.procyon.org.uk> (raw)
In-Reply-To: <5973.1535316177@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> > ... we have bugs in the implementation.
>
> Allegedly. It would be useful if you could've pointed out what it was that
> you think you see. I don't see offhand what it reintroduces.
This?
- ns->mq_mnt = kern_mount_data(&mqueue_fs_type, ns, 0);
- if (IS_ERR(ns->mq_mnt)) {
- int err = PTR_ERR(ns->mq_mnt);
- ns->mq_mnt = NULL;
- return err;
- }
+ m = mq_create_mount(&init_ipc_ns);
+ if (IS_ERR(m))
+ return PTR_ERR(m);
+ ns->mq_mnt = m;
Should be passing ns into mq_create_mount() rather than init_ipc_ns maybe?
David
next prev parent reply other threads:[~2018-08-27 0:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 22:31 [git pull] new mount API Al Viro
2018-08-23 23:24 ` Andy Lutomirski
2018-08-24 0:08 ` David Howells
2018-08-24 0:16 ` Andy Lutomirski
2018-08-24 0:31 ` Al Viro
2018-08-24 2:36 ` Andy Lutomirski
2018-08-24 3:13 ` Al Viro
2018-08-24 4:51 ` Andy Lutomirski
2018-08-24 6:05 ` Theodore Y. Ts'o
2018-08-24 8:38 ` Miklos Szeredi
2018-08-24 8:56 ` Miklos Szeredi
2018-08-24 9:29 ` Miklos Szeredi
2018-08-24 9:45 ` David Howells
2018-08-24 10:06 ` Miklos Szeredi
2018-08-24 14:18 ` Miklos Szeredi
2018-08-24 14:26 ` Karel Zak
2018-08-24 14:26 ` David Howells
2018-08-24 14:30 ` Miklos Szeredi
2018-08-24 14:49 ` Andy Lutomirski
2018-08-24 15:02 ` Miklos Szeredi
2018-08-24 15:09 ` Andy Lutomirski
2018-08-24 17:08 ` Miklos Szeredi
2018-08-24 17:10 ` David Howells
2018-08-24 17:43 ` Andy Lutomirski
2018-08-24 19:25 ` Miklos Szeredi
2018-08-24 19:51 ` Al Viro
2018-08-29 12:32 ` Miklos Szeredi
2018-08-26 3:22 ` Eric W. Biederman
2018-08-26 20:42 ` David Howells
2018-08-26 20:46 ` David Howells [this message]
2018-08-26 21:03 ` [PATCH] mqueue: Fix bug from mount API conversion David Howells
2018-08-26 21:22 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6161.1535316413@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).