From: David Howells <dhowells@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: dhowells@redhat.com, "Theodore Y. Ts'o" <tytso@mit.edu>,
Andy Lutomirski <luto@amacapital.net>,
Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [git pull] new mount API
Date: Fri, 24 Aug 2018 10:45:31 +0100 [thread overview]
Message-ID: <362.1535103931@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAJfpegvh_NoXxwMEhrmUdt5C4djMy=gKLBHqe-79XUWOi0j9eQ@mail.gmail.com>
Miklos Szeredi <miklos@szeredi.hu> wrote:
> I'm not against merging this patchset (have nits about resuing the
> MS_* constants for the new API that I've complained about, but that's
> really easy to fix before -final),
Can you send me a patch that does what you want here? They're only used by
fsmount() for creating a vfsmount and not used for the superblock creation or
reconfiguration.
> but it may make sense to differentiate the legacy behavior from a saner one
> from the very start. I.e. rename FSCONFIG_CMD_CREATE
I would suggest leaving it as-is and add an FSCONFIG_CMD_CREATE_EXCLUSIVE.
> to something implying it's actually *not* a create in exclusive sense that
> one would first imply (and yeah, we have creat() and O_CREAT, which don't
> imply exclusivity, yet they at least have clear semantics that current super
> block creation does definitely not).
The problem is that "exclusivity" isn't necessarily an easy thing to define.
Take nfs4 and btrfs for example. They creating a backing superblock that the
actual node is derived from (though in different ways). How do you define
what "exclusive" means in their case?
David
next prev parent reply other threads:[~2018-08-24 13:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 22:31 [git pull] new mount API Al Viro
2018-08-23 23:24 ` Andy Lutomirski
2018-08-24 0:08 ` David Howells
2018-08-24 0:16 ` Andy Lutomirski
2018-08-24 0:31 ` Al Viro
2018-08-24 2:36 ` Andy Lutomirski
2018-08-24 3:13 ` Al Viro
2018-08-24 4:51 ` Andy Lutomirski
2018-08-24 6:05 ` Theodore Y. Ts'o
2018-08-24 8:38 ` Miklos Szeredi
2018-08-24 8:56 ` Miklos Szeredi
2018-08-24 9:29 ` Miklos Szeredi
2018-08-24 9:45 ` David Howells [this message]
2018-08-24 10:06 ` Miklos Szeredi
2018-08-24 14:18 ` Miklos Szeredi
2018-08-24 14:26 ` Karel Zak
2018-08-24 14:26 ` David Howells
2018-08-24 14:30 ` Miklos Szeredi
2018-08-24 14:49 ` Andy Lutomirski
2018-08-24 15:02 ` Miklos Szeredi
2018-08-24 15:09 ` Andy Lutomirski
2018-08-24 17:08 ` Miklos Szeredi
2018-08-24 17:10 ` David Howells
2018-08-24 17:43 ` Andy Lutomirski
2018-08-24 19:25 ` Miklos Szeredi
2018-08-24 19:51 ` Al Viro
2018-08-29 12:32 ` Miklos Szeredi
2018-08-26 3:22 ` Eric W. Biederman
2018-08-26 20:42 ` David Howells
2018-08-26 20:46 ` David Howells
2018-08-26 21:03 ` [PATCH] mqueue: Fix bug from mount API conversion David Howells
2018-08-26 21:22 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=362.1535103931@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).