* [PATCH] pinctrl: ocelot: Add platform dependency @ 2020-05-07 11:40 Geert Uytterhoeven 2020-05-07 11:45 ` Alexandre Belloni 0 siblings, 1 reply; 9+ messages in thread From: Geert Uytterhoeven @ 2020-05-07 11:40 UTC (permalink / raw) To: Linus Walleij, Alexandre Belloni Cc: Arnd Bergmann, Microchip Linux Driver Support, linux-gpio, linux-mips, Geert Uytterhoeven The Microsemi Ocelot pin controller is only present on Microsemi Ocelot and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT config symbol, to avoid asking the user about it when configuring a kernel without Ocelot or Jaguar2 support. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/pinctrl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index f0ce4ce3e0f52456..bed67c08a0892240 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -394,8 +394,8 @@ config PINCTRL_RK805 config PINCTRL_OCELOT bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" - depends on OF - depends on HAS_IOMEM + depends on OF && HAS_IOMEM + depends on MSCC_OCELOT || COMPILE_TEST select GPIOLIB select GPIOLIB_IRQCHIP select GENERIC_PINCONF -- 2.17.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: ocelot: Add platform dependency 2020-05-07 11:40 [PATCH] pinctrl: ocelot: Add platform dependency Geert Uytterhoeven @ 2020-05-07 11:45 ` Alexandre Belloni 2020-05-07 11:52 ` Geert Uytterhoeven 2020-05-07 12:27 ` Lars Povlsen 0 siblings, 2 replies; 9+ messages in thread From: Alexandre Belloni @ 2020-05-07 11:45 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linus Walleij, Arnd Bergmann, Microchip Linux Driver Support, linux-gpio, linux-mips Hi, On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote: > The Microsemi Ocelot pin controller is only present on Microsemi Ocelot > and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT > config symbol, to avoid asking the user about it when configuring a > kernel without Ocelot or Jaguar2 support. > I have to NAK here because there are upcoming (hopefully this cycle) SoCs using this driver. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/pinctrl/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index f0ce4ce3e0f52456..bed67c08a0892240 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -394,8 +394,8 @@ config PINCTRL_RK805 > > config PINCTRL_OCELOT > bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" > - depends on OF > - depends on HAS_IOMEM > + depends on OF && HAS_IOMEM > + depends on MSCC_OCELOT || COMPILE_TEST > select GPIOLIB > select GPIOLIB_IRQCHIP > select GENERIC_PINCONF > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: ocelot: Add platform dependency 2020-05-07 11:45 ` Alexandre Belloni @ 2020-05-07 11:52 ` Geert Uytterhoeven 2020-05-07 12:27 ` Lars Povlsen 1 sibling, 0 replies; 9+ messages in thread From: Geert Uytterhoeven @ 2020-05-07 11:52 UTC (permalink / raw) To: Alexandre Belloni Cc: Linus Walleij, Arnd Bergmann, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, open list:BROADCOM NVRAM DRIVER Hi Alexandre, On Thu, May 7, 2020 at 1:46 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote: > > The Microsemi Ocelot pin controller is only present on Microsemi Ocelot > > and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT > > config symbol, to avoid asking the user about it when configuring a > > kernel without Ocelot or Jaguar2 support. > > I have to NAK here because there are upcoming (hopefully this cycle) > SoCs using this driver. So which symbol do I have to extend the dependency with? ;-) > > --- a/drivers/pinctrl/Kconfig > > +++ b/drivers/pinctrl/Kconfig > > @@ -394,8 +394,8 @@ config PINCTRL_RK805 > > > > config PINCTRL_OCELOT > > bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" > > - depends on OF > > - depends on HAS_IOMEM > > + depends on OF && HAS_IOMEM > > + depends on MSCC_OCELOT || COMPILE_TEST > > select GPIOLIB > > select GPIOLIB_IRQCHIP > > select GENERIC_PINCONF Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: ocelot: Add platform dependency 2020-05-07 11:45 ` Alexandre Belloni 2020-05-07 11:52 ` Geert Uytterhoeven @ 2020-05-07 12:27 ` Lars Povlsen 2020-05-07 12:44 ` Alexandre Belloni 1 sibling, 1 reply; 9+ messages in thread From: Lars Povlsen @ 2020-05-07 12:27 UTC (permalink / raw) To: Alexandre Belloni Cc: Geert Uytterhoeven, Linus Walleij, Arnd Bergmann, Microchip Linux Driver Support, linux-gpio, linux-mips Alexandre Belloni writes: > Hi, > > On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote: >> The Microsemi Ocelot pin controller is only present on Microsemi Ocelot >> and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT >> config symbol, to avoid asking the user about it when configuring a >> kernel without Ocelot or Jaguar2 support. >> > > I have to NAK here because there are upcoming (hopefully this cycle) > SoCs using this driver. > Not only because of that, but also an arbitrary system connecting to ocelot by PCI could be using the driver. >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> --- >> drivers/pinctrl/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig >> index f0ce4ce3e0f52456..bed67c08a0892240 100644 >> --- a/drivers/pinctrl/Kconfig >> +++ b/drivers/pinctrl/Kconfig >> @@ -394,8 +394,8 @@ config PINCTRL_RK805 >> >> config PINCTRL_OCELOT >> bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" >> - depends on OF >> - depends on HAS_IOMEM >> + depends on OF && HAS_IOMEM >> + depends on MSCC_OCELOT || COMPILE_TEST >> select GPIOLIB >> select GPIOLIB_IRQCHIP >> select GENERIC_PINCONF >> -- >> 2.17.1 >> -- Lars Povlsen, Microchip ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: ocelot: Add platform dependency 2020-05-07 12:27 ` Lars Povlsen @ 2020-05-07 12:44 ` Alexandre Belloni 2020-05-11 11:39 ` Geert Uytterhoeven 0 siblings, 1 reply; 9+ messages in thread From: Alexandre Belloni @ 2020-05-07 12:44 UTC (permalink / raw) To: Lars Povlsen Cc: Geert Uytterhoeven, Linus Walleij, Arnd Bergmann, Microchip Linux Driver Support, linux-gpio, linux-mips On 07/05/2020 14:27:06+0200, Lars Povlsen wrote: > > Alexandre Belloni writes: > > > Hi, > > > > On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote: > >> The Microsemi Ocelot pin controller is only present on Microsemi Ocelot > >> and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT > >> config symbol, to avoid asking the user about it when configuring a > >> kernel without Ocelot or Jaguar2 support. > >> > > > > I have to NAK here because there are upcoming (hopefully this cycle) > > SoCs using this driver. > > > > Not only because of that, but also an arbitrary system connecting to > ocelot by PCI could be using the driver. > Right, and that was why I removed the dependency when adding jaguar2 support I never booted the mips core of jaguar2, I used it using PCIe. > >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> --- > >> drivers/pinctrl/Kconfig | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > >> index f0ce4ce3e0f52456..bed67c08a0892240 100644 > >> --- a/drivers/pinctrl/Kconfig > >> +++ b/drivers/pinctrl/Kconfig > >> @@ -394,8 +394,8 @@ config PINCTRL_RK805 > >> > >> config PINCTRL_OCELOT > >> bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" > >> - depends on OF > >> - depends on HAS_IOMEM > >> + depends on OF && HAS_IOMEM > >> + depends on MSCC_OCELOT || COMPILE_TEST > >> select GPIOLIB > >> select GPIOLIB_IRQCHIP > >> select GENERIC_PINCONF > >> -- > >> 2.17.1 > >> > > -- > Lars Povlsen, > Microchip -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: ocelot: Add platform dependency 2020-05-07 12:44 ` Alexandre Belloni @ 2020-05-11 11:39 ` Geert Uytterhoeven 2020-05-11 14:20 ` Alexandre Belloni 0 siblings, 1 reply; 9+ messages in thread From: Geert Uytterhoeven @ 2020-05-11 11:39 UTC (permalink / raw) To: Alexandre Belloni Cc: Lars Povlsen, Linus Walleij, Arnd Bergmann, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, open list:BROADCOM NVRAM DRIVER Hi Alexandre, On Thu, May 7, 2020 at 2:47 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > On 07/05/2020 14:27:06+0200, Lars Povlsen wrote: > > Alexandre Belloni writes: > > > On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote: > > >> The Microsemi Ocelot pin controller is only present on Microsemi Ocelot > > >> and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT > > >> config symbol, to avoid asking the user about it when configuring a > > >> kernel without Ocelot or Jaguar2 support. > > >> > > > > > > I have to NAK here because there are upcoming (hopefully this cycle) > > > SoCs using this driver. > > > > Not only because of that, but also an arbitrary system connecting to > > ocelot by PCI could be using the driver. > > Right, and that was why I removed the dependency when adding jaguar2 That is far from obvious from the description of commit da801ab56ad87489 ("pinctrl: ocelot: add MSCC Jaguar2 support").... BTW, probably PINCTRL_OCELOT should have got "default y if MSCC_OCELOT", to avoid breaking old configs? > support I never booted the mips core of jaguar2, I used it using PCIe. Ah, you're using it as a PCIe endpoint. So what about ... > > >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > >> --- > > >> drivers/pinctrl/Kconfig | 4 ++-- > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > >> index f0ce4ce3e0f52456..bed67c08a0892240 100644 > > >> --- a/drivers/pinctrl/Kconfig > > >> +++ b/drivers/pinctrl/Kconfig > > >> @@ -394,8 +394,8 @@ config PINCTRL_RK805 > > >> > > >> config PINCTRL_OCELOT > > >> bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" > > >> - depends on OF > > >> - depends on HAS_IOMEM > > >> + depends on OF && HAS_IOMEM > > >> + depends on MSCC_OCELOT || COMPILE_TEST ... "depends on MSCC_OCELOT || PCI || COMPILE_TEST" instead? If other SoCs gain support, the dependency list can be extended. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: ocelot: Add platform dependency 2020-05-11 11:39 ` Geert Uytterhoeven @ 2020-05-11 14:20 ` Alexandre Belloni 2020-05-11 14:48 ` Geert Uytterhoeven 0 siblings, 1 reply; 9+ messages in thread From: Alexandre Belloni @ 2020-05-11 14:20 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Lars Povlsen, Linus Walleij, Arnd Bergmann, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, open list:BROADCOM NVRAM DRIVER On 11/05/2020 13:39:42+0200, Geert Uytterhoeven wrote: > Hi Alexandre, > > On Thu, May 7, 2020 at 2:47 PM Alexandre Belloni > <alexandre.belloni@bootlin.com> wrote: > > On 07/05/2020 14:27:06+0200, Lars Povlsen wrote: > > > Alexandre Belloni writes: > > > > On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote: > > > >> The Microsemi Ocelot pin controller is only present on Microsemi Ocelot > > > >> and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT > > > >> config symbol, to avoid asking the user about it when configuring a > > > >> kernel without Ocelot or Jaguar2 support. > > > >> > > > > > > > > I have to NAK here because there are upcoming (hopefully this cycle) > > > > SoCs using this driver. > > > > > > Not only because of that, but also an arbitrary system connecting to > > > ocelot by PCI could be using the driver. > > > > Right, and that was why I removed the dependency when adding jaguar2 > > That is far from obvious from the description of commit da801ab56ad87489 > ("pinctrl: ocelot: add MSCC Jaguar2 support").... > BTW, probably PINCTRL_OCELOT should have got "default y if MSCC_OCELOT", > to avoid breaking old configs? > > > support I never booted the mips core of jaguar2, I used it using PCIe. > > Ah, you're using it as a PCIe endpoint. So what about ... > > > > >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > >> --- > > > >> drivers/pinctrl/Kconfig | 4 ++-- > > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > > >> > > > >> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > > >> index f0ce4ce3e0f52456..bed67c08a0892240 100644 > > > >> --- a/drivers/pinctrl/Kconfig > > > >> +++ b/drivers/pinctrl/Kconfig > > > >> @@ -394,8 +394,8 @@ config PINCTRL_RK805 > > > >> > > > >> config PINCTRL_OCELOT > > > >> bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" > > > >> - depends on OF > > > >> - depends on HAS_IOMEM > > > >> + depends on OF && HAS_IOMEM > > > >> + depends on MSCC_OCELOT || COMPILE_TEST > > ... "depends on MSCC_OCELOT || PCI || COMPILE_TEST" instead? > > If other SoCs gain support, the dependency list can be extended. > Hum ok, note that it can also be connected as a SPI slave but I think this is a bit far fetched currently. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: ocelot: Add platform dependency 2020-05-11 14:20 ` Alexandre Belloni @ 2020-05-11 14:48 ` Geert Uytterhoeven 2020-05-11 14:53 ` Alexandre Belloni 0 siblings, 1 reply; 9+ messages in thread From: Geert Uytterhoeven @ 2020-05-11 14:48 UTC (permalink / raw) To: Alexandre Belloni Cc: Lars Povlsen, Linus Walleij, Arnd Bergmann, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, open list:BROADCOM NVRAM DRIVER Hi Alexandre, On Mon, May 11, 2020 at 4:20 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > On 11/05/2020 13:39:42+0200, Geert Uytterhoeven wrote: > > On Thu, May 7, 2020 at 2:47 PM Alexandre Belloni > > <alexandre.belloni@bootlin.com> wrote: > > > On 07/05/2020 14:27:06+0200, Lars Povlsen wrote: > > > > Alexandre Belloni writes: > > > > > On 07/05/2020 13:40:15+0200, Geert Uytterhoeven wrote: > > > > >> The Microsemi Ocelot pin controller is only present on Microsemi Ocelot > > > > >> and Jaguar2 SoCs. Add a platform dependency to the PINCTRL_OCELOT > > > > >> config symbol, to avoid asking the user about it when configuring a > > > > >> kernel without Ocelot or Jaguar2 support. > > > > >> > > > > > > > > > > I have to NAK here because there are upcoming (hopefully this cycle) > > > > > SoCs using this driver. > > > > > > > > Not only because of that, but also an arbitrary system connecting to > > > > ocelot by PCI could be using the driver. > > > > > > Right, and that was why I removed the dependency when adding jaguar2 > > > > That is far from obvious from the description of commit da801ab56ad87489 > > ("pinctrl: ocelot: add MSCC Jaguar2 support").... > > BTW, probably PINCTRL_OCELOT should have got "default y if MSCC_OCELOT", > > to avoid breaking old configs? > > > > > support I never booted the mips core of jaguar2, I used it using PCIe. > > > > Ah, you're using it as a PCIe endpoint. So what about ... > > > > > > >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > >> --- > > > > >> drivers/pinctrl/Kconfig | 4 ++-- > > > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > > > >> > > > > >> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > > > >> index f0ce4ce3e0f52456..bed67c08a0892240 100644 > > > > >> --- a/drivers/pinctrl/Kconfig > > > > >> +++ b/drivers/pinctrl/Kconfig > > > > >> @@ -394,8 +394,8 @@ config PINCTRL_RK805 > > > > >> > > > > >> config PINCTRL_OCELOT > > > > >> bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" > > > > >> - depends on OF > > > > >> - depends on HAS_IOMEM > > > > >> + depends on OF && HAS_IOMEM > > > > >> + depends on MSCC_OCELOT || COMPILE_TEST > > > > ... "depends on MSCC_OCELOT || PCI || COMPILE_TEST" instead? > > > > If other SoCs gain support, the dependency list can be extended. > > Hum ok, note that it can also be connected as a SPI slave but I think > this is a bit far fetched currently. I can connect whatever other system using SPI, i2c, CAN, or Ethernet ;-) That doesn't mean I will directly program the other system's pin controller over that link, using the standard (MMIO) pinctrl driver. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] pinctrl: ocelot: Add platform dependency 2020-05-11 14:48 ` Geert Uytterhoeven @ 2020-05-11 14:53 ` Alexandre Belloni 0 siblings, 0 replies; 9+ messages in thread From: Alexandre Belloni @ 2020-05-11 14:53 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Lars Povlsen, Linus Walleij, Arnd Bergmann, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, open list:BROADCOM NVRAM DRIVER On 11/05/2020 16:48:01+0200, Geert Uytterhoeven wrote: > I can connect whatever other system using SPI, i2c, CAN, or Ethernet ;-) > That doesn't mean I will directly program the other system's pin controller > over that link, using the standard (MMIO) pinctrl driver. > Yes, my point is that you can access all the SoC registers over SPI and so you will probably need to also control the pinctrl for example to be able to actually use the on-SoC switch. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-05-11 14:53 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-07 11:40 [PATCH] pinctrl: ocelot: Add platform dependency Geert Uytterhoeven 2020-05-07 11:45 ` Alexandre Belloni 2020-05-07 11:52 ` Geert Uytterhoeven 2020-05-07 12:27 ` Lars Povlsen 2020-05-07 12:44 ` Alexandre Belloni 2020-05-11 11:39 ` Geert Uytterhoeven 2020-05-11 14:20 ` Alexandre Belloni 2020-05-11 14:48 ` Geert Uytterhoeven 2020-05-11 14:53 ` Alexandre Belloni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).