* [PATCH 01/14] dt-bindings: interrupt-controller: qcom-pdc: add compatible for sa8775p
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-19 12:44 ` Krzysztof Kozlowski
2023-03-14 18:30 ` [PATCH 02/14] arm64: dts: qcom: sa8775p: add the pdc node Bartosz Golaszewski
` (12 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski, Thomas Gleixner, Marc Zyngier
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add a compatible for the Power Domain Controller on SA8775p platforms.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <maz@kernel.org>
---
.../devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
index 94791e261c42..25c4662a0280 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
@@ -26,6 +26,7 @@ properties:
compatible:
items:
- enum:
+ - qcom,sa8775p-pdc
- qcom,sc7180-pdc
- qcom,sc7280-pdc
- qcom,sc8280xp-pdc
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 01/14] dt-bindings: interrupt-controller: qcom-pdc: add compatible for sa8775p
2023-03-14 18:30 ` [PATCH 01/14] dt-bindings: interrupt-controller: qcom-pdc: add compatible for sa8775p Bartosz Golaszewski
@ 2023-03-19 12:44 ` Krzysztof Kozlowski
0 siblings, 0 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-19 12:44 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski, Thomas Gleixner, Marc Zyngier
On 14/03/2023 19:30, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add a compatible for the Power Domain Controller on SA8775p platforms.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Marc Zyngier <maz@kernel.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 02/14] arm64: dts: qcom: sa8775p: add the pdc node
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
2023-03-14 18:30 ` [PATCH 01/14] dt-bindings: interrupt-controller: qcom-pdc: add compatible for sa8775p Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 18:30 ` [PATCH 03/14] arm64: dts: qcom: sa8775p: add the spmi node Bartosz Golaszewski
` (11 subsequent siblings)
13 siblings, 0 replies; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add the Power Domain Controller node for SA8775p.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 41 +++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index c5b73c591e0f..428d9e0849b8 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -585,6 +585,47 @@ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ALWAYS>,
};
};
+ pdc: interrupt-controller@b220000 {
+ compatible = "qcom,sa8775p-pdc", "qcom,pdc";
+ reg = <0x0 0x0b220000 0x0 0x30000>,
+ <0x0 0x17c000f0 0x0 0x64>;
+ qcom,pdc-ranges = <0 480 40>,
+ <40 140 14>,
+ <54 263 1>,
+ <55 306 4>,
+ <59 312 3>,
+ <62 374 2>,
+ <64 434 2>,
+ <66 438 2>,
+ <70 520 1>,
+ <73 523 1>,
+ <118 568 6>,
+ <124 609 3>,
+ <159 638 1>,
+ <160 720 3>,
+ <169 728 30>,
+ <199 416 2>,
+ <201 449 1>,
+ <202 89 1>,
+ <203 451 1>,
+ <204 462 1>,
+ <205 264 1>,
+ <206 579 1>,
+ <207 653 1>,
+ <208 656 1>,
+ <209 659 1>,
+ <210 122 1>,
+ <211 699 1>,
+ <212 705 1>,
+ <213 450 1>,
+ <214 643 2>,
+ <216 646 5>,
+ <221 390 5>;
+ #interrupt-cells = <2>;
+ interrupt-parent = <&intc>;
+ interrupt-controller;
+ };
+
intc: interrupt-controller@17a00000 {
compatible = "arm,gic-v3";
reg = <0x0 0x17a00000 0x0 0x10000>, /* GICD */
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 03/14] arm64: dts: qcom: sa8775p: add the spmi node
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
2023-03-14 18:30 ` [PATCH 01/14] dt-bindings: interrupt-controller: qcom-pdc: add compatible for sa8775p Bartosz Golaszewski
2023-03-14 18:30 ` [PATCH 02/14] arm64: dts: qcom: sa8775p: add the pdc node Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 20:21 ` Konrad Dybcio
2023-03-14 18:30 ` [PATCH 04/14] dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654au Bartosz Golaszewski
` (10 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add the SPMI PMIC Arbiter node for SA8775p platforms.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 428d9e0849b8..22c98ebc4c46 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -943,6 +943,24 @@ apps_smmu: iommu@15000000 {
};
};
+ spmi_bus: spmi@c440000 {
+ compatible = "qcom,spmi-pmic-arb";
+ reg = <0x0 0x0c440000 0x0 0x1100>,
+ <0x0 0x0c600000 0x0 0x2000000>,
+ <0x0 0x0e600000 0x0 0x100000>,
+ <0x0 0x0e700000 0x0 0xa0000>,
+ <0x0 0x0c40a000 0x0 0x26000>;
+ reg-names = "core", "chnls", "obsrvr", "intr", "cnfg";
+ qcom,channel = <0>;
+ qcom,ee = <0>;
+ interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "periph_irq";
+ interrupt-controller;
+ #interrupt-cells = <4>;
+ #address-cells = <2>;
+ #size-cells = <0>;
+ };
+
arch_timer: timer {
compatible = "arm,armv8-timer";
interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 03/14] arm64: dts: qcom: sa8775p: add the spmi node
2023-03-14 18:30 ` [PATCH 03/14] arm64: dts: qcom: sa8775p: add the spmi node Bartosz Golaszewski
@ 2023-03-14 20:21 ` Konrad Dybcio
0 siblings, 0 replies; 32+ messages in thread
From: Konrad Dybcio @ 2023-03-14 20:21 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
On 14.03.2023 19:30, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add the SPMI PMIC Arbiter node for SA8775p platforms.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 428d9e0849b8..22c98ebc4c46 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -943,6 +943,24 @@ apps_smmu: iommu@15000000 {
> };
> };
>
> + spmi_bus: spmi@c440000 {
> + compatible = "qcom,spmi-pmic-arb";
> + reg = <0x0 0x0c440000 0x0 0x1100>,
> + <0x0 0x0c600000 0x0 0x2000000>,
> + <0x0 0x0e600000 0x0 0x100000>,
> + <0x0 0x0e700000 0x0 0xa0000>,
> + <0x0 0x0c40a000 0x0 0x26000>;
> + reg-names = "core", "chnls", "obsrvr", "intr", "cnfg";
Please make this a vertical list and sort the node properly.
lgtm otherwise
Konrad
> + qcom,channel = <0>;
> + qcom,ee = <0>;
> + interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "periph_irq";
> + interrupt-controller;
> + #interrupt-cells = <4>;
> + #address-cells = <2>;
> + #size-cells = <0>;
> + };
> +
> arch_timer: timer {
> compatible = "arm,armv8-timer";
> interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 04/14] dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654au
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (2 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 03/14] arm64: dts: qcom: sa8775p: add the spmi node Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-20 14:49 ` Rob Herring
2023-03-30 11:41 ` Lee Jones
2023-03-14 18:30 ` [PATCH 05/14] arm64: dts: qcom: sa8775p: add support for the on-board PMICs Bartosz Golaszewski
` (9 subsequent siblings)
13 siblings, 2 replies; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski, Lee Jones
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
PMM8654au is the SPMI PMIC variant used on sa8775p-ride. Add a compatible
for it.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Lee Jones <lee@kernel.org>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 8f076bb622b1..078d47a6ac83 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -78,6 +78,7 @@ properties:
- qcom,pmk8350
- qcom,pmk8550
- qcom,pmm8155au
+ - qcom,pmm8654au
- qcom,pmp8074
- qcom,pmr735a
- qcom,pmr735b
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 04/14] dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654au
2023-03-14 18:30 ` [PATCH 04/14] dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654au Bartosz Golaszewski
@ 2023-03-20 14:49 ` Rob Herring
2023-03-30 11:41 ` Lee Jones
1 sibling, 0 replies; 32+ messages in thread
From: Rob Herring @ 2023-03-20 14:49 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: devicetree, Bartosz Golaszewski, Andy Gross, Bjorn Andersson,
Konrad Dybcio, linux-kernel, linux-gpio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, Lee Jones
On Tue, 14 Mar 2023 19:30:33 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> PMM8654au is the SPMI PMIC variant used on sa8775p-ride. Add a compatible
> for it.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Cc: Lee Jones <lee@kernel.org>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 04/14] dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654au
2023-03-14 18:30 ` [PATCH 04/14] dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654au Bartosz Golaszewski
2023-03-20 14:49 ` Rob Herring
@ 2023-03-30 11:41 ` Lee Jones
1 sibling, 0 replies; 32+ messages in thread
From: Lee Jones @ 2023-03-30 11:41 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
linux-gpio, Bartosz Golaszewski
On Tue, 14 Mar 2023, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> PMM8654au is the SPMI PMIC variant used on sa8775p-ride. Add a compatible
> for it.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Cc: Lee Jones <lee@kernel.org>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 05/14] arm64: dts: qcom: sa8775p: add support for the on-board PMICs
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (3 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 04/14] dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654au Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 20:22 ` Konrad Dybcio
2023-03-14 18:30 ` [PATCH 06/14] arm64: dts: qcom: sa8775p-ride: enable PMIC support Bartosz Golaszewski
` (8 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add a new .dtsi file for sa8775p PMICs and add the four PMICs interfaced
to the SoC via SPMI.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 37 +++++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
new file mode 100644
index 000000000000..77e2515a7ab9
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
@@ -0,0 +1,37 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023, Linaro Limited
+ */
+
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+ pmk8775_0: pmic@0 {
+ compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
+ reg = <0x0 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ pmk8775_1: pmic@2 {
+ compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
+ reg = <0x2 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ pmk8775_2: pmic@4 {
+ compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
+ reg = <0x4 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ pmk8775_3: pmic@6 {
+ compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
+ reg = <0x6 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+};
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 05/14] arm64: dts: qcom: sa8775p: add support for the on-board PMICs
2023-03-14 18:30 ` [PATCH 05/14] arm64: dts: qcom: sa8775p: add support for the on-board PMICs Bartosz Golaszewski
@ 2023-03-14 20:22 ` Konrad Dybcio
2023-03-20 10:24 ` Bartosz Golaszewski
0 siblings, 1 reply; 32+ messages in thread
From: Konrad Dybcio @ 2023-03-14 20:22 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
On 14.03.2023 19:30, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add a new .dtsi file for sa8775p PMICs and add the four PMICs interfaced
> to the SoC via SPMI.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 37 +++++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> new file mode 100644
> index 000000000000..77e2515a7ab9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> @@ -0,0 +1,37 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Linaro Limited
> + */
> +
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus {
> + pmk8775_0: pmic@0 {
pmk8775..
> + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
..or pmm8654au?
Konrad
> + reg = <0x0 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> + pmk8775_1: pmic@2 {
> + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
> + reg = <0x2 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> + pmk8775_2: pmic@4 {
> + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
> + reg = <0x4 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> + pmk8775_3: pmic@6 {
> + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
> + reg = <0x6 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +};
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 05/14] arm64: dts: qcom: sa8775p: add support for the on-board PMICs
2023-03-14 20:22 ` Konrad Dybcio
@ 2023-03-20 10:24 ` Bartosz Golaszewski
2023-03-20 10:38 ` Konrad Dybcio
0 siblings, 1 reply; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-20 10:24 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski
On Tue, Mar 14, 2023 at 9:22 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 14.03.2023 19:30, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add a new .dtsi file for sa8775p PMICs and add the four PMICs interfaced
> > to the SoC via SPMI.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 37 +++++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > new file mode 100644
> > index 000000000000..77e2515a7ab9
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > @@ -0,0 +1,37 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) 2023, Linaro Limited
> > + */
> > +
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/spmi/spmi.h>
> > +
> > +&spmi_bus {
> > + pmk8775_0: pmic@0 {
> pmk8775..
>
> > + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
> ..or pmm8654au?
>
Honestly, I got inspired by this bit from sc8280xp-pmics.dtsi:
54 &spmi_bus {
55 pmk8280: pmic@0 {
56 compatible = "qcom,pmk8350", "qcom,spmi-pmic";
57 reg = <0x0 SPMI_USID>;
58 #address-cells = <1>;
59 #size-cells = <0>;
Where the label seems to follow the SoC's numbering. Do you think it
would be better to consistently use the pmic's name?
Bartosz
> Konrad
> > + reg = <0x0 SPMI_USID>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + };
> > +
> > + pmk8775_1: pmic@2 {
> > + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
> > + reg = <0x2 SPMI_USID>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + };
> > +
> > + pmk8775_2: pmic@4 {
> > + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
> > + reg = <0x4 SPMI_USID>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + };
> > +
> > + pmk8775_3: pmic@6 {
> > + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
> > + reg = <0x6 SPMI_USID>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + };
> > +};
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 05/14] arm64: dts: qcom: sa8775p: add support for the on-board PMICs
2023-03-20 10:24 ` Bartosz Golaszewski
@ 2023-03-20 10:38 ` Konrad Dybcio
0 siblings, 0 replies; 32+ messages in thread
From: Konrad Dybcio @ 2023-03-20 10:38 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski
On 20.03.2023 11:24, Bartosz Golaszewski wrote:
> On Tue, Mar 14, 2023 at 9:22 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>>
>> On 14.03.2023 19:30, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> Add a new .dtsi file for sa8775p PMICs and add the four PMICs interfaced
>>> to the SoC via SPMI.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 37 +++++++++++++++++++++
>>> 1 file changed, 37 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
>>> new file mode 100644
>>> index 000000000000..77e2515a7ab9
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
>>> @@ -0,0 +1,37 @@
>>> +// SPDX-License-Identifier: BSD-3-Clause
>>> +/*
>>> + * Copyright (c) 2023, Linaro Limited
>>> + */
>>> +
>>> +#include <dt-bindings/input/input.h>
>>> +#include <dt-bindings/spmi/spmi.h>
>>> +
>>> +&spmi_bus {
>>> + pmk8775_0: pmic@0 {
>> pmk8775..
>>
>>> + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
>> ..or pmm8654au?
>>
>
> Honestly, I got inspired by this bit from sc8280xp-pmics.dtsi:
>
> 54 &spmi_bus {
> 55 pmk8280: pmic@0 {
> 56 compatible = "qcom,pmk8350", "qcom,spmi-pmic";
> 57 reg = <0x0 SPMI_USID>;
> 58 #address-cells = <1>;
> 59 #size-cells = <0>;
>
> Where the label seems to follow the SoC's numbering. Do you think it
> would be better to consistently use the pmic's name?
Generally, the automotive PMICs seem to be carbon copies of their non-AU
relatives, except they're built to a better electrical spec (because well..
they're gonna be used in cars) or very very slightly modified, so I propose:
actual_pmic: pmic@sid {
compatbile = "qcom,actualpmic", "qcom,pmic-its-based-on";
}
Konrad
>
> Bartosz
>
>> Konrad
>>> + reg = <0x0 SPMI_USID>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + };
>>> +
>>> + pmk8775_1: pmic@2 {
>>> + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
>>> + reg = <0x2 SPMI_USID>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + };
>>> +
>>> + pmk8775_2: pmic@4 {
>>> + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
>>> + reg = <0x4 SPMI_USID>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + };
>>> +
>>> + pmk8775_3: pmic@6 {
>>> + compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
>>> + reg = <0x6 SPMI_USID>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + };
>>> +};
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 06/14] arm64: dts: qcom: sa8775p-ride: enable PMIC support
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (4 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 05/14] arm64: dts: qcom: sa8775p: add support for the on-board PMICs Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 18:30 ` [PATCH 07/14] arm64: dts: qcom: sa8775p: add the Power On device node Bartosz Golaszewski
` (7 subsequent siblings)
13 siblings, 0 replies; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Include the PMIC .dtsi file in the board's .dts to enable PMIC support
on sa8775p-ride.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
index 1020dfd21da2..b7ee4cc676b5 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
@@ -6,6 +6,7 @@
/dts-v1/;
#include "sa8775p.dtsi"
+#include "sa8775p-pmics.dtsi"
/ {
model = "Qualcomm SA8775P Ride";
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 07/14] arm64: dts: qcom: sa8775p: add the Power On device node
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (5 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 06/14] arm64: dts: qcom: sa8775p-ride: enable PMIC support Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 20:25 ` Konrad Dybcio
2023-03-14 18:30 ` [PATCH 08/14] arm64: dts: qcom: sa8775p: pmic: add the power key Bartosz Golaszewski
` (6 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add the PON node to PMIC #0 for sa8775p platforms.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
index 77e2515a7ab9..5d73212fbd16 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
@@ -12,6 +12,13 @@ pmk8775_0: pmic@0 {
reg = <0x0 SPMI_USID>;
#address-cells = <1>;
#size-cells = <0>;
+
+ pmk8775_0_pon: pon@1200 {
+ compatible = "qcom,pmk8350-pon";
+ reg = <0x1200>, <0x800>;
+ mode-recovery = <0x1>;
+ mode-bootloader = <0x2>;
+ };
};
pmk8775_1: pmic@2 {
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 07/14] arm64: dts: qcom: sa8775p: add the Power On device node
2023-03-14 18:30 ` [PATCH 07/14] arm64: dts: qcom: sa8775p: add the Power On device node Bartosz Golaszewski
@ 2023-03-14 20:25 ` Konrad Dybcio
2023-03-20 10:50 ` Bartosz Golaszewski
0 siblings, 1 reply; 32+ messages in thread
From: Konrad Dybcio @ 2023-03-14 20:25 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
On 14.03.2023 19:30, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add the PON node to PMIC #0 for sa8775p platforms.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> index 77e2515a7ab9..5d73212fbd16 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> @@ -12,6 +12,13 @@ pmk8775_0: pmic@0 {
> reg = <0x0 SPMI_USID>;
> #address-cells = <1>;
> #size-cells = <0>;
> +
> + pmk8775_0_pon: pon@1200 {
> + compatible = "qcom,pmk8350-pon";
> + reg = <0x1200>, <0x800>;
reg-names = "hlos", "pbs"
Also, are you sure hlos shouldn't be @1300?
Konrad
> + mode-recovery = <0x1>;
> + mode-bootloader = <0x2>;
> + };
> };
>
> pmk8775_1: pmic@2 {
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 07/14] arm64: dts: qcom: sa8775p: add the Power On device node
2023-03-14 20:25 ` Konrad Dybcio
@ 2023-03-20 10:50 ` Bartosz Golaszewski
0 siblings, 0 replies; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-20 10:50 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski
On Tue, Mar 14, 2023 at 9:25 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 14.03.2023 19:30, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add the PON node to PMIC #0 for sa8775p platforms.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > index 77e2515a7ab9..5d73212fbd16 100644
> > --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > @@ -12,6 +12,13 @@ pmk8775_0: pmic@0 {
> > reg = <0x0 SPMI_USID>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> > +
> > + pmk8775_0_pon: pon@1200 {
> > + compatible = "qcom,pmk8350-pon";
> > + reg = <0x1200>, <0x800>;
> reg-names = "hlos", "pbs"
>
> Also, are you sure hlos shouldn't be @1300?
>
Nope, that's the right one here.
Bart
> Konrad
> > + mode-recovery = <0x1>;
> > + mode-bootloader = <0x2>;
> > + };
> > };
> >
> > pmk8775_1: pmic@2 {
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 08/14] arm64: dts: qcom: sa8775p: pmic: add the power key
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (6 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 07/14] arm64: dts: qcom: sa8775p: add the Power On device node Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 20:26 ` Konrad Dybcio
2023-03-14 18:30 ` [PATCH 09/14] arm64: dts: qcom: sa8775p-ride: enable " Bartosz Golaszewski
` (5 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add the power key node under the PON node for PMIC #0 on sa8775p.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
index 5d73212fbd16..874460d087db 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
@@ -18,6 +18,13 @@ pmk8775_0_pon: pon@1200 {
reg = <0x1200>, <0x800>;
mode-recovery = <0x1>;
mode-bootloader = <0x2>;
+
+ pmk8775_0_pon_pwrkey: pwrkey {
+ compatible = "qcom,pmk8350-pwrkey";
+ interrupts-extended = <&spmi_bus 0x0 0x12 0x7 IRQ_TYPE_EDGE_BOTH>;
+ linux,code = <KEY_POWER>;
+ status = "disabled";
+ };
};
};
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 08/14] arm64: dts: qcom: sa8775p: pmic: add the power key
2023-03-14 18:30 ` [PATCH 08/14] arm64: dts: qcom: sa8775p: pmic: add the power key Bartosz Golaszewski
@ 2023-03-14 20:26 ` Konrad Dybcio
2023-03-20 10:52 ` Bartosz Golaszewski
0 siblings, 1 reply; 32+ messages in thread
From: Konrad Dybcio @ 2023-03-14 20:26 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
On 14.03.2023 19:30, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add the power key node under the PON node for PMIC #0 on sa8775p.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> index 5d73212fbd16..874460d087db 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> @@ -18,6 +18,13 @@ pmk8775_0_pon: pon@1200 {
> reg = <0x1200>, <0x800>;
> mode-recovery = <0x1>;
> mode-bootloader = <0x2>;
> +
> + pmk8775_0_pon_pwrkey: pwrkey {
> + compatible = "qcom,pmk8350-pwrkey";
> + interrupts-extended = <&spmi_bus 0x0 0x12 0x7 IRQ_TYPE_EDGE_BOTH>;
> + linux,code = <KEY_POWER>;
> + status = "disabled";
Does it make any sense to disable the power button?
Konrad
> + };
> };
> };
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 08/14] arm64: dts: qcom: sa8775p: pmic: add the power key
2023-03-14 20:26 ` Konrad Dybcio
@ 2023-03-20 10:52 ` Bartosz Golaszewski
2023-03-20 11:01 ` Konrad Dybcio
0 siblings, 1 reply; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-20 10:52 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski
On Tue, Mar 14, 2023 at 9:26 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 14.03.2023 19:30, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add the power key node under the PON node for PMIC #0 on sa8775p.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > index 5d73212fbd16..874460d087db 100644
> > --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > @@ -18,6 +18,13 @@ pmk8775_0_pon: pon@1200 {
> > reg = <0x1200>, <0x800>;
> > mode-recovery = <0x1>;
> > mode-bootloader = <0x2>;
> > +
> > + pmk8775_0_pon_pwrkey: pwrkey {
> > + compatible = "qcom,pmk8350-pwrkey";
> > + interrupts-extended = <&spmi_bus 0x0 0x12 0x7 IRQ_TYPE_EDGE_BOTH>;
> > + linux,code = <KEY_POWER>;
> > + status = "disabled";
> Does it make any sense to disable the power button?
>
Since this is an automotive platform, I'd say yes - you wouldn't
normally have physical access to the board or even be sure for it to
have a power button? But if you prefer it the other way, I won't be
dying on this hill.
Bart
> Konrad
> > + };
> > };
> > };
> >
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 08/14] arm64: dts: qcom: sa8775p: pmic: add the power key
2023-03-20 10:52 ` Bartosz Golaszewski
@ 2023-03-20 11:01 ` Konrad Dybcio
0 siblings, 0 replies; 32+ messages in thread
From: Konrad Dybcio @ 2023-03-20 11:01 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski
On 20.03.2023 11:52, Bartosz Golaszewski wrote:
> On Tue, Mar 14, 2023 at 9:26 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>>
>> On 14.03.2023 19:30, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> Add the power key node under the PON node for PMIC #0 on sa8775p.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
>>> index 5d73212fbd16..874460d087db 100644
>>> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
>>> @@ -18,6 +18,13 @@ pmk8775_0_pon: pon@1200 {
>>> reg = <0x1200>, <0x800>;
>>> mode-recovery = <0x1>;
>>> mode-bootloader = <0x2>;
>>> +
>>> + pmk8775_0_pon_pwrkey: pwrkey {
>>> + compatible = "qcom,pmk8350-pwrkey";
>>> + interrupts-extended = <&spmi_bus 0x0 0x12 0x7 IRQ_TYPE_EDGE_BOTH>;
>>> + linux,code = <KEY_POWER>;
>>> + status = "disabled";
>> Does it make any sense to disable the power button?
>>
>
> Since this is an automotive platform, I'd say yes - you wouldn't
> normally have physical access to the board or even be sure for it to
> have a power button?
On Qualcomm platforms there's little different ways to turn on the
device short of giving it DC power (though that may also be config
dependent), so I'd expect *something* would be connected to PON_PWR..
>But if you prefer it the other way, I won't be
> dying on this hill.
Yeah if you could, please leave it on (unless somebody has strong
arguments against that)
Konrad
>
> Bart
>
>> Konrad
>>> + };
>>> };
>>> };
>>>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 09/14] arm64: dts: qcom: sa8775p-ride: enable the power key
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (7 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 08/14] arm64: dts: qcom: sa8775p: pmic: add the power key Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 18:30 ` [PATCH 10/14] arm64: dts: qcom: sa8775p: pmic: add support for the pmm8654 RESIN input Bartosz Golaszewski
` (4 subsequent siblings)
13 siblings, 0 replies; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Enable the power key for sa8775p-ride.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
index b7ee4cc676b5..396a2543c78a 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
@@ -40,6 +40,10 @@ &qupv3_id_2 {
status = "okay";
};
+&pmk8775_0_pon_pwrkey {
+ status = "okay";
+};
+
&sleep_clk {
clock-frequency = <32764>;
};
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 10/14] arm64: dts: qcom: sa8775p: pmic: add support for the pmm8654 RESIN input
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (8 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 09/14] arm64: dts: qcom: sa8775p-ride: enable " Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 20:26 ` Konrad Dybcio
2023-03-14 18:30 ` [PATCH 11/14] arm64: dts: qcom: sa8775p: pmic: add thermal zones Bartosz Golaszewski
` (3 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add the RESIN input for sa8775p platforms' PMIC.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
index 874460d087db..d55fa5165864 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
@@ -25,6 +25,12 @@ pmk8775_0_pon_pwrkey: pwrkey {
linux,code = <KEY_POWER>;
status = "disabled";
};
+
+ pmk8775_0_pon_resin: resin {
+ compatible = "qcom,pmk8350-resin";
+ interrupts-extended = <&spmi_bus 0x0 0x12 0x6 IRQ_TYPE_EDGE_BOTH>;
+ status = "disabled";
+ };
};
};
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 10/14] arm64: dts: qcom: sa8775p: pmic: add support for the pmm8654 RESIN input
2023-03-14 18:30 ` [PATCH 10/14] arm64: dts: qcom: sa8775p: pmic: add support for the pmm8654 RESIN input Bartosz Golaszewski
@ 2023-03-14 20:26 ` Konrad Dybcio
0 siblings, 0 replies; 32+ messages in thread
From: Konrad Dybcio @ 2023-03-14 20:26 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
On 14.03.2023 19:30, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add the RESIN input for sa8775p platforms' PMIC.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> index 874460d087db..d55fa5165864 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> @@ -25,6 +25,12 @@ pmk8775_0_pon_pwrkey: pwrkey {
> linux,code = <KEY_POWER>;
> status = "disabled";
> };
> +
> + pmk8775_0_pon_resin: resin {
> + compatible = "qcom,pmk8350-resin";
> + interrupts-extended = <&spmi_bus 0x0 0x12 0x6 IRQ_TYPE_EDGE_BOTH>;
> + status = "disabled";
No usual 15625 debounce time?
Konrad
> + };
> };
> };
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 11/14] arm64: dts: qcom: sa8775p: pmic: add thermal zones
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (9 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 10/14] arm64: dts: qcom: sa8775p: pmic: add support for the pmm8654 RESIN input Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 18:30 ` [PATCH 12/14] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio Bartosz Golaszewski
` (2 subsequent siblings)
13 siblings, 0 replies; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add the thermal zones and associated alarm nodes for the PMICs that have
them hooked up on sa8775p-ride.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 59 +++++++++++++++++++++
1 file changed, 59 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
index d55fa5165864..437cfa8aee2f 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
@@ -6,6 +6,50 @@
#include <dt-bindings/input/input.h>
#include <dt-bindings/spmi/spmi.h>
+/ {
+ thermal-zones {
+ pm8775_1_thermal: pm8775-1-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pm8775_1_temp_alarm>;
+
+ trips {
+ trip0 {
+ temperature = <105000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ trip1 {
+ temperature = <125000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+
+ pm8775_3_thermal: pm8775-3-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pm8775_3_temp_alarm>;
+
+ trips {
+ trip0 {
+ temperature = <105000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ trip1 {
+ temperature = <125000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+ };
+};
+
&spmi_bus {
pmk8775_0: pmic@0 {
compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
@@ -16,6 +60,7 @@ pmk8775_0: pmic@0 {
pmk8775_0_pon: pon@1200 {
compatible = "qcom,pmk8350-pon";
reg = <0x1200>, <0x800>;
+
mode-recovery = <0x1>;
mode-bootloader = <0x2>;
@@ -39,6 +84,13 @@ pmk8775_1: pmic@2 {
reg = <0x2 SPMI_USID>;
#address-cells = <1>;
#size-cells = <0>;
+
+ pm8775_1_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts-extended = <&spmi_bus 0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
};
pmk8775_2: pmic@4 {
@@ -53,5 +105,12 @@ pmk8775_3: pmic@6 {
reg = <0x6 SPMI_USID>;
#address-cells = <1>;
#size-cells = <0>;
+
+ pm8775_3_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts-extended = <&spmi_bus 0x6 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
};
};
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 12/14] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (10 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 11/14] arm64: dts: qcom: sa8775p: pmic: add thermal zones Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-20 15:06 ` Rob Herring
2023-03-23 8:23 ` Linus Walleij
2023-03-14 18:30 ` [PATCH 13/14] pinctrl: qcom: spmi-gpio: add support " Bartosz Golaszewski
2023-03-14 18:30 ` [PATCH 14/14] arm64: dts: qcom: sa8775p: add PMIC GPIO controller nodes Bartosz Golaszewski
13 siblings, 2 replies; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski, Linus Walleij
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add a new compatible for the GPIO controller on the pm8654au PMIC. It
has 12 pins with no holes.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index db505fdeac86..512378a2d4fd 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -58,6 +58,7 @@ properties:
- qcom,pmk8350-gpio
- qcom,pmk8550-gpio
- qcom,pmm8155au-gpio
+ - qcom,pmm8654au-gpio
- qcom,pmp8074-gpio
- qcom,pmr735a-gpio
- qcom,pmr735b-gpio
@@ -439,6 +440,7 @@ $defs:
- gpio1-gpio4 for pmk8350
- gpio1-gpio6 for pmk8550
- gpio1-gpio10 for pmm8155au
+ - gpio1-gpio12 for pmm8654au
- gpio1-gpio12 for pmp8074 (holes on gpio1 and gpio12)
- gpio1-gpio4 for pmr735a
- gpio1-gpio4 for pmr735b
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 12/14] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio
2023-03-14 18:30 ` [PATCH 12/14] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio Bartosz Golaszewski
@ 2023-03-20 15:06 ` Rob Herring
2023-03-23 8:23 ` Linus Walleij
1 sibling, 0 replies; 32+ messages in thread
From: Rob Herring @ 2023-03-20 15:06 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: devicetree, Linus Walleij, Andy Gross, Bjorn Andersson,
linux-gpio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm,
linux-kernel, Konrad Dybcio, Bartosz Golaszewski
On Tue, 14 Mar 2023 19:30:41 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add a new compatible for the GPIO controller on the pm8654au PMIC. It
> has 12 pins with no holes.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 12/14] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio
2023-03-14 18:30 ` [PATCH 12/14] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio Bartosz Golaszewski
2023-03-20 15:06 ` Rob Herring
@ 2023-03-23 8:23 ` Linus Walleij
2023-03-23 13:30 ` Bartosz Golaszewski
1 sibling, 1 reply; 32+ messages in thread
From: Linus Walleij @ 2023-03-23 8:23 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
linux-gpio, Bartosz Golaszewski
On Tue, Mar 14, 2023 at 7:31 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add a new compatible for the GPIO controller on the pm8654au PMIC. It
> has 12 pins with no holes.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
Bartosz are these two something I should apply to the pinctrl
tree or will you queue them?
Either way:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 12/14] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio
2023-03-23 8:23 ` Linus Walleij
@ 2023-03-23 13:30 ` Bartosz Golaszewski
2023-03-28 13:23 ` Linus Walleij
0 siblings, 1 reply; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-23 13:30 UTC (permalink / raw)
To: Linus Walleij
Cc: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel, linux-gpio
On Thu, 23 Mar 2023 at 09:23, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Mar 14, 2023 at 7:31 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add a new compatible for the GPIO controller on the pm8654au PMIC. It
> > has 12 pins with no holes.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
>
> Bartosz are these two something I should apply to the pinctrl
> tree or will you queue them?
> Either way:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
I think it's better if Bjorn takes it through the arm-msm tree if you
don't mind.
Bart
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 12/14] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio
2023-03-23 13:30 ` Bartosz Golaszewski
@ 2023-03-28 13:23 ` Linus Walleij
0 siblings, 0 replies; 32+ messages in thread
From: Linus Walleij @ 2023-03-28 13:23 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel, linux-gpio
On Thu, Mar 23, 2023 at 2:30 PM Bartosz Golaszewski
<bartosz.golaszewski@linaro.org> wrote:
> On Thu, 23 Mar 2023 at 09:23, Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Tue, Mar 14, 2023 at 7:31 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Add a new compatible for the GPIO controller on the pm8654au PMIC. It
> > > has 12 pins with no holes.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > Cc: Linus Walleij <linus.walleij@linaro.org>
> >
> > Bartosz are these two something I should apply to the pinctrl
> > tree or will you queue them?
> > Either way:
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >
>
> I think it's better if Bjorn takes it through the arm-msm tree if you
> don't mind.
That's fine, I'll ACK the latest version so Bjorn can apply it.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 13/14] pinctrl: qcom: spmi-gpio: add support for pmm8654au-gpio
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (11 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 12/14] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
2023-03-14 18:30 ` [PATCH 14/14] arm64: dts: qcom: sa8775p: add PMIC GPIO controller nodes Bartosz Golaszewski
13 siblings, 0 replies; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Bartosz Golaszewski, Linus Walleij
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add support for the GPIO controller present on the pmm8654au PMIC.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index ea3485344f06..0d94175b34f8 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1238,6 +1238,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
{ .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 },
{ .compatible = "qcom,pmk8550-gpio", .data = (void *) 6 },
{ .compatible = "qcom,pmm8155au-gpio", .data = (void *) 10 },
+ { .compatible = "qcom,pmm8654au-gpio", .data = (void *) 12 },
/* pmp8074 has 12 GPIOs with holes on 1 and 12 */
{ .compatible = "qcom,pmp8074-gpio", .data = (void *) 12 },
{ .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH 14/14] arm64: dts: qcom: sa8775p: add PMIC GPIO controller nodes
2023-03-14 18:30 [PATCH 00/14] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
` (12 preceding siblings ...)
2023-03-14 18:30 ` [PATCH 13/14] pinctrl: qcom: spmi-gpio: add support " Bartosz Golaszewski
@ 2023-03-14 18:30 ` Bartosz Golaszewski
13 siblings, 0 replies; 32+ messages in thread
From: Bartosz Golaszewski @ 2023-03-14 18:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Add GPIO controller nodes to PMICs that have the GPIO hooked up on
sa8775p-ride.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
index 437cfa8aee2f..9386a113f1f8 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
@@ -77,6 +77,16 @@ pmk8775_0_pon_resin: resin {
status = "disabled";
};
};
+
+ pm8775_0_gpios: gpio@8800 {
+ compatible = "qcom,pmm8654au-gpio", "qcom,spmi-gpio";
+ reg = <0x8800>;
+ gpio-controller;
+ gpio-ranges = <&pm8775_0_gpios 0 0 12>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
};
pmk8775_1: pmic@2 {
@@ -98,6 +108,16 @@ pmk8775_2: pmic@4 {
reg = <0x4 SPMI_USID>;
#address-cells = <1>;
#size-cells = <0>;
+
+ pm8775_2_gpios: gpio@8800 {
+ compatible = "qcom,pmm8654au-gpio", "qcom,spmi-gpio";
+ reg = <0x8800>;
+ gpio-controller;
+ gpio-ranges = <&pm8775_2_gpios 0 0 12>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
};
pmk8775_3: pmic@6 {
--
2.37.2
^ permalink raw reply related [flat|nested] 32+ messages in thread