[PATCH v1 1/1] gpiolib: Split property name from the warning message

[PATCH v1 1/1] gpiolib: Split property name from the warning message

[Andy Shevchenko]

Split property name from the warning message to make object file
shorter. The linker will use the single copy of it. It's fine
to pass a pointer to the printing function since it's a slow path
anyway.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpiolib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 51a19cbe39a4..112d99a5eec4 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -403,8 +403,8 @@ static int gpiochip_set_names(struct gpio_chip *chip)
 	 * gpiochips.
 	 */
 	if (count <= chip->offset) {
-		dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n",
-			 count, chip->offset);
+		dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n",
+			 "gpio-line-names", count, chip->offset);
 		return 0;
 	}
 
-- 
2.40.0.1.gaa8946217a0b

Re: [PATCH v1 1/1] gpiolib: Split property name from the warning message

[Bartosz Golaszewski]

On Tue, Mar 21, 2023 at 2:52 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Split property name from the warning message to make object file
> shorter. The linker will use the single copy of it. It's fine
> to pass a pointer to the printing function since it's a slow path
> anyway.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/gpio/gpiolib.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 51a19cbe39a4..112d99a5eec4 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -403,8 +403,8 @@ static int gpiochip_set_names(struct gpio_chip *chip)
>          * gpiochips.
>          */
>         if (count <= chip->offset) {
> -               dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n",
> -                        count, chip->offset);
> +               dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n",
> +                        "gpio-line-names", count, chip->offset);
>                 return 0;
>         }
>
> --
> 2.40.0.1.gaa8946217a0b
>

I'd say being able to grep the code easily for messages is more
important than saving a couple bytes here?

Bart

Re: [PATCH v1 1/1] gpiolib: Split property name from the warning message

[Andy Shevchenko]

On Wed, Mar 29, 2023 at 01:37:16PM +0200, Bartosz Golaszewski wrote:
> On Tue, Mar 21, 2023 at 2:52 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

...

> > -               dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n",
> > -                        count, chip->offset);
> > +               dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n",
> > +                        "gpio-line-names", count, chip->offset);
> >                 return 0;
> >         }
> 
> I'd say being able to grep the code easily for messages is more
> important than saving a couple bytes here?

We still grep by the rest of the message. But anyway, up to you,
I've no hard feelings to this patch.

-- 
With Best Regards,
Andy Shevchenko