* [PATCH v2 1/2] dt-bindings: hwmon: adi,ltc2992: correct unit address in example @ 2023-01-18 17:22 Krzysztof Kozlowski 2023-01-18 17:22 ` [PATCH v2 2/2] dt-bindings: hwmon: correct indentation and style in examples Krzysztof Kozlowski 2023-01-18 18:57 ` [PATCH v2 1/2] dt-bindings: hwmon: adi,ltc2992: correct unit address in example Guenter Roeck 0 siblings, 2 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2023-01-18 17:22 UTC (permalink / raw) To: Michael Hennerich, Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Nuno Sá, Robert Marko, Luka Perkov, Alexandru Tachici, Akshay Gupta, Kun Yi, Supreeth Venkatesh, Jonathan Cameron, Linus Walleij, Eric Tremblay, linux-hwmon, devicetree, linux-kernel Cc: Krzysztof Kozlowski, Rob Herring lower-case hex is expected for unit addresses: adi,ltc2992.example.dts:22.24-38.15: Warning (i2c_bus_reg): /example-0/i2c/ltc2992@6F: I2C bus unit address format error, expected "6f" Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Rob Herring <robh@kernel.org> --- Changes since v1: 1. Add Rb tag 2. Reorder patches to silence warnings. --- Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml index 64a8fcb7bc46..ec984248219e 100644 --- a/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml @@ -59,12 +59,12 @@ examples: #address-cells = <1>; #size-cells = <0>; - ltc2992@6F { + ltc2992@6f { #address-cells = <1>; #size-cells = <0>; compatible = "adi,ltc2992"; - reg = <0x6F>; + reg = <0x6f>; channel@0 { reg = <0x0>; -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] dt-bindings: hwmon: correct indentation and style in examples 2023-01-18 17:22 [PATCH v2 1/2] dt-bindings: hwmon: adi,ltc2992: correct unit address in example Krzysztof Kozlowski @ 2023-01-18 17:22 ` Krzysztof Kozlowski 2023-01-18 18:57 ` Guenter Roeck 2023-01-18 18:57 ` [PATCH v2 1/2] dt-bindings: hwmon: adi,ltc2992: correct unit address in example Guenter Roeck 1 sibling, 1 reply; 4+ messages in thread From: Krzysztof Kozlowski @ 2023-01-18 17:22 UTC (permalink / raw) To: Michael Hennerich, Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Nuno Sá, Robert Marko, Luka Perkov, Alexandru Tachici, Akshay Gupta, Kun Yi, Supreeth Venkatesh, Jonathan Cameron, Linus Walleij, Eric Tremblay, linux-hwmon, devicetree, linux-kernel Cc: Krzysztof Kozlowski, Rob Herring Fix mixed indentation to 4-spaces, remove unnecessary suffix from i2c node name and use lower-case hex. No functional impact. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Rob Herring <robh@kernel.org> --- Changes since v1: 1. Add Rb tag 2. Reorder patches to silence warnings. --- .../bindings/hwmon/adi,adm1177.yaml | 12 ++--- .../bindings/hwmon/adi,adm1266.yaml | 6 +-- .../bindings/hwmon/adi,axi-fan-control.yaml | 20 ++++----- .../bindings/hwmon/adi,ltc2947.yaml | 20 ++++----- .../bindings/hwmon/adi,ltc2992.yaml | 26 +++++------ .../devicetree/bindings/hwmon/amd,sbrmi.yaml | 6 +-- .../devicetree/bindings/hwmon/amd,sbtsi.yaml | 6 +-- .../devicetree/bindings/hwmon/iio-hwmon.yaml | 8 ++-- .../bindings/hwmon/national,lm90.yaml | 44 +++++++++---------- .../bindings/hwmon/ntc-thermistor.yaml | 2 +- .../bindings/hwmon/nuvoton,nct7802.yaml | 16 +++---- .../devicetree/bindings/hwmon/ti,tmp513.yaml | 22 +++++----- .../bindings/hwmon/ti,tps23861.yaml | 16 +++---- 13 files changed, 102 insertions(+), 102 deletions(-) diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml index d794deb08bb7..ca2b47320689 100644 --- a/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml @@ -52,16 +52,16 @@ examples: - | #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> - i2c0 { + i2c { #address-cells = <1>; #size-cells = <0>; pwmon@5a { - compatible = "adi,adm1177"; - reg = <0x5a>; - shunt-resistor-micro-ohms = <50000>; /* 50 mOhm */ - adi,shutdown-threshold-microamp = <1059000>; /* 1.059 A */ - adi,vrange-high-enable; + compatible = "adi,adm1177"; + reg = <0x5a>; + shunt-resistor-micro-ohms = <50000>; /* 50 mOhm */ + adi,shutdown-threshold-microamp = <1059000>; /* 1.059 A */ + adi,vrange-high-enable; }; }; ... diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml index 43b4f4f57b49..4f8e11bd5142 100644 --- a/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml @@ -39,13 +39,13 @@ additionalProperties: false examples: - | - i2c0 { + i2c { #address-cells = <1>; #size-cells = <0>; adm1266@40 { - compatible = "adi,adm1266"; - reg = <0x40>; + compatible = "adi,adm1266"; + reg = <0x40>; }; }; ... diff --git a/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml b/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml index f2f99afb3a3b..0cf3ed6212a6 100644 --- a/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml +++ b/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml @@ -49,15 +49,15 @@ additionalProperties: false examples: - | fpga_axi: fpga-axi { - #address-cells = <0x2>; - #size-cells = <0x1>; - - axi_fan_control: axi-fan-control@80000000 { - compatible = "adi,axi-fan-control-1.00.a"; - reg = <0x0 0x80000000 0x10000>; - clocks = <&clk 71>; - interrupts = <0 110 0>; - pulses-per-revolution = <2>; - }; + #address-cells = <0x2>; + #size-cells = <0x1>; + + axi_fan_control: axi-fan-control@80000000 { + compatible = "adi,axi-fan-control-1.00.a"; + reg = <0x0 0x80000000 0x10000>; + clocks = <&clk 71>; + interrupts = <0 110 0>; + pulses-per-revolution = <2>; + }; }; ... diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml index bf04151b63d2..152935334c76 100644 --- a/Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml @@ -87,15 +87,15 @@ additionalProperties: false examples: - | spi { - #address-cells = <1>; - #size-cells = <0>; - - ltc2947_spi: ltc2947@0 { - compatible = "adi,ltc2947"; - reg = <0>; - /* accumulation takes place always for energ1/charge1. */ - /* accumulation only on positive current for energy2/charge2. */ - adi,accumulator-ctl-pol = <0 1>; - }; + #address-cells = <1>; + #size-cells = <0>; + + ltc2947_spi: ltc2947@0 { + compatible = "adi,ltc2947"; + reg = <0>; + /* accumulation takes place always for energ1/charge1. */ + /* accumulation only on positive current for energy2/charge2. */ + adi,accumulator-ctl-pol = <0 1>; + }; }; ... diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml index ec984248219e..dba74f400bc2 100644 --- a/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml @@ -55,26 +55,26 @@ additionalProperties: false examples: - | - i2c1 { + i2c { #address-cells = <1>; #size-cells = <0>; ltc2992@6f { - #address-cells = <1>; - #size-cells = <0>; + #address-cells = <1>; + #size-cells = <0>; - compatible = "adi,ltc2992"; - reg = <0x6f>; + compatible = "adi,ltc2992"; + reg = <0x6f>; - channel@0 { - reg = <0x0>; - shunt-resistor-micro-ohms = <10000>; - }; + channel@0 { + reg = <0x0>; + shunt-resistor-micro-ohms = <10000>; + }; - channel@1 { - reg = <0x1>; - shunt-resistor-micro-ohms = <10000>; - }; + channel@1 { + reg = <0x1>; + shunt-resistor-micro-ohms = <10000>; + }; }; }; ... diff --git a/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml b/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml index 7598b083979c..353d81d89bf5 100644 --- a/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml +++ b/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml @@ -41,13 +41,13 @@ additionalProperties: false examples: - | - i2c0 { + i2c { #address-cells = <1>; #size-cells = <0>; sbrmi@3c { - compatible = "amd,sbrmi"; - reg = <0x3c>; + compatible = "amd,sbrmi"; + reg = <0x3c>; }; }; ... diff --git a/Documentation/devicetree/bindings/hwmon/amd,sbtsi.yaml b/Documentation/devicetree/bindings/hwmon/amd,sbtsi.yaml index 446b09f1ce94..75088244a274 100644 --- a/Documentation/devicetree/bindings/hwmon/amd,sbtsi.yaml +++ b/Documentation/devicetree/bindings/hwmon/amd,sbtsi.yaml @@ -42,13 +42,13 @@ additionalProperties: false examples: - | - i2c0 { + i2c { #address-cells = <1>; #size-cells = <0>; sbtsi@4c { - compatible = "amd,sbtsi"; - reg = <0x4c>; + compatible = "amd,sbtsi"; + reg = <0x4c>; }; }; ... diff --git a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml index e1ccbd30e0eb..c54b5986b365 100644 --- a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml +++ b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml @@ -31,7 +31,7 @@ additionalProperties: false examples: - | - iio-hwmon { - compatible = "iio-hwmon"; - io-channels = <&adc 1>, <&adc 2>; - }; + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc 1>, <&adc 2>; + }; diff --git a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml index e1719839faf0..7b9d48d6d6da 100644 --- a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml +++ b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml @@ -198,30 +198,30 @@ examples: }; - | i2c { - #address-cells = <1>; - #size-cells = <0>; - - sensor@4c { - compatible = "adi,adt7481"; - reg = <0x4c>; #address-cells = <1>; #size-cells = <0>; - channel@0 { - reg = <0x0>; - label = "local"; - }; - - channel@1 { - reg = <0x1>; - label = "front"; - temperature-offset-millicelsius = <4000>; - }; - - channel@2 { - reg = <0x2>; - label = "back"; - temperature-offset-millicelsius = <750>; + sensor@4c { + compatible = "adi,adt7481"; + reg = <0x4c>; + #address-cells = <1>; + #size-cells = <0>; + + channel@0 { + reg = <0x0>; + label = "local"; + }; + + channel@1 { + reg = <0x1>; + label = "front"; + temperature-offset-millicelsius = <4000>; + }; + + channel@2 { + reg = <0x2>; + label = "back"; + temperature-offset-millicelsius = <750>; + }; }; - }; }; diff --git a/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml b/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml index 6a1920712fb9..3d0146e20d3e 100644 --- a/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml +++ b/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml @@ -131,7 +131,7 @@ additionalProperties: false examples: - | - thermistor0 { + thermistor { compatible = "murata,ncp18wb473"; io-channels = <&gpadc 0x06>; pullup-uv = <1800000>; diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml index 2f0620ecccc9..cd8dcd797031 100644 --- a/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml @@ -123,23 +123,23 @@ examples: #size-cells = <0>; channel@0 { /* LTD */ - reg = <0>; + reg = <0>; }; channel@1 { /* RTD1 */ - reg = <1>; - sensor-type = "voltage"; + reg = <1>; + sensor-type = "voltage"; }; channel@2 { /* RTD2 */ - reg = <2>; - sensor-type = "temperature"; - temperature-mode = "thermal-diode"; + reg = <2>; + sensor-type = "temperature"; + temperature-mode = "thermal-diode"; }; channel@3 { /* RTD3 */ - reg = <3>; - sensor-type = "temperature"; + reg = <3>; + sensor-type = "temperature"; }; }; }; diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml index 1502b22c77cc..fde5225ce012 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml @@ -77,15 +77,15 @@ additionalProperties: false examples: - | i2c { - #address-cells = <1>; - #size-cells = <0>; - - tmp513@5c { - compatible = "ti,tmp513"; - reg = <0x5C>; - shunt-resistor-micro-ohms = <330000>; - ti,bus-range-microvolt = <32000000>; - ti,pga-gain = <8>; - ti,nfactor = <0x1 0xF3 0x00>; - }; + #address-cells = <1>; + #size-cells = <0>; + + tmp513@5c { + compatible = "ti,tmp513"; + reg = <0x5c>; + shunt-resistor-micro-ohms = <330000>; + ti,bus-range-microvolt = <32000000>; + ti,pga-gain = <8>; + ti,nfactor = <0x1 0xf3 0x00>; + }; }; diff --git a/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml b/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml index 3bc8e73dfbf0..bce68a326919 100644 --- a/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml +++ b/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml @@ -40,12 +40,12 @@ additionalProperties: false examples: - | i2c { - #address-cells = <1>; - #size-cells = <0>; - - tps23861@30 { - compatible = "ti,tps23861"; - reg = <0x30>; - shunt-resistor-micro-ohms = <255000>; - }; + #address-cells = <1>; + #size-cells = <0>; + + tps23861@30 { + compatible = "ti,tps23861"; + reg = <0x30>; + shunt-resistor-micro-ohms = <255000>; + }; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: hwmon: correct indentation and style in examples 2023-01-18 17:22 ` [PATCH v2 2/2] dt-bindings: hwmon: correct indentation and style in examples Krzysztof Kozlowski @ 2023-01-18 18:57 ` Guenter Roeck 0 siblings, 0 replies; 4+ messages in thread From: Guenter Roeck @ 2023-01-18 18:57 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Michael Hennerich, Jean Delvare, Rob Herring, Krzysztof Kozlowski, Nuno Sá, Robert Marko, Luka Perkov, Alexandru Tachici, Akshay Gupta, Kun Yi, Supreeth Venkatesh, Jonathan Cameron, Linus Walleij, Eric Tremblay, linux-hwmon, devicetree, linux-kernel, Rob Herring On Wed, Jan 18, 2023 at 06:22:37PM +0100, Krzysztof Kozlowski wrote: > Fix mixed indentation to 4-spaces, remove unnecessary suffix from > i2c node name and use lower-case hex. No functional impact. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> Applied to hwmon-next. Thanks, Guenter > --- > > Changes since v1: > 1. Add Rb tag > 2. Reorder patches to silence warnings. > --- > .../bindings/hwmon/adi,adm1177.yaml | 12 ++--- > .../bindings/hwmon/adi,adm1266.yaml | 6 +-- > .../bindings/hwmon/adi,axi-fan-control.yaml | 20 ++++----- > .../bindings/hwmon/adi,ltc2947.yaml | 20 ++++----- > .../bindings/hwmon/adi,ltc2992.yaml | 26 +++++------ > .../devicetree/bindings/hwmon/amd,sbrmi.yaml | 6 +-- > .../devicetree/bindings/hwmon/amd,sbtsi.yaml | 6 +-- > .../devicetree/bindings/hwmon/iio-hwmon.yaml | 8 ++-- > .../bindings/hwmon/national,lm90.yaml | 44 +++++++++---------- > .../bindings/hwmon/ntc-thermistor.yaml | 2 +- > .../bindings/hwmon/nuvoton,nct7802.yaml | 16 +++---- > .../devicetree/bindings/hwmon/ti,tmp513.yaml | 22 +++++----- > .../bindings/hwmon/ti,tps23861.yaml | 16 +++---- > 13 files changed, 102 insertions(+), 102 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml > index d794deb08bb7..ca2b47320689 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml > @@ -52,16 +52,16 @@ examples: > - | > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/interrupt-controller/irq.h> > - i2c0 { > + i2c { > #address-cells = <1>; > #size-cells = <0>; > > pwmon@5a { > - compatible = "adi,adm1177"; > - reg = <0x5a>; > - shunt-resistor-micro-ohms = <50000>; /* 50 mOhm */ > - adi,shutdown-threshold-microamp = <1059000>; /* 1.059 A */ > - adi,vrange-high-enable; > + compatible = "adi,adm1177"; > + reg = <0x5a>; > + shunt-resistor-micro-ohms = <50000>; /* 50 mOhm */ > + adi,shutdown-threshold-microamp = <1059000>; /* 1.059 A */ > + adi,vrange-high-enable; > }; > }; > ... > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml > index 43b4f4f57b49..4f8e11bd5142 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1266.yaml > @@ -39,13 +39,13 @@ additionalProperties: false > > examples: > - | > - i2c0 { > + i2c { > #address-cells = <1>; > #size-cells = <0>; > > adm1266@40 { > - compatible = "adi,adm1266"; > - reg = <0x40>; > + compatible = "adi,adm1266"; > + reg = <0x40>; > }; > }; > ... > diff --git a/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml b/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml > index f2f99afb3a3b..0cf3ed6212a6 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml > @@ -49,15 +49,15 @@ additionalProperties: false > examples: > - | > fpga_axi: fpga-axi { > - #address-cells = <0x2>; > - #size-cells = <0x1>; > - > - axi_fan_control: axi-fan-control@80000000 { > - compatible = "adi,axi-fan-control-1.00.a"; > - reg = <0x0 0x80000000 0x10000>; > - clocks = <&clk 71>; > - interrupts = <0 110 0>; > - pulses-per-revolution = <2>; > - }; > + #address-cells = <0x2>; > + #size-cells = <0x1>; > + > + axi_fan_control: axi-fan-control@80000000 { > + compatible = "adi,axi-fan-control-1.00.a"; > + reg = <0x0 0x80000000 0x10000>; > + clocks = <&clk 71>; > + interrupts = <0 110 0>; > + pulses-per-revolution = <2>; > + }; > }; > ... > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml > index bf04151b63d2..152935334c76 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml > @@ -87,15 +87,15 @@ additionalProperties: false > examples: > - | > spi { > - #address-cells = <1>; > - #size-cells = <0>; > - > - ltc2947_spi: ltc2947@0 { > - compatible = "adi,ltc2947"; > - reg = <0>; > - /* accumulation takes place always for energ1/charge1. */ > - /* accumulation only on positive current for energy2/charge2. */ > - adi,accumulator-ctl-pol = <0 1>; > - }; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ltc2947_spi: ltc2947@0 { > + compatible = "adi,ltc2947"; > + reg = <0>; > + /* accumulation takes place always for energ1/charge1. */ > + /* accumulation only on positive current for energy2/charge2. */ > + adi,accumulator-ctl-pol = <0 1>; > + }; > }; > ... > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml > index ec984248219e..dba74f400bc2 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml > @@ -55,26 +55,26 @@ additionalProperties: false > > examples: > - | > - i2c1 { > + i2c { > #address-cells = <1>; > #size-cells = <0>; > > ltc2992@6f { > - #address-cells = <1>; > - #size-cells = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > > - compatible = "adi,ltc2992"; > - reg = <0x6f>; > + compatible = "adi,ltc2992"; > + reg = <0x6f>; > > - channel@0 { > - reg = <0x0>; > - shunt-resistor-micro-ohms = <10000>; > - }; > + channel@0 { > + reg = <0x0>; > + shunt-resistor-micro-ohms = <10000>; > + }; > > - channel@1 { > - reg = <0x1>; > - shunt-resistor-micro-ohms = <10000>; > - }; > + channel@1 { > + reg = <0x1>; > + shunt-resistor-micro-ohms = <10000>; > + }; > }; > }; > ... > diff --git a/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml b/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml > index 7598b083979c..353d81d89bf5 100644 > --- a/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml > +++ b/Documentation/devicetree/bindings/hwmon/amd,sbrmi.yaml > @@ -41,13 +41,13 @@ additionalProperties: false > > examples: > - | > - i2c0 { > + i2c { > #address-cells = <1>; > #size-cells = <0>; > > sbrmi@3c { > - compatible = "amd,sbrmi"; > - reg = <0x3c>; > + compatible = "amd,sbrmi"; > + reg = <0x3c>; > }; > }; > ... > diff --git a/Documentation/devicetree/bindings/hwmon/amd,sbtsi.yaml b/Documentation/devicetree/bindings/hwmon/amd,sbtsi.yaml > index 446b09f1ce94..75088244a274 100644 > --- a/Documentation/devicetree/bindings/hwmon/amd,sbtsi.yaml > +++ b/Documentation/devicetree/bindings/hwmon/amd,sbtsi.yaml > @@ -42,13 +42,13 @@ additionalProperties: false > > examples: > - | > - i2c0 { > + i2c { > #address-cells = <1>; > #size-cells = <0>; > > sbtsi@4c { > - compatible = "amd,sbtsi"; > - reg = <0x4c>; > + compatible = "amd,sbtsi"; > + reg = <0x4c>; > }; > }; > ... > diff --git a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml > index e1ccbd30e0eb..c54b5986b365 100644 > --- a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml > +++ b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml > @@ -31,7 +31,7 @@ additionalProperties: false > > examples: > - | > - iio-hwmon { > - compatible = "iio-hwmon"; > - io-channels = <&adc 1>, <&adc 2>; > - }; > + iio-hwmon { > + compatible = "iio-hwmon"; > + io-channels = <&adc 1>, <&adc 2>; > + }; > diff --git a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml > index e1719839faf0..7b9d48d6d6da 100644 > --- a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml > +++ b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml > @@ -198,30 +198,30 @@ examples: > }; > - | > i2c { > - #address-cells = <1>; > - #size-cells = <0>; > - > - sensor@4c { > - compatible = "adi,adt7481"; > - reg = <0x4c>; > #address-cells = <1>; > #size-cells = <0>; > > - channel@0 { > - reg = <0x0>; > - label = "local"; > - }; > - > - channel@1 { > - reg = <0x1>; > - label = "front"; > - temperature-offset-millicelsius = <4000>; > - }; > - > - channel@2 { > - reg = <0x2>; > - label = "back"; > - temperature-offset-millicelsius = <750>; > + sensor@4c { > + compatible = "adi,adt7481"; > + reg = <0x4c>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + channel@0 { > + reg = <0x0>; > + label = "local"; > + }; > + > + channel@1 { > + reg = <0x1>; > + label = "front"; > + temperature-offset-millicelsius = <4000>; > + }; > + > + channel@2 { > + reg = <0x2>; > + label = "back"; > + temperature-offset-millicelsius = <750>; > + }; > }; > - }; > }; > diff --git a/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml b/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml > index 6a1920712fb9..3d0146e20d3e 100644 > --- a/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml > @@ -131,7 +131,7 @@ additionalProperties: false > > examples: > - | > - thermistor0 { > + thermistor { > compatible = "murata,ncp18wb473"; > io-channels = <&gpadc 0x06>; > pullup-uv = <1800000>; > diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml > index 2f0620ecccc9..cd8dcd797031 100644 > --- a/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml > +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml > @@ -123,23 +123,23 @@ examples: > #size-cells = <0>; > > channel@0 { /* LTD */ > - reg = <0>; > + reg = <0>; > }; > > channel@1 { /* RTD1 */ > - reg = <1>; > - sensor-type = "voltage"; > + reg = <1>; > + sensor-type = "voltage"; > }; > > channel@2 { /* RTD2 */ > - reg = <2>; > - sensor-type = "temperature"; > - temperature-mode = "thermal-diode"; > + reg = <2>; > + sensor-type = "temperature"; > + temperature-mode = "thermal-diode"; > }; > > channel@3 { /* RTD3 */ > - reg = <3>; > - sensor-type = "temperature"; > + reg = <3>; > + sensor-type = "temperature"; > }; > }; > }; > diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > index 1502b22c77cc..fde5225ce012 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > @@ -77,15 +77,15 @@ additionalProperties: false > examples: > - | > i2c { > - #address-cells = <1>; > - #size-cells = <0>; > - > - tmp513@5c { > - compatible = "ti,tmp513"; > - reg = <0x5C>; > - shunt-resistor-micro-ohms = <330000>; > - ti,bus-range-microvolt = <32000000>; > - ti,pga-gain = <8>; > - ti,nfactor = <0x1 0xF3 0x00>; > - }; > + #address-cells = <1>; > + #size-cells = <0>; > + > + tmp513@5c { > + compatible = "ti,tmp513"; > + reg = <0x5c>; > + shunt-resistor-micro-ohms = <330000>; > + ti,bus-range-microvolt = <32000000>; > + ti,pga-gain = <8>; > + ti,nfactor = <0x1 0xf3 0x00>; > + }; > }; > diff --git a/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml b/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml > index 3bc8e73dfbf0..bce68a326919 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml > @@ -40,12 +40,12 @@ additionalProperties: false > examples: > - | > i2c { > - #address-cells = <1>; > - #size-cells = <0>; > - > - tps23861@30 { > - compatible = "ti,tps23861"; > - reg = <0x30>; > - shunt-resistor-micro-ohms = <255000>; > - }; > + #address-cells = <1>; > + #size-cells = <0>; > + > + tps23861@30 { > + compatible = "ti,tps23861"; > + reg = <0x30>; > + shunt-resistor-micro-ohms = <255000>; > + }; > }; ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: hwmon: adi,ltc2992: correct unit address in example 2023-01-18 17:22 [PATCH v2 1/2] dt-bindings: hwmon: adi,ltc2992: correct unit address in example Krzysztof Kozlowski 2023-01-18 17:22 ` [PATCH v2 2/2] dt-bindings: hwmon: correct indentation and style in examples Krzysztof Kozlowski @ 2023-01-18 18:57 ` Guenter Roeck 1 sibling, 0 replies; 4+ messages in thread From: Guenter Roeck @ 2023-01-18 18:57 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Michael Hennerich, Jean Delvare, Rob Herring, Krzysztof Kozlowski, Nuno Sá, Robert Marko, Luka Perkov, Alexandru Tachici, Akshay Gupta, Kun Yi, Supreeth Venkatesh, Jonathan Cameron, Linus Walleij, Eric Tremblay, linux-hwmon, devicetree, linux-kernel, Rob Herring On Wed, Jan 18, 2023 at 06:22:36PM +0100, Krzysztof Kozlowski wrote: > lower-case hex is expected for unit addresses: > > adi,ltc2992.example.dts:22.24-38.15: Warning (i2c_bus_reg): /example-0/i2c/ltc2992@6F: I2C bus unit address format error, expected "6f" > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> Applied to hwmon-next. Thanks, Guenter > --- > > Changes since v1: > 1. Add Rb tag > 2. Reorder patches to silence warnings. > --- > Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml > index 64a8fcb7bc46..ec984248219e 100644 > --- a/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2992.yaml > @@ -59,12 +59,12 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > - ltc2992@6F { > + ltc2992@6f { > #address-cells = <1>; > #size-cells = <0>; > > compatible = "adi,ltc2992"; > - reg = <0x6F>; > + reg = <0x6f>; > > channel@0 { > reg = <0x0>; ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-18 18:58 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-01-18 17:22 [PATCH v2 1/2] dt-bindings: hwmon: adi,ltc2992: correct unit address in example Krzysztof Kozlowski 2023-01-18 17:22 ` [PATCH v2 2/2] dt-bindings: hwmon: correct indentation and style in examples Krzysztof Kozlowski 2023-01-18 18:57 ` Guenter Roeck 2023-01-18 18:57 ` [PATCH v2 1/2] dt-bindings: hwmon: adi,ltc2992: correct unit address in example Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).