From: Wolfram Sang <wsa@the-dreams.de>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Kieran Bingham" <kieran@ksquared.org.uk>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jacopo Mondi" <jacopo@jmondi.org>,
"Vladimir Zapolskiy" <vz@mleia.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Linux I2C" <linux-i2c@vger.kernel.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
linux-i3c@lists.infradead.org,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Subject: Re: [RFC PATCH 7/7] i2c: core: hand over reserved devices when requesting ancillary addresses
Date: Thu, 12 Mar 2020 12:30:43 +0100 [thread overview]
Message-ID: <20200312113042.GD1013@ninjato> (raw)
In-Reply-To: <dc831357-8545-6f6e-71a2-bef282e0bd94@lucaceresoli.net>
[-- Attachment #1.1: Type: text/plain, Size: 1228 bytes --]
> >> + strlcpy(reserved_client->name, I2C_DUMMY_DRV_NAME, sizeof(client->name));
>
> Any strong reason for not giving the device a more informative name?
Yes, sadly...
> Reading "dummy" in several /sys/bus/i2c/devices/?-????/name files is not
> helping. Using the 'name' string that is passed to
> i2c_new_ancillary_device() would be way better, perhaps prefixed by
> dev->name. But this opens the question of why not doing it in
... I never liked the plain "dummy" name as well. However, because
'name' is what we need to bind to a driver we can't have a more
descriptive or run-time generated name at that place.
> i2c_new_dummy_device() as well, which currently receives no "name"
> parameter.
I thought about it but discarded the idea because then you still have
no connection to the driver which created the dummy device. My
favourite idea so far is to advertise i2c_new_ancillary_device() instead
of i2c_new_dummy_device(), because there we already have access to the
client structure. With that, we could add another link in sysfs to the
main address and vice-versa.
> Of course this is not strictly related to this patch and can be done in
> a later step.
Exactly.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 155 bytes --]
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-03-12 11:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 17:23 [RFC PATCH 0/7] i2c: of: reserve unknown and ancillary addresses Wolfram Sang
2020-02-20 17:23 ` [RFC PATCH 1/7] i2c: add sanity check for parameter of i2c_verify_client() Wolfram Sang
2020-02-21 9:36 ` Geert Uytterhoeven
2020-02-20 17:23 ` [RFC PATCH 2/7] i2c: use DEFINE for the dummy driver name Wolfram Sang
2020-02-21 9:38 ` Geert Uytterhoeven
2020-02-20 17:23 ` [RFC PATCH 3/7] i2c: allow DT nodes without 'compatible' Wolfram Sang
2020-02-21 9:45 ` Geert Uytterhoeven
2020-02-21 9:48 ` Geert Uytterhoeven
2020-02-23 23:11 ` Luca Ceresoli
2020-03-12 11:19 ` Wolfram Sang
2020-03-12 11:44 ` Alexandre Belloni
2020-04-10 13:47 ` Luca Ceresoli
2020-02-26 16:30 ` Rob Herring
2020-02-20 17:24 ` [RFC PATCH 4/7] i2c: of: remove superfluous parameter from exported function Wolfram Sang
2020-02-21 9:50 ` Geert Uytterhoeven
2020-02-24 8:12 ` Luca Ceresoli
2020-02-20 17:24 ` [RFC PATCH 5/7] i2c: of: error message unification Wolfram Sang
2020-02-21 9:54 ` Geert Uytterhoeven
2020-02-20 17:24 ` [RFC PATCH 6/7] i2c: of: mark a whole array of regs as reserved Wolfram Sang
2020-02-21 10:09 ` Geert Uytterhoeven
2020-03-12 11:21 ` Wolfram Sang
2020-03-18 14:33 ` Wolfram Sang
2020-02-28 12:11 ` Luca Ceresoli
2020-02-20 17:24 ` [RFC PATCH 7/7] i2c: core: hand over reserved devices when requesting ancillary addresses Wolfram Sang
2020-02-21 10:13 ` Geert Uytterhoeven
2020-02-28 12:11 ` Luca Ceresoli
2020-03-12 11:30 ` Wolfram Sang [this message]
2020-03-12 11:21 ` Wolfram Sang
2020-03-13 12:42 ` Wolfram Sang
2020-02-21 10:15 ` [RFC PATCH 0/7] i2c: of: reserve unknown and " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312113042.GD1013@ninjato \
--to=wsa@the-dreams.de \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=jacopo@jmondi.org \
--cc=kieran@ksquared.org.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=niklas.soderlund@ragnatech.se \
--cc=vz@mleia.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).