From: Luca Ceresoli <luca@lucaceresoli.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, "Jacopo Mondi" <jacopo@jmondi.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Kieran Bingham" <kieran@ksquared.org.uk>,
"Vladimir Zapolskiy" <vz@mleia.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Linux I2C" <linux-i2c@vger.kernel.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
linux-i3c@lists.infradead.org,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Subject: Re: [RFC PATCH 7/7] i2c: core: hand over reserved devices when requesting ancillary addresses
Date: Fri, 28 Feb 2020 13:11:53 +0100 [thread overview]
Message-ID: <dc831357-8545-6f6e-71a2-bef282e0bd94@lucaceresoli.net> (raw)
In-Reply-To: <CAMuHMdV-dfjukuSKiFg4vb4Ntn+XWU0XwHPxyoaWs1vtQVg4cw@mail.gmail.com>
Hi,
On 21/02/20 11:13, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Thu, Feb 20, 2020 at 6:26 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
>> With i2c_new_ancillary_address, we can check if the intended driver is
>> requesting a reserved address. Update the function to do these checks.
>> If the check passes, the "reserved" device will become a regular "dummy"
>> device.
>>
>> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Thanks for your patch!
>
>> --- a/drivers/i2c/i2c-core-base.c
>> +++ b/drivers/i2c/i2c-core-base.c
>> @@ -975,6 +975,8 @@ struct i2c_client *i2c_new_ancillary_device(struct i2c_client *client,
>> u16 default_addr)
>> {
>> struct device_node *np = client->dev.of_node;
>> + struct device *reserved_dev, *adapter_dev = &client->adapter->dev;
>> + struct i2c_client *reserved_client;
>> u32 addr = default_addr;
>> int i;
>>
>> @@ -984,7 +986,21 @@ struct i2c_client *i2c_new_ancillary_device(struct i2c_client *client,
>> of_property_read_u32_index(np, "reg", i, &addr);
>> }
>>
>> - dev_dbg(&client->adapter->dev, "Address for %s : 0x%x\n", name, addr);
>> + dev_info(adapter_dev, "Address for %s : 0x%x\n", name, addr);
>> +
>> + /* No need to scan muxes, siblings must sit on the same adapter */
>> + reserved_dev = device_find_child(adapter_dev, &addr, __i2c_check_addr_busy);
>> + reserved_client = i2c_verify_client(reserved_dev);
>> +
>> + if (reserved_client) {
>> + if (reserved_client->dev.of_node != np ||
>> + strcmp(reserved_client->name, I2C_RESERVED_DRV_NAME) != 0)
>> + return ERR_PTR(-EBUSY);
>
> Missing put_device(reserved_dev).
>
>> +
>> + strlcpy(reserved_client->name, I2C_DUMMY_DRV_NAME, sizeof(client->name));
Any strong reason for not giving the device a more informative name?
Reading "dummy" in several /sys/bus/i2c/devices/?-????/name files is not
helping. Using the 'name' string that is passed to
i2c_new_ancillary_device() would be way better, perhaps prefixed by
dev->name. But this opens the question of why not doing it in
i2c_new_dummy_device() as well, which currently receives no "name"
parameter.
Of course this is not strictly related to this patch and can be done in
a later step.
About the patch itself, except for the issues pointed out by Geert the
approach looks generally good to me.
--
Luca
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-02-28 12:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 17:23 [RFC PATCH 0/7] i2c: of: reserve unknown and ancillary addresses Wolfram Sang
2020-02-20 17:23 ` [RFC PATCH 1/7] i2c: add sanity check for parameter of i2c_verify_client() Wolfram Sang
2020-02-21 9:36 ` Geert Uytterhoeven
2020-02-20 17:23 ` [RFC PATCH 2/7] i2c: use DEFINE for the dummy driver name Wolfram Sang
2020-02-21 9:38 ` Geert Uytterhoeven
2020-02-20 17:23 ` [RFC PATCH 3/7] i2c: allow DT nodes without 'compatible' Wolfram Sang
2020-02-21 9:45 ` Geert Uytterhoeven
2020-02-21 9:48 ` Geert Uytterhoeven
2020-02-23 23:11 ` Luca Ceresoli
2020-03-12 11:19 ` Wolfram Sang
2020-03-12 11:44 ` Alexandre Belloni
2020-04-10 13:47 ` Luca Ceresoli
2020-02-26 16:30 ` Rob Herring
2020-02-20 17:24 ` [RFC PATCH 4/7] i2c: of: remove superfluous parameter from exported function Wolfram Sang
2020-02-21 9:50 ` Geert Uytterhoeven
2020-02-24 8:12 ` Luca Ceresoli
2020-02-20 17:24 ` [RFC PATCH 5/7] i2c: of: error message unification Wolfram Sang
2020-02-21 9:54 ` Geert Uytterhoeven
2020-02-20 17:24 ` [RFC PATCH 6/7] i2c: of: mark a whole array of regs as reserved Wolfram Sang
2020-02-21 10:09 ` Geert Uytterhoeven
2020-03-12 11:21 ` Wolfram Sang
2020-03-18 14:33 ` Wolfram Sang
2020-02-28 12:11 ` Luca Ceresoli
2020-02-20 17:24 ` [RFC PATCH 7/7] i2c: core: hand over reserved devices when requesting ancillary addresses Wolfram Sang
2020-02-21 10:13 ` Geert Uytterhoeven
2020-02-28 12:11 ` Luca Ceresoli [this message]
2020-03-12 11:30 ` Wolfram Sang
2020-03-12 11:21 ` Wolfram Sang
2020-03-13 12:42 ` Wolfram Sang
2020-02-21 10:15 ` [RFC PATCH 0/7] i2c: of: reserve unknown and " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc831357-8545-6f6e-71a2-bef282e0bd94@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=jacopo@jmondi.org \
--cc=kieran@ksquared.org.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=vz@mleia.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).