Re: [PATCH 0/5] ti_am335x_tsc: Enable wakeup capability

From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Vignesh R <vigneshr@ti.com>, Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 0/5] ti_am335x_tsc: Enable wakeup capability
Date: Mon, 23 Jul 2018 06:37:08 +0100	[thread overview]
Message-ID: <20180723053708.GA4213@dell> (raw)
In-Reply-To: <20180718170902.vk7rahyoaevucxbi@penguin>

On Wed, 18 Jul 2018, Dmitry Torokhov wrote:

> On Wed, Jul 18, 2018 at 08:47:36AM +0100, Lee Jones wrote:
> > On Tue, 17 Jul 2018, Vignesh R wrote:
> > 
> > > Hi Dmitry,
> > > 
> > > On Saturday 30 June 2018 04:03 PM, Vignesh R wrote:
> > > > On AM335x, resistive TSC can wakeup the system from low power state.
> > > > Currently, parent MFD device is marked as wakeup source, which is
> > > > inaccurate as its the touch event generated by TSC thats the wakeup
> > > > source. This series moves all wakeup related calls to operate on TSC
> > > > device instead of MFD. It also marks TSC IRQ as wakeup capable, so that
> > > > its not disabled during system suspend.
> > > > 
> > > > This series is based on Dmitry's comments here:
> > > > https://lkml.org/lkml/2018/4/24/65
> > > > 
> > > > There are many new patches in this series, hence did not mark this as v4.
> > > > 
> > > > Vignesh R (5):
> > > >   mfd: ti_am335x_tscadc: Don't mark TSCADC MFD as wakeup capable
> > > >   Input: ti_am335x_tsc: Mark TSC device as wakeup source
> > > >   mfd: ti_am335x_tscadc: Keep ADC interface on if child is wakeup
> > > >     capable
> > > >   iio: adc: ti_am335x_adc: Disable ADC during suspend unconditionally
> > > >   Input: ti_am335x_tsc: Mark IRQ as wakeup capable
> > > > 
> > > >  drivers/iio/adc/ti_am335x_adc.c           | 12 ++++--------
> > > >  drivers/input/touchscreen/ti_am335x_tsc.c | 22 +++++++++++++++++-----
> > > >  drivers/mfd/ti_am335x_tscadc.c            | 14 +++++++++++++-
> > > >  3 files changed, 34 insertions(+), 14 deletions(-)
> > > > 
> > > 
> > > Gentle ping... Could you review/pick this series? MFD amd IIO bits are
> > > already ACKed
> > 
> > MFD patches are reviewed "for my own reference" meaning that we
> > haven't yet agreed on a merge plan yet.
> 
> I think this series makes sense to be pushed through a single tree as
> opposed to being spread between 3, even if it could technically be
> possible. It looks like Jonathan is fine with going it through either
> his or some other tree, I am fine with it going through MFD.

I'm happy either way.

> I just Acked the 2 input-related patches.

Thanks Dmitry.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog