[PATCH 2/2] iio: dac: ds4422/ds4424 fix chip verification

[PATCH 2/2] iio: dac: ds4422/ds4424 fix chip verification

[Ruslan Babayev]

The ds4424_get_value function takes channel number as it's 3rd
argument and translates it internally into I2C address using
DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an
already translated I2C address as its last argument.

Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
Cc: xe-linux-external@cisco.com
---
 drivers/iio/dac/ds4424.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
index 2b3ba1a66fe8..ae9be792693b 100644
--- a/drivers/iio/dac/ds4424.c
+++ b/drivers/iio/dac/ds4424.c
@@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio_dev *indio_dev)
 {
 	int ret, val;
 
-	ret = ds4424_get_value(indio_dev, &val, DS4424_DAC_ADDR(0));
+	ret = ds4424_get_value(indio_dev, &val, 0);
 	if (ret < 0)
 		dev_err(&indio_dev->dev,
 				"%s failed. ret: %d\n", __func__, ret);
-- 
2.17.1

Re: [PATCH 2/2] iio: dac: ds4422/ds4424 fix chip verification

[Jonathan Cameron]

On Sun,  5 May 2019 12:24:37 -0700
Ruslan Babayev <ruslan@babayev.com> wrote:

> The ds4424_get_value function takes channel number as it's 3rd
> argument and translates it internally into I2C address using
> DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an
> already translated I2C address as its last argument.
> 
> Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
> Cc: xe-linux-external@cisco.com
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ds4424.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index 2b3ba1a66fe8..ae9be792693b 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio_dev *indio_dev)
>  {
>  	int ret, val;
>  
> -	ret = ds4424_get_value(indio_dev, &val, DS4424_DAC_ADDR(0));
> +	ret = ds4424_get_value(indio_dev, &val, 0);
>  	if (ret < 0)
>  		dev_err(&indio_dev->dev,
>  				"%s failed. ret: %d\n", __func__, ret);