linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/14] iio: SPDX headers for core + non device driver parts.
@ 2019-06-22 14:55 jic23
  2019-06-22 14:55 ` [PATCH 01/14] iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE jic23
                   ` (14 more replies)
  0 siblings, 15 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

There is a general movement towards ensuring all of the kernel source
files have SPDX headers.  I have previously expressed the view, that,
like many cleanups it would be better to do these when otherwise touching
the relevant part of the code, rather than creating noise throughout.

Time to change my mind on that, and push through adding these to IIO.

Even in the core code, I was less than entirely consistent with the
existing license markings, so there are places where the file headers
don't match with the MODULE_LICENSE macro.
There were also headers that gained default SPDX license markings
that actually aren't quite correct given the related c files sometimes
did have well stated licenses.

If someone has time to check my logic on the these that would be great.

For the drivers, my intent is to use random periods of boredom
(I'm on some long haul flights in the near future) to see if I can
plough through them.  If anyone wants to get ahead of the game and
do their own drivers that would be great.  This is particularly true
in the big octopus drivers that spread throughout the IIO directories
and beyond.  I'd love it if other people took those on.

If in doubt, don't do a given file or put out a clearly worded email
to the list asking for help!

Jonathan Cameron (14):
  iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE
  iio:configfs: SPDX headers.
  iio: sw-device: SPDX headers
  iio: sw-trigger: SPDX headers.
  iio: triggered-event: Add SPDX and fix header license to match the
    code.
  iio:buffer-dma: SPDX headers.
  iio: buffer-cb: SPDX headers
  iio: kfifo-buf: Add SPDX header
  iio: buffer-dmaengine: SPDX GPL-2.0+
  iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
  iio: trig-hrtimer: SPDX header GPLv2
  iio: trig-interrupt: SPDX headers. GPLv2
  iio: trig-loop: SPDX headers GPL-v2
  iio: trig-sysfs: SPDX headers GPLv2.

 drivers/iio/buffer/industrialio-buffer-cb.c        |  8 +++-----
 drivers/iio/buffer/industrialio-buffer-dma.c       |  3 +--
 drivers/iio/buffer/industrialio-buffer-dmaengine.c |  3 +--
 drivers/iio/buffer/industrialio-triggered-buffer.c |  9 +++------
 drivers/iio/buffer/kfifo_buf.c                     |  1 +
 drivers/iio/iio_core.h                             |  8 +++-----
 drivers/iio/iio_core_trigger.h                     |  2 +-
 drivers/iio/industrialio-buffer.c                  |  8 +++-----
 drivers/iio/industrialio-configfs.c                |  5 +----
 drivers/iio/industrialio-core.c                    | 10 ++++------
 drivers/iio/industrialio-event.c                   |  4 +++-
 drivers/iio/industrialio-sw-device.c               |  5 +----
 drivers/iio/industrialio-sw-trigger.c              |  5 +----
 drivers/iio/industrialio-trigger.c                 |  8 +++-----
 drivers/iio/industrialio-triggered-event.c         |  6 +-----
 drivers/iio/inkern.c                               |  8 +++-----
 drivers/iio/trigger/iio-trig-hrtimer.c             |  6 +-----
 drivers/iio/trigger/iio-trig-interrupt.c           |  5 +----
 drivers/iio/trigger/iio-trig-loop.c                |  3 +--
 drivers/iio/trigger/iio-trig-sysfs.c               |  4 +---
 include/linux/iio/buffer-dma.h                     |  3 +--
 include/linux/iio/buffer-dmaengine.h               |  3 +--
 include/linux/iio/buffer.h                         |  8 +++-----
 include/linux/iio/configfs.h                       |  5 +----
 include/linux/iio/consumer.h                       |  5 +----
 include/linux/iio/driver.h                         |  5 +----
 include/linux/iio/events.h                         |  8 +++-----
 include/linux/iio/iio.h                            |  9 +++------
 include/linux/iio/kfifo_buf.h                      |  2 +-
 include/linux/iio/machine.h                        |  5 +----
 include/linux/iio/sw_device.h                      |  5 +----
 include/linux/iio/sw_trigger.h                     |  5 +----
 include/linux/iio/sysfs.h                          | 10 ++++------
 include/linux/iio/trigger.h                        |  5 +----
 include/linux/iio/trigger_consumer.h               |  8 +++-----
 include/linux/iio/triggered_event.h                |  2 +-
 include/linux/iio/types.h                          |  8 +++-----
 37 files changed, 67 insertions(+), 140 deletions(-)

-- 
2.22.0


^ permalink raw reply	[flat|nested] 22+ messages in thread

* [PATCH 01/14] iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 02/14] iio:configfs: SPDX headers jic23
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

There is a concerted push to ensure all of the kernel files
have SPDX headers going on, so about time IIO caught up.

Given the large and mechanical nature of the changes + the
need to actually check the changes are correct by hand,
I'll split them down in to fairly bite sized chunks.

This first patch is those files that feed directly into
industrialio.ko.

Note the visual inspection showed that MODULE_LICENSE(GPL)
was different from the clearly file headers which did not
have the or later text that implies.  I have taken the
code as having precedence and changed this to GPL v2.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/iio_core.h               |  8 +++-----
 drivers/iio/iio_core_trigger.h       |  2 +-
 drivers/iio/industrialio-buffer.c    |  8 +++-----
 drivers/iio/industrialio-core.c      | 10 ++++------
 drivers/iio/industrialio-event.c     |  4 +++-
 drivers/iio/industrialio-trigger.c   |  8 +++-----
 drivers/iio/inkern.c                 |  8 +++-----
 include/linux/iio/buffer.h           |  8 +++-----
 include/linux/iio/consumer.h         |  5 +----
 include/linux/iio/driver.h           |  5 +----
 include/linux/iio/events.h           |  8 +++-----
 include/linux/iio/iio.h              |  9 +++------
 include/linux/iio/machine.h          |  5 +----
 include/linux/iio/sysfs.h            | 10 ++++------
 include/linux/iio/trigger.h          |  5 +----
 include/linux/iio/trigger_consumer.h |  8 +++-----
 include/linux/iio/types.h            |  8 +++-----
 17 files changed, 43 insertions(+), 76 deletions(-)

diff --git a/drivers/iio/iio_core.h b/drivers/iio/iio_core.h
index c775fedbcaf6..62b3c436d367 100644
--- a/drivers/iio/iio_core.h
+++ b/drivers/iio/iio_core.h
@@ -1,11 +1,9 @@
-/* The industrial I/O core function defs.
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core function defs.
  *
  * Copyright (c) 2008 Jonathan Cameron
  *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
- *
  * These definitions are meant for use only within the IIO core, not individual
  * drivers.
  */
diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h
index 1fdb1e4ea4a5..e945764da1b0 100644
--- a/drivers/iio/iio_core_trigger.h
+++ b/drivers/iio/iio_core_trigger.h
@@ -1,4 +1,4 @@
-
+/* SPDX-License-Identifier: GPL-2.0 */
 /* The industrial I/O core, trigger consumer handling functions
  *
  * Copyright (c) 2008 Jonathan Cameron
diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index 4fa273002c03..698f650145a0 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -1,11 +1,9 @@
-/* The industrial I/O core
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O core
  *
  * Copyright (c) 2008 Jonathan Cameron
  *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
- *
  * Handling of buffer allocation / resizing.
  *
  *
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 85a699b5ae96..518b654a248b 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -1,11 +1,9 @@
-/* The industrial I/O core
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O core
  *
  * Copyright (c) 2008 Jonathan Cameron
  *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
- *
  * Based on elements of hwmon and input subsystems.
  */
 
@@ -1821,4 +1819,4 @@ module_exit(iio_exit);
 
 MODULE_AUTHOR("Jonathan Cameron <jic23@kernel.org>");
 MODULE_DESCRIPTION("Industrial I/O core");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
index c6dfdf0aaac5..d32ebf47960f 100644
--- a/drivers/iio/industrialio-event.c
+++ b/drivers/iio/industrialio-event.c
@@ -1,4 +1,6 @@
-/* Industrial I/O event handling
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Industrial I/O event handling
  *
  * Copyright (c) 2008 Jonathan Cameron
  *
diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
index e5b538379ed1..affe336842e0 100644
--- a/drivers/iio/industrialio-trigger.c
+++ b/drivers/iio/industrialio-trigger.c
@@ -1,10 +1,8 @@
-/* The industrial I/O core, trigger handling functions
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O core, trigger handling functions
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/kernel.h>
diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index 4a5eff3f18bc..89684464b72a 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -1,10 +1,8 @@
-/* The industrial I/O core in kernel channel mapping
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O core in kernel channel mapping
  *
  * Copyright (c) 2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #include <linux/err.h>
 #include <linux/export.h>
diff --git a/include/linux/iio/buffer.h b/include/linux/iio/buffer.h
index 48767c776119..50c645369544 100644
--- a/include/linux/iio/buffer.h
+++ b/include/linux/iio/buffer.h
@@ -1,10 +1,8 @@
-/* The industrial I/O core - generic buffer interfaces.
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core - generic buffer interfaces.
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef _IIO_BUFFER_GENERIC_H_
diff --git a/include/linux/iio/consumer.h b/include/linux/iio/consumer.h
index b2d34831ed7c..25c5f932c03d 100644
--- a/include/linux/iio/consumer.h
+++ b/include/linux/iio/consumer.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O in kernel consumer interface
  *
  * Copyright (c) 2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #ifndef _IIO_INKERN_CONSUMER_H_
 #define _IIO_INKERN_CONSUMER_H_
diff --git a/include/linux/iio/driver.h b/include/linux/iio/driver.h
index f54a7bcdefe3..d5e63a832f49 100644
--- a/include/linux/iio/driver.h
+++ b/include/linux/iio/driver.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O in kernel access map interface.
  *
  * Copyright (c) 2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef _IIO_INKERN_H_
diff --git a/include/linux/iio/events.h b/include/linux/iio/events.h
index 8ad87d1c5340..4ed5a1e4b3c0 100644
--- a/include/linux/iio/events.h
+++ b/include/linux/iio/events.h
@@ -1,10 +1,8 @@
-/* The industrial I/O - event passing to userspace
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O - event passing to userspace
  *
  * Copyright (c) 2008-2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #ifndef _IIO_EVENTS_H_
 #define _IIO_EVENTS_H_
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index bb10c1bee301..9a5d40874ed5 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -1,11 +1,8 @@
-
-/* The industrial I/O core
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #ifndef _INDUSTRIAL_IO_H_
 #define _INDUSTRIAL_IO_H_
diff --git a/include/linux/iio/machine.h b/include/linux/iio/machine.h
index 5e1cfa75f652..3a2dfd43c8ef 100644
--- a/include/linux/iio/machine.h
+++ b/include/linux/iio/machine.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O in kernel access map definitions for board files.
  *
  * Copyright (c) 2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef __LINUX_IIO_MACHINE_H__
diff --git a/include/linux/iio/sysfs.h b/include/linux/iio/sysfs.h
index ce9426c507fd..e70291975d5b 100644
--- a/include/linux/iio/sysfs.h
+++ b/include/linux/iio/sysfs.h
@@ -1,10 +1,8 @@
-/* The industrial I/O core
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core
  *
- *Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
+ * Copyright (c) 2008 Jonathan Cameron
  *
  * General attributes
  */
diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index b19b7204ef84..430b99f76081 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -1,10 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /* The industrial I/O core, trigger handling functions
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #include <linux/irq.h>
 #include <linux/module.h>
diff --git a/include/linux/iio/trigger_consumer.h b/include/linux/iio/trigger_consumer.h
index c4f8c7409666..6c6d7da8d626 100644
--- a/include/linux/iio/trigger_consumer.h
+++ b/include/linux/iio/trigger_consumer.h
@@ -1,10 +1,8 @@
-/* The industrial I/O core, trigger consumer functions
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The industrial I/O core, trigger consumer functions
  *
  * Copyright (c) 2008-2011 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef __LINUX_IIO_TRIGGER_CONSUMER_H__
diff --git a/include/linux/iio/types.h b/include/linux/iio/types.h
index 6eb3d683ef62..a4af165d6461 100644
--- a/include/linux/iio/types.h
+++ b/include/linux/iio/types.h
@@ -1,10 +1,8 @@
-/* industrial I/O data types needed both in and out of kernel
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * industrial I/O data types needed both in and out of kernel
  *
  * Copyright (c) 2008 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef _IIO_TYPES_H_
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 02/14] iio:configfs: SPDX headers.
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
  2019-06-22 14:55 ` [PATCH 01/14] iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 03/14] iio: sw-device: " jic23
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Simple removal of boilerplate and insertion of spdx for GPL v2.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
 drivers/iio/industrialio-configfs.c | 5 +----
 include/linux/iio/configfs.h        | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/iio/industrialio-configfs.c b/drivers/iio/industrialio-configfs.c
index 5a0aae119369..92b1ab4f159d 100644
--- a/drivers/iio/industrialio-configfs.c
+++ b/drivers/iio/industrialio-configfs.c
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Industrial I/O configfs bits
  *
  * Copyright (c) 2015 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/configfs.h>
diff --git a/include/linux/iio/configfs.h b/include/linux/iio/configfs.h
index 93befd67c15c..75752e69916c 100644
--- a/include/linux/iio/configfs.h
+++ b/include/linux/iio/configfs.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O configfs support
  *
  * Copyright (c) 2015 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 #ifndef __IIO_CONFIGFS
 #define __IIO_CONFIGFS
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 03/14] iio: sw-device: SPDX headers
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
  2019-06-22 14:55 ` [PATCH 01/14] iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE jic23
  2019-06-22 14:55 ` [PATCH 02/14] iio:configfs: SPDX headers jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 04/14] iio: sw-trigger: " jic23
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Simple GPLv2.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
 drivers/iio/industrialio-sw-device.c | 5 +----
 include/linux/iio/sw_device.h        | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/iio/industrialio-sw-device.c b/drivers/iio/industrialio-sw-device.c
index 90df97c542f6..cefa6ce4555a 100644
--- a/drivers/iio/industrialio-sw-device.c
+++ b/drivers/iio/industrialio-sw-device.c
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * The Industrial I/O core, software IIO devices functions
  *
  * Copyright (c) 2016 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/module.h>
diff --git a/include/linux/iio/sw_device.h b/include/linux/iio/sw_device.h
index 8642b91a7577..253ae5fce3d0 100644
--- a/include/linux/iio/sw_device.h
+++ b/include/linux/iio/sw_device.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O software device interface
  *
  * Copyright (c) 2016 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef __IIO_SW_DEVICE
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 04/14] iio: sw-trigger: SPDX headers.
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (2 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 03/14] iio: sw-device: " jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 05/14] iio: triggered-event: Add SPDX and fix header license to match the code jic23
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

GPLv2, add SPDX headers and remove boilerplate.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/industrialio-sw-trigger.c | 5 +----
 include/linux/iio/sw_trigger.h        | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/iio/industrialio-sw-trigger.c b/drivers/iio/industrialio-sw-trigger.c
index bc6b7fb43e3a..b8fcb4cd06f1 100644
--- a/drivers/iio/industrialio-sw-trigger.c
+++ b/drivers/iio/industrialio-sw-trigger.c
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * The Industrial I/O core, software trigger functions
  *
  * Copyright (c) 2015 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/module.h>
diff --git a/include/linux/iio/sw_trigger.h b/include/linux/iio/sw_trigger.h
index 0c43738a9e24..c8b9868b5e62 100644
--- a/include/linux/iio/sw_trigger.h
+++ b/include/linux/iio/sw_trigger.h
@@ -1,11 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Industrial I/O software trigger interface
  *
  * Copyright (c) 2015 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #ifndef __IIO_SW_TRIGGER
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 05/14] iio: triggered-event: Add SPDX and fix header license to match the code.
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (3 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 04/14] iio: sw-trigger: " jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 06/14] iio:buffer-dma: SPDX headers jic23
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The c file had clear license text, this disgreed with the default
GPL-2.0 added due to the header having no previous license
text at all.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/industrialio-triggered-event.c | 6 +-----
 include/linux/iio/triggered_event.h        | 2 +-
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/industrialio-triggered-event.c b/drivers/iio/industrialio-triggered-event.c
index 8cc254fac16a..77b59dbfe710 100644
--- a/drivers/iio/industrialio-triggered-event.c
+++ b/drivers/iio/industrialio-triggered-event.c
@@ -1,10 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Copyright (C) 2015 Cogent Embedded, Inc.
- *
- * This program is free software; you can redistribute  it and/or modify it
- * under  the terms of  the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include <linux/kernel.h>
diff --git a/include/linux/iio/triggered_event.h b/include/linux/iio/triggered_event.h
index 13250fd99745..8f73190188ce 100644
--- a/include/linux/iio/triggered_event.h
+++ b/include/linux/iio/triggered_event.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: GPL-2.0+ */
 #ifndef _LINUX_IIO_TRIGGERED_EVENT_H_
 #define _LINUX_IIO_TRIGGERED_EVENT_H_
 
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 06/14] iio:buffer-dma: SPDX headers.
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (4 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 05/14] iio: triggered-event: Add SPDX and fix header license to match the code jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 07/14] iio: buffer-cb: " jic23
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

GPLv2 as clearly stated in prior headers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/buffer/industrialio-buffer-dma.c | 3 +--
 include/linux/iio/buffer-dma.h               | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/buffer/industrialio-buffer-dma.c b/drivers/iio/buffer/industrialio-buffer-dma.c
index b32bf57910ca..debe0f6c44fb 100644
--- a/drivers/iio/buffer/industrialio-buffer-dma.c
+++ b/drivers/iio/buffer/industrialio-buffer-dma.c
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright 2013-2015 Analog Devices Inc.
  *  Author: Lars-Peter Clausen <lars@metafoo.de>
- *
- * Licensed under the GPL-2.
  */
 
 #include <linux/slab.h>
diff --git a/include/linux/iio/buffer-dma.h b/include/linux/iio/buffer-dma.h
index 67c75372b691..b0fa722d0ccf 100644
--- a/include/linux/iio/buffer-dma.h
+++ b/include/linux/iio/buffer-dma.h
@@ -1,8 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright 2013-2015 Analog Devices Inc.
  *  Author: Lars-Peter Clausen <lars@metafoo.de>
- *
- * Licensed under the GPL-2.
  */
 
 #ifndef __INDUSTRIALIO_DMA_BUFFER_H__
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 07/14] iio: buffer-cb: SPDX headers
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (5 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 06/14] iio:buffer-dma: SPDX headers jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 08/14] iio: kfifo-buf: Add SPDX header jic23
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Another simple GPL v2 only.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/buffer/industrialio-buffer-cb.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/buffer/industrialio-buffer-cb.c b/drivers/iio/buffer/industrialio-buffer-cb.c
index df21e7dbec40..1628ba36515c 100644
--- a/drivers/iio/buffer/industrialio-buffer-cb.c
+++ b/drivers/iio/buffer/industrialio-buffer-cb.c
@@ -1,8 +1,6 @@
-/* The industrial I/O callback buffer
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * The industrial I/O callback buffer
  */
 
 #include <linux/kernel.h>
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 08/14] iio: kfifo-buf: Add SPDX header
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (6 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 07/14] iio: buffer-cb: " jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 09/14] iio: buffer-dmaengine: SPDX GPL-2.0+ jic23
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Previously no license header, but there is a MODULE_LICENSE
so match that with GPL-2.0+

Header was filled with default GPL-2.0 so update fix that as well.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/buffer/kfifo_buf.c | 1 +
 include/linux/iio/kfifo_buf.h  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/buffer/kfifo_buf.c b/drivers/iio/buffer/kfifo_buf.c
index 70c302a93d7f..041a8d0b9aac 100644
--- a/drivers/iio/buffer/kfifo_buf.c
+++ b/drivers/iio/buffer/kfifo_buf.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
 #include <linux/slab.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
diff --git a/include/linux/iio/kfifo_buf.h b/include/linux/iio/kfifo_buf.h
index 764659e01b68..4611bbcc37c3 100644
--- a/include/linux/iio/kfifo_buf.h
+++ b/include/linux/iio/kfifo_buf.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: GPL-2.0+ */
 #ifndef __LINUX_IIO_KFIFO_BUF_H__
 #define __LINUX_IIO_KFIFO_BUF_H__
 
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 09/14] iio: buffer-dmaengine: SPDX GPL-2.0+
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (7 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 08/14] iio: kfifo-buf: Add SPDX header jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 10/14] iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2 jic23
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Clearly stated in existing headers so just convert to SDPX.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 +--
 include/linux/iio/buffer-dmaengine.h               | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
index 2b5a320f42c5..9a0a02e89e9b 100644
--- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
+++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Copyright 2014-2015 Analog Devices Inc.
  *  Author: Lars-Peter Clausen <lars@metafoo.de>
- *
- * Licensed under the GPL-2 or later.
  */
 
 #include <linux/slab.h>
diff --git a/include/linux/iio/buffer-dmaengine.h b/include/linux/iio/buffer-dmaengine.h
index 5dcddf427bb0..c7dbcd359213 100644
--- a/include/linux/iio/buffer-dmaengine.h
+++ b/include/linux/iio/buffer-dmaengine.h
@@ -1,8 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright 2014-2015 Analog Devices Inc.
  *  Author: Lars-Peter Clausen <lars@metafoo.de>
- *
- * Licensed under the GPL-2 or later.
  */
 
 #ifndef __IIO_DMAENGINE_H__
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 10/14] iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (8 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 09/14] iio: buffer-dmaengine: SPDX GPL-2.0+ jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 11/14] iio: trig-hrtimer: SPDX header GPLv2 jic23
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

The licensing was inconsistent for this module, so gone with
the clearly stated header text which had no "or later"
element.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/buffer/industrialio-triggered-buffer.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/buffer/industrialio-triggered-buffer.c b/drivers/iio/buffer/industrialio-triggered-buffer.c
index d3db1fce54d2..0c413012f8e1 100644
--- a/drivers/iio/buffer/industrialio-triggered-buffer.c
+++ b/drivers/iio/buffer/industrialio-triggered-buffer.c
@@ -1,10 +1,7 @@
- /*
+// SPDX-License-Identifier: GPL-2.0
+/*
  * Copyright (c) 2012 Analog Devices, Inc.
  *  Author: Lars-Peter Clausen <lars@metafoo.de>
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/kernel.h>
@@ -142,4 +139,4 @@ EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_cleanup);
 
 MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
 MODULE_DESCRIPTION("IIO helper functions for setting up triggered buffers");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 11/14] iio: trig-hrtimer: SPDX header GPLv2
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (9 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 10/14] iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2 jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 12/14] iio: trig-interrupt: SPDX headers. GPLv2 jic23
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Clearly stated license text so simple conversion.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
 drivers/iio/trigger/iio-trig-hrtimer.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/iio/trigger/iio-trig-hrtimer.c b/drivers/iio/trigger/iio-trig-hrtimer.c
index 7accd0187ba1..14cfb4074f64 100644
--- a/drivers/iio/trigger/iio-trig-hrtimer.c
+++ b/drivers/iio/trigger/iio-trig-hrtimer.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /**
  * The industrial I/O periodic hrtimer trigger driver
  *
@@ -6,11 +7,6 @@
  * Copyright (C) 2012, Analog Device Inc.
  *	Author: Lars-Peter Clausen <lars@metafoo.de>
  * Copyright (C) 2015, Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
- *
  */
 #include <linux/kernel.h>
 #include <linux/slab.h>
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 12/14] iio: trig-interrupt: SPDX headers. GPLv2
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (10 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 11/14] iio: trig-hrtimer: SPDX header GPLv2 jic23
@ 2019-06-22 14:55 ` jic23
  2019-06-22 14:55 ` [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2 jic23
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/trigger/iio-trig-interrupt.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/iio/trigger/iio-trig-interrupt.c b/drivers/iio/trigger/iio-trig-interrupt.c
index 171c4ed03543..04c38fad6a28 100644
--- a/drivers/iio/trigger/iio-trig-interrupt.c
+++ b/drivers/iio/trigger/iio-trig-interrupt.c
@@ -1,11 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Industrial I/O - generic interrupt based trigger support
  *
  * Copyright (c) 2008-2013 Jonathan Cameron
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published by
- * the Free Software Foundation.
  */
 
 #include <linux/kernel.h>
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (11 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 12/14] iio: trig-interrupt: SPDX headers. GPLv2 jic23
@ 2019-06-22 14:55 ` jic23
  2019-07-17 17:58   ` Himanshu Jha
  2019-06-22 14:55 ` [PATCH 14/14] iio: trig-sysfs: SPDX headers GPLv2 jic23
  2019-07-17 16:07 ` [PATCH 00/14] iio: SPDX headers for core + non device driver parts Jonathan Cameron
  14 siblings, 1 reply; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Not exactly standard license text, but clear in intent and it's
my copyright anyway.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/trigger/iio-trig-loop.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
index 9258d3cf149b..f0205a9e47d0 100644
--- a/drivers/iio/trigger/iio-trig-loop.c
+++ b/drivers/iio/trigger/iio-trig-loop.c
@@ -1,8 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright 2016 Jonathan Cameron <jic23@kernel.org>
  *
- * Licensed under the GPL-2.
- *
  * Based on a mashup of the hrtimer trigger and continuous sampling proposal of
  * Gregor Boirie <gregor.boirie@parrot.com>
  *
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH 14/14] iio: trig-sysfs: SPDX headers GPLv2.
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (12 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2 jic23
@ 2019-06-22 14:55 ` jic23
  2019-07-17 16:07 ` [PATCH 00/14] iio: SPDX headers for core + non device driver parts Jonathan Cameron
  14 siblings, 0 replies; 22+ messages in thread
From: jic23 @ 2019-06-22 14:55 UTC (permalink / raw)
  To: linux-iio
  Cc: Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron, Michael Hennerich

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Non standard but clear statement of intent.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
---
 drivers/iio/trigger/iio-trig-sysfs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/iio/trigger/iio-trig-sysfs.c b/drivers/iio/trigger/iio-trig-sysfs.c
index 45c4897295d6..c86a78baeba4 100644
--- a/drivers/iio/trigger/iio-trig-sysfs.c
+++ b/drivers/iio/trigger/iio-trig-sysfs.c
@@ -1,8 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright 2011 Analog Devices Inc.
- *
- * Licensed under the GPL-2.
- *
  */
 
 #include <linux/kernel.h>
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH 00/14] iio: SPDX headers for core + non device driver parts.
  2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
                   ` (13 preceding siblings ...)
  2019-06-22 14:55 ` [PATCH 14/14] iio: trig-sysfs: SPDX headers GPLv2 jic23
@ 2019-07-17 16:07 ` Jonathan Cameron
  2019-07-18  8:36   ` Ardelean, Alexandru
  14 siblings, 1 reply; 22+ messages in thread
From: Jonathan Cameron @ 2019-07-17 16:07 UTC (permalink / raw)
  To: jic23
  Cc: linux-iio, Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler

If anyone has time to sanity check these, it would be much appreciated.

At somepoint I'll take a view on them being too dull to garner review, but
I really don't like applying stuff that hasn't had a second set of eyes on it.

Thanks,

Jonathan

On Sat, 22 Jun 2019 15:55:02 +0100
<jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> There is a general movement towards ensuring all of the kernel source
> files have SPDX headers.  I have previously expressed the view, that,
> like many cleanups it would be better to do these when otherwise touching
> the relevant part of the code, rather than creating noise throughout.
> 
> Time to change my mind on that, and push through adding these to IIO.
> 
> Even in the core code, I was less than entirely consistent with the
> existing license markings, so there are places where the file headers
> don't match with the MODULE_LICENSE macro.
> There were also headers that gained default SPDX license markings
> that actually aren't quite correct given the related c files sometimes
> did have well stated licenses.
> 
> If someone has time to check my logic on the these that would be great.
> 
> For the drivers, my intent is to use random periods of boredom
> (I'm on some long haul flights in the near future) to see if I can
> plough through them.  If anyone wants to get ahead of the game and
> do their own drivers that would be great.  This is particularly true
> in the big octopus drivers that spread throughout the IIO directories
> and beyond.  I'd love it if other people took those on.
> 
> If in doubt, don't do a given file or put out a clearly worded email
> to the list asking for help!
> 
> Jonathan Cameron (14):
>   iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE
>   iio:configfs: SPDX headers.
>   iio: sw-device: SPDX headers
>   iio: sw-trigger: SPDX headers.
>   iio: triggered-event: Add SPDX and fix header license to match the
>     code.
>   iio:buffer-dma: SPDX headers.
>   iio: buffer-cb: SPDX headers
>   iio: kfifo-buf: Add SPDX header
>   iio: buffer-dmaengine: SPDX GPL-2.0+
>   iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
>   iio: trig-hrtimer: SPDX header GPLv2
>   iio: trig-interrupt: SPDX headers. GPLv2
>   iio: trig-loop: SPDX headers GPL-v2
>   iio: trig-sysfs: SPDX headers GPLv2.
> 
>  drivers/iio/buffer/industrialio-buffer-cb.c        |  8 +++-----
>  drivers/iio/buffer/industrialio-buffer-dma.c       |  3 +--
>  drivers/iio/buffer/industrialio-buffer-dmaengine.c |  3 +--
>  drivers/iio/buffer/industrialio-triggered-buffer.c |  9 +++------
>  drivers/iio/buffer/kfifo_buf.c                     |  1 +
>  drivers/iio/iio_core.h                             |  8 +++-----
>  drivers/iio/iio_core_trigger.h                     |  2 +-
>  drivers/iio/industrialio-buffer.c                  |  8 +++-----
>  drivers/iio/industrialio-configfs.c                |  5 +----
>  drivers/iio/industrialio-core.c                    | 10 ++++------
>  drivers/iio/industrialio-event.c                   |  4 +++-
>  drivers/iio/industrialio-sw-device.c               |  5 +----
>  drivers/iio/industrialio-sw-trigger.c              |  5 +----
>  drivers/iio/industrialio-trigger.c                 |  8 +++-----
>  drivers/iio/industrialio-triggered-event.c         |  6 +-----
>  drivers/iio/inkern.c                               |  8 +++-----
>  drivers/iio/trigger/iio-trig-hrtimer.c             |  6 +-----
>  drivers/iio/trigger/iio-trig-interrupt.c           |  5 +----
>  drivers/iio/trigger/iio-trig-loop.c                |  3 +--
>  drivers/iio/trigger/iio-trig-sysfs.c               |  4 +---
>  include/linux/iio/buffer-dma.h                     |  3 +--
>  include/linux/iio/buffer-dmaengine.h               |  3 +--
>  include/linux/iio/buffer.h                         |  8 +++-----
>  include/linux/iio/configfs.h                       |  5 +----
>  include/linux/iio/consumer.h                       |  5 +----
>  include/linux/iio/driver.h                         |  5 +----
>  include/linux/iio/events.h                         |  8 +++-----
>  include/linux/iio/iio.h                            |  9 +++------
>  include/linux/iio/kfifo_buf.h                      |  2 +-
>  include/linux/iio/machine.h                        |  5 +----
>  include/linux/iio/sw_device.h                      |  5 +----
>  include/linux/iio/sw_trigger.h                     |  5 +----
>  include/linux/iio/sysfs.h                          | 10 ++++------
>  include/linux/iio/trigger.h                        |  5 +----
>  include/linux/iio/trigger_consumer.h               |  8 +++-----
>  include/linux/iio/triggered_event.h                |  2 +-
>  include/linux/iio/types.h                          |  8 +++-----
>  37 files changed, 67 insertions(+), 140 deletions(-)
> 



^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
  2019-06-22 14:55 ` [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2 jic23
@ 2019-07-17 17:58   ` Himanshu Jha
  2019-07-17 21:12     ` Greg KH
  0 siblings, 1 reply; 22+ messages in thread
From: Himanshu Jha @ 2019-07-17 17:58 UTC (permalink / raw)
  To: jic23
  Cc: linux-iio, Daniel Baluta, Lars-Peter Clausen, Hartmut Knaack,
	Peter Meerwald-Stadler, Jonathan Cameron, linux-spdx

On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Not exactly standard license text, but clear in intent and it's
> my copyright anyway.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  drivers/iio/trigger/iio-trig-loop.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
> index 9258d3cf149b..f0205a9e47d0 100644
> --- a/drivers/iio/trigger/iio-trig-loop.c
> +++ b/drivers/iio/trigger/iio-trig-loop.c
> @@ -1,8 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0

I think it should be:

	// SPDX-License-Identifier: GPL-2.0-only

https://spdx.org/licenses/
https://spdx.org/licenses/GPL-2.0-only.html

I don't know if `spdxcheck.py` points out about
such a mismatch.

Yes, documentation and sanity checkers needs to be updated.
https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/


>  /*
>   * Copyright 2016 Jonathan Cameron <jic23@kernel.org>
>   *
> - * Licensed under the GPL-2.
> - *
>   * Based on a mashup of the hrtimer trigger and continuous sampling proposal of
>   * Gregor Boirie <gregor.boirie@parrot.com>
>   *
> -- 
> 2.22.0
> 

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
  2019-07-17 17:58   ` Himanshu Jha
@ 2019-07-17 21:12     ` Greg KH
  2019-08-17 19:08       ` J Lovejoy
  0 siblings, 1 reply; 22+ messages in thread
From: Greg KH @ 2019-07-17 21:12 UTC (permalink / raw)
  To: Himanshu Jha
  Cc: jic23, linux-iio, Daniel Baluta, Lars-Peter Clausen,
	Hartmut Knaack, Peter Meerwald-Stadler, Jonathan Cameron,
	linux-spdx

On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote:
> On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Not exactly standard license text, but clear in intent and it's
> > my copyright anyway.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> >  drivers/iio/trigger/iio-trig-loop.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
> > index 9258d3cf149b..f0205a9e47d0 100644
> > --- a/drivers/iio/trigger/iio-trig-loop.c
> > +++ b/drivers/iio/trigger/iio-trig-loop.c
> > @@ -1,8 +1,7 @@
> > +// SPDX-License-Identifier: GPL-2.0
> 
> I think it should be:
> 
> 	// SPDX-License-Identifier: GPL-2.0-only
> 
> https://spdx.org/licenses/
> https://spdx.org/licenses/GPL-2.0-only.html
> 
> I don't know if `spdxcheck.py` points out about
> such a mismatch.
> 
> Yes, documentation and sanity checkers needs to be updated.
> https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/

Please read the in-kernel documentation about this.  We support both
types of tags now and have done so since the beginning.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 00/14] iio: SPDX headers for core + non device driver parts.
  2019-07-17 16:07 ` [PATCH 00/14] iio: SPDX headers for core + non device driver parts Jonathan Cameron
@ 2019-07-18  8:36   ` Ardelean, Alexandru
  2019-07-21 17:04     ` Jonathan Cameron
  0 siblings, 1 reply; 22+ messages in thread
From: Ardelean, Alexandru @ 2019-07-18  8:36 UTC (permalink / raw)
  To: jonathan.cameron, jic23; +Cc: pmeerw, lars, linux-iio, daniel.baluta, knaack.h

On Wed, 2019-07-17 at 17:07 +0100, Jonathan Cameron wrote:
> [External]
> 
> If anyone has time to sanity check these, it would be much appreciated.
> 
> At somepoint I'll take a view on them being too dull to garner review, but
> I really don't like applying stuff that hasn't had a second set of eyes on it.
> 

Found only one inconsistency in patch 07/14.
`MODULE_LICENSE("GPL")` vs `// SPDX-License-Identifier: GPL-2.0`

Hopefully that email/reply comes through on the patch itself.
If not, maybe this email comes through.


> Thanks,
> 
> Jonathan
> 
> On Sat, 22 Jun 2019 15:55:02 +0100
> <jic23@kernel.org> wrote:
> 
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > There is a general movement towards ensuring all of the kernel source
> > files have SPDX headers.  I have previously expressed the view, that,
> > like many cleanups it would be better to do these when otherwise touching
> > the relevant part of the code, rather than creating noise throughout.
> > 
> > Time to change my mind on that, and push through adding these to IIO.
> > 
> > Even in the core code, I was less than entirely consistent with the
> > existing license markings, so there are places where the file headers
> > don't match with the MODULE_LICENSE macro.
> > There were also headers that gained default SPDX license markings
> > that actually aren't quite correct given the related c files sometimes
> > did have well stated licenses.
> > 
> > If someone has time to check my logic on the these that would be great.
> > 
> > For the drivers, my intent is to use random periods of boredom
> > (I'm on some long haul flights in the near future) to see if I can
> > plough through them.  If anyone wants to get ahead of the game and
> > do their own drivers that would be great.  This is particularly true
> > in the big octopus drivers that spread throughout the IIO directories
> > and beyond.  I'd love it if other people took those on.
> > 
> > If in doubt, don't do a given file or put out a clearly worded email
> > to the list asking for help!
> > 
> > Jonathan Cameron (14):
> >   iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE
> >   iio:configfs: SPDX headers.
> >   iio: sw-device: SPDX headers
> >   iio: sw-trigger: SPDX headers.
> >   iio: triggered-event: Add SPDX and fix header license to match the
> >     code.
> >   iio:buffer-dma: SPDX headers.
> >   iio: buffer-cb: SPDX headers
> >   iio: kfifo-buf: Add SPDX header
> >   iio: buffer-dmaengine: SPDX GPL-2.0+
> >   iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
> >   iio: trig-hrtimer: SPDX header GPLv2
> >   iio: trig-interrupt: SPDX headers. GPLv2
> >   iio: trig-loop: SPDX headers GPL-v2
> >   iio: trig-sysfs: SPDX headers GPLv2.
> > 
> >  drivers/iio/buffer/industrialio-buffer-cb.c        |  8 +++-----
> >  drivers/iio/buffer/industrialio-buffer-dma.c       |  3 +--
> >  drivers/iio/buffer/industrialio-buffer-dmaengine.c |  3 +--
> >  drivers/iio/buffer/industrialio-triggered-buffer.c |  9 +++------
> >  drivers/iio/buffer/kfifo_buf.c                     |  1 +
> >  drivers/iio/iio_core.h                             |  8 +++-----
> >  drivers/iio/iio_core_trigger.h                     |  2 +-
> >  drivers/iio/industrialio-buffer.c                  |  8 +++-----
> >  drivers/iio/industrialio-configfs.c                |  5 +----
> >  drivers/iio/industrialio-core.c                    | 10 ++++------
> >  drivers/iio/industrialio-event.c                   |  4 +++-
> >  drivers/iio/industrialio-sw-device.c               |  5 +----
> >  drivers/iio/industrialio-sw-trigger.c              |  5 +----
> >  drivers/iio/industrialio-trigger.c                 |  8 +++-----
> >  drivers/iio/industrialio-triggered-event.c         |  6 +-----
> >  drivers/iio/inkern.c                               |  8 +++-----
> >  drivers/iio/trigger/iio-trig-hrtimer.c             |  6 +-----
> >  drivers/iio/trigger/iio-trig-interrupt.c           |  5 +----
> >  drivers/iio/trigger/iio-trig-loop.c                |  3 +--
> >  drivers/iio/trigger/iio-trig-sysfs.c               |  4 +---
> >  include/linux/iio/buffer-dma.h                     |  3 +--
> >  include/linux/iio/buffer-dmaengine.h               |  3 +--
> >  include/linux/iio/buffer.h                         |  8 +++-----
> >  include/linux/iio/configfs.h                       |  5 +----
> >  include/linux/iio/consumer.h                       |  5 +----
> >  include/linux/iio/driver.h                         |  5 +----
> >  include/linux/iio/events.h                         |  8 +++-----
> >  include/linux/iio/iio.h                            |  9 +++------
> >  include/linux/iio/kfifo_buf.h                      |  2 +-
> >  include/linux/iio/machine.h                        |  5 +----
> >  include/linux/iio/sw_device.h                      |  5 +----
> >  include/linux/iio/sw_trigger.h                     |  5 +----
> >  include/linux/iio/sysfs.h                          | 10 ++++------
> >  include/linux/iio/trigger.h                        |  5 +----
> >  include/linux/iio/trigger_consumer.h               |  8 +++-----
> >  include/linux/iio/triggered_event.h                |  2 +-
> >  include/linux/iio/types.h                          |  8 +++-----
> >  37 files changed, 67 insertions(+), 140 deletions(-)
> > 
> 
> 

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 00/14] iio: SPDX headers for core + non device driver parts.
  2019-07-18  8:36   ` Ardelean, Alexandru
@ 2019-07-21 17:04     ` Jonathan Cameron
  0 siblings, 0 replies; 22+ messages in thread
From: Jonathan Cameron @ 2019-07-21 17:04 UTC (permalink / raw)
  To: Ardelean, Alexandru
  Cc: jonathan.cameron, pmeerw, lars, linux-iio, daniel.baluta, knaack.h

On Thu, 18 Jul 2019 08:36:56 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Wed, 2019-07-17 at 17:07 +0100, Jonathan Cameron wrote:
> > [External]
> > 
> > If anyone has time to sanity check these, it would be much appreciated.
> > 
> > At somepoint I'll take a view on them being too dull to garner review, but
> > I really don't like applying stuff that hasn't had a second set of eyes on it.
> >   
> 
> Found only one inconsistency in patch 07/14.
> `MODULE_LICENSE("GPL")` vs `// SPDX-License-Identifier: GPL-2.0`
> 
> Hopefully that email/reply comes through on the patch itself.
> If not, maybe this email comes through.

Seems Thomas Gleixner did a tree wide conversion anyway so this
series is now defunct. Oh well.  I'll do a set to cleanup the various
inconsistencies next time I get really bored.

Jonathan

> 
> 
> > Thanks,
> > 
> > Jonathan
> > 
> > On Sat, 22 Jun 2019 15:55:02 +0100
> > <jic23@kernel.org> wrote:
> >   
> > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > 
> > > There is a general movement towards ensuring all of the kernel source
> > > files have SPDX headers.  I have previously expressed the view, that,
> > > like many cleanups it would be better to do these when otherwise touching
> > > the relevant part of the code, rather than creating noise throughout.
> > > 
> > > Time to change my mind on that, and push through adding these to IIO.
> > > 
> > > Even in the core code, I was less than entirely consistent with the
> > > existing license markings, so there are places where the file headers
> > > don't match with the MODULE_LICENSE macro.
> > > There were also headers that gained default SPDX license markings
> > > that actually aren't quite correct given the related c files sometimes
> > > did have well stated licenses.
> > > 
> > > If someone has time to check my logic on the these that would be great.
> > > 
> > > For the drivers, my intent is to use random periods of boredom
> > > (I'm on some long haul flights in the near future) to see if I can
> > > plough through them.  If anyone wants to get ahead of the game and
> > > do their own drivers that would be great.  This is particularly true
> > > in the big octopus drivers that spread throughout the IIO directories
> > > and beyond.  I'd love it if other people took those on.
> > > 
> > > If in doubt, don't do a given file or put out a clearly worded email
> > > to the list asking for help!
> > > 
> > > Jonathan Cameron (14):
> > >   iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE
> > >   iio:configfs: SPDX headers.
> > >   iio: sw-device: SPDX headers
> > >   iio: sw-trigger: SPDX headers.
> > >   iio: triggered-event: Add SPDX and fix header license to match the
> > >     code.
> > >   iio:buffer-dma: SPDX headers.
> > >   iio: buffer-cb: SPDX headers
> > >   iio: kfifo-buf: Add SPDX header
> > >   iio: buffer-dmaengine: SPDX GPL-2.0+
> > >   iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
> > >   iio: trig-hrtimer: SPDX header GPLv2
> > >   iio: trig-interrupt: SPDX headers. GPLv2
> > >   iio: trig-loop: SPDX headers GPL-v2
> > >   iio: trig-sysfs: SPDX headers GPLv2.
> > > 
> > >  drivers/iio/buffer/industrialio-buffer-cb.c        |  8 +++-----
> > >  drivers/iio/buffer/industrialio-buffer-dma.c       |  3 +--
> > >  drivers/iio/buffer/industrialio-buffer-dmaengine.c |  3 +--
> > >  drivers/iio/buffer/industrialio-triggered-buffer.c |  9 +++------
> > >  drivers/iio/buffer/kfifo_buf.c                     |  1 +
> > >  drivers/iio/iio_core.h                             |  8 +++-----
> > >  drivers/iio/iio_core_trigger.h                     |  2 +-
> > >  drivers/iio/industrialio-buffer.c                  |  8 +++-----
> > >  drivers/iio/industrialio-configfs.c                |  5 +----
> > >  drivers/iio/industrialio-core.c                    | 10 ++++------
> > >  drivers/iio/industrialio-event.c                   |  4 +++-
> > >  drivers/iio/industrialio-sw-device.c               |  5 +----
> > >  drivers/iio/industrialio-sw-trigger.c              |  5 +----
> > >  drivers/iio/industrialio-trigger.c                 |  8 +++-----
> > >  drivers/iio/industrialio-triggered-event.c         |  6 +-----
> > >  drivers/iio/inkern.c                               |  8 +++-----
> > >  drivers/iio/trigger/iio-trig-hrtimer.c             |  6 +-----
> > >  drivers/iio/trigger/iio-trig-interrupt.c           |  5 +----
> > >  drivers/iio/trigger/iio-trig-loop.c                |  3 +--
> > >  drivers/iio/trigger/iio-trig-sysfs.c               |  4 +---
> > >  include/linux/iio/buffer-dma.h                     |  3 +--
> > >  include/linux/iio/buffer-dmaengine.h               |  3 +--
> > >  include/linux/iio/buffer.h                         |  8 +++-----
> > >  include/linux/iio/configfs.h                       |  5 +----
> > >  include/linux/iio/consumer.h                       |  5 +----
> > >  include/linux/iio/driver.h                         |  5 +----
> > >  include/linux/iio/events.h                         |  8 +++-----
> > >  include/linux/iio/iio.h                            |  9 +++------
> > >  include/linux/iio/kfifo_buf.h                      |  2 +-
> > >  include/linux/iio/machine.h                        |  5 +----
> > >  include/linux/iio/sw_device.h                      |  5 +----
> > >  include/linux/iio/sw_trigger.h                     |  5 +----
> > >  include/linux/iio/sysfs.h                          | 10 ++++------
> > >  include/linux/iio/trigger.h                        |  5 +----
> > >  include/linux/iio/trigger_consumer.h               |  8 +++-----
> > >  include/linux/iio/triggered_event.h                |  2 +-
> > >  include/linux/iio/types.h                          |  8 +++-----
> > >  37 files changed, 67 insertions(+), 140 deletions(-)
> > >   
> > 
> >   


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
  2019-07-17 21:12     ` Greg KH
@ 2019-08-17 19:08       ` J Lovejoy
  2019-08-17 20:38         ` Greg KH
  0 siblings, 1 reply; 22+ messages in thread
From: J Lovejoy @ 2019-08-17 19:08 UTC (permalink / raw)
  To: Greg KH
  Cc: Himanshu Jha, jic23, linux-iio, Daniel Baluta,
	Lars-Peter Clausen, Hartmut Knaack, Peter Meerwald-Stadler,
	Jonathan Cameron, linux-spdx



> On Jul 17, 2019, at 3:12 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote:
>> On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote:
>>> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> 
>>> Not exactly standard license text, but clear in intent and it's
>>> my copyright anyway.
>>> 
>>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> ---
>>> drivers/iio/trigger/iio-trig-loop.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>> 
>>> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
>>> index 9258d3cf149b..f0205a9e47d0 100644
>>> --- a/drivers/iio/trigger/iio-trig-loop.c
>>> +++ b/drivers/iio/trigger/iio-trig-loop.c
>>> @@ -1,8 +1,7 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>> 
>> I think it should be:
>> 
>> 	// SPDX-License-Identifier: GPL-2.0-only
>> 
>> https://spdx.org/licenses/
>> https://spdx.org/licenses/GPL-2.0-only.html
>> 
>> I don't know if `spdxcheck.py` points out about
>> such a mismatch.
>> 
>> Yes, documentation and sanity checkers needs to be updated.
>> https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/
> 
> Please read the in-kernel documentation about this.  We support both
> types of tags now and have done so since the beginning.
> 
> 
While I understand that the previous SPDX License List and current version identifiers are supported here, it would be really helpful more generally if we could use the current ones now and going forward.

Thanks,
Jilayne
SPDX legal team co-lead


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2
  2019-08-17 19:08       ` J Lovejoy
@ 2019-08-17 20:38         ` Greg KH
  0 siblings, 0 replies; 22+ messages in thread
From: Greg KH @ 2019-08-17 20:38 UTC (permalink / raw)
  To: J Lovejoy
  Cc: Himanshu Jha, jic23, linux-iio, Daniel Baluta,
	Lars-Peter Clausen, Hartmut Knaack, Peter Meerwald-Stadler,
	Jonathan Cameron, linux-spdx

On Sat, Aug 17, 2019 at 01:08:44PM -0600, J Lovejoy wrote:
> 
> 
> > On Jul 17, 2019, at 3:12 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > 
> > On Wed, Jul 17, 2019 at 11:28:37PM +0530, Himanshu Jha wrote:
> >> On Sat, Jun 22, 2019 at 03:55:15PM +0100, jic23@kernel.org wrote:
> >>> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >>> 
> >>> Not exactly standard license text, but clear in intent and it's
> >>> my copyright anyway.
> >>> 
> >>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >>> ---
> >>> drivers/iio/trigger/iio-trig-loop.c | 3 +--
> >>> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>> 
> >>> diff --git a/drivers/iio/trigger/iio-trig-loop.c b/drivers/iio/trigger/iio-trig-loop.c
> >>> index 9258d3cf149b..f0205a9e47d0 100644
> >>> --- a/drivers/iio/trigger/iio-trig-loop.c
> >>> +++ b/drivers/iio/trigger/iio-trig-loop.c
> >>> @@ -1,8 +1,7 @@
> >>> +// SPDX-License-Identifier: GPL-2.0
> >> 
> >> I think it should be:
> >> 
> >> 	// SPDX-License-Identifier: GPL-2.0-only
> >> 
> >> https://spdx.org/licenses/
> >> https://spdx.org/licenses/GPL-2.0-only.html
> >> 
> >> I don't know if `spdxcheck.py` points out about
> >> such a mismatch.
> >> 
> >> Yes, documentation and sanity checkers needs to be updated.
> >> https://lore.kernel.org/lkml/CAHk-=wipjStEwJj2_iWxBdVC4oV8rY5NjrRb1tmWLUa0VrS_Eg@mail.gmail.com/
> > 
> > Please read the in-kernel documentation about this.  We support both
> > types of tags now and have done so since the beginning.
> > 
> > 
> While I understand that the previous SPDX License List and current
> version identifiers are supported here, it would be really helpful
> more generally if we could use the current ones now and going forward.

That is fine, but for now, both are acceptable, it's up to the submitter
to pick which they want to use, we have much bigger things to worry
about here :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2019-08-17 20:39 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
2019-06-22 14:55 ` [PATCH 01/14] iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE jic23
2019-06-22 14:55 ` [PATCH 02/14] iio:configfs: SPDX headers jic23
2019-06-22 14:55 ` [PATCH 03/14] iio: sw-device: " jic23
2019-06-22 14:55 ` [PATCH 04/14] iio: sw-trigger: " jic23
2019-06-22 14:55 ` [PATCH 05/14] iio: triggered-event: Add SPDX and fix header license to match the code jic23
2019-06-22 14:55 ` [PATCH 06/14] iio:buffer-dma: SPDX headers jic23
2019-06-22 14:55 ` [PATCH 07/14] iio: buffer-cb: " jic23
2019-06-22 14:55 ` [PATCH 08/14] iio: kfifo-buf: Add SPDX header jic23
2019-06-22 14:55 ` [PATCH 09/14] iio: buffer-dmaengine: SPDX GPL-2.0+ jic23
2019-06-22 14:55 ` [PATCH 10/14] iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2 jic23
2019-06-22 14:55 ` [PATCH 11/14] iio: trig-hrtimer: SPDX header GPLv2 jic23
2019-06-22 14:55 ` [PATCH 12/14] iio: trig-interrupt: SPDX headers. GPLv2 jic23
2019-06-22 14:55 ` [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2 jic23
2019-07-17 17:58   ` Himanshu Jha
2019-07-17 21:12     ` Greg KH
2019-08-17 19:08       ` J Lovejoy
2019-08-17 20:38         ` Greg KH
2019-06-22 14:55 ` [PATCH 14/14] iio: trig-sysfs: SPDX headers GPLv2 jic23
2019-07-17 16:07 ` [PATCH 00/14] iio: SPDX headers for core + non device driver parts Jonathan Cameron
2019-07-18  8:36   ` Ardelean, Alexandru
2019-07-21 17:04     ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).